Re: [dpdk-stable] [dpdk-dev] [PATCH v2] net/mlx5: close tools socket with the last device

[Raslan Darawsheh <rasland@nvidia.com>]

Hi,

> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Dmitry Kozlyuk
> Sent: Thursday, October 14, 2021 11:55 AM
> To: dev@dpdk.org
> Cc: David Marchand <david.marchand@redhat.com>; Raslan Darawsheh
> <rasland@oss.nvidia.com>; Xueming Li <xuemingl@oss.nvidia.com>;
> stable@dpdk.org; Harman Kalra <hkalra@marvell.com>; NBU-Contact-
> Thomas Monjalon <thomas@monjalon.net>; Matan Azrad
> <matan@oss.nvidia.com>; Viacheslav Ovsiienko
> <viacheslavo@oss.nvidia.com>
> Subject: [dpdk-dev] [PATCH v2] net/mlx5: close tools socket with the last
> device
> 
> MLX5 PMD exposes a socket for external tools to dump port state.
> Socket events are listened using an interrupt source of EXT type.
> The socket was closed and the interrupt callback was unregistered at
> program exit, which is incorrect because DPDK could be already shut down at
> this point. Move actions performed at program exit to the moment the last
> MLX5 port is closed. The socket will be opened again if later a new MLX5
> device is plugged in and probed.
> Also fix comments that were deceisively talking about secondary processes
> instead of external tools.
> 
> Fixes: e6cdc54cc0ef ("net/mlx5: add socket server for external tools")
> Cc: Xueming Li <xuemingl@nvidia.com>
> Cc: stable@dpdk.org
> 
> Reported-by: Harman Kalra <hkalra@marvell.com>
> Signed-off-by: Dmitry Kozlyuk <dkozlyuk@nvidia.com>
> Acked-by: Thomas Monjalon <thomas@monjalon.net>
> ---
> v2: add Fixes tag
> 

Patch applied to next-net-mlx,

Kindest regards,
Raslan Darawsheh