From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 05685A0C45 for ; Wed, 17 Nov 2021 12:53:27 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F08BC411B5; Wed, 17 Nov 2021 12:53:26 +0100 (CET) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2069.outbound.protection.outlook.com [40.107.237.69]) by mails.dpdk.org (Postfix) with ESMTP id 6E3F541158; Wed, 17 Nov 2021 12:53:24 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oa6N+naO9mfGH7SbBYtcbdmg4AKhun1khu1+SBkXBsPpuGjXHfMOv4S/bV1sBeM3wrR4sHRikLVsDBpnfdZm5bgUlHSm+bW76eXpFVtI2WdtrNuQ9uYOeNdWNU2eRyREqSqBpK/BqKCkUF+DRZz6tRQybtkiQiFlXWQQYUajP5Aefa9dfrNTE94cx6OOoJ16hSXnXvQV36NSYeJiucUJIKpdEX5pDsDNkQclN7bgYCoOVGukgkGd+QVDiEmZahEh06644pO0IEgiu1BKSpdeTsrbAYN3aunzQtV52+wF3RxvvCmSXLByq/kjzm+7FRq6Xgt92LXk5Lvhi+PoPSRZiw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dpndI3wDcWYk88oEZUR9gjeZ42dh/5vsFopivxGJ6po=; b=TQKyh2WzkTQRFT7FnW3QjZvgryz8n0zWApwtV3RXn7WsnHBwL+LLdEt626uJsjiuGCvWlpL7EOofxIfIY455mpcGLq0LVY+9a6zGGmzVTyqYD0/r7ref/dB+yhmGyyAK6h8fe3c+rdBcc1Pi8G3qHbRYLOaG5/aR73yFQwOIBjABiNBVtw6j+SkaTOJBppjc+JQs2PHTsSbWN/a0Yyh8eUHdy2hKf+nocS/tEouNA9AJVOn41zaHGe18FAb/VLrPZT+LG2a41Wg4t+uIRvonaQppe/NwUjyFc5089TrzmQ6d5gLhnUbHQFrbL1YSMSdONj6392IHLNH1MXN9btozsA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dpndI3wDcWYk88oEZUR9gjeZ42dh/5vsFopivxGJ6po=; b=qtNWgvWddBKR4xDfS4EbSeMkscIP+LccSLXkSTt8f8YZWNtx1GNIBUVZAqRec0+znv//VhBwAwsaXiIqtjPiAmvjWawrSlu3TGzwgW0CBiba5I05E/WroVHX0VIeA4Jf97J4fCSFx61tQLLGQxhD/xdougUX5tAUOFbbo8cZWaym8Zinzs3HswTWLc3FtR/4vPTxB49i9+0qU7mE1DB6Tl8TDHV8NIvqFVKla1jjg5MJxyuIHgLs0KH/oB+IUi+o82ihZph5qODJARi2xFsH5AzJ0hnlaKFeieJqfW/7F9Pkl4hz9PbkoLQ1xhWjQJan7oqdfgG8LXFFzUSJ3zUi7g== Received: from DM4PR12MB5312.namprd12.prod.outlook.com (2603:10b6:5:39d::20) by DM4PR12MB5310.namprd12.prod.outlook.com (2603:10b6:5:39e::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4713.19; Wed, 17 Nov 2021 11:53:23 +0000 Received: from DM4PR12MB5312.namprd12.prod.outlook.com ([fe80::7cf5:9d34:fc6b:b4a4]) by DM4PR12MB5312.namprd12.prod.outlook.com ([fe80::7cf5:9d34:fc6b:b4a4%9]) with mapi id 15.20.4713.019; Wed, 17 Nov 2021 11:53:23 +0000 From: Raslan Darawsheh To: Dariusz Sosnowski , Matan Azrad , Slava Ovsiienko CC: "dev@dpdk.org" , "stable@dpdk.org" Subject: RE: [PATCH] net/mlx5: fix partial inline of fine grain packets Thread-Topic: [PATCH] net/mlx5: fix partial inline of fine grain packets Thread-Index: AQHX25i2C7sheFql+EyMZ4yknPL+uqwHnCBQ Date: Wed, 17 Nov 2021 11:53:23 +0000 Message-ID: References: <20211117095050.74177-1-dsosnowski@nvidia.com> In-Reply-To: <20211117095050.74177-1-dsosnowski@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f8ee0212-dbe4-4d33-c166-08d9a9c0db9f x-ms-traffictypediagnostic: DM4PR12MB5310: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2887; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: q9BP0rhGRa1S8EQVlotAO+CnUh72mpGK+On1095jt2+3klOh8PWtKJxzpqUo1aY1qAyGWBw/cSiwoI2ENso052KYx06dglUyfbLdmBfzeMJZm6ghD67dYGgLo2/fLdctqe+Qv9phIfDREbjDRh0HtJ0aRu9NNlv0An+ax3mw65hiInrtsuhan2NlvS6M1hDHxbaEk1NJSKaYCEP7T4YfcQQnFdic8sQFcwuqAk3YewrQwJW2gucjipnQwsuY6ag/Wvz5j2ADhjmo5mQRiltv5XVZ6/EWVx/Wl56u0TahKDubymITyxiHNoQkI2Xo2KTDvGktwYMP5TwkI2GrZ+Gkryy5Qj9W28DRkAN1NGlpXMoRVLOCIdh0kmKxi1HtomhNCtQAyETP+oJNbyx+8AV+7WHJQ5MbcXFf8VxL72Q5K+1DlOre2JrFjFSdIAPj4T0iZTSyrwdfVZjzC0atu5kHk1ZwDKJeciaRzfyCE/2TUMRIbrhzcygqUWO65cmlhMDvm+KLmeXVZzVdwvtoABdd5L3809QT71aAi30AMaLmjicYs1apu4wyR62LqusxSHeGfxVOnajK5T4FzZNS+2XLtkpWcsIQEkyM4UiO+i5ONFmu0DpKRV2wcbSgb9ZBaMYaYZc9HpK6IAPsqtsKY+gH9/wgK+QlQAs0yCj87MZl+huSEecOlERQl8ISWFA5vzAh5s+moqtnGkEcnd2icfwbGg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR12MB5312.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(76116006)(450100002)(110136005)(38100700002)(508600001)(71200400001)(66946007)(186003)(64756008)(66446008)(66476007)(26005)(6636002)(66556008)(316002)(2906002)(83380400001)(6506007)(86362001)(8936002)(52536014)(38070700005)(54906003)(8676002)(53546011)(33656002)(55016002)(5660300002)(7696005)(122000001)(4326008)(9686003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?+G9KwHHiL5uZG1PPEOUNR1lZoZt5hPONYx65Pn6611EOSrHcbCKSDlgSrUi7?= =?us-ascii?Q?koY7tzmNDI9RLuseCvMPBFpTvqfL3nMHFWrEsRKF2Xpjv07mWLKMlTNYYLzr?= =?us-ascii?Q?GKnHJAsyenzCCrbUaPsiSZ3y48qSPWFG3jzsSuK63S/MloFLKqbvhm3KSyBn?= =?us-ascii?Q?vOsaYIeluYY3Sk4JtGHDKbOu9mzJMRUEu98Ail6bBhU9ANIZaFo5JJyGQ3fG?= =?us-ascii?Q?sKfSinXkbgrln9r6L7lnQlUqDbFMJiq2EHfSr+tUp61AtUL06KP7zo7VtV4R?= =?us-ascii?Q?wZWZfYpuAzZXGRyrxAwqtKaJs3yaF9fzsgCStcsFqFWCw7ZRMMhHiak8D0tO?= =?us-ascii?Q?NosRd2jy3EfbygR+adnxn7KeuI7dkrKqWasax2d868BU0ZRZLNbj6SzcRwny?= =?us-ascii?Q?Vg1jzjKEcD6hYAzvdgBp+HVSFI3SJQUTgJuKiyWySijo5Wc+zO60FrExoQ+s?= =?us-ascii?Q?f1I4vSH4JGy2zC2ZXsaVXsB71NjBjfc1L1nDqzEQBr2TtdBZ0QA/rIB4Ppyb?= =?us-ascii?Q?1/2envfZ27mZE6FFDwFimDsti6+QKZ2OgrHm3BCpEgLpXJ8egmWMCUs0w6x8?= =?us-ascii?Q?ZJVrBNrBsSrxYeRBITr4RYLO63hPcLDZyb2n0nwrRMVh7/x8VUPR4fkI2Uia?= =?us-ascii?Q?IuGTcvrYdCoylUEqwTG5jEx4JkmMLPYdY/iDdIu30ZN6hDCRFK7EIHkHzNNZ?= =?us-ascii?Q?LgxwLO0FGZM3xUKRy/EgA8wfKw4Ks6+yhcnwIIJZSKvqudwTzI6eJx6OrPGH?= =?us-ascii?Q?eGpwq2jQPlhnHiSNW4QQSePiVCSr0YBsmRg5yu7fDL7NCw4tepxGfjWrpKua?= =?us-ascii?Q?sB4CXYG7XQZgLTu1dDY7Y5dblHqUKJo6CJ8LKMEmQsI/MNRHuTiAHnopJtyv?= =?us-ascii?Q?omymOzMNfRaAWZy3vUUBXGv7dMFJN2rdRqHJuMOFaHNQtsOUzFH+1qRlvgnd?= =?us-ascii?Q?LhyBu9IXH5LazEI7+rjFnYd6r2FZFjmx5zxN7azVAu8KGlb4hlwVTn1M7gob?= =?us-ascii?Q?B5DYdqYYk7YoY75Ca+TDhJAeDMI5vtIAz2Vi47smus7Q2Jlflvo5sMtUFQ9R?= =?us-ascii?Q?UoUrpyznFJxBHjXGZ+6u2UOxe7C9QKK2AZ4IXzLYn8G2UQjSpSnabYwYkEol?= =?us-ascii?Q?eV1uDbaZxg6HUdENq9wGT4ZQ+JIbdHzV90uPemBByD/RN9PiZHHAUCt6FgPY?= =?us-ascii?Q?8/O+NWJxy5T1r3Rk0ex33pZWiFdmn3PBUvd362UV9ltpEZB/iO7zQgD+53cZ?= =?us-ascii?Q?Rf9fRs3twKILgvqseugBLyvY9uxaPumi132jN7YIB4v/zdwk7yghZvFITWnM?= =?us-ascii?Q?eN/t7nao78ebKJiv35ZJFX6JxH1L1ynlbNVBdMAOM9SU2VACt5IbX3d0mQ6u?= =?us-ascii?Q?A+XIHX3ZfOjQ4uvMW51n/L5mkej4eIWSzAw4c3KROplNXQbytbp3fKue+XFR?= =?us-ascii?Q?A0Z88RFw9MsgrQG90q/0W9L0mzovl7r/rFKHvxxREhTeMrFP3AerKxcNe5gC?= =?us-ascii?Q?XrMP8m7mn2TXYWWgnC6rjUqd+LxfDRfhPrO/KnDYSm2ZCvM05rk7WPezsSQD?= =?us-ascii?Q?Br5X7IhLuDfo4CjSbJYVEFkIiwkYHVCDfTFxv8AACPhs+V7NvEO4qTb2evFJ?= =?us-ascii?Q?kBQVOefZO1OrDINE4Bjf8oU=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5312.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f8ee0212-dbe4-4d33-c166-08d9a9c0db9f X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Nov 2021 11:53:23.1926 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 2FmUq4RYVH+NSlP+1FRmb/NiTNlNzI5gUa8SJ1KKAN0vaUFQhHAy9zVvQwNDJTNBA8K5M5vd+4xqrXtgjY7BfA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5310 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, > -----Original Message----- > From: Dariusz Sosnowski > Sent: Wednesday, November 17, 2021 11:51 AM > To: Matan Azrad ; Slava Ovsiienko > > Cc: dev@dpdk.org; stable@dpdk.org > Subject: [PATCH] net/mlx5: fix partial inline of fine grain packets >=20 > Assuming a user tried to send multi-segment packets, with > RTE_PMD_MLX5_FINE_GRANULARITY_INLINE flag set, using a device with > minimum inlining requirements (such as ConnectX-4 Lx or when user > specified them explicitly), sending such packets caused segfault. > Segfault was caused by failed invariants in mlx5_tx_packet_multi_inline > function. >=20 > This patch introduces a logic for multi-segment packets, with > RTE_PMD_MLX5_FINE_GRANULARITY_INLINE flag set, to omit mbuf > scanning for filling inline buffer and inline only minimal amount of data > required. >=20 > Fixes: ec837ad0fc7c ("net/mlx5: fix multi-segment inline for the first > segments") > Cc: viacheslavo@nvidia.com > Cc: stable@dpdk.org Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh