From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2E42CA0C4C for ; Tue, 9 Nov 2021 10:58:16 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 18D4641104; Tue, 9 Nov 2021 10:58:16 +0100 (CET) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2078.outbound.protection.outlook.com [40.107.220.78]) by mails.dpdk.org (Postfix) with ESMTP id 2A00940E03; Tue, 9 Nov 2021 10:58:14 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NmHh/O3CQ6UYBbHPiGCZiTXJlzplegZAVwWVB8xpf/p4bDGIcpcZzU5JKslrpRbrsHO367D6oC/OhJ3G5/P3+Q/TbCsuvtbu7siH1ldY8ryuPA77oWlJ26k7Wlp0CLI3JmJ3n3gGERC80z03JhqsGe0EcNNMSxs00cta1P+rWHdwQ8/ttqhErsya2qWsth93xUG8UJMw/vX34qHBgKa6ZmocjTd+JlPj11PBr4vFRkt3KmgUkTE2G38Rqh4YI4ag9wGxuiMpHmLcLYh7lDNtdRr34tE5Ij+r3T10iwWRsVi0rU+Z14/hKZuL2hCIZANPwwgIdtjYbrg29ncqDnfsGA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OCy1WPnx/z4NnARK/V5H/1uX8Ikk3p8JyO3z75VbN5c=; b=cPv0GSPJiV2YdeBSZS37W8gsSqBBr1NHroTafMIA/sPMGzA8FrnkRuYH2T4kql9juv12qqsvSkcB70FLu2m6Hnz/0AV7LG84Y2GjofMnn30rbXU8k7GNJFb3tIVNLvWGSFEYTA3OFMgKQc1wnKOAQg1GXVoWsPCRbADueoYdwKeEHo9U2CLxI1JAoxeIFclFGC/LmnprSnDVMZU26hGXQgMUSrOFFVCBbSv72J7z6oPiYDgmkAoiKLVxFvzrRmQyYvBKTBlFck1yfpksJ1jxYVaJmuB9qCpG6Eno8KKCQqeCHTzX10TQA21PKfgMIGwQ5Jhtjrd+Ajc5VyGBW/EngA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OCy1WPnx/z4NnARK/V5H/1uX8Ikk3p8JyO3z75VbN5c=; b=Lvo3gC2qYhBCdSkaDyoSqluPM61ABscGrI9Fv87XYDKrVa2Q63yUOWlCGS4JTQ1XjbbsfS7N8IfeZm3sLrCXsGp6mg8qenkLXKhiXOQhiSzfPQ1wDshQUYFBe/ukdj3j0/pjIWBBvTtrHvcc3Kffq7QPxWnGMZrHnXDRB9m7tbp8xv0NEYWUbMDpK1Z7OcBIvtLJhblGx8y0xQ3ST8gZL5Qw/5HoJR2AxOaLatOZJpiPqLQ19sdwRZArlYTXMYNsG2zt8ApkIg2TiWVFiF5Klq9vdmY5PjMn4ACmgU4EALMExair7Dx4Fh0YUTicPqNemg2r8v0VV8z6KBA/okp9LQ== Received: from DM4PR12MB5312.namprd12.prod.outlook.com (2603:10b6:5:39d::20) by DM8PR12MB5447.namprd12.prod.outlook.com (2603:10b6:8:36::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4669.10; Tue, 9 Nov 2021 09:57:17 +0000 Received: from DM4PR12MB5312.namprd12.prod.outlook.com ([fe80::7cf5:9d34:fc6b:b4a4]) by DM4PR12MB5312.namprd12.prod.outlook.com ([fe80::7cf5:9d34:fc6b:b4a4%7]) with mapi id 15.20.4669.016; Tue, 9 Nov 2021 09:57:17 +0000 From: Raslan Darawsheh To: Bing Zhao , Slava Ovsiienko , Matan Azrad CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [PATCH v2] net/mlx5: fix the RSS consistency check of meter policy Thread-Index: AQHXxC6KRe0x0SSe5UW1wdmpurRqRav7F+nw Date: Tue, 9 Nov 2021 09:57:16 +0000 Message-ID: References: <20211018131612.145215-1-bingz@nvidia.com> <20211018144307.148246-1-bingz@nvidia.com> In-Reply-To: <20211018144307.148246-1-bingz@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 432570e9-4fc3-4e81-958b-08d9a3675039 x-ms-traffictypediagnostic: DM8PR12MB5447: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: gynj05NTIrIUiGtAddYVdCJSypz+2gjj8F7jBiZ6zk0IN8k6OL2QjoxcSzINYyeC1H9gbTwLCHAnInd21Hf0oyQflBGwChp4bouUSVd4VQ/e5dityu2JrSF/Azj+CU0jMBaiB1MK0TL+yHt+MPH2a7w+57L24Enr48AGc2rJWngIUDDUejQBN/gAbIv7PbakvVikfhjlzOqAk61s5V1sd0jbfQhP3sxCmkdswYwjoEHP1giDrKAdgt6DVlBfNpNKZtMWMUeIebvNnI+4eTpsYBIvqnAztrtWctevPkAAiUP7zS1XNOjCMD4s80fU1n2aYujWxt3XFHnrOVnDCQSblRRvUnG6R0E051kFKv41dqgHRV88puhVF/rwQ6DZKmrwK+/5Mk+3J7oii3d7XBnSaKO3d5E/vjPPXGkdgiIaFNck5jJ6WocTpbkHp8ftjsaW2DXhKoTsXcT6Lyo6S1SRxs7z28TyagqhIE9HJkO2su6KQaepccMcep+eubEPDcA6fPYAz+kG9ydkphZifoSFlZRydI+2WmKvSpXmBLeCM62YGQ3KArOQBK+Guw1fifl2Wh+drPp6o5UZjUnCmB5008rnNeNxVpCNVwPM4R9LUoRyx3P4gdlkac5qOnhGO3gJ9eqc6y51k0YpyucV6JD7VKk8bGthQ8a5MRafJJ0AZT+1v71dU1Smz0ijEZ25G070SVhArtJts010+wzuYeG8mg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR12MB5312.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(54906003)(186003)(110136005)(71200400001)(66946007)(8936002)(86362001)(66556008)(64756008)(450100002)(66446008)(76116006)(8676002)(33656002)(6506007)(9686003)(508600001)(4326008)(6636002)(5660300002)(38070700005)(122000001)(2906002)(26005)(316002)(53546011)(83380400001)(66476007)(55016002)(52536014)(38100700002)(7696005); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?2P7RV5Mc3jJK5iNZDbKnf021Cv2y9W8Ug97BBSV2SRAGdaGkr/duHzReorQ+?= =?us-ascii?Q?GwNFxUTbBRHaPITB0QmO6HeRx+BGCM+oepwtxToWF5bL+YFLT+8nu4Cni1Jc?= =?us-ascii?Q?rhHFlhFx999fQKhDeyS38Tf7ssr6nC85tdVGfPEKoS8+PkR8HRLospDGXCIQ?= =?us-ascii?Q?IMS8qbkYvMQiPvEC5s+N02NEV3uy5tYbvpcoAejS9vhgNyuRm9C6K1ukaUKy?= =?us-ascii?Q?MoosjXUYvuAhsYIJndR3kDqmIROpviQtlsclFuVd7Qxf6sS0eui8IYAdEYcd?= =?us-ascii?Q?9pT3EuLeKl+W6dGa/PX9SWvqUYHI6EbpQdLAEvw6aQAN/4MrkxjKZwfWn6fn?= =?us-ascii?Q?40fqzjHHS8R37HESk2M+vzUnooGatDSRQHk7jtVi19MRFDASCq0VK2K0FPF0?= =?us-ascii?Q?YILDAHyQdMrdDWq2MZwuyRd6gfoyVmvdsNGASoTDEL3R85DUTDp/aAwRxy6m?= =?us-ascii?Q?Giz0+IfwbOD2SyuGQEe58YShE7zxB/TficLZi0zWfrZK2PovexFBIPlzIfz5?= =?us-ascii?Q?6AolsSjHvZLuaZ4jxMFM210fGE01gi5neo4I1w9XMLsoOZNoPuojtRX6DKGR?= =?us-ascii?Q?XAQDSEDS8OTbqoTQEsJfuK6ktFSbiDq1My6v8e76qzW0iAGUvVzkJDPuz292?= =?us-ascii?Q?siP4CTyC8nLTARBhlVit14DqZChDG7s651zLYoFxqO1/Fae6gVHHXN2tOK7P?= =?us-ascii?Q?TZ6LrIMtQaMq5miH8YhocizxeMhK95w3qiL93DTvHV2Ju+x01ufZSp6DbKFm?= =?us-ascii?Q?NlJf4IkL+o6YPcGk96f687FBxmk3wGcsWrcNI9CtTH0EnIB2Oeu8Fqt/HYQt?= =?us-ascii?Q?ulVwt/oefW2Z2KGqbTDpvZJlybc4JCo9+raw25VR2S50rWXK5QAmckhj/WXE?= =?us-ascii?Q?I0Nl2eiIiDReLD9EQ6FLac3VGOcLCQb/C5mtSu4ybIHSqz+QQYitv4ccBeZv?= =?us-ascii?Q?8+S+hSYXbCw1C81ZiQEVyrcZo0lrbaLfmBQImggkItjh5ykTExRw1R29r5LK?= =?us-ascii?Q?DB9PB1ktGBL90VGlfPwYcwvySFiE4Gi/6ynsZ5Yw1Ns1RPFsnxDcabjIth3D?= =?us-ascii?Q?MgIR3fopYzEPDImMukHFg6I9/WV6WfT8LdFnH6RYG5bVjRWsDiTR9FL789O4?= =?us-ascii?Q?sunAD576F5y4lR2lVVDKml+rf5+2g5saO+URLT0CpVoL2p74US7rY7Zd0zLy?= =?us-ascii?Q?QYCkDqB2ja8C2UItZ9PjuXmBiDCEzHutNM2znMjPUp5lepeE9EJ3xYrcjPef?= =?us-ascii?Q?gdI43GTBDTf4E0QJGOGsgjDd58kH6b7JGDZ6+c4vdpiD5W+A0K/9Ct/MeC+O?= =?us-ascii?Q?KXVK5ITgIlYVfqVqWbBOyYUewB8n6pcV2buyfQQqajnkIKsVmnEi2k6BCCbA?= =?us-ascii?Q?N9qQe5ccBjy/LAzahfb0FlnZt3nkMbyBdPVV2bjAlXuq/8mvmZRVlDeiB4ly?= =?us-ascii?Q?L7SwDOQOeWueQHtyOQl9rz9spFU+ysQDqk7Y7vIm9HS2J8C4ulPnO7KyoPRQ?= =?us-ascii?Q?INyubXWqUKwS/n+OlU3nj+Z9wsGadggA5A06m4PttGBOf78PSNnDaJ3j7X5t?= =?us-ascii?Q?+YUXNaCqTOnqwPYG39k75iOHto0QzB1bylukyEddlG08A7M/b3pbY8tYCsyn?= =?us-ascii?Q?ZLy5pKow0f5ENnF48Qkiy28=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5312.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 432570e9-4fc3-4e81-958b-08d9a3675039 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Nov 2021 09:57:17.1301 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: +CSkLU9dO72wMAifPFgq1qJIx7WkFqrCl+Ckbu5WywhzGnRuSPCxQq4YGVAHE+BpzieNzIKd+oEkm/qcYETAmQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR12MB5447 Subject: Re: [dpdk-stable] [PATCH v2] net/mlx5: fix the RSS consistency check of meter policy X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, > -----Original Message----- > From: Bing Zhao > Sent: Monday, October 18, 2021 5:43 PM > To: Slava Ovsiienko ; Matan Azrad > > Cc: dev@dpdk.org; Raslan Darawsheh ; > stable@dpdk.org > Subject: [PATCH v2] net/mlx5: fix the RSS consistency check of meter poli= cy >=20 > After yellow color actions in the metering policy were supported, the RSS > could be used for both green and yellow colors and only the queues attrib= ute > could be different. >=20 > When specifying the attributes of a RSS, some fields can be ignored and > some default values will be used in PMD. For example, there is a default = RSS > key in the PMD and it will be used to create the TIR if nothing is provid= ed by > the application. >=20 > The default value cases were missed in the current implementation and it > would cause some false positives or crashes. >=20 > The comparison function should be adjusted to take all cases into > consideration when RSS is used for both green and yellow colors. >=20 > Fixes: 4b7bf3ffb473 ("net/mlx5: support yellow in meter policy validation= ") > Cc: stable@dpdk.org >=20 > Signed-off-by: Bing Zhao > --- > v2: remove unnecessary parenthesis > --- Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh