patches for DPDK stable branches
 help / color / mirror / Atom feed
* [PATCH] net/mlx4: fix empty ETH spec with VLAN support
@ 2021-11-22 13:53 Xiaoyu Min
  2021-11-23 13:26 ` Raslan Darawsheh
  0 siblings, 1 reply; 2+ messages in thread
From: Xiaoyu Min @ 2021-11-22 13:53 UTC (permalink / raw)
  To: Matan Azrad, Viacheslav Ovsiienko, Dekel Peled; +Cc: dev, stable

When the ETH spec is empty MLX4 PMD doesn't allow match other criteria,
which means the flow should be promisc one.

Currently, PMD validates this by setting flow->promisc bit when ETH spec
is empty and checking whether there is other rte_flow_item followed
when flow->promisc is on.

However, commit [1] adds support to match traffic only on VLAN id, the
above validation logic should be changed accordingly.

This patch changes the above validate logic by skipping flow->promisc
check if this item is VLAN.

Fixes: c0d239263156 ("net/mlx4: support flow w/o ETH spec and with VLAN")
Cc: stable@dpdk.org

[1]:
commit c0d239263156 ("net/mlx4: support flow w/o ETH spec and with VLAN")

Signed-off-by: Xiaoyu Min <jackmin@nvidia.com>
Acked-by: Matan Azrad <matan@nvidia.com>
---
 drivers/net/mlx4/mlx4_flow.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/mlx4/mlx4_flow.c b/drivers/net/mlx4/mlx4_flow.c
index 2e1b6c87e9..9d7247cf81 100644
--- a/drivers/net/mlx4/mlx4_flow.c
+++ b/drivers/net/mlx4/mlx4_flow.c
@@ -713,7 +713,8 @@ mlx4_flow_prepare(struct mlx4_priv *priv,
 			flow->internal = 1;
 			continue;
 		}
-		if (flow->promisc || flow->allmulti) {
+		if ((item->type != RTE_FLOW_ITEM_TYPE_VLAN && flow->promisc) ||
+		    flow->allmulti) {
 			msg = "mlx4 does not support additional matching"
 				" criteria combined with indiscriminate"
 				" matching on Ethernet headers";
-- 
2.34.0


^ permalink raw reply	[flat|nested] 2+ messages in thread

* RE: [PATCH] net/mlx4: fix empty ETH spec with VLAN support
  2021-11-22 13:53 [PATCH] net/mlx4: fix empty ETH spec with VLAN support Xiaoyu Min
@ 2021-11-23 13:26 ` Raslan Darawsheh
  0 siblings, 0 replies; 2+ messages in thread
From: Raslan Darawsheh @ 2021-11-23 13:26 UTC (permalink / raw)
  To: Jack Min, Matan Azrad, Slava Ovsiienko, Dekel Peled; +Cc: dev, stable

Hi,
> -----Original Message-----
> From: Xiaoyu Min <jackmin@nvidia.com>
> Sent: Monday, November 22, 2021 3:53 PM
> To: Matan Azrad <matan@nvidia.com>; Slava Ovsiienko
> <viacheslavo@nvidia.com>; Dekel Peled <dekelp@mellanox.com>
> Cc: dev@dpdk.org; stable@dpdk.org
> Subject: [PATCH] net/mlx4: fix empty ETH spec with VLAN support
> 
> When the ETH spec is empty MLX4 PMD doesn't allow match other criteria,
> which means the flow should be promisc one.
> 
> Currently, PMD validates this by setting flow->promisc bit when ETH spec is
> empty and checking whether there is other rte_flow_item followed when
> flow->promisc is on.
> 
> However, commit [1] adds support to match traffic only on VLAN id, the
> above validation logic should be changed accordingly.
> 
> This patch changes the above validate logic by skipping flow->promisc check
> if this item is VLAN.
> 
> Fixes: c0d239263156 ("net/mlx4: support flow w/o ETH spec and with VLAN")
> Cc: stable@dpdk.org
> 
> [1]:
> commit c0d239263156 ("net/mlx4: support flow w/o ETH spec and with
> VLAN")
> 
> Signed-off-by: Xiaoyu Min <jackmin@nvidia.com>
> Acked-by: Matan Azrad <matan@nvidia.com>
> ---

Patch applied to next-net-mlx,

Kindest regards,
Raslan Darawsheh


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-11-23 13:26 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-22 13:53 [PATCH] net/mlx4: fix empty ETH spec with VLAN support Xiaoyu Min
2021-11-23 13:26 ` Raslan Darawsheh

patches for DPDK stable branches

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ http://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git