From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8EFCE428B7 for ; Sat, 8 Apr 2023 15:31:24 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 684DD40EDE; Sat, 8 Apr 2023 15:31:24 +0200 (CEST) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2055.outbound.protection.outlook.com [40.107.223.55]) by mails.dpdk.org (Postfix) with ESMTP id BA71B40DDB for ; Sat, 8 Apr 2023 15:31:23 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KJW5EFLykwbFsWIph700VazLIssKXEt8xzCybIgQ4P/DAifiykqPol34c8MobpJ/Bb0R5XsU5at4X+15xUQr2XEOw8XhEkVubPduld47CYkpMjh4TJmKKrjftih5fn8R3EdI1BsJxkvgG/Vb9UA325a9Q9zOBt4ONVcWeIeGBAFV2XUwPg05mR4sMsFaMEdtrfngJUEEfVPF6KKtV1YZZx/tP/w+WzACW2+dfGe6Ao4ALxXTtSpPyr6G0xUoxdy1Q3JKIr3tEeD3t/nqOpHiP9VQ/FfG2ixbWYNAkEkHzia2uTCLW6Ds/Y5JixifCWQ5gtuJQLlmX7/lVZx2LVRA+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LuK2mmutsRMZRO/f5Z1hem4nzszdBWMxVB9/hfZZavM=; b=iXqWcC6TlIFGQOYVaUHYNRiwOWHw/cIl3vqXS10VB9rS5bx4w47X/k9fCG+ylJ2JugcnIMM/Kff/sxVzUxahRTwbDfBe4tedSnWT4med3bVcqcjtSPJ7AgHFlKy0xNk0k3nwQG1MP4BPodf9xhTVqJ+aDE5eo6uFEUtWt1CSLSaJOeU/6zIKSRvuSduSqIb4c996fYVEx1QrUhozSy2T8s9kRHDXqXpAZCOFy+JEdg7rQnGl5CVBVU0UaW33lSMbXqqq5YzbqfBsyOKsMoegb2zQv1RfqL6l1ZGTkLROnX58B24WqH0XF68oHWi8SMheaDOT1IVzqplKqTrF+mhE+A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LuK2mmutsRMZRO/f5Z1hem4nzszdBWMxVB9/hfZZavM=; b=nX2O6frC1MonMfZUnhDIktEOPjFCmlK8t42vNsAWlgV+pJUMRC8UjY9naS4bIiPTzbQKO79SgvNCDvQfTihrkRmL2ZvYKbD78zOw1/9yr/ZBF1njUVTvl2i+UnilXEG/j7Sy8Ai/Grdol1U8t9wjDIdWWAe1OEcxTKP2jkU8MfV/bAhLiQcdCW8mOH/9BRzDqZM6hAEn3oBQmaCB51ratVdRGprHGDnXpzjdRrdrYHEUIdZRBQStW4tc2yhnCRp3mCIrMxTDo5jx6rjPmGkJS0vXn1+k39B/zXQ7wR8oUHz2py6f/8Jpb0/M1nWhiu72ssJNpEL1K/NAuxAOt2UtmQ== Received: from DM4PR12MB5373.namprd12.prod.outlook.com (2603:10b6:5:39d::14) by SJ2PR12MB8845.namprd12.prod.outlook.com (2603:10b6:a03:538::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.34; Sat, 8 Apr 2023 13:31:21 +0000 Received: from DM4PR12MB5373.namprd12.prod.outlook.com ([fe80::f16:b0ef:d3e:556d]) by DM4PR12MB5373.namprd12.prod.outlook.com ([fe80::f16:b0ef:d3e:556d%7]) with mapi id 15.20.6277.036; Sat, 8 Apr 2023 13:31:21 +0000 From: "Xueming(Steven) Li" To: Rongwei Liu , Matan Azrad , Slava Ovsiienko , Ori Kam , "NBU-Contact-Thomas Monjalon (EXTERNAL)" , Suanming Mou CC: "stable@dpdk.org" , Raslan Darawsheh Subject: RE: [PATCH 22.11] net/mlx5: fix crash on action template failure Thread-Topic: [PATCH 22.11] net/mlx5: fix crash on action template failure Thread-Index: AQHZUBt5XAu7wHRTSU+Y7nvi5DxgH68hnGQA Date: Sat, 8 Apr 2023 13:31:20 +0000 Message-ID: References: <32273080.6xKfjbll68@thomas> <20230306110419.2262250-1-rongweil@nvidia.com> In-Reply-To: <20230306110419.2262250-1-rongweil@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM4PR12MB5373:EE_|SJ2PR12MB8845:EE_ x-ms-office365-filtering-correlation-id: 50ec9118-d780-41c9-81a5-08db38358a68 x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 0ijrWIoqKOTWFVuRVDLukrYZmYql0Q11/p/lo2WWrW+HIzjuzL/8r3bvq5ibn7AHe7iMy16728iPup4KF0X/pAwwf36D7a9n7q1aP7Xj0LbO97Rx+ZuAuQeqCM6pun/MMtOFGOOpPR0lDBHejK4kOxzkAXZ2LTf8P1nV1XlqwIxN+/CPDOOi6fbNzGnnoHwsy8uXm3ygciqQ17N0GMNegzOBEIJtRI3O31OoIVJSMHjPpaNN2Wt/0j8LuQO5dHNYCzNiUx5p6yu7rYsgb7IZV5uLob7WQQZWybG1nB78j/lyPClJ/WU+gwSFzgzkDi32F9FEFWMe+ZyWEJXJ9HmDBXfJRqLGba+857E9UO9o3Xm3T9IgJNvmGHEE7J+5ZyxzCVnZkymeQddR8JypjboKsBQIsWLb/PirpqwMDlP/A7v230ZH7638SIazd3rcfMG5WPfg78dKBH/oi+8mVx4tPwtGcN2OXsplwb9hu+RcIEYUQyhi7QnoqlkBOH1rr1BmIPllUa4bYQJsC94S0gZZ41sLiW/OkyOw7bjkVJoJsnD6oZEeeNz97FP2cj3AG4BDYxyz4lBuAwXCjS6jaTlKsRVMpuw/xJTRc9o73QNIeKM= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR12MB5373.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(346002)(136003)(366004)(396003)(39860400002)(376002)(451199021)(8936002)(41300700001)(7696005)(71200400001)(52536014)(55016003)(38070700005)(83380400001)(316002)(110136005)(6636002)(54906003)(38100700002)(122000001)(107886003)(5660300002)(4326008)(33656002)(8676002)(66476007)(478600001)(86362001)(66556008)(186003)(66946007)(76116006)(9686003)(6506007)(2906002)(53546011)(26005)(64756008)(66446008); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?z1vGHIWGB/Z8HfK8PYCoBYP3lnpzS+KReXg6ToG7H2l1/uE/szlK+Z6Rp+Ku?= =?us-ascii?Q?bCkKWeAFgSI73oLb0a5A4Y8kDuDO68GwaaEopoa3s6I7R89zaz8L3q/ufSla?= =?us-ascii?Q?GRkvyo4GU3sqLry4gCJ3HClFxMDcmqXmVW44/j8LA9mVVGJqW3bvdEylFTcx?= =?us-ascii?Q?UWShDCVvY8mVmMXQrydPhZQf8+gPesv2TGX7MlFDKQHumyAQsAiUSNS6WnLN?= =?us-ascii?Q?Yc8BnAou3mA/yAzrfiuO/cby85gX+21xct2p6GT732TxEIKRlOlJ+2x5Y+dl?= =?us-ascii?Q?AhWqgwkE8pIShvRfXCXSzZP8mNFw8E3DCV92nLPJpD2vpX8b4BjZcKv+6s9G?= =?us-ascii?Q?1DwGRrR4jDlrCBZobvLhzcUMrWfqRYJkvXJrMAI2t4zoiUvmsI94zx8EfZGB?= =?us-ascii?Q?TsGB6F0AZ7Twtx3XPPSWvKlf6fWiKFSGHb37uMScSXWtc5mM07mSwuFP8lxR?= =?us-ascii?Q?5tXDDajUAV4cDECvqnEHKBEoqNDUVRLCETJ1ILB5uMMkFfIy76/KCLU2ZC63?= =?us-ascii?Q?i8265PiBp+VgZQDo6M1MuJ8Keo6QXxwPtDMRpw4jwEJwXbtK3IBh8EcAkNyt?= =?us-ascii?Q?z/f5lF3cYdlohwvDJu6bKA4cDSpagLoPdwctzxphuUA1th5nowzUQWhNReD/?= =?us-ascii?Q?6HTTyjWZU/Nu833y8tAaunqXLjdjjD7ytX26Pw8HSiHqwvw4BbVfecnrUDtZ?= =?us-ascii?Q?ogvXQmzXVqG1ocUtzVFxPZ5LXtyfKRdqrtxbKoFsa4FlTCnbqeAHPMGdrPnX?= =?us-ascii?Q?P2hJ+eztcTJRgANtouXVPTH43kW8spapitW0fNUhzvRokt1+kmNE8rMbD9zS?= =?us-ascii?Q?lYgqSPXSgLwnU9xqHk5g57Rb23gQYmdGpTuIOIRhoYPllZYGWZ3NOlfgywP3?= =?us-ascii?Q?cCwfPV558ICri1UDaDnSVRMck8lPKb8IBHW70VA+NCLn4WYn4Ds1hVbwHVg1?= =?us-ascii?Q?2Kv4unHyu1QyozsFr/I3Cs7nTkyf282p/qVEDiNuta6nwpAIw2K9SIUIgYNS?= =?us-ascii?Q?INnca8sfIZPmJLkFh9ONZqPv44Qt+eEnd0/z9tbH5uPME0ewH05AmPYVgQSa?= =?us-ascii?Q?BhAWSTF8G/wXWTvpGVuNzAnSlqNCZKsqyU9yV2M4B8RQEHJqqRJ+NkcNo9r8?= =?us-ascii?Q?TXPpQXlvFgDL07wubLWUtXPWqZNCGlyOFTfqgD7pcTH9xEVtGrD/vTRtWZ7S?= =?us-ascii?Q?6Qe2wiLpHB84bFkd0iNfodL13/WQPVFA8ByV8Gggc25FfOmSExNG6JZnOSXi?= =?us-ascii?Q?E93NvQAA2gBOTD0vv8AOBne7zFfKirWDxW3oXwdCeC99DnYKlNQkFmIszLyY?= =?us-ascii?Q?iYu5rrthbKy8XP8gMutiqM9ofJjgZHQyxLJhVCkXQFziuJStvceCZ2cRYd+Z?= =?us-ascii?Q?QFGqW68sKIuTS1cxQaNsIelibkgWEKFVcKzxC85Psic9TKC6Wnb01N/GICt/?= =?us-ascii?Q?7w1jXKAh7fonwjG7UYfg93UvwB+PRmIvZmugxvie9oSP9yYBq6ilbkFLNuqx?= =?us-ascii?Q?0W+BezyKfLXNVT9tYhrm12CDLRuvUtKv9XxFuyGbZGAQ1SqcWXokDSSEo+yo?= =?us-ascii?Q?cd3rtYE2VM/a4fTd/0v7AqcENWUoapY619lJhY9e?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5373.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 50ec9118-d780-41c9-81a5-08db38358a68 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Apr 2023 13:31:20.9231 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: c37tx+IeRDIIaj01KWW75wRn1zKaUR2cmmg3GZ+PKYSdt8I3e+OV54uRhbpI1uIZyWWND7eyqUjQJvg62It9ug== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR12MB8845 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Thanks, patch queued to 22.11.2. Best Regards, Xueming Li > -----Original Message----- > From: Rongwei Liu > Sent: 3/6/2023 19:04 > To: Matan Azrad ; Slava Ovsiienko > ; Ori Kam ; NBU-Contact- > Thomas Monjalon (EXTERNAL) ; Suanming Mou > > Cc: stable@dpdk.org; Raslan Darawsheh > Subject: [PATCH 22.11] net/mlx5: fix crash on action template failure >=20 > When action template creation fails the testpmd expects error details. > The driver did not set the error structure and testpmd failed with a > segmentation fault. >=20 > Fixes: 836b5c9b5e0e ("net/mlx5: add action template management") > Cc: stable@dpdk.org > Signed-off-by: Rongwei Liu > Acked-by: Viacheslav Ovsiienko > --- > drivers/net/mlx5/mlx5_flow_hw.c | 15 ++++++++++++++- > 1 file changed, 14 insertions(+), 1 deletion(-) >=20 > diff --git a/drivers/net/mlx5/mlx5_flow_hw.c > b/drivers/net/mlx5/mlx5_flow_hw.c index b4a80f977f..9e5f263ccf 100644 > --- a/drivers/net/mlx5/mlx5_flow_hw.c > +++ b/drivers/net/mlx5/mlx5_flow_hw.c > @@ -4946,6 +4950,9 @@ flow_hw_actions_template_create(struct > rte_eth_dev *dev, > mlx5dr_action_template_destroy(at->tmpl); > mlx5_free(at); > } > + rte_flow_error_set(error, rte_errno, > + RTE_FLOW_ERROR_TYPE_UNSPECIFIED, NULL, > + "Failed to create action template"); > return NULL; > } > -- > 2.27.0