From: "Xueming(Steven) Li" <xuemingl@nvidia.com>
To: Matan Azrad <matan@nvidia.com>, "stable@dpdk.org" <stable@dpdk.org>
Cc: Luca Boccassi <bluca@debian.org>,
Kevin Traynor <ktraynor@redhat.com>,
Christian Ehrhardt <christian.ehrhardt@canonical.com>
Subject: RE: [PATCH 20.11] net/mlx5: fix typo in queue counter query
Date: Fri, 12 Aug 2022 07:34:34 +0000 [thread overview]
Message-ID: <DM4PR12MB53738DBD0978E32D0E808438A1679@DM4PR12MB5373.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20220731143415.1550792-1-matan@nvidia.com>
Hi Matan,
Slava sent another backport patch for the same issue, I'll use that version:
https://mails.dpdk.org/archives/stable/2022-August/039873.html
Thanks,
Xueming
> -----Original Message-----
> From: Matan Azrad <matan@nvidia.com>
> Sent: Sunday, July 31, 2022 10:34 PM
> To: stable@dpdk.org
> Cc: Luca Boccassi <bluca@debian.org>; Kevin Traynor <ktraynor@redhat.com>; Christian Ehrhardt <christian.ehrhardt@canonical.com>;
> Xueming(Steven) Li <xuemingl@nvidia.com>
> Subject: [PATCH 20.11] net/mlx5: fix typo in queue counter query
>
> The backport commit of the imissed statistics fix for 20.11 includes a typo issue and use a wrong pointer in DevX command to query queue
> counters.
>
> Set the correct pointer points to the created queue counter object instead of the context pointer used wrongly in this query API.
>
> Fixes: ede02cfc4783 ("net/mlx5: fix imissed statistics")
> Cc: stable@dpdk.org
>
> Signed-off-by: Matan Azrad <matan@nvidia.com>
> ---
> drivers/net/mlx5/linux/mlx5_os.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/mlx5/linux/mlx5_os.c b/drivers/net/mlx5/linux/mlx5_os.c
> index f98cf90dd8..05f47127c9 100644
> --- a/drivers/net/mlx5/linux/mlx5_os.c
> +++ b/drivers/net/mlx5/linux/mlx5_os.c
> @@ -2589,7 +2589,7 @@ mlx5_os_read_dev_stat(struct mlx5_priv *priv, const char *ctr_name,
> if (priv->sh) {
> if (priv->q_counters != NULL &&
> strcmp(ctr_name, "out_of_buffer") == 0)
> - return mlx5_devx_cmd_queue_counter_query(priv->sh->ctx,
> + return mlx5_devx_cmd_queue_counter_query(priv->q_counters,
> 0, (uint32_t *)stat);
> MKSTR(path, "%s/ports/%d/hw_counters/%s",
> priv->sh->ibdev_path,
> --
> 2.25.1
prev parent reply other threads:[~2022-08-12 7:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-31 14:34 Matan Azrad
2022-08-12 7:34 ` Xueming(Steven) Li [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM4PR12MB53738DBD0978E32D0E808438A1679@DM4PR12MB5373.namprd12.prod.outlook.com \
--to=xuemingl@nvidia.com \
--cc=bluca@debian.org \
--cc=christian.ehrhardt@canonical.com \
--cc=ktraynor@redhat.com \
--cc=matan@nvidia.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).