From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E90A5A0543 for ; Fri, 12 Aug 2022 09:34:37 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DFA2A40A82; Fri, 12 Aug 2022 09:34:37 +0200 (CEST) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2050.outbound.protection.outlook.com [40.107.220.50]) by mails.dpdk.org (Postfix) with ESMTP id 152A640A82 for ; Fri, 12 Aug 2022 09:34:36 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=P37YR6m5NpC+9743eyO7bODmzHZpIi16EYwAiHftu5uN0Se+fYI5wDRuQ4Kf1HNkXU5awnkJbBNvuxDvnUeXlI4ls7rY/ecMw/M0ELx21TQ8mp5w60q/28HYlUjhOSFZyMpPBBixAqF38Z7TBU0lGxQqqFkPSTJosz7vU+k9AAZHQlzRchxlYmPDymMS37KHF16ZGEpcj/FxHbSqTMjC5O+e6qqzQQrAfoHa4yXIJG0DHSLhREihOH3/0+3K913qHgUB8qesDoGBVUXpUiXbtvJPebG1BTksuSq5+6qaIdeo8aj5PnjZY54dc5d4v3CayQX9zkLgDyZ1aZzbFNjc0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zsCQsHJxjfBV6De3rCKdftP3E6yMCylJIKDCHnmzbOw=; b=UjnW0MEMv773KFV4ctagFQLhMNqre1qv0wD8dd00eTTAP0M37wxEEVOv/rXReHBDt+mhFJ/3W2xvjhbWyL71PESoMfGS2ltYJLfaQuTUErfsoCcx9UIknEcQaK5opnGS1nldxRFVL+Y6CeRbmkK9ijJKR8vWIOG1opITg7bmLxcBAE1UWYYP6HhxlorSOlYV5ThVvrj7L3MejUoOCmc+Sja5+g14wE3omlvqZW+mpo22vg7ampFudhDeBeQXfIgpqxiwrTO06HW19xIjAc1dyDCkUW5qacHQtLSlUBcFPQJaXplBU8xgWGzKJiHPafI9a5VctMGQgWlb+XbWU3VLzQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zsCQsHJxjfBV6De3rCKdftP3E6yMCylJIKDCHnmzbOw=; b=GAYjzpwdjFAM1TaEYYw6aTFtGUbXGFPZeOcWUIwlYG68s7J4N4yyIaJxt51AWRvktsyXlkjDhxipaICsW2+ukILsqwsoNF5csk2e/x/jqfOHlJKp3fNgw4qaELX2+gTwmxf4o+L0pakwGDBEG2/N750aKAHfAxrAl4nJvvl+UZFAxu1souL+NVZeFRmn9AvSfJGFIFKo6T6CTMXnEHKzPCWpaF+UuhyyDoftzXWAy+0GKDwBsQP+gBzq51FsIxXR/umUVyVybOxqpBYMJZOSo7B9ry7GABuFapr5KCGvPq0Q35kB+cNVfkL2eUz0ihD6dFTGYYGL89/AdKlQNceWGg== Received: from DM4PR12MB5373.namprd12.prod.outlook.com (2603:10b6:5:39d::14) by DM5PR12MB1450.namprd12.prod.outlook.com (2603:10b6:4:3::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5504.15; Fri, 12 Aug 2022 07:34:34 +0000 Received: from DM4PR12MB5373.namprd12.prod.outlook.com ([fe80::442b:be8b:c1ec:a6ee]) by DM4PR12MB5373.namprd12.prod.outlook.com ([fe80::442b:be8b:c1ec:a6ee%3]) with mapi id 15.20.5504.024; Fri, 12 Aug 2022 07:34:34 +0000 From: "Xueming(Steven) Li" To: Matan Azrad , "stable@dpdk.org" CC: Luca Boccassi , Kevin Traynor , Christian Ehrhardt Subject: RE: [PATCH 20.11] net/mlx5: fix typo in queue counter query Thread-Topic: [PATCH 20.11] net/mlx5: fix typo in queue counter query Thread-Index: AQHYpOqoCb9y2SzRHUGjySL8XR4kBa2q8YLw Date: Fri, 12 Aug 2022 07:34:34 +0000 Message-ID: References: <20220731143415.1550792-1-matan@nvidia.com> In-Reply-To: <20220731143415.1550792-1-matan@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 25e04200-38f4-4d49-3abe-08da7c351a3e x-ms-traffictypediagnostic: DM5PR12MB1450:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: N2YBMINrlQfXRmc/EQFwEeCc2jallNYhztRABVNT58PEKzcb9gh2EjrkLZJbuwO/hfA94giyPw5F2tqZRdM7lzQmeaSbVPDWMwHlDz9nKCkbJ4ImOAOqurbVx5o5seD8dPADbOIvEt9oCjJu/2fWpeQ1TLaDUMbaDlZHOblRrOCXbvjqNJfpwDPS0tXKrssRNX6pyrsybk3OrfVj7jdKKZkvUfqA0h1jIpjtKGD+PVTEUg6oehYtLnKQftjVMJbERRuOOI8vOt1nXoMeLFvc/Q6uOWysVJDu8uGLkkHQKvHOeDc4mueJl45IS01XSWjw1qxLWHVrEjemyRPsBlb6hH32891lI55Gd1jEr4BUg3ouuAd8gf0a8tqTC4eovpozoHlnN8B7zNtrWLH05X5jtfRfuZgRDCW4um59kDFchTt5tmWBZhWbCRTJq2ujtozhZOmUYWo2HdHBeV+q3x9gjHQTjBh0yIqy5aZs6tkid7p1604L5odeNkFJ1TB0EQYnpMg29QXtn1XusM/G3ihxBxS65AP9A6rJuWYht9ouiWmP5XVfp3rZ+2diTEhZMsTx9twzuMdbOGYv5PwC5Z/OjjkBPxjy6ljcKo98/lIUCFI5Clu/ZpNmtdOIoO8T3LvX67eE6Z1SJ8BZcZd4XFwIYjsFhGn0GldPvPRdbsA12+1BrfrhPAUcG/7w295UkRBgjM+u+kVoYylieSxvz+y+GcxeKXCZmJQvx25IwqNQWt94U+Z1tXqiv/r85vNQIVWjdRb/+2NyMbq8j8x6DPruP7b4oG7f2atRZ7AaueQaPsEvOQAcbd3ylvKN1tCz6fCuJk0xU8pBsVkCWPh8NJS/hXAK2HjenWQJN2o9VA3k/AGvqtpzwBRgXdz5lQ3Mn2VvURCgLDy4c4xm5AbjJSfEkg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR12MB5373.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(4636009)(346002)(39860400002)(366004)(136003)(396003)(376002)(2906002)(38070700005)(54906003)(110136005)(316002)(186003)(83380400001)(86362001)(71200400001)(55016003)(9686003)(26005)(7696005)(6506007)(53546011)(966005)(38100700002)(478600001)(41300700001)(122000001)(76116006)(4326008)(66476007)(8676002)(66446008)(64756008)(66946007)(66556008)(52536014)(33656002)(5660300002)(8936002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?0q+aBFkTi4I0eFNxNUtvHJpophoE47xrCCZJsLhIQ2/DmsNNOobXRDo3my8f?= =?us-ascii?Q?PHZcwb9wtVSnO/EWBSCFfvjkLcTcfCz+evPes68DsftZD5ILzO9ilkqYSI7Z?= =?us-ascii?Q?JgMyYslTtqXihh05ADpUYKZRVFGBSB/hxDNSCQAgdxix8+VHZRftIxlwZY4q?= =?us-ascii?Q?dXFrIxrss2iXBg2F1a+rPkgqetTn7RmGwqAO7zAAf4Dikmg71LW4hszNlGO2?= =?us-ascii?Q?T5x4kqDfBLkYZnmJURdI89qq2CrxFkOtbly2rwDLJntvoszPhtSRx1p0sI4q?= =?us-ascii?Q?EWpd4ipYHBWfd5FoXNJ25Du5wwF4M6+ttNS4PLatJXIfu0FfLPXVDiVeEwF9?= =?us-ascii?Q?6S8Fhpp++oLGDarP19V+I+Ws5BEw92xTahdxtnxpaOMJ6yvUOW0ItMpnhYfN?= =?us-ascii?Q?+eqq5Ly3gyL7Yyq+ic7kb9NxSYpfChO95yJYAl+JpaxKqI9QUv5C6YfEq+0X?= =?us-ascii?Q?5RWf32+/Q0JcM1GZlrArV2UvvuhNCcFsEoZZ0qzuHJH9+RmBsj4y3tvjlOqU?= =?us-ascii?Q?aKoOTMArzNvuBEqcEB31n9yc7j0naCZiPDZusmsXGgvwHi2o9GGOucEZuvPf?= =?us-ascii?Q?73r0IIlwIFhenIg7GLTVVs0POsG+91jGRaEAXyhvtfaQ8pefu3kLEfQ+KDV2?= =?us-ascii?Q?iXsFjZPdc7noms+oxaH7SL5okpz9Q9AlPhfZIsTGrtvs0Z5MdRve8n5DHd1u?= =?us-ascii?Q?296vailzmPvzpWGkufZBzpjUC4Q1UqhZRKrAelaUf8EsCm6F0j0jSZa7I3tb?= =?us-ascii?Q?uaI1xv/6BgIegzzKdp1QrvHxweiEVJO1QxskULloA20bpStLe7oME6TCI/g6?= =?us-ascii?Q?ZjFuOqiBsmIM5ZqpfN1fPJ25Rq6I2sMg2TnqxQXlbEeDz7W3L9ZuFzWY3y08?= =?us-ascii?Q?38aUmmdwhnYOeLBbAN1Fl3jnf49dIBVVbG/yUIAZj5D5hvSyjNREPAtTtI9o?= =?us-ascii?Q?hLr/Xq5HJu0xZmgrlcRIRCOOZTGfoBNhm7z4i0Mn0+QW30ons84xNQ9HP1nD?= =?us-ascii?Q?hONPkkgwXYW91IZiVtS5wRJv93qdF3C9iaRCDjA8GCHOYq+WHJpiIiIdZx4L?= =?us-ascii?Q?E8Ln4oklOErnWBsk+vrg+X4kWnuwE9DKLMMLr5k5p72irU3E4t04yTX3hCDn?= =?us-ascii?Q?KlJrG4c3kn3sEzw/T4oTXBdjtJzCxx5WjyT/75b2OffDQ0fp/rtcj380fyr3?= =?us-ascii?Q?97qu+xYvx3LKOQAMYHreolyn/3FpnWZR8riMx7mYHdXiLBzqWyB+m7a6zg9y?= =?us-ascii?Q?/TuAABZIArkrD0sKTf0wGwtM5oMUEQV2q7hGTS5sJkMzDC0cs9GfOcRpIw45?= =?us-ascii?Q?oHLPxjTROne/eh5unHGFetBxNCECbQCoTQ3PmK/TTp/7crMq3CnKaFNuGyGD?= =?us-ascii?Q?bo50EMwYr74cKDkmF2Xh9NXDOGDMazzkTO5x5IXq9QoSeuoV8zvJUqmWOJpM?= =?us-ascii?Q?v+qIB67zKKpqqgi5pzs5GvQi57VcMaPKPV+T9ubj6SZTMB+wVmExylj0aKat?= =?us-ascii?Q?J74rtaNLvIn9Q5sux8waDL0oHE7OIfDhy/rwRff0K3PGffziu8PGFnULZiMC?= =?us-ascii?Q?R8bDsM41aULtw2NSi4dzHgdDd8OlVDzwf9iF6ND5?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5373.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 25e04200-38f4-4d49-3abe-08da7c351a3e X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Aug 2022 07:34:34.1586 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: sAyrW00SM1xac4chFApj8moA77PM35pIO7IpH+HmCqQ5s1qlil+v66LNLNUNOC7Fvw36ZYfIudrbHBPXYcrTBQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR12MB1450 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi Matan, Slava sent another backport patch for the same issue, I'll use that version= : https://mails.dpdk.org/archives/stable/2022-August/039873.html Thanks, Xueming > -----Original Message----- > From: Matan Azrad > Sent: Sunday, July 31, 2022 10:34 PM > To: stable@dpdk.org > Cc: Luca Boccassi ; Kevin Traynor = ; Christian Ehrhardt ; > Xueming(Steven) Li > Subject: [PATCH 20.11] net/mlx5: fix typo in queue counter query >=20 > The backport commit of the imissed statistics fix for 20.11 includes a ty= po issue and use a wrong pointer in DevX command to query queue > counters. >=20 > Set the correct pointer points to the created queue counter object instea= d of the context pointer used wrongly in this query API. >=20 > Fixes: ede02cfc4783 ("net/mlx5: fix imissed statistics") > Cc: stable@dpdk.org >=20 > Signed-off-by: Matan Azrad > --- > drivers/net/mlx5/linux/mlx5_os.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/net/mlx5/linux/mlx5_os.c b/drivers/net/mlx5/linux/ml= x5_os.c > index f98cf90dd8..05f47127c9 100644 > --- a/drivers/net/mlx5/linux/mlx5_os.c > +++ b/drivers/net/mlx5/linux/mlx5_os.c > @@ -2589,7 +2589,7 @@ mlx5_os_read_dev_stat(struct mlx5_priv *priv, const= char *ctr_name, > if (priv->sh) { > if (priv->q_counters !=3D NULL && > strcmp(ctr_name, "out_of_buffer") =3D=3D 0) > - return mlx5_devx_cmd_queue_counter_query(priv->sh->ctx, > + return mlx5_devx_cmd_queue_counter_query(priv->q_counters, > 0, (uint32_t *)stat); > MKSTR(path, "%s/ports/%d/hw_counters/%s", > priv->sh->ibdev_path, > -- > 2.25.1