From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D8CF343F05 for ; Wed, 1 May 2024 03:19:33 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E3B5D402A8; Wed, 1 May 2024 03:19:32 +0200 (CEST) Received: from NAM02-DM3-obe.outbound.protection.outlook.com (mail-dm3nam02on2071.outbound.protection.outlook.com [40.107.95.71]) by mails.dpdk.org (Postfix) with ESMTP id EB7B8402A7 for ; Wed, 1 May 2024 03:19:30 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iqX4ruXxiyBu7DB49qZOo+wXA2PlDl6W9KhImtU3uYmkJMSm/06ypQGHXL7GIqIJVKSpwxoMjilGlhe/JxNEs+keCyiYwzStoPkpaQsP75qyK3qLp2OgBAwnThnfR0kZM+PS9ZgrGrGb0xsG2km+ilR+mc6op5WIzBPmqsBiKogm9/a4R0Q1J+7hMb7QakbM/0skjOHYtAk9TFjheyUGwl5iSK9jtdsACZkt2iTVQR+bCaC3loUD7zTt2/4f0313dFWWBKHQyRjvJzjYNkuox9BwKknKyTutElJs4YuMREzNT7txx7To04x9FxaGKfn1OjWTGql+xxnwdjJ7MmAfPA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AkM2QJfQQfkMbyGoKjJoi3+4quUIcx6+PgRfh8WfhBA=; b=B7M90KwXC9FELp/a+ndKqCBlyBs0Y/awYprOm+3VELnAoDelCxd2Inq+cnQm59GyyC6dOLZTSHGJ5DkHp2jIMuPt1FT6rt7uLxatT3fWp6m3KD1V/8MRup8kOQ0AGiV4+Jtv5GQvWKwJsJx5xlajxlgV/ANlZNTFCbSert767Fe3gLd7vtqxInmvAnVLKp18SydFpWfDkvBH9mDravB2H2QcYn1otTpJvzxFrOt6sR5TsQeM0Zu/8JXFvVFSFAvyZvoFr+5PBomyZA+W0KurqdeTR6tGwfQtkK9CFuhLALUPGmh/DgzSbtAq32+E6jIer8PhBQSyE1sdiUS9TimvMg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AkM2QJfQQfkMbyGoKjJoi3+4quUIcx6+PgRfh8WfhBA=; b=WEgluesx9QoI17V64O7bTrwX8rsiiC4hfyJztq10UdUjvjWbgnrNjnLRkgVrcw3EHWyupDb/CZjHkWdkQ7IyIrlKGmpcQeqngN0jpthxmettBWv2ZMWCaJrIUgrIhxnraZgN8hsLLehDTvIjqghFsLRhTXKHfwi/ZgFzMKGmQ/dtzOo/G4QOpd+Wsw3kyLpAIYON3MuQ5ECasNCec684N8J9S7fUgbfDox2fA+HT/yzSLIuK3o+lAEFgwpRZjUEndvINPipcOWNcfeIuyj1ODXcdh3b9036JWAFzdXt2zYFtAByqeH+d6hiYIxF3uoKLlY87lLDCrv1Jl0mmHGfHBA== Received: from DM4PR12MB5373.namprd12.prod.outlook.com (2603:10b6:5:39d::14) by CH2PR12MB4168.namprd12.prod.outlook.com (2603:10b6:610:a8::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7519.36; Wed, 1 May 2024 01:19:26 +0000 Received: from DM4PR12MB5373.namprd12.prod.outlook.com ([fe80::630f:22c9:1d04:12d8]) by DM4PR12MB5373.namprd12.prod.outlook.com ([fe80::630f:22c9:1d04:12d8%4]) with mapi id 15.20.7519.031; Wed, 1 May 2024 01:19:25 +0000 From: Xueming Li To: Chaoyong He , "stable@dpdk.org" CC: "oss-drivers@corigine.com" , Long Wu , Peng Zhang Subject: Re: [PATCH 23.11] net/nfp: fix port ID meta data use in Rx Thread-Topic: [PATCH 23.11] net/nfp: fix port ID meta data use in Rx Thread-Index: AQHajt5MD4GWD1ql20+xETtQfPsgMLGBrSeN Date: Wed, 1 May 2024 01:19:25 +0000 Message-ID: References: <20240415024008.1000358-1-chaoyong.he@corigine.com> In-Reply-To: <20240415024008.1000358-1-chaoyong.he@corigine.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM4PR12MB5373:EE_|CH2PR12MB4168:EE_ x-ms-office365-filtering-correlation-id: afcc7b9c-c043-4f85-5913-08dc697cbd6e x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230031|366007|376005|1800799015|38070700009; x-microsoft-antispam-message-info: =?us-ascii?Q?QiidwstHV8F8zYztGX3AEq9OsPtw90SBRwOc6al24CypJb8uSP1OuQQvivso?= =?us-ascii?Q?e2BfPir8rYx9LzO9Ga4gusbXaz+cPPY9g4b4W0NFbTAKq6QMR9ztjgS0LB8k?= =?us-ascii?Q?//skYu6JkDHjsDx6McuPlxymiNqK6t+CQGV1Pf4dE8I/ISyiZ/Z+aO/M7jVh?= =?us-ascii?Q?JQKdmZ6CJmTf00jmBvejfxAOAxIegdHHwIs5cJDArYbuEzo097zIp9ZElQb3?= =?us-ascii?Q?cIz5KWrs0i6SWLuaqhQjCbRueCrC2srFMH6akX9dM299dER9V8ZNwcZUEXiC?= =?us-ascii?Q?qFi6TOCnry5nrY0Q/xPTnw/RnTYnsIB331iQJvf/kzxmkfO9TBhkgMOvHuZN?= =?us-ascii?Q?whKvplbpJExKG3mC7dVQAQ4FIvVMhsnVqNwdSm7a74RRb+Wx4PWvtGFlOIUj?= =?us-ascii?Q?y1LgZREjQQVuKpxCxiZRfMHn4JX4SH8RA/K9qw2KE8kocbhRS0SYnr/lo5NP?= =?us-ascii?Q?/FWMAjGpRVU9T7bIIwbmPucV7SA639naHO5LdmHKZgatN/MiGkeTjN9MBpxr?= =?us-ascii?Q?S4IFzMTi1bXr7mZ/YkDNIQK6GtBGaGvFmWHLmVoJIZSvV4Xf/SY4GPXnx4O2?= =?us-ascii?Q?tQTzMbqoRzc1ClOmG5nZ8RQGKxrkSZS+6J/wqZxYADQr/72zh6USzda//3H2?= =?us-ascii?Q?c/NI/Rh25+6m5AA2vMR/EFHtsT6//UA25K4kIqMtxas3VQhbjxKzlzqe6KHO?= =?us-ascii?Q?KX6NkADW9gKCX5/zWhsdiTHIRNRSaYieIw8FboW4kWrhJZz85Ut+ZneUwDJ+?= =?us-ascii?Q?qoiLSDwiAtLkSX4JCbZGv9gVdOYqo+R0ioNx4HL/BgWiBNmrqS8ls5PPtbcK?= =?us-ascii?Q?IRhSjyJLtgt6QRQ37x0ny8k1ChSgzn5aaGSZZ/weQWSKAb5jP/jSM3rGhxiM?= =?us-ascii?Q?P4y9irQGNB37dQGi4mUrJyYRDU6ZQQXKaX/hYPPRa3LfKzLXb5VUxdF+vFHq?= =?us-ascii?Q?k0I9V4dk+cx5VIn7CNYgynrt6pM6xfdXJeTTVIGxDgqvTSpUk7II4yWYxejw?= =?us-ascii?Q?/G+RrO9db6Hv/Obu6ZCHFqD7PNxHmFFRUyz3dBMPaFQOPdelvLYZ9ERVh0ei?= =?us-ascii?Q?mYR5jJoULYrMvr6XsbOfP94Rk25ejX3AAJVbxLrxbiKb1w0qDe2fWQfeUvOK?= =?us-ascii?Q?nvL6ZCCLY01UaUCNoIrriO+utvhjiYD7NpRW2YTltM/hvf38UP+5tHXrbeJo?= =?us-ascii?Q?rBa4vBHPBQtwzCsY9KD5ho68+J9eyrsNfZniDTotxrofNEnsDmIERwjbIR+W?= =?us-ascii?Q?dc6b+BTJGc3xsbchoC8rKrZusNpc4V4AU1/rMoIOB3U92JhUTmPojOwTxYca?= =?us-ascii?Q?QaLZxiXKj4YVU7F6ars5wKJDLDOceUcKReCHQGQ5RAejaw=3D=3D?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR12MB5373.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(366007)(376005)(1800799015)(38070700009); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?SsCF/W+agpxKBPAffDpg7sHS/SfqIpsJk5nOFeoW9AtRrGgJnkTpi11uROmk?= =?us-ascii?Q?XFpmmb+xF60XVcWDJDtRPwrQXzlUvq9fGp0R7MLpIJXm9CBRRav0jX1Dgiob?= =?us-ascii?Q?IdVeLncSMRYhXyi7FObKlCSXTrUK8pdKberNgYf6nAu7OfGewctbZxNezsX5?= =?us-ascii?Q?oO5IRHapdJRS84cCTh9PKWZLyzduuPJKL+iv5d6NZkwTSwjO1dUv5rK2tWeN?= =?us-ascii?Q?FaYD4Vgdgl3tJSEHxVNTTWuvtNJkFAM0qeO+0eeC/Sl2Aq8rYy2JXjZMFWoh?= =?us-ascii?Q?mMa3RheRMRWsszMP2pUZpKXKODiRt89dfoyeFLx+Oc6CP2Vteb+KACySqb3N?= =?us-ascii?Q?RmSP9EqOug+96lu3jAvUQHtNTN/QpMWld2oAZu2qcy9T2BmRTMFELhHUHvNo?= =?us-ascii?Q?Jk9Wz5gUGTplNO5snR5Ul7I0oqeDefdGRdskdcuYQXMEC9pRxRslTYDWiIDe?= =?us-ascii?Q?tuboXj+wYM90FCuvL25L7Z1BsNWvUFgQbDx5NRCP85h+GohEqMRH2ha1f8og?= =?us-ascii?Q?riSPeRqzebR2FRkgMQQg4Xy5ol5VS8FnBPGJcDR4YUZJ8JdaHKiUStRTsexm?= =?us-ascii?Q?py9QrjAhX2Yb0vfCgcN2uKoXvT0fkwuVcXlSKKWmrD+HjDRECgyRsBQx2T6Z?= =?us-ascii?Q?Wp5qsGDyeEOJ6gqVNoukBMBXKoN6KzRdLq7r36Z+0XXxQkxFQqeicooXwPlB?= =?us-ascii?Q?BEO/EkJUo3/IH1QHJxStupuuH4znfB/VQs5i++IMQPaJM5aVcWmg2LYbM7W1?= =?us-ascii?Q?fPzoF1cm/aM6TCxAeiygrW529g4AxGUjDOdp0FBKd10Nfciq4QMPi5en5uS6?= =?us-ascii?Q?5N0YMrHEOeqxanbEgw4ZAVKn8JQk3+XJGu1X4evn9y0WUhpV6z9mcvcfhAXa?= =?us-ascii?Q?fnvtbXbxpmNRoUXjTgBW2XoEafpF3KhPpl8Gc163LY6F7ESAEvcz+0+LpuOl?= =?us-ascii?Q?J/h+/7C70sv0sJZtacRTQAluZ1SMcibOzDeeVm0eAn3m0Uu/BWa3TDTvMhB3?= =?us-ascii?Q?sL/IWWoS4y5aMZalbMFtrwpOMooSa8cdTmoENzle4tzicdQNS6zJlW3DMR//?= =?us-ascii?Q?MyfrEyCqLKjb14CZiDvEhVHqwMadtQb2Tq0kIvFSSoMNetYuE/AMsIVmOMgg?= =?us-ascii?Q?uiPBO6V9jHMmYrneRMXlt00YpH/teUG1HdSTP89XMXNf7tFIYU8ewuaWPWn7?= =?us-ascii?Q?KjmTd3m9O6XkPLiNzlPJzT4FbfOdOiOEHQzDgvvA1wZyCWF+BPBDfz40ZhE5?= =?us-ascii?Q?uhG8a0Yy+zX7oiafYKokHb9wvuGeQ6dmToXu2ysm3k+pSt4o7Y3R43C8dVAe?= =?us-ascii?Q?MlJsfuaswkFaiQj/wDkb9Tkx5wcrKWSMkcDchH1GZ5AVqO9pn/4XOW0DMRwL?= =?us-ascii?Q?LMaYXS+N4y0Cof4rC7l4IbnyHR0jOlBqXVCzsW7TVXv9pt2rKpXntnQmc+4n?= =?us-ascii?Q?tgpnC8fEiNp2blsno3CHCjeg377KDHAEmAwChorRg8vPzFYd3O9H6g6Km0Hi?= =?us-ascii?Q?7UpsUlbeQH/s497NcULfsPFwcn+g0DrIrUdZAh//av7Iw3ldNw2hfTj2pNVq?= =?us-ascii?Q?xSJY+tc3/q/b1zy7clg9A6N9+34fkEelvp7tMpk+?= Content-Type: multipart/alternative; boundary="_000_DM4PR12MB537395786162D749420341D0A1192DM4PR12MB5373namp_" MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5373.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: afcc7b9c-c043-4f85-5913-08dc697cbd6e X-MS-Exchange-CrossTenant-originalarrivaltime: 01 May 2024 01:19:25.4580 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 5VYkP4uFi4uM0iuO8hI3m5FibuqLhbHrKS4wZhv0PZGFlhdOAuPRgZY6hpBRp/tkP99Qg3xrO2ERxRgXtvSzOg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB4168 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org --_000_DM4PR12MB537395786162D749420341D0A1192DM4PR12MB5373namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Chaoyong, Thanks for your help, patch added into release queue. ________________________________ From: Chaoyong He Sent: Monday, April 15, 2024 10:40 AM To: stable@dpdk.org Cc: oss-drivers@corigine.com ; Long Wu ; Chaoyong He ; Peng Zhang Subject: [PATCH 23.11] net/nfp: fix port ID meta data use in Rx From: Long Wu [ upstream commit ddc84b53f38281ff2c15f7feb7e3a0b556dd92b2 ] Meta data parsing should be controlled by meta data flag. So use flag to determine if receive function can use 'port_id' meta data. Fixes: 580ea0b09a7c ("net/nfp: fix Rx descriptor") Signed-off-by: Long Wu Reviewed-by: Chaoyong He Reviewed-by: Peng Zhang --- drivers/net/nfp/nfp_rxtx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/nfp/nfp_rxtx.c b/drivers/net/nfp/nfp_rxtx.c index 8ca651ba55..5033d659d3 100644 --- a/drivers/net/nfp/nfp_rxtx.c +++ b/drivers/net/nfp/nfp_rxtx.c @@ -760,7 +760,7 @@ nfp_net_recv_pkts(void *rx_queue, if (unlikely(rxq->rd_p =3D=3D rxq->rx_count)) /* Wrapping = */ rxq->rd_p =3D 0; - if (meta.port_id =3D=3D 0) { + if (((meta.flags >> NFP_NET_META_PORTID) & 0x1) =3D=3D 0) { rx_pkts[avail++] =3D mb; } else if (nfp_flower_pf_dispatch_pkts(hw, mb, meta.port_i= d)) { avail_multiplexed++; -- 2.27.0 --_000_DM4PR12MB537395786162D749420341D0A1192DM4PR12MB5373namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable
Hi Chaoyong,

Thanks for your help, patch added into release queue.
From: Chaoyong He <chaoy= ong.he@corigine.com>
Sent: Monday, April 15, 2024 10:40 AM
To: stable@dpdk.org <stable@dpdk.org>
Cc: oss-drivers@corigine.com <oss-drivers@corigine.com>; Long = Wu <long.wu@corigine.com>; Chaoyong He <chaoyong.he@corigine.com&g= t;; Peng Zhang <peng.zhang@corigine.com>
Subject: [PATCH 23.11] net/nfp: fix port ID meta data use in Rx
 
From: Long Wu <long.wu@corigine.com>

[ upstream commit ddc84b53f38281ff2c15f7feb7e3a0b556dd92b2 ]

Meta data parsing should be controlled by meta data flag. So use
flag to determine if receive function can use 'port_id' meta data.

Fixes: 580ea0b09a7c ("net/nfp: fix Rx descriptor")

Signed-off-by: Long Wu <long.wu@corigine.com>
Reviewed-by: Chaoyong He <chaoyong.he@corigine.com>
Reviewed-by: Peng Zhang <peng.zhang@corigine.com>
---
 drivers/net/nfp/nfp_rxtx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/nfp/nfp_rxtx.c b/drivers/net/nfp/nfp_rxtx.c
index 8ca651ba55..5033d659d3 100644
--- a/drivers/net/nfp/nfp_rxtx.c
+++ b/drivers/net/nfp/nfp_rxtx.c
@@ -760,7 +760,7 @@ nfp_net_recv_pkts(void *rx_queue,
            &nb= sp;    if (unlikely(rxq->rd_p =3D=3D rxq->rx_count)) /= * Wrapping */
            &nb= sp;            rxq-&= gt;rd_p =3D 0;
 
-            &n= bsp;  if (meta.port_id =3D=3D 0) {
+            &n= bsp;  if (((meta.flags >> NFP_NET_META_PORTID) & 0x1) =3D=3D= 0) {
            &nb= sp;            rx_pk= ts[avail++] =3D mb;
            &nb= sp;    } else if (nfp_flower_pf_dispatch_pkts(hw, mb, meta.p= ort_id)) {
            &nb= sp;            avail= _multiplexed++;
--
2.27.0

--_000_DM4PR12MB537395786162D749420341D0A1192DM4PR12MB5373namp_--