From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 70F7942979 for ; Tue, 18 Apr 2023 08:23:05 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6C12442D0B; Tue, 18 Apr 2023 08:23:05 +0200 (CEST) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2057.outbound.protection.outlook.com [40.107.243.57]) by mails.dpdk.org (Postfix) with ESMTP id 5347342C24 for ; Tue, 18 Apr 2023 08:23:03 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jxIyYg6lPz1tspxMzPEHF3gN1fhqvjkSGwKpx8vcdxwBAc/nrMV6uGfGaSwI+q01Te7krjpXRNykIZfE1DEjEKU2bPiTcmCZmVGQBajDMkBaBXWguGp9p5eUcmWIv/bciJeGjW2W2Pn3HKyEpQbXhnkcFPzFVT1U4OZ03DNH9UNCFAqtEltSP+UGMBVGA+/AukzRFNximJ8+XvzfvVx30ER1MdxSTyBKMxMa6t85uGyePuh2j7LtSGb/keOn8FolSzTKPQPyeE8XeQo9z+WLq/ApLTFAKsiu5JsM6latlmSXZlmoHCbOXI5lc7JW9f82ci6m9nvKo+MXxCk0Rr58XQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+aZvpOhBtkLG7zsBufLndX43C4mkGl65C+EvEyXW3Ik=; b=Qqn1pP9qNx57WWYEHN8A8k/9wQ4G53YjW6V8aF4+vkdIPWyqXACDvkUUcUiSayaYWZ9nZ2Mh8twWCxj4Jycd6rNZHImWPy9RJst9LSA8iO9jMsH38KC/L7V7TvEeudmcd1TXOlsJGAoQWjDQTUczvtumbG14ZYMNwwXGjzv1EqeZEnPMOuj+umTihMnMDVQKSHF+vIRn/EEnGfdpkf6ZrIZiYnuZHyB2CzDCML7lOcVViqnRduV/bRwahws71PmanmtTMmwGwyUd0w00BE4G5ba67TGpGDYzVzYInimbrzbiMzT/qIZtYwzj1Z/vZXfX9TEDOU8L2xYr4c7v7Chn6w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+aZvpOhBtkLG7zsBufLndX43C4mkGl65C+EvEyXW3Ik=; b=ZCMe9VSUJIrbbh+iRqLaeFPdtggS1UckVa3TrGjOBHrdcwIzUbbjrLRZgTg72fH4V8GhoVL3GHR800GKZUMnY9k5gdhE/uz0m+Sv12Le4+FwVIZgvfbnh0pTzU3bTM8OvndOLSoFxUc+lNZIMRlDqGgyeUA1K7P2Mp++IOkSW7JS2k8KEmBhS6vNbu0XbFReJ7KKqnIGnCJzlqjS0bAzPDtVY17SlMMOupwCqjIqrMYPaGEz7bctLD0p7CNrCoKI/dVTDpgwEESGXsFwTKJaD83Hwi54sxWOLwa1Qy93qKNR4F21TKlGpZhRqe3NkGVmUqAttk5hzHFFonbtVelrIg== Received: from DM4PR12MB5373.namprd12.prod.outlook.com (2603:10b6:5:39d::14) by MN6PR12MB8516.namprd12.prod.outlook.com (2603:10b6:208:46f::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.45; Tue, 18 Apr 2023 06:23:01 +0000 Received: from DM4PR12MB5373.namprd12.prod.outlook.com ([fe80::95e7:39c2:fac6:f6c8]) by DM4PR12MB5373.namprd12.prod.outlook.com ([fe80::95e7:39c2:fac6:f6c8%6]) with mapi id 15.20.6298.045; Tue, 18 Apr 2023 06:23:01 +0000 From: "Xueming(Steven) Li" To: Gowrishankar Muthukrishnan , "stable@dpdk.org" CC: "anoobj@marvell.com" Subject: RE: [PATCH 22.11] crypto/cnxk: fix order of ECFPM parameters Thread-Topic: [PATCH 22.11] crypto/cnxk: fix order of ECFPM parameters Thread-Index: AQHZbEj2tfuXdhiJAUepN0Dkcpa5qq8woYiQ Date: Tue, 18 Apr 2023 06:23:00 +0000 Message-ID: References: <20230411074050.789415-1-gmuthukrishn@marvell.com> In-Reply-To: <20230411074050.789415-1-gmuthukrishn@marvell.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM4PR12MB5373:EE_|MN6PR12MB8516:EE_ x-ms-office365-filtering-correlation-id: 6f039d53-439b-4b6c-0b24-08db3fd55cae x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: BdOeHebl9bFUQxNIeC9XLbyZcmsXwGzD6nnbY2gzpukQ2oBd9a+0OBPZRW3jpIqzHMyUxPV/+QaR/kzmUkp6s/C/doRxtnavBtnPSLNAl2LNbfhYipTv/nmdAud178fJ+tH46CsoNAiwQzY09DYGJ5gIhoh1/bCrbfYz0sgLic6iesSLBuQzSyQ19sl2HSexZrF9f9MC4DTt9vp8U8oNPblftNHDFiRCT2SbXgr1+HZYdMKLt/627QlMmt+Ca4PkG43u+qbAhw7mY385Y27SmJxCVq7a8VIT6+VZSLQUo55TWSq9usi4A+jnpQ7FhK2zAsE3loSL+mEhpamxBIbPkMD1Y4RLfpKzr52hfZqdhqWaUystofvxBV7um3mUkuAp7pAluhZqcysh8dn0FnvqLrF6X6ZWQDuJnRE7MpPpScR9ri5YnltfRs0SVV+I7ya4WtnC5Drrl4VOy3kDYCO8ZWiUGSbriTEj5NAoceUlfy7U7A5Llkj5RGnycLKepKOcGx6lkuePnvF9Is0X9t1EFIFztbK+TzywDdeYl8iFwYUOqeOPCLDF+HrRdUSBTj30oAm3sX2yF5IUFbLwqRbZw8doxgn44sqCKRppzdl82x38jTTUM0vO/QqtxuwPYcYF x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR12MB5373.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(376002)(136003)(346002)(396003)(39860400002)(366004)(451199021)(7696005)(478600001)(86362001)(110136005)(55016003)(71200400001)(26005)(83380400001)(33656002)(9686003)(6506007)(53546011)(186003)(38070700005)(38100700002)(122000001)(64756008)(76116006)(66556008)(66946007)(66476007)(316002)(66446008)(2906002)(4326008)(8936002)(5660300002)(8676002)(52536014)(41300700001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?XlW1lu+WBw8RnCvWsoGQze+uCUQA/pMq0WCjvjQK81OQJrEf8L+Abrj9DKNx?= =?us-ascii?Q?A5mzLVMaOeRh7YsohY2dCLmhkio/fClnP2sZLLhu5IRt3zl+rThRseaLHNM0?= =?us-ascii?Q?S5hAgTimsa6sQvLXgPbADe0HqHXH/dYFRt2pvkgI8BtWXWE9/j1y2usucFmB?= =?us-ascii?Q?Eg+iGXrOGBwhbAorGy6B/asmLFCyN+RJQlIn2QcEzkXArr3TpsCFm5MKqB32?= =?us-ascii?Q?VwK7zENo3YmAOxibI1n4nBkV/M6KLWr6bPzyMAEFmWnPvUxB9dWToB4qyCtv?= =?us-ascii?Q?3krPcvCBCm/uYcFFUPloidZ19XaV8lmUc4LqX7OjuBcNL/+Y1kv/VWyU0WuT?= =?us-ascii?Q?OjgnyEi96JUzJ6cJeI0fFosz5JG5iHq0uPaPMc3PbGXotJujiOho6v/UB68i?= =?us-ascii?Q?9GZaQ7KysNHihCyPQsgbBXnsxQ4DCqo0ppPTG3o+gl7QpmJJF3LyRbNGJQMt?= =?us-ascii?Q?mr61E2lxO+yN7JsJVNm8554JezdfJltrCsabUg5w5YBysFDs+JByFF15qZfa?= =?us-ascii?Q?uWW7MgQ/yjkDzFsqOaEroKUcL6qHmxzYuTOjaJq4LVLTGGtW1wwwnGLxhvqP?= =?us-ascii?Q?ZdEY0vPnzXXKC6N9f+TmW+K1tsju7tMYi5nA0gRxAjXYUPPOee9kYl2TwGUz?= =?us-ascii?Q?X3edwLFkCWhCxoM0aHpHwsaeni1rbdctrCsUypj84h4HW2aEtvtKMSSsXa3X?= =?us-ascii?Q?H0DMv96o0+Lc9n4Tv2kzHpdQ8oa1cqS9TN+6UbSR4KDy46iCI0+Yz7uasmk3?= =?us-ascii?Q?l6V0h9x65RbLq6Dfy8VWbo48ysq/mS1kLnE8i162jGsWrieUUbS0Hk2RkoTg?= =?us-ascii?Q?3TvzscfYV+A7Cx/5rMraL0TWikltUaOdFoid45Df6De0uEXo+RQpsiaAT6zo?= =?us-ascii?Q?XxIHzY167Qmg6iJCnC7tvgRNRYVnKDahNpWhIpTLacvQGq2uJoYkHAdxMTh3?= =?us-ascii?Q?eEHG0kT+yZjaJeL2xRMrDn+2ldRFTEAdY9PgVpHwYcw0iiDg1Tv9Rl39YBVz?= =?us-ascii?Q?U/Qil0YeTnKZGv3gdnZ8O7MldyoprzjOAg1TT4+rIF3389QGOTJz7p+QXJ74?= =?us-ascii?Q?EeeSAvVmcucFVuVHDMdU0tGjjQwXVPuico4263Sr1Q18Lf/U5U/OdVTjEv9t?= =?us-ascii?Q?yFGHqmzdygOW2fevY8L3EFJXk1hNr4Y4XmlBn0ZdjlTkpJvA1PnKtFcIXf3i?= =?us-ascii?Q?zqzUKOC38ObzvX7hyvjjfNsXE2ZhVuYdhUjAzfJPLJo7hau2c+0BLDYWgEQf?= =?us-ascii?Q?Z2CzoLsZ0XqFGeFzKEYttDcgFKFAhjf/uUNGyA7193W2wco3ep8UGbd2FZJ8?= =?us-ascii?Q?PyOR6vXd6zVazDzhiytf7SXc9s6i5WM/UDsymejYfJuzMqGvOWNLOVZ7qWNK?= =?us-ascii?Q?CwxRByGtjxb7aXtd1rahXiLuZ1vtWuL7FaoNsq//38tRQRdkSepm5Iz8dlWy?= =?us-ascii?Q?Gl+rvPrZLkecAMqAMpbCsiRQBY2plWEd/COiIKiv/Ges6svO8f33KDHEzN/P?= =?us-ascii?Q?wpUSWPHdmskca1rMlgpYg/RlUngd4HjZsz/Aez+87dZQ/d7RUYn/x+jozn+z?= =?us-ascii?Q?XWx9Umu9bpVh4OI+fZFnFLPq0ZSwwIK1eF2/VbTc?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5373.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6f039d53-439b-4b6c-0b24-08db3fd55cae X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Apr 2023 06:23:00.2885 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Fe0wEQQ9kWggNqAPmWBK7rhrwuiUtkBS/KSuZXUFyluJrpTDbIA6GJ+AF4Z3OXi78pQUOATLsVrVa4dpOj68wA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN6PR12MB8516 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Thanks, patch applied. > -----Original Message----- > From: Gowrishankar Muthukrishnan > Sent: 4/11/2023 15:41 > To: stable@dpdk.org > Cc: anoobj@marvell.com; Xueming(Steven) Li ; > Gowrishankar Muthukrishnan > Subject: [PATCH 22.11] crypto/cnxk: fix order of ECFPM parameters >=20 > [ upstream commit 76618fc4bef616f16b6c92f15681ea080eabb486 ] >=20 > Fix the order of ECFPM parameters according to target board. >=20 > Fixes: 8e39b133235 ("crypto/cnxk: support fixed point multiplication") > Cc: stable@dpdk.org >=20 > Signed-off-by: Gowrishankar Muthukrishnan > --- > drivers/crypto/cnxk/cnxk_ae.h | 48 ++++++++++++++++++++--------------- > 1 file changed, 28 insertions(+), 20 deletions(-) >=20 > diff --git a/drivers/crypto/cnxk/cnxk_ae.h b/drivers/crypto/cnxk/cnxk_ae.= h > index adf719da73..f1183376d0 100644 > --- a/drivers/crypto/cnxk/cnxk_ae.h > +++ b/drivers/crypto/cnxk/cnxk_ae.h > @@ -678,7 +678,7 @@ static __rte_always_inline int > cnxk_ae_ecfpm_prep(struct rte_crypto_ecpm_op_param *ecpm, > struct roc_ae_buf_ptr *meta_buf, uint64_t *fpm_iova, > struct roc_ae_ec_group *ec_grp, uint8_t curveid, > - struct cpt_inst_s *inst) > + struct cpt_inst_s *inst, int cpt_ver) > { > uint16_t scalar_align, p_align; > uint16_t dlen, prime_len; > @@ -697,26 +697,33 @@ cnxk_ae_ecfpm_prep(struct > rte_crypto_ecpm_op_param *ecpm, > scalar_align =3D RTE_ALIGN_CEIL(ecpm->scalar.length, 8); >=20 > /* > - * Set dlen =3D sum(ROUNDUP8(input point(x and y coordinates), prime, > - * scalar length), > + * Set dlen =3D sum(prime, scalar length, table address and > + * optionally ROUNDUP8(input point(x and y coordinates)). > * Please note point length is equivalent to prime of the curve > */ > - dlen =3D sizeof(fpm_table_iova) + 3 * p_align + scalar_align; > - > - memset(dptr, 0, dlen); > - > - *(uint64_t *)dptr =3D fpm_table_iova; > - dptr +=3D sizeof(fpm_table_iova); > - > - /* Copy scalar, prime */ > - memcpy(dptr, ecpm->scalar.data, ecpm->scalar.length); > - dptr +=3D scalar_align; > - memcpy(dptr, ec_grp->prime.data, ec_grp->prime.length); > - dptr +=3D p_align; > - memcpy(dptr, ec_grp->consta.data, ec_grp->consta.length); > - dptr +=3D p_align; > - memcpy(dptr, ec_grp->constb.data, ec_grp->constb.length); > - dptr +=3D p_align; > + if (cpt_ver =3D=3D ROC_CPT_REVISION_ID_96XX_C0) { > + dlen =3D sizeof(fpm_table_iova) + 3 * p_align + scalar_align; > + memset(dptr, 0, dlen); > + *(uint64_t *)dptr =3D fpm_table_iova; > + dptr +=3D sizeof(fpm_table_iova); > + memcpy(dptr, ecpm->scalar.data, ecpm->scalar.length); > + dptr +=3D scalar_align; > + memcpy(dptr, ec_grp->prime.data, ec_grp->prime.length); > + dptr +=3D p_align; > + memcpy(dptr, ec_grp->consta.data, ec_grp->consta.length); > + dptr +=3D p_align; > + memcpy(dptr, ec_grp->constb.data, ec_grp->constb.length); > + dptr +=3D p_align; > + } else { > + dlen =3D sizeof(fpm_table_iova) + p_align + scalar_align; > + memset(dptr, 0, dlen); > + memcpy(dptr, ecpm->scalar.data, ecpm->scalar.length); > + dptr +=3D scalar_align; > + memcpy(dptr, ec_grp->prime.data, ec_grp->prime.length); > + dptr +=3D p_align; > + *(uint64_t *)dptr =3D fpm_table_iova; > + dptr +=3D sizeof(fpm_table_iova); > + } >=20 > /* Setup opcodes */ > w4.s.opcode_major =3D ROC_AE_MAJOR_OP_ECC; @@ -947,7 +954,8 > @@ cnxk_ae_enqueue(struct cnxk_cpt_qp *qp, struct rte_crypto_op *op, > ret =3D cnxk_ae_ecfpm_prep(&asym_op->ecpm, &meta_buf, > sess->cnxk_fpm_iova, > sess->ec_grp[sess->ec_ctx.curveid], > - sess->ec_ctx.curveid, inst); > + sess->ec_ctx.curveid, inst, > + sess->lf->roc_cpt->cpt_revision); > if (unlikely(ret)) > goto req_fail; > break; > -- > 2.25.1