From: "Xueming(Steven) Li" <xuemingl@nvidia.com>
To: Rahul Bhansali <rbhansali@marvell.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: RE: [PATCH 22.11] common/cnxk: fix CPT backpressure disable on LBK
Date: Wed, 9 Aug 2023 12:54:28 +0000 [thread overview]
Message-ID: <DM4PR12MB5373B6707CC3A5770FDEAA9CA112A@DM4PR12MB5373.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20230703132821.470471-1-rbhansali@marvell.com>
Hi Rahul,
Thanks for the backport! Patch queued to 22.11.3 stable list.
> -----Original Message-----
> From: Rahul Bhansali <rbhansali@marvell.com>
> Sent: 7/3/2023 21:28
> To: stable@dpdk.org
> Cc: Rahul Bhansali <rbhansali@marvell.com>
> Subject: [PATCH 22.11] common/cnxk: fix CPT backpressure disable on LBK
>
> [ upstream commit 772e30281a1d686096b27e5926e2f369caa05cff ]
>
> For LBK interfaces, roc_nix_inl_inb_is_enabled() is false, hence backpressure
> on CPT is disabled and causing CQ full interrupt.
>
> NIXX_AF_RX_CHAN[0x800]_CFG is global config for all PF, VF of RPM/LBK,
> hence backpressure disable on CPT is not required.
>
> Fixes: 0663a84524e5 ("common/cnxk: enable backpressure on CPT with inline
> inbound")
>
> Signed-off-by: Rahul Bhansali <rbhansali@marvell.com>
> ---
> drivers/common/cnxk/roc_nix_fc.c | 11 -----------
> 1 file changed, 11 deletions(-)
>
> diff --git a/drivers/common/cnxk/roc_nix_fc.c
> b/drivers/common/cnxk/roc_nix_fc.c
> index 033e17a4bf..5e8a01c775 100644
> --- a/drivers/common/cnxk/roc_nix_fc.c
> +++ b/drivers/common/cnxk/roc_nix_fc.c
> @@ -88,17 +88,6 @@ nix_fc_rxchan_bpid_set(struct roc_nix *roc_nix, bool
> enable)
> req->chan_cnt = 1;
> req->bpid_per_chan = 0;
>
> - rc = mbox_process_msg(mbox, (void *)&rsp);
> - if (rc)
> - goto exit;
> - } else {
> - req = mbox_alloc_msg_nix_cpt_bp_disable(mbox);
> - if (req == NULL)
> - return rc;
> - req->chan_base = 0;
> - req->chan_cnt = 1;
> - req->bpid_per_chan = 0;
> -
> rc = mbox_process_msg(mbox, (void *)&rsp);
> if (rc)
> goto exit;
> --
> 2.25.1
prev parent reply other threads:[~2023-08-09 12:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-03 13:28 Rahul Bhansali
2023-08-09 12:54 ` Xueming(Steven) Li [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM4PR12MB5373B6707CC3A5770FDEAA9CA112A@DM4PR12MB5373.namprd12.prod.outlook.com \
--to=xuemingl@nvidia.com \
--cc=rbhansali@marvell.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).