From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6C6BF4297C for ; Tue, 18 Apr 2023 13:22:32 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 67D0340EDF; Tue, 18 Apr 2023 13:22:32 +0200 (CEST) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2058.outbound.protection.outlook.com [40.107.94.58]) by mails.dpdk.org (Postfix) with ESMTP id 2974040698 for ; Tue, 18 Apr 2023 13:22:31 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XL29Xb5Jgy0nPXA1uuArEUzya4SeVXJeTtBuqamC04HyAv4Ux3WifXj5qZq5bhgQxfA6cNoiS17cqQDCu9PlTFfkyCnXr6xagiYc/CiQe2p+nijgIwpxGrLS8Q+ui5qn9noGi7rbPw/Rygz5ktqEGCB/pKhq2gXl4KPe5qA2S9RJhbFb3LqZjG1dgndNfRgnFiu+PV7XL4HFyhsRYam6hR2/HNqfW5D3ffqNdD+inyK6KJwJhBksCBKTi/Pqc3ntnElouQSh60hWYmdzNpsPMMbkpzxcHzi2HKyvSpOC1DXjRHXcJnLzaR3lLjsWNMNB0vfdXL1aYmz6f8vjxBI+jA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FNszMLAubQ8duHu1ncqN/0DXuyY8v8+xwEn9oGE0frU=; b=ZflyqIvA97Ldh0be+pIJC0ZJn00ILzJQQlk6tYsnNhOyYs41VgRx9t+rBZKgHJJwtJCTxpMUc4WciHpLPkh666Mg8SX3PSlLv7LDenbK0I1JVGa+yf6nJjVajxgMq925+Alvtl3U+7JSzr8P7OGZYpJgSVlRxu8OvregJt+UpVrQ+VeNz9Bn1O5Q7xTvv1aZq+2T+Y32hZb3F1KVuHeFPkVJmijd804IZDuhjXF334lat844QhMYlfxaocXtk97a/sea59wph/tMWI4ZTW4ydbwvAFQmn1BH+9A+Lc8FNJAymIz/tc2PV/hYZn+JRN6RSX5ZVJHwVyyRvM5psim/Uw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FNszMLAubQ8duHu1ncqN/0DXuyY8v8+xwEn9oGE0frU=; b=FeqIs7P79K4uDxG+MXM/n+kC7PM0kZ75yP4XSc+OLDeFwd3EP4aoWUSJ44bLqlbQrdt4gGg0G6l0wENMZE9li30Av2RZX4m2upVMIl9DWdPzqnb0dAsWD2Q2vma5TdX/1T1DdALe30mQGLUpU65v3Zc805f9qGW8D1dT9GnxT6T69d0iELP3cNDJkVMWsMkeCp57LDvTo09BPqy8B8O0ZVYfz6T9tNNB1PYR5kZeDO/7rLRgVe0nLiMZsaU3heYoCB8pSsTl17xC6+jp3tze6OrVXpbDwYtFGsKqSgiybPcUTmr/Ugk0rtuNaf9TVSFjaCEHk+lAYs0RN4q8oo6xAQ== Received: from DM4PR12MB5373.namprd12.prod.outlook.com (2603:10b6:5:39d::14) by CYYPR12MB8961.namprd12.prod.outlook.com (2603:10b6:930:bf::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.45; Tue, 18 Apr 2023 11:22:28 +0000 Received: from DM4PR12MB5373.namprd12.prod.outlook.com ([fe80::95e7:39c2:fac6:f6c8]) by DM4PR12MB5373.namprd12.prod.outlook.com ([fe80::95e7:39c2:fac6:f6c8%6]) with mapi id 15.20.6298.045; Tue, 18 Apr 2023 11:22:28 +0000 From: "Xueming(Steven) Li" To: Gowrishankar Muthukrishnan , "stable@dpdk.org" CC: "anoobj@marvell.com" Subject: RE: [PATCH 22.11] crypto/cnxk: fix order of ECFPM parameters Thread-Topic: [PATCH 22.11] crypto/cnxk: fix order of ECFPM parameters Thread-Index: AQHZbEj2tfuXdhiJAUepN0Dkcpa5qq8woYiQgABVIQA= Date: Tue, 18 Apr 2023 11:22:28 +0000 Message-ID: References: <20230411074050.789415-1-gmuthukrishn@marvell.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM4PR12MB5373:EE_|CYYPR12MB8961:EE_ x-ms-office365-filtering-correlation-id: 054a439e-124e-452e-f059-08db3fff3188 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 1apnEWzeFNmeZtj3SWPeCG7tZNxEoi/kvtW5acNmXG2HrNLzUB+YZq0VbvJpmrUti0Osav00DIWwzjdmT/WRTgV6LCZUoBBdKqDy/RNKsUlehpWzYekJS5yK5Gl+RQklR5XzvPVfbqKsDLGbePUXfe7oehY2By3wzXU3kMI0TES45CO9SvujMZI5tuIhi1RCVmp8mu/feNBpQ1Dopj7PEohvaYhd5EQYeBXtHBIyXGhQPzD/PQaJe6/5l5VDic6Mc8F9YwAvexm0zpeqNV/Qrfj1/Iu6rUBHdN5qVSRX9Mh91S7Xjf8Y7y3+MrxA1d/7M0SeBvTBwTQ3rVaX93tGhydPAaB0XbUrzaDu8C8q/MV1sjKpIIrhszX7h9sJ+U+4qRGxPcoRHJNqcFTVUOH99by6Jv+a6YN344a6hXHr6lzzNpxS0OSP2tPVIdA1LoUzZ8eLQCg5Fp6CdjKV9CHuDJK9vSaUTQ/enySBi4YhoGojIlB8AxDeGZ7nnrWfPLKa8Rq11drcvDYg9AOXBJPlt9Bxvu03Q5vaqooeYHjuV/FdrLoy+J9CNgiZD0dEKYee8UnssofTxXfqvAJoWuVkRHsbvqYKE1NmrulsFSltHLXcTCoOhSRJPsDG3HtASsld x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR12MB5373.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(396003)(366004)(39860400002)(346002)(376002)(136003)(451199021)(4326008)(9686003)(26005)(53546011)(8676002)(8936002)(41300700001)(38070700005)(86362001)(316002)(66946007)(5660300002)(52536014)(76116006)(66476007)(66446008)(66556008)(64756008)(110136005)(122000001)(38100700002)(2906002)(55016003)(33656002)(7696005)(71200400001)(6506007)(186003)(2940100002)(478600001)(83380400001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?kyixq+QS0ON+FYgokMXsi729lD9Z6Plbilq3uleCN7dn9dCs+BXDipvser+9?= =?us-ascii?Q?3ORKx1Fbx80yujZiftwKw6KbaX+AFrYNANVJoRhKqiWA4DDpvSYjKjwkSUwj?= =?us-ascii?Q?GE3yJKQdyUs5Wjq90JvXkv7uq022aKj4Wr9pil63dd4E1EJUdpXh5fP/sm14?= =?us-ascii?Q?q3xD0QlnaATLc/hRUevt9SPzpMcbcI/DMuDl3FJPQaEP0nfVrtf63cBamrMj?= =?us-ascii?Q?x85ZveFL1xSU33D+2d9a+CGAXd5fNnRnLqmjDZkq0A9MmHndwN2MS6iitsH0?= =?us-ascii?Q?1Gikpec8NTSrd017raEbjmXjNsJFo82nOGYoJ1n3P8vA/ozaDMNWrnDMcGPM?= =?us-ascii?Q?FC8aY3meaFfwR/e6kZfdKIlRPeF2oeFWxaIvjtoPtwLwke1MEfD3mUdAttjQ?= =?us-ascii?Q?DiV4GftiJX+aVjMYK6pzhceKaJqr1UA9wFcWvE/y6WIc4z7wpQzP3V5qq7XZ?= =?us-ascii?Q?/HmpestLirksf4D+WapAtWpcaAo/vlWLhKh/rfWmUDV3rLOxJGukZZhjBGRW?= =?us-ascii?Q?P2OsDCGb0GgIPKf948WjG1P56fhd2/qxQOaqpMAqx6U7+b+FNKbXwSkReEvz?= =?us-ascii?Q?tlcQ0WXxpcslAZvXA39TirS2MUNgvu1YGNu84Sgu6nUuRfPDTdoP84iSiMRQ?= =?us-ascii?Q?u6c7+WbDp4zRVJIamNIRCfA5NQKL5lIpJrUwhoX+oi3k1pAJHijm/0r58pVN?= =?us-ascii?Q?3K2GryBjhzZtm2aO8MxevNUk721cOxoY1xNpt36TT0Xu4KP28mpkxHFhBGne?= =?us-ascii?Q?rluUdoRrxtasOz3Dz96DC2GuHKBx3Jd6aPvUgtijmc3c4/WEVepJ+7IGgpwB?= =?us-ascii?Q?8Hu43lVvLxsIJSZyf5fSR04c1AEE+FL2L0lZ/n1jOIioyzUKKH6ENx3uc7Ci?= =?us-ascii?Q?t7RuAOaJ34QlVsG3BtxUP49l1G95x0J9SaCBcY3aoy3mcVjl1PYk7i49d+WN?= =?us-ascii?Q?ehlExxDy3854lrSroM8H7d8EWUo5NgAArDBTZZBhL0PVnuW8Ru/RvZXWlJbg?= =?us-ascii?Q?DaHogPlmt9GlNeVX4mG1yI+T1bZ4iqRogQYJakkxz0F8hNTqtnmREHWxnT7D?= =?us-ascii?Q?bMShW4kReY4TxGTackKaX8RgWP/sCsWg87g2uWzJuqVBQJuhxbglIou72N6r?= =?us-ascii?Q?qFOEaWhRKMLa4IDabLSWqFYejfG7qgjUGGrCPbBKiwDtOO+p17+KKAwHNcEq?= =?us-ascii?Q?glmTxGrXgRGiWkZpyUqOJhI1S2G67RIZnGjOvLt3vUP8QQboiWTDspaah0Ld?= =?us-ascii?Q?1ZGkPzTbDfvO+kB8R3v0i12KLukr5nJS/YTjX3cziZlOK2o29vzQuFkBsVsp?= =?us-ascii?Q?G8ff4b1oX2RneDQHMDwdWGefTAq9YUJwrgel4ghUsgk1YCnzh+IFeDFnH0TQ?= =?us-ascii?Q?7ZBfxXgRuvHVfo/eTSy6YxN/W4Bg1WC0+sUknaBB6FQ84dG2Zg0668gbhYiy?= =?us-ascii?Q?2KRK+xlN/nvUNtD5qt+9xez+8RouYwo5y2SypqAZvUfmLPq8CrqcqHRMQdxY?= =?us-ascii?Q?HU/PbJ1bgR0KCp/RVJnOe5VHmINBKSZrT+zBTXP55j2OPLpVr7f49uN/aKSj?= =?us-ascii?Q?s1DtXlowQkRgeX6BonlZd9t90HW+HRAgWoTIqx1Z?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5373.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 054a439e-124e-452e-f059-08db3fff3188 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Apr 2023 11:22:28.3268 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: EA6LCzes+GH2ECRmtdlYynQnWi+muxynCcDhYHdBeDtN0LoMhxdpNksG6BUWLc8RCO6p6fLUrA/xW8OpVWDlxA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CYYPR12MB8961 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org There is a compilation error: In file included from ../../../auto/mtbcswgwork/xuemingl/workspace/dpdk/dri= vers/crypto/cnxk/cn9k_cryptodev_ops.c:15: ../../../auto/mtbcswgwork/xuemingl/workspace/dpdk/drivers/crypto/cnxk/cnxk_= ae.h:958:13: error: no member named 'lf' in 'struct cnxk_ae_sess' sess->lf->roc_cpt->cpt_revision); ~~~~ ^ Please provide a new version if we do need it for 22.11 LTS. > -----Original Message----- > From: Xueming(Steven) Li > Sent: 4/18/2023 14:23 > To: Gowrishankar Muthukrishnan ; > stable@dpdk.org > Cc: anoobj@marvell.com > Subject: RE: [PATCH 22.11] crypto/cnxk: fix order of ECFPM parameters >=20 > Thanks, patch applied. >=20 > > -----Original Message----- > > From: Gowrishankar Muthukrishnan > > Sent: 4/11/2023 15:41 > > To: stable@dpdk.org > > Cc: anoobj@marvell.com; Xueming(Steven) Li ; > > Gowrishankar Muthukrishnan > > Subject: [PATCH 22.11] crypto/cnxk: fix order of ECFPM parameters > > > > [ upstream commit 76618fc4bef616f16b6c92f15681ea080eabb486 ] > > > > Fix the order of ECFPM parameters according to target board. > > > > Fixes: 8e39b133235 ("crypto/cnxk: support fixed point multiplication") > > Cc: stable@dpdk.org > > > > Signed-off-by: Gowrishankar Muthukrishnan > > --- > > drivers/crypto/cnxk/cnxk_ae.h | 48 > > ++++++++++++++++++++--------------- > > 1 file changed, 28 insertions(+), 20 deletions(-) > > > > diff --git a/drivers/crypto/cnxk/cnxk_ae.h > > b/drivers/crypto/cnxk/cnxk_ae.h index adf719da73..f1183376d0 100644 > > --- a/drivers/crypto/cnxk/cnxk_ae.h > > +++ b/drivers/crypto/cnxk/cnxk_ae.h > > @@ -678,7 +678,7 @@ static __rte_always_inline int > > cnxk_ae_ecfpm_prep(struct rte_crypto_ecpm_op_param *ecpm, > > struct roc_ae_buf_ptr *meta_buf, uint64_t *fpm_iova, > > struct roc_ae_ec_group *ec_grp, uint8_t curveid, > > - struct cpt_inst_s *inst) > > + struct cpt_inst_s *inst, int cpt_ver) > > { > > uint16_t scalar_align, p_align; > > uint16_t dlen, prime_len; > > @@ -697,26 +697,33 @@ cnxk_ae_ecfpm_prep(struct > > rte_crypto_ecpm_op_param *ecpm, > > scalar_align =3D RTE_ALIGN_CEIL(ecpm->scalar.length, 8); > > > > /* > > - * Set dlen =3D sum(ROUNDUP8(input point(x and y coordinates), prime, > > - * scalar length), > > + * Set dlen =3D sum(prime, scalar length, table address and > > + * optionally ROUNDUP8(input point(x and y coordinates)). > > * Please note point length is equivalent to prime of the curve > > */ > > - dlen =3D sizeof(fpm_table_iova) + 3 * p_align + scalar_align; > > - > > - memset(dptr, 0, dlen); > > - > > - *(uint64_t *)dptr =3D fpm_table_iova; > > - dptr +=3D sizeof(fpm_table_iova); > > - > > - /* Copy scalar, prime */ > > - memcpy(dptr, ecpm->scalar.data, ecpm->scalar.length); > > - dptr +=3D scalar_align; > > - memcpy(dptr, ec_grp->prime.data, ec_grp->prime.length); > > - dptr +=3D p_align; > > - memcpy(dptr, ec_grp->consta.data, ec_grp->consta.length); > > - dptr +=3D p_align; > > - memcpy(dptr, ec_grp->constb.data, ec_grp->constb.length); > > - dptr +=3D p_align; > > + if (cpt_ver =3D=3D ROC_CPT_REVISION_ID_96XX_C0) { > > + dlen =3D sizeof(fpm_table_iova) + 3 * p_align + scalar_align; > > + memset(dptr, 0, dlen); > > + *(uint64_t *)dptr =3D fpm_table_iova; > > + dptr +=3D sizeof(fpm_table_iova); > > + memcpy(dptr, ecpm->scalar.data, ecpm->scalar.length); > > + dptr +=3D scalar_align; > > + memcpy(dptr, ec_grp->prime.data, ec_grp->prime.length); > > + dptr +=3D p_align; > > + memcpy(dptr, ec_grp->consta.data, ec_grp->consta.length); > > + dptr +=3D p_align; > > + memcpy(dptr, ec_grp->constb.data, ec_grp->constb.length); > > + dptr +=3D p_align; > > + } else { > > + dlen =3D sizeof(fpm_table_iova) + p_align + scalar_align; > > + memset(dptr, 0, dlen); > > + memcpy(dptr, ecpm->scalar.data, ecpm->scalar.length); > > + dptr +=3D scalar_align; > > + memcpy(dptr, ec_grp->prime.data, ec_grp->prime.length); > > + dptr +=3D p_align; > > + *(uint64_t *)dptr =3D fpm_table_iova; > > + dptr +=3D sizeof(fpm_table_iova); > > + } > > > > /* Setup opcodes */ > > w4.s.opcode_major =3D ROC_AE_MAJOR_OP_ECC; @@ -947,7 +954,8 > @@ > > cnxk_ae_enqueue(struct cnxk_cpt_qp *qp, struct rte_crypto_op *op, > > ret =3D cnxk_ae_ecfpm_prep(&asym_op->ecpm, &meta_buf, > > sess->cnxk_fpm_iova, > > sess->ec_grp[sess->ec_ctx.curveid], > > - sess->ec_ctx.curveid, inst); > > + sess->ec_ctx.curveid, inst, > > + sess->lf->roc_cpt->cpt_revision); > > if (unlikely(ret)) > > goto req_fail; > > break; > > -- > > 2.25.1