From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 272B6A034C for ; Fri, 12 Aug 2022 09:21:09 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F0281406A2; Fri, 12 Aug 2022 09:21:08 +0200 (CEST) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2058.outbound.protection.outlook.com [40.107.244.58]) by mails.dpdk.org (Postfix) with ESMTP id 8D80840697 for ; Fri, 12 Aug 2022 09:21:07 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=P5TPVJasus97ID5NHp+1uL2ww9xmqazI4NwEtHKa8y5bvABWVCNuxo0VTEjRAfIPWOC9aPYsbjvnf1lQieetRUEcPNcWAoffkLOMp1sx0NHPULkrUZplSpg4IxA8YUhU/Qg7XmG+MndxYXf+0ub8ZutLJ9hTnMDFfSUuFzTIZqTE2YBx4QJwMIWUqDKrUjsmr9Vs/f6e27JeVFDF7+d19GOXcbxGCDWMKeIllsrkR4WeoT0eXChoeSLkGHzvPlvlLT0bOr0gxmeoXYg/4gOxYXPG+kBfFWC2eB30qqg6c1TqqxCvagFGTj54mBNg3Gla2QSminazAgi469biaPVImQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=l6PBB8TWxvh6dZPKuukOrDx/jnOVG2Hy4vTDfgJ1HnE=; b=hhb9AWcJPQmsVSuVigxFO12Swh4yWSb7+VOyfkDDG4bQ6sHrvn2Efzc6sVWquKSFtgablZU6LXwTBL1jYggraw0skdYSaX47Xl4ro7bXwSm07rmT39cyvOFrAfNXwFchdDCzmOXgx7i7rYyTGjFNy4woVJ4bQkB6WpjjpbgTAYQiQAXMzybyMhFo0lRTFeHMOqPiXS1t485LE3RPhJbl3wWO1d+NDn0vV4Tb9rKqSNdkWaR26dHq9NDENvuy3/NIUU2M+Gtv2CFAVe89mAnBbcbyeHh7yRXyqGnqkbN1qh5o6VhxXHgU7DG/WrdAC3ZY7sn/o+z13BCNjelPuG++cA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=l6PBB8TWxvh6dZPKuukOrDx/jnOVG2Hy4vTDfgJ1HnE=; b=tXtujRUn43KjL154yTYM+XiUqCLR+5CHj/DdviyIS0EvcgRtFUbHHfZmeDokFoGBVGRTXIz6CXZIxLNlSbLz5SQC667eW4+7ep1clMwULCE9me5WiMDdxZX8ZiKHeb14dKq70AeRlD9wizCHj2iTQDEkpr0snw5QnLlZF8TrauVy5cyWU9FBDji8CXc33c+o6uLae0IRB/jrf59Bg+WIz7sjK8L0xpAY8m/XOo5HNa+G8EcjxkXmUQxQ85ml6JGdBSvFjkJTaW1h1fxRx5JRqvrAJWMiIztBUnNfkgQD1pQjDW+9s86CTZ3p7Q5tpMbVsEJl3c2qNCxD8GeFVb3CcQ== Received: from DM4PR12MB5373.namprd12.prod.outlook.com (2603:10b6:5:39d::14) by DM4PR12MB6351.namprd12.prod.outlook.com (2603:10b6:8:a2::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5525.11; Fri, 12 Aug 2022 07:21:05 +0000 Received: from DM4PR12MB5373.namprd12.prod.outlook.com ([fe80::442b:be8b:c1ec:a6ee]) by DM4PR12MB5373.namprd12.prod.outlook.com ([fe80::442b:be8b:c1ec:a6ee%3]) with mapi id 15.20.5504.024; Fri, 12 Aug 2022 07:21:05 +0000 From: "Xueming(Steven) Li" To: Dmitry Kozlyuk , "stable@dpdk.org" Subject: RE: [PATCH 20.11] net/mlx5: destroy indirect actions on port stop Thread-Topic: [PATCH 20.11] net/mlx5: destroy indirect actions on port stop Thread-Index: AQHYrVUzn0zu7cqImUeMsN4+Egh+Pa2q3Wtg Date: Fri, 12 Aug 2022 07:21:05 +0000 Message-ID: References: <20220811073716.3631212-1-dkozlyuk@nvidia.com> In-Reply-To: <20220811073716.3631212-1-dkozlyuk@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 3fd0106c-57ec-4e64-9b0e-08da7c333867 x-ms-traffictypediagnostic: DM4PR12MB6351:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: +arR98lPsPvHeLv4bx+8ErWQOixo7KnVAXBwMGwREHtw//WtPmotVZ2yX65i5sNHXof1zwWuCxLHBGSv7iM6O4tw5hgX007BD+p8sNBqf9MyaDiTYCkwdHdvxwH3DP2uZ+LpboBSjhnv91m11Vp4/BWcLb4yoYDsVb6eN7WSxg9hpW8pxeBeWsmxnILqwoYVyWVrTC1ja2b/FA2U1gq4yAsMhK1Xd747HRZdvuWzwyYK1+fXGxrryzdvoRp9Giidk3zZUlgByqNWLKEuqUSBDQD4zveNRKgH4LqvsEVSHSS2JJuNy29fN7SznRQa0a60yt7jkYM7494zp+7ExLBKMAQl24Nx6TjNyzBaZQPIT8C+ZpXSN5UFUNc8adXbNB+kl/mSEcj0jn84HMcRuoJocck0XxVXT01trqz1K1CIc7c7tR0TycstAXgODyaAPejzrcA3SzPQdoG6tVOPAh/SVSCQNLSB5NDXKMPsG4gWveUddCEYD98nW1g647mn7LzHKZa+r5214fBkCJlcZheyt3fn2YOwRYU2vohkT9lieoiQgNqZ1gwIBs8nvfoT9wzzFyJKCpHqvxa9DIEx0adCEhH8U1RqemHJlkQHaOROqLxNFOqBT6oOW0ccP10t+432pDqeRbKB1C95d2khVNDSLkTSlpTSLZmz+dQ+UJZUtP6XZkN5pyjA/b03gaSGEFOkl7Vfhz9AIEAIank04qkVAXPXaDKlUDIGS5ZFFguoX7qKsGJead/cI6TkI39fYTqc0PWvNN2wmRCyYqy1JpDn1GsgC4eZqmlvPZF0z1ecNZFv2ZZQnFDVYDnSyZE+prTt x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR12MB5373.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(4636009)(376002)(39860400002)(366004)(346002)(396003)(136003)(33656002)(86362001)(53546011)(122000001)(38070700005)(9686003)(7696005)(83380400001)(186003)(6506007)(478600001)(316002)(71200400001)(41300700001)(66946007)(64756008)(110136005)(66556008)(66446008)(38100700002)(8676002)(5660300002)(52536014)(8936002)(76116006)(66476007)(2906002)(26005)(55016003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?e6EbP+gWA+EHW1A93ptunRho4OBW8CIYZRDp20FAgmCs8GNHd/fP9MTjvgdl?= =?us-ascii?Q?j++kcijFmkjBZj7ZV5wWb1leGMgkKr3PbejnlToq+pfylGWR3gChM3/JsRxj?= =?us-ascii?Q?JqzJsM4mqD0DZETPwEB62EHP9An9jGJZaQPP72IOIShLqG+JKLyG7tlm/Nc5?= =?us-ascii?Q?UgZ8NLlOys4RKWv87sgyCIX9bo1YXsQRhh7vHHpqSwwfEIOrcxBC/ep/kuSs?= =?us-ascii?Q?ZCM/S242k17WjHI9d3XJmzkc5lwzQyba/+nPXw3gDhZdblzuR9Ozb8bdHHyR?= =?us-ascii?Q?UVX46rjXIxQ+bB1le5zoSMRpVFLc8t7wbooC9ETUCD66CL7f1+wPRPm2Lm1S?= =?us-ascii?Q?z+7z3bYP1zpbc4gJ2A9pE07Wrz6cFqDkBXZRiCHQ9PfOXyMEyxluo6OjiYRc?= =?us-ascii?Q?rFJ3NfmD+wPPgRL563d0+hPvYYg3txU6mosIP2M1jxY+fV0ID1+sUMBXIe1q?= =?us-ascii?Q?zZ2SmYGwQFzhcf9JtylIhMeKibgD5j5ET6BIqgQlF3IegNbOozj5JxYt3m4a?= =?us-ascii?Q?j+27w6dEzSOkH4N301Imi6cymh66/Pb2RlIyfU5IZ+3ldg58cKF0GSNw+XM2?= =?us-ascii?Q?WHJip4vhsdnsff1qTSBq+N1igC4tZprFL/damudku1fEgrHyEX+ofGs7u2iS?= =?us-ascii?Q?ZZVpSQtVcT5r1JvZT0uCYGLri5bn5hkSPEbEILfYrXYz1e/3D4/QIGe00qC9?= =?us-ascii?Q?JZxjz/EDJtWuF/dIJB2TVmTWt9J6vW2OQQbkSk/IgTOUxsd9LJJInXRi3myO?= =?us-ascii?Q?T5YEs8AqUdULlouXEOfMu3u48wsdtgtEJchpa4SpfpjgtdJ+vsgpQFH03dY0?= =?us-ascii?Q?JGsRmqOWcNQ39CsSZae2um7o2EjN9arPuEOECOl8T+L7pafuHW/JpelA4PVz?= =?us-ascii?Q?o8Qwp1r6XxKQU3VpynK2IJf0HYHZBaQ3WaHUKmk9xOTPP1wiNk2BNKtZvfJc?= =?us-ascii?Q?Z/TXmELojdT58wYjTQiUTVglfb0ozgdHn3RCrDS81laChsZNPbaMJxV7ynVa?= =?us-ascii?Q?yDY63KavyBxctZFsfM7g+DVLWcEV/eGJspOHH2+BW1BFG8EZF3HC/+iJuQ3B?= =?us-ascii?Q?fhQuGGu9B2QO6w6Sj51uuGmRBl/dLGWN5MD9NcGhJIT9f9y0Y4CXG69wBNat?= =?us-ascii?Q?dcsmB3kqyoukCCWHfnBSy1aADdIdSGRek+X2KRA0SjZbFQrd3d+46gaTXbus?= =?us-ascii?Q?ZRo7oRxT6LYWUE9vqyluPZ8ORR7R0PcfnRFD60boMeJE12uRkzPWXNAXHDOK?= =?us-ascii?Q?pVQyDvX/ZtxOZ/eNCE5ztyqpZtgGt8DReJ6xUlY5d4MrJJirKl/a3zC2a5Ns?= =?us-ascii?Q?uB4mIAXC6Hb+f+d8ZDMcOjdEqrTch4N171tcmWMwBWUDtopUHNGHY+qWisSU?= =?us-ascii?Q?91jfFvWKVQ8F3LlJWYT0iQ4sMka2msC/dVhYpDcmEm+rPrjdiR6aKwFC0Irj?= =?us-ascii?Q?JPDwtFiz5GH7bfiphATEYQv0FrtSAqXwcFfWRmZ3HL3fqQoULcvmfDNP4SRH?= =?us-ascii?Q?qUcdm84jnvM72H4wc6JJ94V1Al8pkPq4oVhzZ2tFxRR2SFMVjRp64EsOUnqJ?= =?us-ascii?Q?0GAUdVVeel9yYgjTMtePqAo4n63NOtfl1vqsEOLp?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5373.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3fd0106c-57ec-4e64-9b0e-08da7c333867 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Aug 2022 07:21:05.7524 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: sTL15svjYzlhXKXk+XUyg+LI2dgTEIY6KOoMr0cHqwoTpLrMq5pLMbug2g/a0QOrPabEpe51yAKL/2CaHmpgQQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB6351 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Thanks, applied to 20.11 LTS queue. > -----Original Message----- > From: Dmitry Kozlyuk > Sent: Thursday, August 11, 2022 3:37 PM > To: stable@dpdk.org > Cc: Xueming(Steven) Li > Subject: [PATCH 20.11] net/mlx5: destroy indirect actions on port stop >=20 > [ Upstream commit ec4e11d41d129ebc7c395b567827492e56fb08b7 > cannot be backported, because it avoids the issue > by advertising and using a new capability > of keeping indirect actions across restart. > The behavior was unspecified before then, > so it is correct for 20.11 with this patch > to behave differently compared to the upstream. ] >=20 > Shared RSS actions were not destroyed on port stop, preventing release of= involved RX queue resources. > As a result, associated pool of such queues was exhaused after a number o= f port stop and start operations. > Diagnostic message from rte_eth_dev_start(): >=20 > Rx queue allocation failed: Cannot allocate memory >=20 > When built with RTE_LIBRTE_MLX5_DEBUG, > the following assert was triggered: >=20 > testpmd> port start 0 > PANIC in mlx5_rxq_start(): > line 169 assert "!rxq_ctrl->obj" failed >=20 > Destroy indirect actions on port stop to release the resources. >=20 > Fixes: d7cfcddded61 ("net/mlx5: translate shared action for RSS action") >=20 > Signed-off-by: Dmitry Kozlyuk > --- > drivers/net/mlx5/mlx5_trigger.c | 2 ++ > 1 file changed, 2 insertions(+) >=20 > diff --git a/drivers/net/mlx5/mlx5_trigger.c b/drivers/net/mlx5/mlx5_trig= ger.c index 6273122e40..c8dc0398ea 100644 > --- a/drivers/net/mlx5/mlx5_trigger.c > +++ b/drivers/net/mlx5/mlx5_trigger.c > @@ -13,6 +13,7 @@ > #include >=20 > #include "mlx5.h" > +#include "mlx5_flow.h" > #include "mlx5_mr.h" > #include "mlx5_rxtx.h" > #include "mlx5_utils.h" > @@ -1192,6 +1193,7 @@ mlx5_dev_stop(struct rte_eth_dev *dev) > mlx5_traffic_disable(dev); > /* All RX queue flags will be cleared in the flush interface. */ > mlx5_flow_list_flush(dev, &priv->flows, true); > + mlx5_shared_action_flush(dev); > mlx5_rx_intr_vec_disable(dev); > priv->sh->port[priv->dev_port - 1].ih_port_id =3D RTE_MAX_ETHPORTS; > priv->sh->port[priv->dev_port - 1].devx_ih_port_id =3D RTE_MAX_ETHPORTS= ; > -- > 2.25.1