From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E7E8043703 for ; Sat, 16 Dec 2023 01:54:02 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C39E5402A8; Sat, 16 Dec 2023 01:54:02 +0100 (CET) Received: from NAM04-DM6-obe.outbound.protection.outlook.com (mail-dm6nam04on2048.outbound.protection.outlook.com [40.107.102.48]) by mails.dpdk.org (Postfix) with ESMTP id 2F67D40261 for ; Sat, 16 Dec 2023 01:54:01 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=l4AA7pEh4zvbYLDasMhhbBVvN5Z5dH00/LQ1Y5tO+dcRXxk3u5V58qMvIA6uTfxHEHsZFzw4MVq72wjad8XIx8R+acWKgDHSjyRzWHTIfaxDdLMNBXO3Z8DoA6XJTJvC8Lr5pNwPf32Kbbx3TVKe8qaRpnadDu9DBJSiONtCnAQnL0jLw3Tq+banpH8w+GtjclH9OOZvHz+ovHoy+1E6wHDQxNeYPotNJ80fn5OaqX3Hf3GCcnfpVp8YOFmmXvATVUkwS3OQrWoWsl67bKE0XceWWGp5MmL5QKauYI8Mwjt5GtjQ8JVDqbkj/Gr1DWmQtZsxn7EWbHW3pnmY4ieZyg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ENczq9xdzH4ZOqjISBCBK3duadqlctMS0ZALgLcZnxE=; b=N2isxhJ0BYVRccGWemWGeOu4CQY98Bf7yuy4Z5yEBgExxl3Q6qKLJ/Kb2CtUme8jcTgSiRtt0QbQOWOSlSN4NF9Gzx5Pl+X+x8PkNbwMPoNyufFSJnpWGkcP4D/zvClK3GyeCPYt34xJjDRgJWlFjAWyAthw3TTXLi4uIt3QgK8AzxHTtaVMY9WsXwB969f+q6Q4hkN6SpSg91Yu5Coq8a9Q8ZxSQpBZNfvBL6TmI7XGYtEWNZRunw1mL2UOw02xkqXhNUAf+JTFC5+6hMmqBU41iRJkcnER51cM4pFcn1eETtCLzsdyOkFZwsxZh+tt5SFELx9D7cw3K3XJwpMB5g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ENczq9xdzH4ZOqjISBCBK3duadqlctMS0ZALgLcZnxE=; b=Ag4Mh24kghYpKwDM4ZMOTVgMZ9+LnJlnn9tG2EW5eCbxnq/REr2S9FnSYoh0faZeH9hbZ9AGPJFO6tNZNnfibWo3adbyCPrlrImZV8G6z1BTqEdex2yfZkdYXY0woTZVg8zC36rOJQrbi0oYapVUOpb8N/VcAKkLyn3eteWT5KudLBN//1K2Ms3mr1eX4/B70rl9lSpHFJf14Q2CtQth7f8KWg9jKMibefGBsA25zcSB9sJYq5valydywKg4LJsVM4SBv+J/wvI0e1vGBCD3xMhjff9O4LK2PHmpFfXkln8GY1Hb8C/npJC+JPoCGNnnQ4rJdNoKxGNfyquC2+4GBQ== Received: from DM4PR12MB5373.namprd12.prod.outlook.com (2603:10b6:5:39d::14) by DM6PR12MB4091.namprd12.prod.outlook.com (2603:10b6:5:222::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7091.28; Sat, 16 Dec 2023 00:53:58 +0000 Received: from DM4PR12MB5373.namprd12.prod.outlook.com ([fe80::6e12:5648:d8f4:ab2d]) by DM4PR12MB5373.namprd12.prod.outlook.com ([fe80::6e12:5648:d8f4:ab2d%4]) with mapi id 15.20.7091.032; Sat, 16 Dec 2023 00:53:58 +0000 From: "Xueming(Steven) Li" To: Chaoyong He , "stable@dpdk.org" CC: "oss-drivers@corigine.com" , Shihong Wang , Peng Zhang Subject: RE: [PATCH 22.11] net/nfp: fix link status interrupt Thread-Topic: [PATCH 22.11] net/nfp: fix link status interrupt Thread-Index: AQHaLKje7qAufTvz9Uu1bh8gqX1RZ7CrGz1A Date: Sat, 16 Dec 2023 00:53:58 +0000 Message-ID: References: <20231212031048.1816944-1-chaoyong.he@corigine.com> In-Reply-To: <20231212031048.1816944-1-chaoyong.he@corigine.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM4PR12MB5373:EE_|DM6PR12MB4091:EE_ x-ms-office365-filtering-correlation-id: 94c772b2-0b45-4a2f-e931-08dbfdd17cdb x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Bv2qUB82s//Bq2KRQPXK88JDJTep5BKCNck9DWAMxHuYNcQ/mt1W5PDygMRMzH1uSYVlkdLNrimgsFUdCewyCjgPoTC8VTmm8VoHF6YSt4K+YQbYztUURUTDK/avy88NQQtgrMhvnRH42r9c73b2RX0L3pLtp3S1mev0PbZgz5Sz+v6g7NUqclh6BLwUSQX3FlJdH4C3l7D+rUMGRt8v/TTyWMnljeKFHNKzhmK05mdSFq9a5l66DC/tKptCyFBP8S70dQNSOlvbEsDkuKXiPTwNwnc050aXkRGhDXwe5HyTE96iRj5uZvQAWGwKmYmghF6Xc4D1kRaNE85OWB0xWB3FUG+MWP6F88AKVWTGG+pT590knHNBk2bh5G5ktJJdeBdlztqmQDBZJP1/tshhwNmRFowEk4XqvCZnp3vtucowrsLirqOmJG/50iY4d7dmQIy0ovr1pvbh+hAMNOv6ftJ2kX5OY5uxxtwHjoHgHU3QDckOPH41ueUHSEjnsJR4htjux7WgJetTKGx1FUOop6MsTehbqjwSqy40Rzb4FXhLxGPRcstJDy5bxnb90xYjx+ThgEae9BTk4U4QSuhXlKU1mxEsj0vXZ2CCovbUr7D9Oeu6hHnX3UaLc6Wxvs3U x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR12MB5373.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(346002)(376002)(366004)(136003)(39860400002)(396003)(230922051799003)(186009)(451199024)(64100799003)(1800799012)(26005)(6506007)(9686003)(53546011)(7696005)(71200400001)(83380400001)(5660300002)(52536014)(8936002)(41300700001)(2906002)(478600001)(54906003)(64756008)(8676002)(76116006)(110136005)(66946007)(66476007)(316002)(4326008)(66556008)(66446008)(86362001)(33656002)(122000001)(38070700009)(38100700002)(55016003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?5qCTS/R3iDhW77buTQqeJnqk/Rx2UqdSS+2JEG5dpAl9ynYirJdHF/uewRQy?= =?us-ascii?Q?iuxAYJAmguzgF3mkTQBUZETnHqTXXrJ1LLxmVnTRzDbL0Z2dcM4St7tsKBJ0?= =?us-ascii?Q?6qLQsR0jNnKvaEp+8tL38O1edQHvx/5+dnnZdwar3WmKs4UDpRJ6wek9YhND?= =?us-ascii?Q?2IxNF5lBOBTDZGbphlsFqIEpvwxg9Ta/lXdO+EkbU2ACWgozvvVa6t0oWmbJ?= =?us-ascii?Q?ZNvPgDAnGB+K01JOM7+SNvxHSvRvz2/AQl+YIsrQPN++aC4kC/vd/xEPpf0Q?= =?us-ascii?Q?YffOfoOzlsysenMs0LoRuCcrHbZ+qUYLUl3yw+09RQ/Nof1KmF3lLBL7DkEL?= =?us-ascii?Q?jBcAg+VenSdFMlICPYfkMD1bXBNsR7h5ipmhqmQ4+ZdJ+9e6pS+Lp6L2D+b6?= =?us-ascii?Q?HH6pGdndIhsoBDiLz0JTKNubS6j0ARDC5zPgp0I5e1WUxrF9cMj7sIedujN4?= =?us-ascii?Q?4K6CtEpjcTaUz0SsaLsFX8YkrDFJC8rMF5g+kldK2HZ1vE+d+I1pYkXn/GbS?= =?us-ascii?Q?60ozEQn0wyKJWfLmkXIKRzsMGIPnngyRWLyw4bCghNoYbklg6NQ59/jxGGqD?= =?us-ascii?Q?TvoLu7zuNlfCii5YGuHStnZM6mL8kW5jW4aAMCxTQH0CnPZ5Cob1g/+7KR71?= =?us-ascii?Q?El8zmXEPN7+A2ey6XZKUE6mxQXbjRPFD10custk4UVR+EefLO0Aw/AEWMtMb?= =?us-ascii?Q?OwMovBchfeSG9LcMyK53fv9hQaVhbW8iPmrgNbectJVS2kL1UQ0abiLBUtcO?= =?us-ascii?Q?OSchmY1Dog3v9z1lYBGtzJA7wmKGdRmPjkQ0IWE6cDPWfuJRE26QEmfXNaFF?= =?us-ascii?Q?eSpXXlxcJWPYUMj1aSr7797Aqmb4LQ7jLlCuXoIT7khV49o6nIFGGfmwwcvE?= =?us-ascii?Q?yfHnuDCpsKe9cNU6AEwAEXKhYIPOLiTAvGnRnoOOklhwCGmluuBSzZUV5xHS?= =?us-ascii?Q?/ILwf6JJ2nb6N3SQEvLXjNgTSQiun9fVazRfvtZCrby/+8g8hs1bZo9D7Hq7?= =?us-ascii?Q?Ivr16y4cF2aP0hW/2XI/Mss8jQjSTXob2GE88cS/b8kqkSm5feannY4pTTI2?= =?us-ascii?Q?06/NMLlgbK6bSTm5Rsk3mexaWNnAJYONwgOB3UGRyyyfXwdbPdGJtkRyp4do?= =?us-ascii?Q?CRXmHNUmTetwmAuAMA9dlzdomRSNZeff8GqITTM5TIagCiggEgVbvgfhmWWx?= =?us-ascii?Q?1YkGJZ2I1PZBQP8+VvbP5kpgrdj/D+RBruAlV+1KqA3G6BZGUfTbYgKA0B9x?= =?us-ascii?Q?PM3Vx6SSBVmPujc5ZEa5eTnQB9YdoywQOKXRacEAPPYr4E5anxyJr+Ckox/P?= =?us-ascii?Q?6eekE1G5EcXKi8u9a0JAvgqSxY1th7pDg4Mmh49/vy3OJxVPTLyPtyjVT+z8?= =?us-ascii?Q?wjryZ26GA/yhNCI68oZcSu4kJ+q1bzHExTbDdpCv9buQscyiJUbnqb50GPGx?= =?us-ascii?Q?FTswiwhaGdbkd/cX5gzywgQTgUeEbTsmSGkzGniU11mzGeRCG3wmIRRXeTkg?= =?us-ascii?Q?l5yKLXGWw6OLO08i1C0oZ2JivEkcypO5sMx8mweWj7lI9bw4I1Dnf7sfuvPW?= =?us-ascii?Q?GE3zSonmcORHIsZ4CzSSJViUW/gg5NHSQwSc6kWR?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5373.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 94c772b2-0b45-4a2f-e931-08dbfdd17cdb X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Dec 2023 00:53:58.7628 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ++jLBCv9kuVhwNE4yi6h3GFO9WeGdE1xCJozd5wouSV8lwhDDdZF8FdylcAyeN/pWCy8YnUufFSiZxdPunGA2Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4091 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi Chaoyong, Thanks for the backporting, patch applied. > -----Original Message----- > From: Chaoyong He > Sent: 12/12/2023 11:11 > To: stable@dpdk.org > Cc: oss-drivers@corigine.com; Chaoyong He ; > Shihong Wang ; Peng Zhang > > Subject: [PATCH 22.11] net/nfp: fix link status interrupt >=20 > [ upstream commit 94d0631a8275afa4314ee1d4f08d2fbd02325124 ] >=20 > In rare cases, when DPDK application exit, the interrupt handler was not > processed the interrupt in time, resulting in the LSC interrupt mask bit = not being > cleared. So when the DPDK application start again, the newly coming LSC > interrupts cannot be received and processed properly. >=20 > Fix this problem by force clear the LSC interrupt mask on port initializa= tion. >=20 > Fixes: 6c53f87b3497 ("nfp: add link status interrupt") >=20 > Signed-off-by: Shihong Wang > Signed-off-by: Peng Zhang > Reviewed-by: Chaoyong He > --- > drivers/net/nfp/nfp_common.c | 2 +- > drivers/net/nfp/nfp_common.h | 1 + > drivers/net/nfp/nfp_ethdev.c | 2 ++ > drivers/net/nfp/nfp_ethdev_vf.c | 2 ++ > 4 files changed, 6 insertions(+), 1 deletion(-) >=20 > diff --git a/drivers/net/nfp/nfp_common.c b/drivers/net/nfp/nfp_common.c > index b75fd22e03..0fa74a43e4 100644 > --- a/drivers/net/nfp/nfp_common.c > +++ b/drivers/net/nfp/nfp_common.c > @@ -885,7 +885,7 @@ nfp_net_dev_link_status_print(struct rte_eth_dev *dev= ) > * If MSI-X auto-masking is enabled clear the mask bit, otherwise > * clear the ICR for the entry. > */ > -static void > +void > nfp_net_irq_unmask(struct rte_eth_dev *dev) { > struct nfp_net_hw *hw; > diff --git a/drivers/net/nfp/nfp_common.h b/drivers/net/nfp/nfp_common.h > index 67c8dc33d8..d1a07f5a72 100644 > --- a/drivers/net/nfp/nfp_common.h > +++ b/drivers/net/nfp/nfp_common.h > @@ -449,6 +449,7 @@ void nfp_net_stop_tx_queue(struct rte_eth_dev *dev); > void nfp_net_close_tx_queue(struct rte_eth_dev *dev); int > nfp_net_set_vxlan_port(struct nfp_net_hw *hw, size_t idx, uint16_t port);= int > nfp_net_check_dma_mask(struct nfp_net_hw *hw, char *name); > +void nfp_net_irq_unmask(struct rte_eth_dev *dev); >=20 > #define NFP_NET_DEV_PRIVATE_TO_HW(adapter)\ > (&((struct nfp_net_adapter *)adapter)->hw) diff --git > a/drivers/net/nfp/nfp_ethdev.c b/drivers/net/nfp/nfp_ethdev.c index > 1b0131b1d8..9f940a12b6 100644 > --- a/drivers/net/nfp/nfp_ethdev.c > +++ b/drivers/net/nfp/nfp_ethdev.c > @@ -691,6 +691,8 @@ nfp_net_init(struct rte_eth_dev *eth_dev) > nfp_net_dev_interrupt_handler, (void *)eth_dev); > /* Telling the firmware about the LSC interrupt entry */ > nn_cfg_writeb(hw, NFP_NET_CFG_LSC, NFP_NET_IRQ_LSC_IDX); > + /* Unmask the LSC interrupt */ > + nfp_net_irq_unmask(eth_dev); > /* Recording current stats counters values */ > nfp_net_stats_reset(eth_dev); >=20 > diff --git a/drivers/net/nfp/nfp_ethdev_vf.c b/drivers/net/nfp/nfp_ethdev= _vf.c > index 6a70daca90..435127604a 100644 > --- a/drivers/net/nfp/nfp_ethdev_vf.c > +++ b/drivers/net/nfp/nfp_ethdev_vf.c > @@ -452,6 +452,8 @@ nfp_netvf_init(struct rte_eth_dev *eth_dev) > (void *)eth_dev); > /* Telling the firmware about the LSC interrupt entry */ > nn_cfg_writeb(hw, NFP_NET_CFG_LSC, > NFP_NET_IRQ_LSC_IDX); > + /* Unmask the LSC interrupt */ > + nfp_net_irq_unmask(eth_dev); > /* Recording current stats counters values */ > nfp_net_stats_reset(eth_dev); > } > -- > 2.39.1