From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B39C3436C4 for ; Mon, 11 Dec 2023 07:25:40 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8A9D2402DC; Mon, 11 Dec 2023 07:25:40 +0100 (CET) Received: from NAM04-BN8-obe.outbound.protection.outlook.com (mail-bn8nam04on2041.outbound.protection.outlook.com [40.107.100.41]) by mails.dpdk.org (Postfix) with ESMTP id C9C08402B2 for ; Mon, 11 Dec 2023 07:25:38 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LuzGNDttzuw3uERHwR3dIWWMaNNbykGsI7Wl0jN5RWRhUynBTr/lDzkRir8IT9cif6KF9lPzrwxhnGpzTbXyid1u3y6TcunSyxmYQ0l2BQrIf5EKRfVRBhmRHgV1HDa/Nqb7FWX5sJFCVdt3FkqRhsk85Vy73DImrUEWMNJ1Mwa6hk4xr0ffr0w0+Btb9ZzwDf8FRxLp1w1xK8NyfG5aRvpO9tCnQDLq6O5tdNZ5Vb+KdfHBj8fpXkJZFK4dCxb5zRLVy8bQKIfXmFrB2IDZR5jFQVt1bOw3hewZgCE8Z2/BTQWZQRJ9fqDf8XWN6478DRrvWbD904QXxsA32N2GnQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=17kpAWe4Lz/5PdjTKguZyTfdVAiw3hG/q1J7pVteoYE=; b=kYDBeUAeNBF3JNBIeFIBcDQWY6hOJ/+Ed1ma0jHGHyLyIO4iyhHPyCu4J7ylUr5GU497Ej3h6re5Svs/1i1+aUWk+Zpc4Y5Y5RTO+A9Uv9wxUutqAv4QooG/qlGbeq/sNlYL8BB375SP0/tcyIWlcHnVY5zAOANhFVO3/7KVKLUnS0YHOGWWyU/Nc8DXBFL5qpUGTt3HHzl/QX9MgQjMCy4L4hTF+F/SSguBKRMR1rsePiTXqGzs3QouyoMG65iDAcfTHspX5o0sdMnUsvVh5Hj9ubjRfdun82JVbmn1zoOH9871FZcswyx2UD12mfTXWFDrn2CWX2Cg8DzR4imNLA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=17kpAWe4Lz/5PdjTKguZyTfdVAiw3hG/q1J7pVteoYE=; b=ucSc//UqVul0ZhmhKSC7iJihTdJwFY2sTpxHczdaxukm59oGF/fAbFp2PuF51to8x4/LvRtS8hFwi01U1RW1bMwxBgHUOmPQPV2o7uPFyCMtFdbS0iyQ3vpb/VNsAOVt+5xCzNtNGIX7V410UjQ9kKZmobhSvTXiq11hCfdU6/kJPY/35F7gRb6rshJFoFH/NxuV7vYol2d/2kiaCLoFp6fbkaKwdYE7Wh8HLxrqXOUOkY55oX3/PNLCRJOl04SjzsrDqsApjQmYlgvdCP4zt6Vtl7wJbd1/QWVGsrVeFgb0gfsIu9u5tS4oaAsIt5Z//boEoSm1fWQlhU9wQ60tjA== Received: from DM4PR12MB5373.namprd12.prod.outlook.com (2603:10b6:5:39d::14) by DM4PR12MB6566.namprd12.prod.outlook.com (2603:10b6:8:8d::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7068.32; Mon, 11 Dec 2023 06:25:34 +0000 Received: from DM4PR12MB5373.namprd12.prod.outlook.com ([fe80::6e12:5648:d8f4:ab2d]) by DM4PR12MB5373.namprd12.prod.outlook.com ([fe80::6e12:5648:d8f4:ab2d%4]) with mapi id 15.20.7068.031; Mon, 11 Dec 2023 06:25:34 +0000 From: "Xueming(Steven) Li" To: Abdullah Sevincer , "stable@dpdk.org" Subject: RE: [PATCH 22.11] event/dlb2: fix disable PASID Thread-Topic: [PATCH 22.11] event/dlb2: fix disable PASID Thread-Index: AQHaE0VhKggjRYiPFkmalWGS1OlJlrCjzwbw Date: Mon, 11 Dec 2023 06:25:34 +0000 Message-ID: References: <20231109194544.3246038-1-abdullah.sevincer@intel.com> In-Reply-To: <20231109194544.3246038-1-abdullah.sevincer@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM4PR12MB5373:EE_|DM4PR12MB6566:EE_ x-ms-office365-filtering-correlation-id: 5353a8ac-0a0d-41ed-18ba-08dbfa11fb90 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: isEed3KgxfmesYUz0LHLXc9u72WS4mwOFhkp9lnniye72h2eMI2CBJ9+nLjnmr52/ZBk+uLHhtpbx0VybGZo8cph1DfmdmLoA7XVw5mGN4+oQ6amkxypzZiuPAbKX8Ojw03GuZPd8CZdrg7OtIhdT142L5RlTGxaVhUD2XKqtM6J93v4w4sOUHhrKu/H60UPko5j/D03jdCm0lAf8gENBXomJ1NFX/9n7G6XVxHQGIf+SlKE/b7IKZOhecyA67QyOc1pYrmyjdnC8dqGngdzL1CRN+p0cydO7Z0gClekKb74rhKRsEho9sYhYa2BsW0f+jztmk9IrjxJmKcb5CYfWcSMh2plQN3hfroofV1vRUm6k/54a54OVaZmvw3f9i8+5ExJQXsjPLzrNgUkOC8YD13vwVtnULoQdYb6Gh+LN4aagQLQRHqKJX8NF5WKkEE/JGFX9zvolJRXjGCI6VkdeKOLyTFg9Uein7gRPO0169gJb4p5EsYaa2A3CX8FZrdD7HkRBme2IQJB2UbRZQtJUauOVfjsENWEKPn4i4+9A3KkYleZHmy7Vh0JY04x5UsksUdNZwbzIQ2Xqbo5scbEz4878hwysx4G8whTZjE62gb/Unsm9nipNPQIVmjzVaXp x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR12MB5373.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(39860400002)(376002)(346002)(136003)(396003)(366004)(230922051799003)(451199024)(186009)(64100799003)(1800799012)(41300700001)(26005)(83380400001)(38070700009)(33656002)(86362001)(38100700002)(122000001)(5660300002)(316002)(8676002)(8936002)(2906002)(7696005)(6506007)(9686003)(71200400001)(53546011)(52536014)(66946007)(66556008)(66476007)(66446008)(64756008)(76116006)(110136005)(478600001)(55016003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?rtIrLbcU+6ARrcgWB42pqW9oBMilGRZMb/LVT5lsgqhu2bXgqE93VHGMiiQp?= =?us-ascii?Q?DXZpcWRXCOLuagrO0rSxG3rIsL5++jfYKNxf/A/CGLng4ojaKMAfEnnAzSIX?= =?us-ascii?Q?Y/YbGiawq9l0DZsvvVRIHGBrSJDoQh6L9CwBsN9T3z20g2IQKtmAYSFsoz0Y?= =?us-ascii?Q?7TpLt4094kFHsCYZKBBvmM4RRQEw461bxMEP1IzE0Cqyiznbfzl/sFW7Hbzl?= =?us-ascii?Q?v6zHBh0WH67BKerPLJIk3sWHCdXmpUZk2bfHULAUn+R9yo6OjguifL5+DwVa?= =?us-ascii?Q?dwfwSSWsbI8JGxtUPc07bPIxxrCbUSWXlY3fUVYu9IilRgOFp3KeVHNCUOjR?= =?us-ascii?Q?ft7HLCodslkfyUEg/DKwV4PO9aW5OFB19HEhxwBqIIeye42d4MIlY64TGC2m?= =?us-ascii?Q?di91r6TUC6T+w/49J5CPztfE0XVbsJJqorSbq6O22abbkZObigAIai6srTVt?= =?us-ascii?Q?tetkxiz/mftiSQ4wDybLha+w/CYGQew/V8blq/KTDyRK6rIWZeQ1+0u4fmfD?= =?us-ascii?Q?ZIoQBDI1E7Qwl+/bfEFki4fJrVhZx3x57ALhHxAEdXXWmRW0DVDXASFKjynj?= =?us-ascii?Q?eZjtsOZeFnhOwXyRtjhq6tRW/yue1UMxiOVnsSvtgz1tjF3KCs5z9ztu8Yqj?= =?us-ascii?Q?B/V7/NBTqtNU9RUM8FXUSw/jDWKaEkn+imJiL0vLloDxbtuMzINitB4Sat40?= =?us-ascii?Q?ciR3W07stMWVHkHldluXL++PQRsNRhTRtpLG+9/8vLi382aQvGSlosmJtsuL?= =?us-ascii?Q?/LX+9scjt/tDgKvbUyq0txH8Ss1QDyGmjN3C9eyfmcZB1CaVfvo4+KURAIxu?= =?us-ascii?Q?zTZfCCAE88NBp984wLelTcSVL/us5J0lfhFouLnYsny02o6dYsFdDuLGZMWV?= =?us-ascii?Q?JHGun6JBkqU0lHY0fG1SPm3rU5zmgP+asw9Pivkks44TtjB+Fq19c8xKcvq+?= =?us-ascii?Q?vvk4XEimkMEDD8m5tqQ4gbqfCv3Bje8wJ4YyxJKu0e2vaoKR7H0n6HGZXLsQ?= =?us-ascii?Q?aulwZ1/NUhrUMjxdAV7VylcbZvPryqvtxSNPK7H1SwjA2pMwv7XRx+gLVjvW?= =?us-ascii?Q?ZXFgj2A3GbuSVRqpvhtBCwKKGMPsZXzg9hevnqZxAB3ZSdFsHntthahl86gD?= =?us-ascii?Q?KqLymPlv1EMYbFYpefs/YWBWHzDHOUxKLXXAO6KqAC48hgiW5bAoFJICHE7A?= =?us-ascii?Q?7yR2xKlejFgsMDsXnnMoWlyOJTeGdI0L56z6ucm0LlGRDhtUFyN/GLZ1JkBL?= =?us-ascii?Q?GFFKmJ6YhrSCRqpg18JoZ3CcBUPo0GxICvjaY1PzG6M7BNqlavGIrvy3KhTz?= =?us-ascii?Q?gNgWz10n9cycEAikZuqhC5Gm9N1qbI+koC8aSbzf3ymusIMyzwLJy0tMxEK6?= =?us-ascii?Q?MT7LNsPNkST5MXt9vx6wVmotbff6UJSfeKFBCl4eh7o57OM5pMvZiqSoS9eR?= =?us-ascii?Q?Y3LDMCy66G5iCGvCCDTmDHbL5QLGKhCKNmk5qhPUIJs/NnBl6g/ycygpCiid?= =?us-ascii?Q?MBT5dKwc3mRKtRiPE3/SljOD8c32rrkx6bxfgdQjgTF9zDdRtZ8fl37A4a9P?= =?us-ascii?Q?IKZK5xBXwtb5W3JZMp7/AoZmt+Jm15Bryc1L5ITo?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5373.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5353a8ac-0a0d-41ed-18ba-08dbfa11fb90 X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Dec 2023 06:25:34.4370 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: QNB1QHciIeOI797Bx9uWFp0uNvVwYDpnNIPHU4JW75XdG2+i1r9fcouPKI4thzhSquZI9r52wKUoDoHgxctoSQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB6566 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org > -----Original Message----- > From: Abdullah Sevincer > Sent: 11/10/2023 3:46 > To: stable@dpdk.org > Cc: Abdullah Sevincer > Subject: [PATCH 22.11] event/dlb2: fix disable PASID >=20 > [ upstream commit 5a6878335b8179337ec2d9931debf1f46525e8fc ] >=20 > In vfio-pci driver when PASID is enabled by default DLB hardware puts DLB= in > SIOV mode. This breaks DLB PF-PMD mode. For DLB PF-PMD mode to function > properly PASID needs to be disabled. >=20 > In this commit this issue is addressed and PASID is disabled by writing a= zero to > PASID control register. >=20 > Fixes: 5433956d5185 ("event/dlb2: add eventdev probe") >=20 > Signed-off-by: Abdullah Sevincer > --- > drivers/event/dlb2/pf/dlb2_main.c | 27 +++++++++++++++++++++++++++ > 1 file changed, 27 insertions(+) >=20 > diff --git a/drivers/event/dlb2/pf/dlb2_main.c > b/drivers/event/dlb2/pf/dlb2_main.c > index 717aa4fc08..63868e2388 100644 > --- a/drivers/event/dlb2/pf/dlb2_main.c > +++ b/drivers/event/dlb2/pf/dlb2_main.c > @@ -46,6 +46,7 @@ > #define DLB2_PCI_CAP_ID_MSIX 0x11 > #define DLB2_PCI_EXT_CAP_ID_PRI 0x13 > #define DLB2_PCI_EXT_CAP_ID_ACS 0xD > +#define DLB2_PCI_EXT_CAP_ID_PASID 0x1B /* Process Address Space ID */ >=20 > #define DLB2_PCI_PRI_CTRL_ENABLE 0x1 > #define DLB2_PCI_PRI_ALLOC_REQ 0xC > @@ -64,6 +65,8 @@ > #define DLB2_PCI_ACS_CR 0x8 > #define DLB2_PCI_ACS_UF 0x10 > #define DLB2_PCI_ACS_EC 0x20 > +#define DLB2_PCI_PASID_CTRL 0x06 /* PASID control regist= er */ > +#define DLB2_PCI_PASID_CAP_OFFSET 0x148 /* PASID capability off= set */ >=20 > static int dlb2_pci_find_capability(struct rte_pci_device *pdev, uint32_= t id) > { @@ -257,12 +260,14 @@ dlb2_pf_reset(struct dlb2_dev *dlb2_dev) > uint16_t rt_ctl_word; > uint32_t pri_reqs_dword; > uint16_t pri_ctrl_word; > + uint16_t pasid_ctrl; >=20 > int pcie_cap_offset; > int pri_cap_offset; > int msix_cap_offset; > int err_cap_offset; > int acs_cap_offset; > + int pasid_cap_offset; > int wait_count; >=20 > uint16_t devsta_busy_word; > @@ -582,6 +587,28 @@ dlb2_pf_reset(struct dlb2_dev *dlb2_dev) > } > } >=20 > + /* The current Linux kernel vfio driver does not expose PASID capabilit= y > to > + * users. It also enables PASID by default, which breaks DLB PF PMD. We > have > + * to use the hardcoded offset for now to disable PASID. > + */ > + pasid_cap_offset =3D DLB2_PCI_PASID_CAP_OFFSET; > + > + off =3D pasid_cap_offset + DLB2_PCI_PASID_CTRL; > + if (rte_pci_read_config(pdev, &pasid_ctrl, 2, off) !=3D 2) > + pasid_ctrl =3D 0; > + > + if (pasid_ctrl) { > + DLB2_INFO(dlb2_dev, "DLB2 disabling pasid...\n"); > + > + pasid_ctrl =3D 0; > + ret =3D rte_pci_write_config(pdev, &pasid_ctrl, 2, off); > + if (ret !=3D 2) { > + DLB2_LOG_ERR("[%s()] failed to write the pcie config > space at offset %d\n", > + __func__, (int)off); > + return ret; > + } > + } > + > return 0; > } >=20 > -- > 2.39.1.windows.1 Applied to 22.11 branch, thanks for backporting!