From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 83F6743F05 for ; Wed, 1 May 2024 03:51:03 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5A6EC402A8; Wed, 1 May 2024 03:51:03 +0200 (CEST) Received: from NAM02-BN1-obe.outbound.protection.outlook.com (mail-bn1nam02on2071.outbound.protection.outlook.com [40.107.212.71]) by mails.dpdk.org (Postfix) with ESMTP id 6700C402A7 for ; Wed, 1 May 2024 03:51:02 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BDNL6V44YZfAlsoqiFkGGGKfybV4kX8ZENmJmbbGXxIlaWo1F9AZ8q/FeN9VUBDg6n+Z2OxV71BoipisLdFuv3AiC40HEzdFjHFXjIIc1bLF0AK9+DrnzSheVVsh55/l6V4z6kr3c6KlXDrflOjIowR3BfRPWflMqsgtWTUG7mb1r3Unh06jMacQ9Wk+V8KvbZN6BxblPnIkaU1w9Y/ICD4IfZxbthZresOnJugVXADyKYdhSlmCg2zd8hSs397GlOHoFDRJAlB9qfH0mCWtjpji2PlMEeoRpjD48aPGxykn0/QclndWfU/LuOROlNzA8Fy+v7jkQ6GgRCEyJ0zKWQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+Q+VN9gA8wZHnI+XYhRooYQfHoDd4gQYClJuulOTZRo=; b=gNvpy8Itnyqr1zaxzV41e9q4Zv5MW5T8dkHwC1JpIKP0u/731AMGpyEOf9VgmV6Z4uOenH+8AvitkvfiOtwJdHQeVw5Hqnq8sbgo9Q9Ed36hXsHQsUahPX2C1L5wVyy77o/cEmbvlHdYLoO//K3FqTlJ5bSyi9P7FTcbms7x/L/f2BXrRum2wqjOiYcHzGnl3g5HTM3IT2xe/m3ccB2AFM8niOSBXS4mmR5cfOkFxQcrNTkdmIhQDkrcniv5609WIXIm+gOi6zI8Ps3LRMDu4IV9KKgQ3KPvRs0a98Y2V2mqH+KDdw5JqAPcQzzDCDNOg5p9P5ETpgu3PT3tIVLmOw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+Q+VN9gA8wZHnI+XYhRooYQfHoDd4gQYClJuulOTZRo=; b=PUMv6qg4POZ1cgjickmps7N4YQygSOayaCSgLuXzQLo9Kenum0ASExfc6IWwP93wxPoipI2XSIOjVRNyrM2KBZHZ0B76hq7sqxpMCxqKgeS//nZ9IiWyiUlnR6LPFMiKy+g+7lCfkM8LnseSiTTF1AoKTRdJebG2tdxPKGrOMdtu3cg3S0yMFPWy2RkJ8JRFbGyKp3zUyUkObMyeNWgA9Z3zOEFxP+UOoUt1rbCo4BDlhBh5D22/yboJArX7v8f8+3f7KTTGJhysAQEvP58fjfSNbC8ptNn45LpnVxmn9ZZrO+RSkIh9cBovAQpV7ePtrYZBpq7IdmdWHac6zZJyNQ== Received: from DM4PR12MB5373.namprd12.prod.outlook.com (2603:10b6:5:39d::14) by MW6PR12MB8959.namprd12.prod.outlook.com (2603:10b6:303:23c::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7519.35; Wed, 1 May 2024 01:50:57 +0000 Received: from DM4PR12MB5373.namprd12.prod.outlook.com ([fe80::630f:22c9:1d04:12d8]) by DM4PR12MB5373.namprd12.prod.outlook.com ([fe80::630f:22c9:1d04:12d8%4]) with mapi id 15.20.7519.031; Wed, 1 May 2024 01:50:57 +0000 From: Xueming Li To: Chaoyong He , "stable@dpdk.org" CC: "oss-drivers@corigine.com" , Long Wu , Peng Zhang Subject: Re: [PATCH 23.11] net/nfp: fix port ID meta data use in Rx Thread-Topic: [PATCH 23.11] net/nfp: fix port ID meta data use in Rx Thread-Index: AQHajt5MD4GWD1ql20+xETtQfPsgMLGBrSeNgAAIm/s= Date: Wed, 1 May 2024 01:50:57 +0000 Message-ID: References: <20240415024008.1000358-1-chaoyong.he@corigine.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM4PR12MB5373:EE_|MW6PR12MB8959:EE_ x-ms-office365-filtering-correlation-id: 0b7af00b-282a-4d1f-6009-08dc69812515 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230031|1800799015|376005|366007|38070700009; x-microsoft-antispam-message-info: =?us-ascii?Q?14ZCrF+Z/VjjtZYsHzPqaOjGwPgJA7UZAe6d7aofQZRnVrKl2hpuzB+u/f/W?= =?us-ascii?Q?FXh5HXQVAaFiTUNXYEyVZwQqsZDhgtS3BNmzZbbGR8/F0/s8nx41FMRw+xjI?= =?us-ascii?Q?5GgVLgmbzRTcSjEJE5+KMSK3PLoYBGSNacNQi4Fmek8OBORBx2UrBA7cY2RO?= =?us-ascii?Q?suYZngdzH+LPuibzT7CIhynxwc9yi0EnEcB+44JFnKJn5ryNZHBi64MuEwQN?= =?us-ascii?Q?j4PokiCN4JnNoNPLmfrcKgB4aa7zXbsVUJzflUcFctembGwOzHJbtXXSH6QZ?= =?us-ascii?Q?CDXXrQNAs0/nyqsJ/ijaDXDzMJNYkNyRs4/0m0hWt/yv/XyCfQsXh6i1HxQJ?= =?us-ascii?Q?7N312QAmCb8B1og2SPk+ucbR0nCGvl0A/ljbTJhdQQqPYlcRKJeiT96inJrs?= =?us-ascii?Q?RmjPk+MZ1mkHmm3Ek8KRJ2gmrI0+JltgfreOKa79S3Ac7qa2aQ2eriGa2tgl?= =?us-ascii?Q?8o1ru3JsIOhMV87hn3vePTyFA6yRolZmQqB8nuNH6eNuf0LKOwUHijp1ZnH2?= =?us-ascii?Q?gNWuIkilnxBMVcAyg+mFBAaJ7DvxriahFJiwVvhC9XUHkUYnyl8YX7+wR4Sl?= =?us-ascii?Q?pfvpC8fEfc48Yak5bXpQFEY7+X47tqQTzhlyNJRoavVs9FB8r6YKU+9j0pjh?= =?us-ascii?Q?ip98pQSQeMa9eVRc/wuLbUcNjeIaIj0DLrf+IqdeRgy+Jh4FFiiRF/h1+oEw?= =?us-ascii?Q?HIlTA73ZHG2E6XbUrka+9bk39EbjxAZDoswcoq06NJvTxabdPdPlNbYAz9oP?= =?us-ascii?Q?+wGwj7OwKW5r1vZ0CDFgmc7G0je8EVCsOIpfr1avss45/OT3+JSAg9yyNaIP?= =?us-ascii?Q?5g6BujNJMhyAzUGw06v6O6HTpqg/54yqqTCP6Hdr+DQ/gMH8JWPA6qMulTkh?= =?us-ascii?Q?APZud4bn2kOC4m4YFH9sPFzYV4+o9jNRl/1VpDlITlQGrKmo7gf3EH+odFXg?= =?us-ascii?Q?N3dxNGZVwuZx8EfiSONLUUfzvvSXHwP0odSVP6qGj6ouTv0n2MfAt7s6yCuV?= =?us-ascii?Q?CHJRBovU0xxXpL+zYhRID1AfJhGzML6ZEzxOx78NWDRwytTuiP0NDQm7Q/Sd?= =?us-ascii?Q?CUj8SGnkSqRlidpHtZMla2DwPCaw3zDQ/N6xjzlVmLgS7i8of7H0vCE9BDA6?= =?us-ascii?Q?lHGSQCmW6WVBYx8g8UbuIdULgWtv/KCBsyXGyDEhv9ug++GaDh9d1P+4TMMs?= =?us-ascii?Q?frGIOi4wUfRX4iBBmerQGZv+VKR/KskzItf+0CPFze8DTUoCAz7S+JpPSRq4?= =?us-ascii?Q?SG1vypK0q3hc8c2EsG1uo8Tz7AH2uPNsOr9gRSbKYoXjpx3taWBKlkFQlRsz?= =?us-ascii?Q?F02Za/BVFVnqzsFfJ9MglWL3VjBl4NDsU8j6RM93RgyHYg=3D=3D?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR12MB5373.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(1800799015)(376005)(366007)(38070700009); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ex7+2hdhtkFAX6mHxdaPF5llNOLOJDRtqHh1qjSn7nSP9e7+mKImV+ith/+I?= =?us-ascii?Q?tQcE97CtgPjGbyplJ1NKy4AUMN/X+vSJXLP5lqSnXxRrJjSzJIqf3Xl/LpO/?= =?us-ascii?Q?IqpMUXB6YRLC3FRv3+oVFUUpIIuHNkK1JT0kDSZ7JHq2r2ebzOKyrxk5Xrd9?= =?us-ascii?Q?aIHxv+dcPHR+ohWsFTVD+hAspDFZyaYeHJ1dAKHweEtWEN5UwzRiX0RbqNwq?= =?us-ascii?Q?HRsBDbn4yanUiTMMUCKqPWUasVSKdOuJs9dW7nidpHZ+ly/+CmTeW/SHygU4?= =?us-ascii?Q?7SqPRkxUY+tYuCqbflZ8vzyqcFxvzGLQTuShgrgE4eQn15AWBygbSXQx5BTW?= =?us-ascii?Q?HLCa6TuyLxlSnY3K00GemLL6NG4fXks/9J/xxNSnASBAWWiomYNA/SA3Rslv?= =?us-ascii?Q?biXSc9e83Rf9XvBW7WkJXNYiH/7+upTGXISh0V7l0fNxK1F8TSHp1yqPc9Me?= =?us-ascii?Q?tPQfB+ZsXa9FQY6QNLelyavgKS9oJwn/YMZilflqkKkjiPNQngoy/zL/JIx2?= =?us-ascii?Q?41v90R40N3j/C7JvAJu4otUWx+WYwA16/+4Brbf9BB9knnhJhaqtRFMNr2/w?= =?us-ascii?Q?nzIEYHmqp5kAyXJgJ/c0du4Ffnt1lh7ss8HunCIPr/c/g5kT6+fXQE5GyEEU?= =?us-ascii?Q?2gF/OQ++goLQVbuFBPsHRC54qdJL0h3N79wglyLV5YlY0gaVCKE7R48tNe1q?= =?us-ascii?Q?KS6DXUkZZ/mjbl0xgif+QiwH7yzh6Ou1/bgSdUiAjkfxYO5x7qAv1Ycqp+T9?= =?us-ascii?Q?SPVhXhR96oipH4R43MEgW/aoir4h1fNYZbpkQwBojQeMNbzc7Cc4eRC1fAI1?= =?us-ascii?Q?v7wPbipW668KNxH2//bz3mhITLcxOPLMB9s+KlZDbdybV37yuHy8wfTeVHKU?= =?us-ascii?Q?R73oksNcn7TxrEfFejg+UIEOZCr5IzTs8BJI9f5U48lQO5v3fcqeb8vo5n7k?= =?us-ascii?Q?nTMk/qG+f/mhqNH+OcyUjipwML0gqmc+gidQPm0gdA6aJtVRUwEprpRkOsp0?= =?us-ascii?Q?+qYMi0ThbA8UAhXO4sBnAIXIYk8VFAvh/7zBF9esm5CbTZY/myFMScbHJ4Yk?= =?us-ascii?Q?foXlUmYtS709Q+h78M0UDxG0qMVIbpoHuv9DtzlZJaJN4NUMS4J6qMQ+/Ah7?= =?us-ascii?Q?yS/RzvMB7j1DSNjZab/O/LKvBFjgf58kXI+pq9jaKFb6TB4Ms5GBYPk5F1a1?= =?us-ascii?Q?eliBUPNPcZNndxVt331s3qWQZb9SVPoXqjRGpLQImlGkbUfIMbBgC5xekjQ7?= =?us-ascii?Q?aZtySEP+vzPRChRyPxkniIBYKvPrqYlYtJYOPrFQxKfRXORXFVadydU/k992?= =?us-ascii?Q?EqJjJtyLTIfs1D4jbKhlWewWLbjgi2N416/C2nsOnh5MXUOZi7h5IrZiwKsa?= =?us-ascii?Q?gS77i7Vn7T1tXhJPkj6vUoDfAq5zs5Ca5YGAxZy0UaSNXHREv4Fx/FSVNEqS?= =?us-ascii?Q?8zD8Ty+Bq1SeHUsFnQhqM4PkhK518ME19Tfn3mnozGhSlaFkz5Srfkpy0vcy?= =?us-ascii?Q?rMMJmvbZ+R2ZY9tfxeGj7puYMB8oUBUSq0k+hIV/Xbu6FiQEtT8zj9Cr4hhl?= =?us-ascii?Q?cF4roemT51BAmDH3MxksA6NhEmdeDs9DvEcf98vw?= Content-Type: multipart/alternative; boundary="_000_DM4PR12MB5373FB7EA5F558A2B89D221CA1192DM4PR12MB5373namp_" MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5373.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0b7af00b-282a-4d1f-6009-08dc69812515 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 May 2024 01:50:57.3548 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: CPN8RzfWIWaC7fD7A/Emuv8IfaiNhrmxIu1yp6xXWTk2VzFDm1PzW+3qZ45E2UrIV0Zh1CcOfEG0ytTxVjA3AQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW6PR12MB8959 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org --_000_DM4PR12MB5373FB7EA5F558A2B89D221CA1192DM4PR12MB5373namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable I got following compilation error: ../../auto/swgwork/xuemingl/workspace/dpdk/drivers/net/nfp/nfp_rxtx.c:763= :14: error: no member named 'flags' in 'struct nfp_meta_parsed' Could you please address ASAP? make sure it tested. Thanks, ________________________________ From: Xueming Li Sent: Wednesday, May 1, 2024 9:19 AM To: Chaoyong He ; stable@dpdk.org Cc: oss-drivers@corigine.com ; Long Wu ; Peng Zhang Subject: Re: [PATCH 23.11] net/nfp: fix port ID meta data use in Rx Hi Chaoyong, Thanks for your help, patch added into release queue. ________________________________ From: Chaoyong He Sent: Monday, April 15, 2024 10:40 AM To: stable@dpdk.org Cc: oss-drivers@corigine.com ; Long Wu ; Chaoyong He ; Peng Zhang Subject: [PATCH 23.11] net/nfp: fix port ID meta data use in Rx From: Long Wu [ upstream commit ddc84b53f38281ff2c15f7feb7e3a0b556dd92b2 ] Meta data parsing should be controlled by meta data flag. So use flag to determine if receive function can use 'port_id' meta data. Fixes: 580ea0b09a7c ("net/nfp: fix Rx descriptor") Signed-off-by: Long Wu Reviewed-by: Chaoyong He Reviewed-by: Peng Zhang --- drivers/net/nfp/nfp_rxtx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/nfp/nfp_rxtx.c b/drivers/net/nfp/nfp_rxtx.c index 8ca651ba55..5033d659d3 100644 --- a/drivers/net/nfp/nfp_rxtx.c +++ b/drivers/net/nfp/nfp_rxtx.c @@ -760,7 +760,7 @@ nfp_net_recv_pkts(void *rx_queue, if (unlikely(rxq->rd_p =3D=3D rxq->rx_count)) /* Wrapping = */ rxq->rd_p =3D 0; - if (meta.port_id =3D=3D 0) { + if (((meta.flags >> NFP_NET_META_PORTID) & 0x1) =3D=3D 0) { rx_pkts[avail++] =3D mb; } else if (nfp_flower_pf_dispatch_pkts(hw, mb, meta.port_i= d)) { avail_multiplexed++; -- 2.27.0 --_000_DM4PR12MB5373FB7EA5F558A2B89D221CA1192DM4PR12MB5373namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable
I got following compilation error:

  ../../auto/swgwork/xuemingl/workspace/dpdk/drivers/net/nfp/nfp_rxtx.= c:763:14: error: no member named 'flags' in 'struct nfp_meta_parsed'

Could you please address ASAP? make sure it tested.

Thanks,
From: Xueming Li <xuemin= gl@nvidia.com>
Sent: Wednesday, May 1, 2024 9:19 AM
To: Chaoyong He <chaoyong.he@corigine.com>; stable@dpdk.org &l= t;stable@dpdk.org>
Cc: oss-drivers@corigine.com <oss-drivers@corigine.com>; Long = Wu <long.wu@corigine.com>; Peng Zhang <peng.zhang@corigine.com>=
Subject: Re: [PATCH 23.11] net/nfp: fix port ID meta data use in Rx<= /font>
 
Hi Chaoyong,

Thanks for your help, patch added into release queue.
From: Chaoyong He <cha= oyong.he@corigine.com>
Sent: Monday, April 15, 2024 10:40 AM
To: stable@dpdk.org <stable@dpdk.org>
Cc: oss-drivers@corigine.com <oss-drivers@corigine.com>; Long = Wu <long.wu@corigine.com>; Chaoyong He <chaoyong.he@corigine.com&g= t;; Peng Zhang <peng.zhang@corigine.com>
Subject: [PATCH 23.11] net/nfp: fix port ID meta data use in Rx
 
From: Long Wu <long.wu@corigine.com>

[ upstream commit ddc84b53f38281ff2c15f7feb7e3a0b556dd92b2 ]

Meta data parsing should be controlled by meta data flag. So use
flag to determine if receive function can use 'port_id' meta data.

Fixes: 580ea0b09a7c ("net/nfp: fix Rx descriptor")

Signed-off-by: Long Wu <long.wu@corigine.com>
Reviewed-by: Chaoyong He <chaoyong.he@corigine.com>
Reviewed-by: Peng Zhang <peng.zhang@corigine.com>
---
 drivers/net/nfp/nfp_rxtx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/nfp/nfp_rxtx.c b/drivers/net/nfp/nfp_rxtx.c
index 8ca651ba55..5033d659d3 100644
--- a/drivers/net/nfp/nfp_rxtx.c
+++ b/drivers/net/nfp/nfp_rxtx.c
@@ -760,7 +760,7 @@ nfp_net_recv_pkts(void *rx_queue,
            &nb= sp;    if (unlikely(rxq->rd_p =3D=3D rxq->rx_count)) /= * Wrapping */
            &nb= sp;            rxq-&= gt;rd_p =3D 0;
 
-            &n= bsp;  if (meta.port_id =3D=3D 0) {
+            &n= bsp;  if (((meta.flags >> NFP_NET_META_PORTID) & 0x1) =3D=3D= 0) {
            &nb= sp;            rx_pk= ts[avail++] =3D mb;
            &nb= sp;    } else if (nfp_flower_pf_dispatch_pkts(hw, mb, meta.p= ort_id)) {
            &nb= sp;            avail= _multiplexed++;
--
2.27.0

--_000_DM4PR12MB5373FB7EA5F558A2B89D221CA1192DM4PR12MB5373namp_--