From: Tal Shnaiderman <talshn@nvidia.com>
To: Pallavi Kadam <pallavi.kadam@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "stable@dpdk.org" <stable@dpdk.org>,
NBU-Contact-Thomas Monjalon <thomas@monjalon.net>,
"ranjit.menon@intel.com" <ranjit.menon@intel.com>,
"dmitry.kozliuk@gmail.com" <dmitry.kozliuk@gmail.com>,
"Narcisa.Vasile@microsoft.com" <Narcisa.Vasile@microsoft.com>,
"Vipin.Varghese@intel.com" <Vipin.Varghese@intel.com>
Subject: Re: [dpdk-stable] [PATCH] bus/pci: fix numa node return value
Date: Thu, 23 Sep 2021 15:44:19 +0000 [thread overview]
Message-ID: <DM4PR12MB538975F4DAC043C1DE72F9DCA4A39@DM4PR12MB5389.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20210922211906.2135-1-pallavi.kadam@intel.com>
> Subject: [PATCH] bus/pci: fix numa node return value
>
> External email: Use caution opening links or attachments
>
>
> On older CPUs, currently numa_node returns value only for socket 0.
> Instead, application should be able to make correct decision and also to keep
> consistent with the Linux code, replace the return value to -1.
>
> Fixes: ac7c98d04f2c ("bus/pci: ignore missing NUMA node on Windows")
> Cc: talshn@nvidia.com
> Cc: stable@dpdk.org
>
> Reported-by: Vipin Varghese <Vipin.Varghese@intel.com>
> Signed-off-by: Pallavi Kadam <pallavi.kadam@intel.com>
> ---
> drivers/bus/pci/windows/pci.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/bus/pci/windows/pci.c b/drivers/bus/pci/windows/pci.c
> index d39a7748b8..343ef6f33b 100644
> --- a/drivers/bus/pci/windows/pci.c
> +++ b/drivers/bus/pci/windows/pci.c
> @@ -5,6 +5,7 @@
> #include <rte_errno.h>
> #include <rte_log.h>
> #include <rte_eal.h>
> +#include <rte_memory.h>
>
> #include "private.h"
> #include "pci_netuio.h"
> @@ -243,7 +244,7 @@ get_device_resource_info(HDEVINFO dev_info,
> DWORD error = GetLastError();
> if (error == ERROR_NOT_FOUND) {
> /* On older CPUs, NUMA is not bound to PCIe locality. */
> - dev->device.numa_node = 0;
> + dev->device.numa_node = SOCKET_ID_ANY;
> return ERROR_SUCCESS;
> }
> RTE_LOG_WIN32_ERR("SetupDiGetDevicePropertyW"
> --
> 2.31.1.windows.1
You should add "on Windows" to the end of the patch name to clarity it's a Windows issue.
Aside from that LGTM.
Acked-by: Tal Shnaiderman <talshn@nvidia.com>
next prev parent reply other threads:[~2021-09-23 15:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-22 21:19 Pallavi Kadam
2021-09-23 15:44 ` Tal Shnaiderman [this message]
2021-09-23 17:09 ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon
2021-09-24 9:13 ` [dpdk-stable] " Varghese, Vipin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM4PR12MB538975F4DAC043C1DE72F9DCA4A39@DM4PR12MB5389.namprd12.prod.outlook.com \
--to=talshn@nvidia.com \
--cc=Narcisa.Vasile@microsoft.com \
--cc=Vipin.Varghese@intel.com \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=pallavi.kadam@intel.com \
--cc=ranjit.menon@intel.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).