From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id ACDFFA04A3 for ; Tue, 16 Jun 2020 11:49:44 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2DFFC1BF4E; Tue, 16 Jun 2020 11:49:44 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id 9F23F1BE99; Tue, 16 Jun 2020 11:49:41 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 05G9jX2D010224; Tue, 16 Jun 2020 02:49:41 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=GjaHNKb5S8saNaUuofAJUiEt/Ncq5Ih45p9Ov6Khn/A=; b=iFMIf8IsLSEeNgPiip1auTZNC+yj01RBLEXcRlVaKDi96tC10kWLc0h0AY1gWdjh9lwf 5qB2g/W3n7I/VcpwtuEaGQnTBMlbPOajfqCPoxgeOvAiZmd4XBbWtUImOe+tj3k0pYGd HhnN9novLYtg7KAIYYucIg36tDYQyiXxMvuepwQ4GVt4jsByLFe115PhuPiMPerYWBr7 4v0whCVTKCn+qx2mn9v0cgW2QTVvoaXceawPIH47kXqXPObI09hs7daBuUNhMjkDVKXZ 2GZhyaMx4qYJAy7lovondgh5VTDGM45oyb5ZsjjwnZX7iZj5TI4wPUAA0gw/74N6YzGI GA== Received: from sc-exch01.marvell.com ([199.233.58.181]) by mx0b-0016f401.pphosted.com with ESMTP id 31mxant08x-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Tue, 16 Jun 2020 02:49:40 -0700 Received: from SC-EXCH02.marvell.com (10.93.176.82) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 16 Jun 2020 02:49:39 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.173) by SC-EXCH02.marvell.com (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Tue, 16 Jun 2020 02:49:39 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Usy8YmHmCX0IDZdJ7Ptiv9YtzOvPE/Kv6NyWKkGwizAIaLkjkRWFDaLBhPSgZyGiDXiwflbzg+ya2z+y8QkCKiI2a5KTpmkv9QP//F99ZijoPnY8T8ZNjsbD+NF8FMT3msnSplV7AO0ULcI59zGsLVNd7O0Id7vsIusyO/0bbwq4YIjSLKI+20hfTwt3CunVkD97Hls+t7FclHYOdUNt8osGKYuwtjd+AX+1EpYJypT4Uur+sGYvz+HMEBTE8/iZG/8liumfwIYDISeIzYMjLh0jbYXLxim10brdN+3nOjpHJ9rUdcBZikXCBHhpNRpDjb0MlKrDVKQRYxMYXVaP3w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GjaHNKb5S8saNaUuofAJUiEt/Ncq5Ih45p9Ov6Khn/A=; b=Hn937P60DK+l7ueoRoZTJ49vs/Lg/MY5kxXqvsWMPWoigtd+BLdKkDWScxF7LzZLeZs7caVZ/JSL6yXOHzEdTSWN6J/NMsW4tPY5YOTqTS8i5HOdhfvNeucAV4MdGEWEbLDNEqPPKf4xxKLnl00EDw5vSYMeu14yfVSS7VBthjHxiZSpzuFdLamiJKLDDKAYHfMMoHvIzjdj03BOx+AtXsQNZ84+vQMIppqLGXw/6lHol/OW31kyUIR2m8ayUeOGBsP8gsd1OUr9vRT2LwdT7616QwYb9SJtIJLGEGoQp6/MKF6JqB+DKnI6YTbl38E+AVdmD8BY0Jk88VticJFI1w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GjaHNKb5S8saNaUuofAJUiEt/Ncq5Ih45p9Ov6Khn/A=; b=cxC1TTKc4wA/vHCEj6CT75Qw3bbgdmc8phEGvkyxAf5X4ttvKkDHVyYsVQNv6CFtQp138rEMnixQcuxgQXBm15gPDYUcDZxQEJFBo0LXhMd+MGYmH10fK0qAHdS9iTBbuEogkfpgXWDDJBtNUfXUWebyw6enww2aPAFja/ViD7c= Received: from DM5PR18MB2214.namprd18.prod.outlook.com (2603:10b6:4:b9::21) by DM6PR18MB2874.namprd18.prod.outlook.com (2603:10b6:5:168::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3088.26; Tue, 16 Jun 2020 09:49:38 +0000 Received: from DM5PR18MB2214.namprd18.prod.outlook.com ([fe80::a18a:2341:a36c:2c41]) by DM5PR18MB2214.namprd18.prod.outlook.com ([fe80::a18a:2341:a36c:2c41%3]) with mapi id 15.20.3088.029; Tue, 16 Jun 2020 09:49:38 +0000 From: Liron Himi To: David Marchand , "dev@dpdk.org" CC: "stable@dpdk.org" , Liron Himi Thread-Topic: [EXT] [PATCH] net/mvpp2: fix non-EAL thread support Thread-Index: AQHWQ8Mf8eXeknmK20idNcRL86M/kqja/xEg Date: Tue, 16 Jun 2020 09:49:38 +0000 Message-ID: References: <20200616094700.31749-1-david.marchand@redhat.com> In-Reply-To: <20200616094700.31749-1-david.marchand@redhat.com> Accept-Language: he-IL, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: redhat.com; dkim=none (message not signed) header.d=none;redhat.com; dmarc=none action=none header.from=marvell.com; x-originating-ip: [46.117.128.244] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 075eeb09-9ac7-4e41-5709-08d811da959d x-ms-traffictypediagnostic: DM6PR18MB2874: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3968; x-forefront-prvs: 04362AC73B x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: O2Yd5/+AYxtu6JM/OyMMz8sClek3NxtrZr6chujnAx4ajMoNWzBs84O5Vq+gcLFupRQfXXv9siR3IzzaWzZLHKdJGMQfJqylOcgW0UPunsS93YYaXwwFWsEJesbLZ9DpDPEcHF0GiJqr/tyCml6CL8aES7IP3P2i8x2a5cxnCNSalU1PKBOicU/Do7Mum9sjReMNqUkkEZUpLva6KhonWLkavSjPtDcSexMfhkFzf13/Ikqk2zY5yJo5EmSZ81cSCbWLnWR8os+RSbWng+kPp6sAcaiNonk8l2n3CM8yF3Wdhq9/IcLshuAkl0C0q1ICojzAbPTUn3Re9CVoCwACBA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM5PR18MB2214.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(396003)(376002)(366004)(346002)(39850400004)(136003)(6506007)(66476007)(26005)(53546011)(110136005)(8676002)(66946007)(2906002)(316002)(54906003)(7696005)(8936002)(76116006)(4326008)(71200400001)(66446008)(64756008)(86362001)(33656002)(66556008)(5660300002)(478600001)(55016002)(83380400001)(107886003)(52536014)(186003)(9686003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: zw4p2Fge9XET8K21xpnFABlOabp/ry/cul7jqkpWEkADDX0XxA1Xtl29ivwBTycXCqwgOl6yttBMNJDsEL9LC0FN8/OtcD7vx2dd8TbBjSwsD/t+CzzJAQiCmV59uknv9jFDKKFhluJrfw53T2MjEXMxcrC3IADBzUvfiW+Gwn2vWW8MvxCAt0S9wQ2futDPzZU0vVl/LEFNx5cI9oMGCh7LiY15Xwe6PutoEFWv/QR5Dbelisnh/l9TgbDycVH/iYYw46ojvXM5WU4T1qXKkJ5Nx6TSpjr4PUl9A1uaAOcpcgivqEFhJ5X5CZrh6fmjvMJSMB4luxQSJR8WKPeVrUNFFYaDxNPlhcx5f2F+EALn7NQ9jQheG9alM68sTQ8YocBMfpEYGplDC2srlGHgVpPjSk7ZOId1RShxmWXsUVIhj0FNxhASkeAirEK3QT39VTINnogqfk4ZmY36gESFim7NVb2tIxmEiKaTRG/XbY/fbFfjxtSe7xCmPC1gZvCl Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 075eeb09-9ac7-4e41-5709-08d811da959d X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Jun 2020 09:49:38.2854 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: H5y4LaldGkwkMKdcKiJF4oSMZqRaT41L7A064aSL+gaDjOm3w6NIKQM9nATSkmuZ7LfffsxU0hjg1DukL7Zm/w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR18MB2874 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.216, 18.0.687 definitions=2020-06-16_03:2020-06-15, 2020-06-16 signatures=0 Subject: Re: [dpdk-stable] [EXT] [PATCH] net/mvpp2: fix non-EAL thread support X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Acked-by: Liron Himi -----Original Message----- From: David Marchand =20 Sent: Tuesday, 16 June 2020 12:47 To: dev@dpdk.org Cc: stable@dpdk.org; Liron Himi ; Natalie Samsonov Subject: [EXT] [PATCH] net/mvpp2: fix non-EAL thread support External Email ---------------------------------------------------------------------- Caught by code inspection, for a non-EAL thread identified with rte_lcore_id() =3D=3D LCORE_ID_ANY, the code currently arbitrarily uses lco= re 0 while there is no guarantee this lcore is used. Fixes: 3588aaa68eab ("net/mrvl: fix HIF objects allocation") Cc: stable@dpdk.org Signed-off-by: David Marchand --- drivers/net/mvpp2/mrvl_ethdev.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/mvpp2/mrvl_ethdev.c b/drivers/net/mvpp2/mrvl_ethde= v.c index b98b1fd667..9037274327 100644 --- a/drivers/net/mvpp2/mrvl_ethdev.c +++ b/drivers/net/mvpp2/mrvl_ethdev.c @@ -816,7 +816,7 @@ mrvl_flush_bpool(struct rte_eth_dev *dev) unsigned int core_id =3D rte_lcore_id(); =20 if (core_id =3D=3D LCORE_ID_ANY) - core_id =3D 0; + core_id =3D rte_get_master_lcore(); =20 hif =3D mrvl_get_hif(priv, core_id); =20 @@ -1620,7 +1620,7 @@ mrvl_fill_bpool(struct mrvl_rxq *rxq, int num) =20 core_id =3D rte_lcore_id(); if (core_id =3D=3D LCORE_ID_ANY) - core_id =3D 0; + core_id =3D rte_get_master_lcore(); =20 hif =3D mrvl_get_hif(rxq->priv, core_id); if (!hif) @@ -1770,7 +1770,7 @@ mrvl_rx_queue_release(void *rxq) unsigned int core_id =3D rte_lcore_id(); =20 if (core_id =3D=3D LCORE_ID_ANY) - core_id =3D 0; + core_id =3D rte_get_master_lcore(); =20 if (!q) return; -- 2.23.0