From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C0D40A09F0 for ; Tue, 15 Dec 2020 23:29:13 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 901E6CA74; Tue, 15 Dec 2020 23:29:12 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id E0A79CA5D; Tue, 15 Dec 2020 23:29:07 +0100 (CET) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 0BFMQdiA015352; Tue, 15 Dec 2020 14:29:06 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0220; bh=kntoCroROWLiVB+qVBHbXQA3YmoOdys139xpjGes5Lk=; b=AdB+yPrZT8rp+NM+c9pmblkRUpDqgoopHNDVEFKYL2cCtDXWr3kCgVG+lhN+bFA/he9f F307d2KwYJIgH/Tm9HWmKeTaopg4bZxcuraL66INVfZtkAjwRVVVSJqfOxm4cQtO9wPD Vulz0DsY0ePjmIX8Nc2nw3YQm8LowiLfugaPNE920U3bxdvLsHwhZviLuagB5pU6t6U+ /8U3mvoOJy2TtTLj13gaRJbr55TkHx6mK+mMYbEL9W9YwSFqm/o2axbDK1N5dzSnWBKv 2EGiRyIehTx8mhx30UqjlPWZBts1+kC5zJ4Nh8fbBW953S9URwatg2MmiMGA84xr1afe TA== Received: from sc-exch01.marvell.com ([199.233.58.181]) by mx0b-0016f401.pphosted.com with ESMTP id 35cx8t9jyv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Tue, 15 Dec 2020 14:29:06 -0800 Received: from DC5-EXCH02.marvell.com (10.69.176.39) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 15 Dec 2020 14:29:04 -0800 Received: from SC-EXCH03.marvell.com (10.93.176.83) by DC5-EXCH02.marvell.com (10.69.176.39) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 15 Dec 2020 14:29:04 -0800 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.102) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Tue, 15 Dec 2020 14:29:03 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nU7H0hoDSmiOKiMBVoxrWcM8Baf2Mo1momWlrk2mTaC/2l/FoSlzHQdYPoZ3gaYJSpDbOt9QmuyFpQEnbW1f0AwXwGIxONueZkhx4KCB+2L7+Rl9Yo3fEqASIveoaEW+StMvbOFgp2ngkdhVUcN8d+iI9UyI755fbWcLx89+o7z29aXYnPOLb8D0lY3wNIMXF5wrXuGQYKa6nzdLpcZM00o9paT/HMaeeZwhlWwKdr26ipwG2Chi98QBUdC3mGyKbq2XCRK4TqK5tIaR2v11wpsabmBmrG8yJqM9Hco/3171JUxCsXcNCVJiF+5Pxuv1kVHm6jN8OsfHEs3F6lzd+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kntoCroROWLiVB+qVBHbXQA3YmoOdys139xpjGes5Lk=; b=VPFnpH7KZqK9mEe5dsV4BOg//dNWU8YU6bvKVO5NmSOi0WHCSNG6/oeW47pHyntDA/ejJx1nQ4AN/5h4Gh4BIRdI8s7Y0CWnkm5P4+PYM5AkfQjg8izpZJZl85jMPoSTEAXvHDTuueQPyTOfXo6suNmhJKlklBcipVLe9Imt2c1AbOjo3Yolw38fIa1bkQM1HgG51NIXSiOep4+heoykD9xBIGvN86M/eypr/h6Vkv0A4N1lt0mwU4cNZvgGnmDkoL3bhUiAzxCi+9lTQJyd9b94ea1i9ZdDX/hrxjbDDWFibSMGejnSa+SmbrWqsxJkfBabqCDXMpZ5E74vYar/Ng== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kntoCroROWLiVB+qVBHbXQA3YmoOdys139xpjGes5Lk=; b=k0pNDIqmogEH0qu7DkIVmWvUDxa0erB7RD8xXqDDkQqg+nYgiG3TxeEflYA8u1Dv0549jvIM1+VCKZl3vWURNmM+JaDtngGLS371F0nAX/vyayuotRT5yyoLygEdq+PxtRSOCzyVmc3WP4ItWScrFzU/KvGsMqqDEdQXJQgFspU= Received: from DM5PR18MB2214.namprd18.prod.outlook.com (2603:10b6:4:b9::21) by DM6PR18MB3635.namprd18.prod.outlook.com (2603:10b6:5:2a2::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3654.18; Tue, 15 Dec 2020 22:29:02 +0000 Received: from DM5PR18MB2214.namprd18.prod.outlook.com ([fe80::5d76:dae3:afeb:1da8]) by DM5PR18MB2214.namprd18.prod.outlook.com ([fe80::5d76:dae3:afeb:1da8%4]) with mapi id 15.20.3654.025; Tue, 15 Dec 2020 22:29:02 +0000 From: Liron Himi To: wangyunjian , "dev@dpdk.org" CC: "zr@semihalf.com" , "Lilijun (Jerry)" , xudingke , "stable@dpdk.org" , Liron Himi Thread-Topic: [EXT] [dpdk-dev] [PATCH] net/mvneta: check allocation in rx queue flush Thread-Index: AQHWzI1bLlnpUuP9zE2NdUUNXPnamqnrkYyQgAAJQYCADS73AA== Date: Tue, 15 Dec 2020 22:29:02 +0000 Message-ID: References: <1607341035-9372-1-git-send-email-wangyunjian@huawei.com> <34EFBCA9F01B0748BEB6B629CE643AE60DB5CC89@DGGEMM533-MBX.china.huawei.com> In-Reply-To: <34EFBCA9F01B0748BEB6B629CE643AE60DB5CC89@DGGEMM533-MBX.china.huawei.com> Accept-Language: he-IL, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: huawei.com; dkim=none (message not signed) header.d=none;huawei.com; dmarc=none action=none header.from=marvell.com; x-originating-ip: [89.139.10.58] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 447c8153-134c-49c7-6bb4-08d8a148d345 x-ms-traffictypediagnostic: DM6PR18MB3635: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6790; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: dH4Njz5Ng5IyrzCnDgTsUOjoY/TpJfnBEm7v2hWWRdB0GkfyL+8glD6Pi42OalLrkgEUQADxpJWhSUgIZg0EYMQnZ3/gboN5OnnV2yOv0TYTApRy7ziohqNfPi60G0V+ex8yD1qQhZaYw1zN07bLegaijZeoxq1Ag6vDhiDEPWOnd1wUunJgwTpkgCeR+q+ULiKLA+bEgVzd+nzzbcMFSi4c014C+pZWKy0eCpWTCW2jMBVX9bAES4MFIXKV4GoxasBBOOWp4ks8QKL8XXYRi64jguE9Oj48A5Rqs2qH8KPzzYEPMJNhXm0mYVOX3pAV6ZRN3sEAFsy4GVbVO3aKMQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM5PR18MB2214.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(136003)(39860400002)(346002)(396003)(366004)(7696005)(71200400001)(76116006)(66946007)(9686003)(52536014)(66476007)(86362001)(316002)(8676002)(4326008)(26005)(66446008)(5660300002)(55016002)(54906003)(66556008)(186003)(8936002)(53546011)(6506007)(2906002)(33656002)(110136005)(64756008)(107886003)(83380400001)(478600001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?KEhx85eJp2WiWqrNrFsf5v5OlRyxOcL3TV+pHfFuE5WiP+/n0v24egK0M718?= =?us-ascii?Q?e0ey9Ol2vhCOHwk7mV/e6CyfXfCMIP3ox+h/Q3l5KNbZGuiCMwUr8g7G/MkW?= =?us-ascii?Q?+4FLnlNQlmtqH3Lk9J9S9dsxJMECsAD08HePRdHQQu9PkP7NS3+2yWAOxSTX?= =?us-ascii?Q?4VaAsBvLhk00bDCzj6AcclQtkqi5/8AtADw8UTNSqrImM5yf+XQVoOzuByPp?= =?us-ascii?Q?LSMI5+evViUKzyOdT6ehLPRuzeJ2xlVsJDBZBVu8j3VdFj3GVpWswJgH9u7Q?= =?us-ascii?Q?lrAIsnrNs0nJRIZnWq9kzKthSn8GvW1vLitA6Cwk3tBU+8Z0rrT58oz/TfAV?= =?us-ascii?Q?hYMGPJEfiukc1cIQCjgoplSXm7eXMv8sO2UHdFReIwVnC2IpGnnUoEft3Hr5?= =?us-ascii?Q?NDkIrwaw2ij8t3vnEeh1ue6XWlmJc/ggXv4MJM+4sFhRZNffJXrH0zWqyDtq?= =?us-ascii?Q?UL/lv1ph7eJnbQxQ7wBte7Qu6oZ9eoOjC6bI2GceIs0UzfA6H+kWBUa/JeuE?= =?us-ascii?Q?m0BZke5KY0MCF6HRfZxNPh8hCGhjhmT6/FJEVnRxp2cZF039n6e6H9SDsCsm?= =?us-ascii?Q?HQt8ahJvUDjuBUWRHPoXergi5tuF1y/Nrz7xauyrWXI8P5H3pRkAyFjak1EV?= =?us-ascii?Q?JUdkLJNu2cyyIGf30n0x1X7hGvk7maug6eU1wdeP/M2kDdNcK6hHVwFBaM0b?= =?us-ascii?Q?AiRSvHTbET/6yXyIVZ3+pRTn40vNPtb5NEXx8FjBd8a2TrUFOcm8fvJoyU8q?= =?us-ascii?Q?lLIPAg+mTpgFgW2GX82Th6rv7CnoIzkuWwX58/l7IiAu6sWleHwCr3MHtHs5?= =?us-ascii?Q?MN/DEiAyKXvIAY3l6ON2fckJzJgOrKYJ4pEC3USmKKqpVboQgNipdlHqxRot?= =?us-ascii?Q?4Itbz7X6pceFjIbkp9fGBhbsAhB7u0heYS7+F0k4wE3E8fDpAvufk/Ox/ZcG?= =?us-ascii?Q?FR7pmwEp4jTM0tPe8Vw2qsZjsZRPjoMG3YAPFkxNfkk=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM5PR18MB2214.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 447c8153-134c-49c7-6bb4-08d8a148d345 X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Dec 2020 22:29:02.6205 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: hnc7422uC7POsY+rv1aF4GiEk8PSvhJI5zE5DZcvcglopA5AXH4r7jk9KrxVtsG6M74EwtgjUvDx5b+6uJO4qA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR18MB3635 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.343, 18.0.737 definitions=2020-12-15_12:2020-12-15, 2020-12-15 signatures=0 Subject: Re: [dpdk-stable] [EXT] [dpdk-dev] [PATCH] net/mvneta: check allocation in rx queue flush X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" -----Original Message----- From: wangyunjian =20 Sent: Monday, 7 December 2020 15:08 To: Liron Himi ; dev@dpdk.org Cc: zr@semihalf.com; Lilijun (Jerry) ; xudingke <= xudingke@huawei.com>; stable@dpdk.org Subject: RE: [EXT] [dpdk-dev] [PATCH] net/mvneta: check allocation in rx qu= eue flush > -----Original Message----- > From: Liron Himi [mailto:lironh@marvell.com] > Sent: Monday, December 7, 2020 8:38 PM > To: wangyunjian ; dev@dpdk.org > Cc: zr@semihalf.com; Lilijun (Jerry) ;=20 > xudingke ; stable@dpdk.org; Liron Himi=20 > > Subject: RE: [EXT] [dpdk-dev] [PATCH] net/mvneta: check allocation in=20 > rx queue flush >=20 > Hi, >=20 > How about use 2 local arrays for descs & bufs instead of the malloc/free? The definition of these 2 arrays is 2048. If it is a local array, is it too= large? [L.H.] I'm not sure. Lets stay with your original patch.=20 Acked-by: Liron Himi >=20 > Liron >=20 >=20 > -----Original Message----- > From: wangyunjian > Sent: Monday, 7 December 2020 13:37 > To: dev@dpdk.org > Cc: Liron Himi ; zr@semihalf.com;=20 > jerry.lilijun@huawei.com; xudingke@huawei.com; Yunjian Wang=20 > ; stable@dpdk.org > Subject: [EXT] [dpdk-dev] [PATCH] net/mvneta: check allocation in rx=20 > queue flush >=20 > External Email >=20 > ---------------------------------------------------------------------- > From: Yunjian Wang >=20 > The function rte_malloc() could return NULL, the return value need to=20 > be checked. >=20 > Fixes: ce7ea764597e ("net/mvneta: support Rx/Tx") > Cc: stable@dpdk.org >=20 > Signed-off-by: Yunjian Wang > --- > drivers/net/mvneta/mvneta_rxtx.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) >=20 > diff --git a/drivers/net/mvneta/mvneta_rxtx.c > b/drivers/net/mvneta/mvneta_rxtx.c > index 10b6f57584..dfa7ecc090 100644 > --- a/drivers/net/mvneta/mvneta_rxtx.c > +++ b/drivers/net/mvneta/mvneta_rxtx.c > @@ -872,7 +872,17 @@ mvneta_rx_queue_flush(struct mvneta_rxq *rxq) > int ret, i; >=20 > descs =3D rte_malloc("rxdesc", MRVL_NETA_RXD_MAX * sizeof(*descs), 0); > + if (descs =3D=3D NULL) { > + MVNETA_LOG(ERR, "Failed to allocate descs."); > + return; > + } > + > bufs =3D rte_malloc("buffs", MRVL_NETA_RXD_MAX * sizeof(*bufs), 0); > + if (bufs =3D=3D NULL) { > + MVNETA_LOG(ERR, "Failed to allocate bufs."); > + rte_free(descs); > + return; > + } >=20 > do { > num =3D MRVL_NETA_RXD_MAX; > -- > 2.23.0