From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D8024A0A06 for ; Tue, 19 Jan 2021 13:23:49 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C66D4140E2F; Tue, 19 Jan 2021 13:23:49 +0100 (CET) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id A8FDD140E1E; Tue, 19 Jan 2021 13:23:45 +0100 (CET) IronPort-SDR: GhZiOQZy5UkpO40/qJzfuuxRe/A2TOSEk70EfhAxl6lUQ8cMhW7D1xVqZ3GISLd4g90zLl52I3 mVYnMfVbe7Vw== X-IronPort-AV: E=McAfee;i="6000,8403,9868"; a="158096875" X-IronPort-AV: E=Sophos;i="5.79,358,1602572400"; d="scan'208";a="158096875" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jan 2021 04:23:44 -0800 IronPort-SDR: w2+ZarrLBCazA3XNcGgcyL53yXXNPFLMXxETu16PS3ibQT7JqGYkTGKC9HriqPetYyrJcwDgec dxL3UH2nGGww== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.79,358,1602572400"; d="scan'208";a="573535118" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmsmga005.fm.intel.com with ESMTP; 19 Jan 2021 04:23:44 -0800 Received: from orsmsx609.amr.corp.intel.com (10.22.229.22) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 19 Jan 2021 04:23:44 -0800 Received: from orsmsx609.amr.corp.intel.com (10.22.229.22) by ORSMSX609.amr.corp.intel.com (10.22.229.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 19 Jan 2021 04:23:43 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx609.amr.corp.intel.com (10.22.229.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Tue, 19 Jan 2021 04:23:43 -0800 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.169) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Tue, 19 Jan 2021 04:23:43 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nAqYUwvkwlcn40dJUhf2dc7cil/PEy+mx7oKtW+RY9hvWgMcgUwCfNJurJqnz7zXGohrR79Hz6EwO6sA2VvivbxM9w4u79x5HZwpXbzl2S8obc/JsqsIJmyawdWshE8o7ihOLuEWhMEb4VhP+Hie8huhuu0YDdbOsP7c7k2P+ffaNSJFtvhFiMxuomlVskOBn+Ya4t3C3b5ClxOpBj9pIzqXYDOAbJCglBsqDcHBZFXU08+Rf4A83kWTk3/Rw1XnG0zlWRjgeXH4B/mGvuBGEtY3fRBC+/Cd+u15X151nft8pRvgbXLckmHtB44iVuogr8uav663jo7axXOWb7Czfg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=huKEQ76W1hw2xpwvfugPEjtkI9QBLtTTrqK6VZ0po68=; b=UuOnBmqwpNZ3vDqm9RitZFbEWBbFJcKqPGri3OroJ4jeCq1DQqIBaBS9Yl6tGqmk7AECoecVLvuNSTdtt1rEdRylDBg25eRalpIFU3GEBy4QGi1QAYJcZxQjXdOCN024WmpcWFqAJ+2BG+wRumMJrUVa8HrSWz1BiDU2ZOIJrEIyZBxeUdB/IZmbO9/tNAOftpGlX05TZkecST83aK06gyCHfETkVcNZJ5sgs3UCgbZ+JIrMKmidIx/dt2uZ8IKqzRuAbbzMt8CwcT4vez4k2B6z6Ch13YSEI/jcpg6v3Bwjape7kNp7T/c+Yah1t5oWYn1ap5+uJbTP5MKtJIsIgQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=huKEQ76W1hw2xpwvfugPEjtkI9QBLtTTrqK6VZ0po68=; b=Bvve1aHbFaibzCmv54TNxNzd1004G2o+99s4WMwO7WKMqqdpoNkA/nTz9tpPqnzjmJhiKAFrBqJ4YfG+3GAO5KLyyzIROh6Baac6+3G/T1yhuP15Q0Qqmqe+cBC7C+6OJ0Q9onRHmHAy1OT1DxwcZUYUycvJuDZblncyOHYGijw= Received: from DM6PR11MB2890.namprd11.prod.outlook.com (2603:10b6:5:63::20) by DM6PR11MB4377.namprd11.prod.outlook.com (2603:10b6:5:1dc::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3763.11; Tue, 19 Jan 2021 12:23:41 +0000 Received: from DM6PR11MB2890.namprd11.prod.outlook.com ([fe80::ecb4:82ca:ca9c:a38b]) by DM6PR11MB2890.namprd11.prod.outlook.com ([fe80::ecb4:82ca:ca9c:a38b%5]) with mapi id 15.20.3763.014; Tue, 19 Jan 2021 12:23:41 +0000 From: "Iremonger, Bernard" To: "Iremonger, Bernard" , "Li, Xiaoyun" , "dev@dpdk.org" CC: "stable@dpdk.org" Thread-Topic: [dpdk-stable] [PATCH] doc: fix testpmd sample qinq flow rules Thread-Index: AQHW6mc0F8NsVIuquUSSW4cg6+9RKaooBXsAgAaug4CAAC6a0A== Date: Tue, 19 Jan 2021 12:23:40 +0000 Message-ID: References: <1610623187-3631-1-git-send-email-bernard.iremonger@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [86.45.108.187] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 47b9a964-1848-4545-a998-08d8bc750e53 x-ms-traffictypediagnostic: DM6PR11MB4377: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2803; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 3CpzzvdzWDmrb9m0neQeq15Qklrkfaa0cEtJwpCQGXcCm58Dl/9KrQimsCPdc6POe/M1RehB3vQqTwkiVYcdEDSjnAdekL4aKgg+5nL314pi/4jjgkSu+bT/501SZnOw80RhY9AjFHh9dlbx7Ax7Law/Ieyiwb+HusBziRDd5SCLQ61rFD4JaIq88JQ4cVFO8bPEq4Ls9CPeTIrfXMH74zxyTfXUYCDaNzuAUK0wjEOOi18iGgWk5GaLr/us1HOo2UljDNAO1zEHmNK9US9XACWvQ1vJIE7Emt2U1q26cQdak9wXF6zfCERfRzJac2Tde61cgf/gXimkql3zd0eJlK+vRqXVM0ls5DoSOwty95J4XZ55VMKalPohO4R9BGI6x/UlyMKf6uvdWBz6le7mVA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB2890.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(346002)(366004)(39860400002)(376002)(136003)(396003)(6506007)(4326008)(450100002)(5660300002)(33656002)(9686003)(186003)(26005)(66556008)(478600001)(53546011)(8936002)(66476007)(110136005)(66446008)(66946007)(2906002)(8676002)(84040400001)(52536014)(64756008)(316002)(76116006)(2940100002)(83380400001)(86362001)(71200400001)(7696005)(55016002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?1rsbhhPpc9WBi932Fy8/Qt53EutBKYUwuR371mei98qhw5TAvvdUJKi4RLxu?= =?us-ascii?Q?MQYBnDuKtZVmn9/S/QpSzbaXD0vf+2/2apkdIlYWn8Ox9FW2PAZ6tBgn6iNW?= =?us-ascii?Q?dY63ncPV6HX7qQPdsoTlMfQY8vdPuEPm8OVPBRJGJsyY1Auy9wwzY4t5XOxX?= =?us-ascii?Q?M4OnY/3N37fnfd+RIirTBBM3vbTuxsPJ9qxD+9NKlWSQcYfqNfBL8AfkA8EM?= =?us-ascii?Q?nABqFp1n0bo5vTXTYZw3pGCP/Q4pMPE0f9y2FayKEd6MWQA6yFSTiksilDx7?= =?us-ascii?Q?ZBwFBhgHsYrrtAurUeSdoYeESst+mVQJ/mDUD0OztGv6deds446G9MKkgzuP?= =?us-ascii?Q?QSRumEuRPeONnU9fy7hErADTPvlQ5Gmwr8fI6vi6FNz9qZYZOLl/GiYEl9Sh?= =?us-ascii?Q?Set9Du4gh08RumY6qyDAkRoLgi9TwHLSu6Ys2DCBWh5NpBv7Zb4N145Qv4zE?= =?us-ascii?Q?kI51WUCEq6NzurlgZul75KLUg1YEMA/U1GQ3el3Vb6Pp6OdUCdAk7QcCE1fH?= =?us-ascii?Q?48OjCqnuBnFyNbNrgTRxV7L7uy1Aa9FRqnglgkVaeFvVpIj/3jFCOaKuXyjN?= =?us-ascii?Q?lRDNXCuHPN4dRe7HeBZYV7m1A7EnyEO6cUBRZ3XIQEFp1ZvQtlZuFzcH/Nzg?= =?us-ascii?Q?Br94mNLrNOnNnsRQKWiG8Slond367+X5xL8v5q6LwQV/XU2EApkR+lJ6TX4k?= =?us-ascii?Q?UGe60cXFxTSHisdWB+g2kfigN1ZsIDb/nyS2dHolXbnqcOOukSoEScgOi7x6?= =?us-ascii?Q?PmzoJJKZnatX6ZQPGHLtVhCjdODd8eJhKRK0+Sd6ghZEmtNerLk8IVccOBMG?= =?us-ascii?Q?OB8hpxIyySkOD73i/jqTJQ8sJzOEn4PBhkM1uL38lcX1gQIRXjhpWzTRy0xd?= =?us-ascii?Q?oY3R4UKTLgOriFCb5TzJ0mkL2R1k0UVHb4rOK4wGdZoSO2VFSMdlCXur/6CJ?= =?us-ascii?Q?KT4XYAnbkZpPLqtvsUAYmdenEJHpQfbTlU00WjToEDw=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB2890.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 47b9a964-1848-4545-a998-08d8bc750e53 X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Jan 2021 12:23:40.9655 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: k/vsGvQ1BDFT9dG3DLvFdUGA8D94PjBrZ0aKB1yMIPcc9X5P1wCaxzgSm703OiXOa+AClgXSnwymYSdEoCHHHAApbpDfEocwXVIjoUcb3NY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4377 X-OriginatorOrg: intel.com Subject: Re: [dpdk-stable] [PATCH] doc: fix testpmd sample qinq flow rules X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi Xiaoyun, > -----Original Message----- > From: dev On Behalf Of Iremonger, Bernard > Sent: Tuesday, January 19, 2021 9:23 AM > To: Li, Xiaoyun ; dev@dpdk.org > Cc: stable@dpdk.org > Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] doc: fix testpmd sample qin= q > flow rules >=20 > Hi Xiaoyun, >=20 > > -----Original Message----- > > From: Li, Xiaoyun > > Sent: Friday, January 15, 2021 3:19 AM > > To: Iremonger, Bernard ; dev@dpdk.org > > Cc: Iremonger, Bernard ; > stable@dpdk.org > > Subject: RE: [dpdk-stable] [PATCH] doc: fix testpmd sample qinq flow > > rules > > > > Hi > > There are two other mistakes in this section "Sample QinQ flow rules". > > Can you help to correct those too? > > 1. testpmd> vlan set qinq_strip on 0 > > Creating QinQ rule(s) command line should be "vlan set extend on 0". You are correct.=20 > > Qinq_strip is not relevant to qinq flow rules. You are correct. > > 2. The sentence "The above command sets the inner and outer TPID's to > > 0x8100." This sentence is correct. Please see lines 4068 to 4076 in i40e_ethdev.c wh= ere both inner and outer TPID's are set to RTE_ETHER_TYPE_VLAN (0x8100). > > Should be "The following command sets the inner TPID to 0x8100 and > > sets the outer TPID to 0x88A8". > > > > Best Regards > > Xiaoyun Li > > > > > -----Original Message----- > > > From: stable On Behalf Of Bernard > > > Iremonger > > > Sent: Thursday, January 14, 2021 19:20 > > > To: dev@dpdk.org > > > Cc: Iremonger, Bernard ; > > stable@dpdk.org > > > Subject: [dpdk-stable] [PATCH] doc: fix testpmd sample qinq flow > > > rules > > > > > > In the Testpmd Flow rules management section, correct the TPID > > > values in the Sample QinQ flow rules sub section. > > > > > > Fixes: bef3bfe7d5f4 ("doc: revise sample testpmd flow commands") > > > Cc: stable@dpdk.org > > > > > > Signed-off-by: Bernard Iremonger > > > --- > > > doc/guides/testpmd_app_ug/testpmd_funcs.rst | 4 ++-- > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > diff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst > > > b/doc/guides/testpmd_app_ug/testpmd_funcs.rst > > > index 9be4500..e0020d6 100644 > > > --- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst > > > +++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst > > > @@ -4432,8 +4432,8 @@ The above command sets the inner and outer > > > TPID's to 0x8100. > > > > > > To change the TPID's the following commands should be used:: > > > > > > - testpmd> vlan set outer tpid 0xa100 0 > > > - testpmd> vlan set inner tpid 0x9100 0 > > > + testpmd> vlan set outer tpid 0x88A8 0 > > > + testpmd> vlan set inner tpid 0x8100 0 > > > testpmd> port start 0 > > > > > > Validate and create a QinQ rule on port 0 to steer traffic to a VF > > > queue in a > > VM. > > > -- > > > 2.7.4 >=20 > I will correct the other mistakes too. >=20 > Regards, >=20 > Bernard. My replies are inline above. Regards, Bernard.