From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0E98BA0093 for ; Wed, 16 Mar 2022 09:11:47 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F160441143; Wed, 16 Mar 2022 09:11:46 +0100 (CET) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id C925C40395; Wed, 16 Mar 2022 09:11:44 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1647418305; x=1678954305; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=3rCBxwe4OO1LA0w9tqIgUKlWe8sXgK93zzwMj4ZeJ40=; b=Ue82TZ7e2jemyGyDXNxAPH6tLXL1u7YaA4oiN15E7gYZN3oz7oxeITQg M/YrhywBHStbjHBLwC0SlDLsCXj8A6BwLMYedBkmvT3W70d+tyYk7mkz5 7TDEbyCtb+qN0b1BfwRx1NByTvLMtXUNp763q4KWyqkhHHcyGpV4bh2c5 iSd3sHCvy49GiZNqp5PWYqH+D/BzE+o+QCP60FRd3uTcNp1jEwZSHfylo Z5I4lZIuhMnUj8YJ3vST9iD67cTK6mmxqua8eR4nsiNKDo0Wa4RrBJUEA yWbzF+Voz7yEgE60oAreC62GI3/WcHKl0uiB/g3v3R6roBG5KU0SNt78j Q==; X-IronPort-AV: E=McAfee;i="6200,9189,10286"; a="237128473" X-IronPort-AV: E=Sophos;i="5.90,186,1643702400"; d="scan'208";a="237128473" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Mar 2022 01:11:43 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,186,1643702400"; d="scan'208";a="644568450" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by fmsmga002.fm.intel.com with ESMTP; 16 Mar 2022 01:11:43 -0700 Received: from orsmsx609.amr.corp.intel.com (10.22.229.22) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Wed, 16 Mar 2022 01:11:43 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX609.amr.corp.intel.com (10.22.229.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Wed, 16 Mar 2022 01:11:42 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21 via Frontend Transport; Wed, 16 Mar 2022 01:11:42 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.107) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.21; Wed, 16 Mar 2022 01:11:42 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=azFGTOl+5W8sMLWiapJN+NZk20K1r+epzPOIE3QnGMyzsYlfIqWOOsLD5tA5nBJWPsgNbdf9kg3PqDB4Y3EFmydQnHS8WL5bhM1K2yEZsD4F7heJr1jY/W55TNgc05Gsd0x9U/YHSe7LkIAjnvGWw0Onpn093JKnnLiupbFtEOVDnV4ckOjwy4oKIJZ65wVZh52Nm5FuQcuCPSWSlad8yYza7qhwes0bMH6OEBeMII3cS/Pchi6srMlhdvMKoPBVvUJWS58SoN+P+JYaVZQUesu+tMcLtAkhpmwPb9TxBVsgzksVfC6yRgfe2uqz9jA1so6SUnI7XcfSY+47wfrp7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GqTtGNPbEHzR38gZ2Enb0F3aK/dshzgyyyPWTQYqndE=; b=iuhL4Sf3aCCmhEmrFPfAISWmDurvAlz4gPVcwKLZawgbXTGPAAzt1ovVvRKGjRjMBO5wUJ/S7ouYh4+0JEurv+gCBriDoGHPkO9Rx8mxi6yTKJ8uhJa/r2pzStyQslirgLcfx7A7kVfqe4nQXKMqlE8L6d4Lq6Z/zpoHieNXGdbx399Uopm3/DuB6YvVh8cFUR7wajchzmpuyYAmH2PsRaOc26Ale0prvuNMe9tqngT5643w2qllqU/+otBcfqu5yr8kQK6Ojrh9CAbGYHqT23P/Wqz5VP78Eh0S62wcPtV3r4nyCyLJ2jlG/WvkQXc62kqp63pDbGXMAgWFNE4s9g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM6PR11MB3098.namprd11.prod.outlook.com (2603:10b6:5:70::11) by DM5PR11MB1995.namprd11.prod.outlook.com (2603:10b6:3:10::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5081.14; Wed, 16 Mar 2022 08:11:34 +0000 Received: from DM6PR11MB3098.namprd11.prod.outlook.com ([fe80::a95a:68ad:463f:de1c]) by DM6PR11MB3098.namprd11.prod.outlook.com ([fe80::a95a:68ad:463f:de1c%3]) with mapi id 15.20.5061.028; Wed, 16 Mar 2022 08:11:33 +0000 From: "Xing, Beilei" To: "Yang, SteveX" , "dev@dpdk.org" CC: "Wu, Jingjing" , "Zhang, Qi Z" , "stable@dpdk.org" Subject: RE: [PATCH v1] net/iavf: fix select wrong scan hw ring by rxdid Thread-Topic: [PATCH v1] net/iavf: fix select wrong scan hw ring by rxdid Thread-Index: AQHYN4dh/P14HO0ci0WmBUIB70ObTqzBq8dQ Date: Wed, 16 Mar 2022 08:11:33 +0000 Message-ID: References: <20220314093146.697256-1-stevex.yang@intel.com> In-Reply-To: <20220314093146.697256-1-stevex.yang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.401.20 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 980e16ac-c988-41d9-6236-08da072495c7 x-ms-traffictypediagnostic: DM5PR11MB1995:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: tusMn0/zyJMoTAq/DD625Ltrf//j0pWN1ODsNrh2y+Wx8uKHvIvtkRmbH6qmNlG8psx5ql3jKdfhIlpalk0qDuUiAdv8Vn7cmw/j3fKjAzF0FCp4xx8DM2MhNt7v86WbyIn09Z8IMm410DqpgnkBJ26sS0wkArHkRxizxcXJEojOQyFtszJ3wXZ1Lm5B0mJBODO81K+NeHKLfa4o7XQYxoVOCGN6sDUstp6QMXZoBjrtk3qdz+Ye+V/q0u8cvh+oaeQ8oPh1/z8CbN2e+8iaEHRlOv4FZ9koUnI10+FuUqDt9vQxe19I5/iEc+yNuG8RXP1h1uzJhRN5sVqVg6z1PC4xlEflOYnhyGg2jmyM5vfMInevD8eO+WQ1BdjdJh/66sETV1BRgZUAM8y4re3C52C7IONVsHKxQhih9XjxXdEsssZ4Jda6i0yJGN+dgqQKD+zVJjdy/0mCjv2AjaH5lEqDIwXSwT3KFdfi7hg62fuoWPhu6UedTpYv0NAKdrr6CQJHdbgixapeCmhDO38oBs+Bz9MdVk5PWpA3B8iSWApIf5VQoje0KO5SxE+6+fPkhZhSJr3yvhgrdcDr4g5tDzwsaiu/H2fiiDbGvMrsfceTWVFcd11aA01QbpKYfV59Dtp3Ntr1F4enQpOeFFrglsfDLmTxkrs0jPhpgTH6N5IF/LrEO+lRxmfhgKUb3NX0kq0df+Yz5Bi2fOJrKU4fJw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB3098.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(5660300002)(2906002)(83380400001)(54906003)(110136005)(86362001)(8936002)(52536014)(316002)(6506007)(38070700005)(122000001)(82960400001)(7696005)(53546011)(186003)(450100002)(38100700002)(508600001)(9686003)(26005)(33656002)(64756008)(71200400001)(55016003)(66446008)(66946007)(66556008)(66476007)(4326008)(8676002)(76116006); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?0TGdh8HfTZtSLH7TBF3gytDf9y0B6BLSC39z79Nj7zJLfHNBk331gQPVqSx2?= =?us-ascii?Q?mHSdeF92A/zd88tsFvHnvx4SPPkM5LgCBXKCtS0ikGo4ddoK+z8AjOVcmXpG?= =?us-ascii?Q?QEAYjIjwUrqM01QkNwbxBJbgKYiG9XHHbNvPA/faWrbrTTk2nMg6FfoJA5Hy?= =?us-ascii?Q?M0ZjdA6MLb1D5kJwyvELSKFr+ZK2bzxcIFpMYLwTheZvJ38hiFosa1lJJ5Mr?= =?us-ascii?Q?5aExSsOlS9OSCMmQkELFJssM2RnZHYGlldH4tO11pdsGMiX2jdPOfLJwENft?= =?us-ascii?Q?mMqoLaUufVmRbNRxAFq+1qQOMOHaYzRV/G5sUry+U0KOTQM8MqiynXdWUIgy?= =?us-ascii?Q?NA3aXv/neEl8MI6uCMI5viL3ZEJlY4+XX+DdrOXm4G24yRqk25M2BF7/jjBj?= =?us-ascii?Q?szMvI6TmfB79oaTJyKeBNlN388usI9hlu/YML8avzfnLVmASPKkTtEpeULOJ?= =?us-ascii?Q?All5M/KpOrAWobDKF9VuJPGyxu7XBMsWSa7uHJn5h1M9IneIjOIp9FZI4Vhv?= =?us-ascii?Q?sN81Z5JNHGnlUsQ4dc8Cq3U+uNQcHeeSHqrEgCAWF54/gUWpO3yqS8tg4Dgc?= =?us-ascii?Q?91+wwDRRggWPTyF3wVRnZBlwgDJjGGMCL7eBnvqxiXGaN2+DeBb/RQUx+Rdn?= =?us-ascii?Q?E0pb1nx7g5v6YQPu99QXFJrPXkPVh7VAo9PWn1lY1qaqkGI53Dk3u8uAx6+0?= =?us-ascii?Q?U8qFMXjeHN0ZhEMCXgI9FVV+jlcAZEfA/IjOmqtsh15xRdbHOjyxn46rZEAh?= =?us-ascii?Q?mX0CYXe60IGi+3aL++DZqIJPytGi7TwP2buKNGPpQazpPonICgYDCQW39hKA?= =?us-ascii?Q?/Dx3nJizDL+/kAhhzJirxXhVC/Rw6bRQxT3LXL9Omw8Bv3Pd4X8clcQGlZ7v?= =?us-ascii?Q?XirnhzpHklUuC1P6hwiMT6lSnkO5Q8bLlBzKekMuZftIoVjqoEcjjT6mC/eZ?= =?us-ascii?Q?/cnbDhIN4kzwWfOFo7vf7dgEmVqnMzciDFhRsfD2EoddLrUgkGtNbUTx64Mv?= =?us-ascii?Q?5bFRzIgmpJqOyM012ttdewO3AZf9WqwKU9eo08Muu/CciLe2xLJnZobasEVA?= =?us-ascii?Q?rdCEsmZjcsLoV5yUk2LJpyu6uePT1JMTQQ/m/bl6CF/hig1IeL9x6bVoKmCK?= =?us-ascii?Q?gW3yTwskQUcdQ482ihq5V5EFCPkVBHSM0GRN1d93g4SqSskdQ8RVPygk58e0?= =?us-ascii?Q?4/rekYpad/Mwaj0Od35ZxcJCrAXCMzY2VEXenJDdMV+8/GS+xGSL8hkMMVZ0?= =?us-ascii?Q?yabDgLADKfrytb3N4sp6o4ZuOLB30gw5RdfS7qQnxxMn48KEqjcaG5oFMyA4?= =?us-ascii?Q?Kd8twfcLyHdsQpppS+OIOPyeMxx5aPiTKIThpfSui5YQQPOxlvLUBwV5LJj7?= =?us-ascii?Q?hH+rIIyM02Uz4V6CXSZAaJaTbegItEhHQ+rOgoPqKnvx9zG6l+nix8yUNCxm?= =?us-ascii?Q?ctw6ZJjWc2q7SaDLUrBLzXZyLkJfmmyR?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3098.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 980e16ac-c988-41d9-6236-08da072495c7 X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Mar 2022 08:11:33.8498 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 9EBrvV1c/yw2GyjnKq8fLxlcfcEOtc9VctCgiupyQ2MeOUrcmAQ/Mv6Z3OA3n1qVvK6EXT62o82oOEcvyol/kA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR11MB1995 X-OriginatorOrg: intel.com X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org > -----Original Message----- > From: Yang, SteveX > Sent: Monday, March 14, 2022 5:32 PM > To: dev@dpdk.org > Cc: Wu, Jingjing ; Xing, Beilei ; > Zhang, Qi Z ; Yang, SteveX ; > stable@dpdk.org > Subject: [PATCH v1] net/iavf: fix select wrong scan hw ring by rxdid >=20 > When setup RX queue, the rxdid would be changed if it's > "IAVF_RXDID_LEGACY_0/1", that caused the scan hw ring used the wrong > function 'iavf_rx_scan_hw_ring_flex_rxd()'. >=20 > Ignore the rxdid changed when equals "IAVF_RXDID_LEGACY_0/1". >=20 > Fixes: 0ed16e01313e ("net/iavf: fix function pointer in multi-process") > Cc: stable@dpdk.org >=20 > Signed-off-by: Steve Yang > --- > drivers/net/iavf/iavf_rxtx.c | 4 ++++ > 1 file changed, 4 insertions(+) >=20 > diff --git a/drivers/net/iavf/iavf_rxtx.c b/drivers/net/iavf/iavf_rxtx.c = index > 16e8d021f9..3b16609f7d 100644 > --- a/drivers/net/iavf/iavf_rxtx.c > +++ b/drivers/net/iavf/iavf_rxtx.c > @@ -477,6 +477,8 @@ iavf_rxd_to_pkt_fields_by_comms_aux_v2(struct > iavf_rx_queue *rxq, >=20 > static const > iavf_rxd_to_pkt_fields_t rxd_to_pkt_fields_ops[IAVF_RXDID_LAST + 1] =3D = { > + [IAVF_RXDID_LEGACY_0] =3D iavf_rxd_to_pkt_fields_by_comms_ovs, > + [IAVF_RXDID_LEGACY_1] =3D iavf_rxd_to_pkt_fields_by_comms_ovs, > [IAVF_RXDID_COMMS_AUX_VLAN] =3D > iavf_rxd_to_pkt_fields_by_comms_aux_v1, > [IAVF_RXDID_COMMS_AUX_IPV4] =3D > iavf_rxd_to_pkt_fields_by_comms_aux_v1, > [IAVF_RXDID_COMMS_AUX_IPV6] =3D > iavf_rxd_to_pkt_fields_by_comms_aux_v1, > @@ -521,6 +523,8 @@ iavf_select_rxd_to_pkt_fields_handler(struct > iavf_rx_queue *rxq, uint32_t rxdid) >=20 > rte_pmd_ifd_dynflag_proto_xtr_ipsec_crypto_said_mask; > break; > case IAVF_RXDID_COMMS_OVS_1: > + case IAVF_RXDID_LEGACY_0: > + case IAVF_RXDID_LEGACY_1: > break; > default: > /* update this according to the RXDID for FLEX_DESC_NONE > */ > -- > 2.27.0 Acked-by: Beilei Xing