patches for DPDK stable branches
 help / color / mirror / Atom feed
From: "Chen, BoX C" <box.c.chen@intel.com>
To: "Yigit, Ferruh" <ferruh.yigit@intel.com>,
	"Lu, Wenzhuo" <wenzhuo.lu@intel.com>,
	"Xing, Beilei" <beilei.xing@intel.com>,
	"Iremonger, Bernard" <bernard.iremonger@intel.com>,
	"Zhang, Qi Z" <qi.z.zhang@intel.com>,
	 Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Cc: "Yigit, Ferruh" <ferruh.yigit@intel.com>,
	"dev@dpdk.org" <dev@dpdk.org>,
	"stable@dpdk.org" <stable@dpdk.org>,
	"Chen, BoX C" <box.c.chen@intel.com>,
	"Yu, PingX" <pingx.yu@intel.com>
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] app/testpmd: revert setting MTU explicitly after	configure
Date: Fri, 20 Nov 2020 01:51:11 +0000
Message-ID: <DM6PR11MB30993FA93A88E501C18F9250D9FF0@DM6PR11MB3099.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20201116190355.3390447-1-ferruh.yigit@intel.com>

Tested-by: Chen, BoX C <BoX.C.Chen@intel.com>
Thanks.

Regards,
Chen Bo

> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Ferruh Yigit
> Sent: November 17, 2020 3:04
> To: Lu, Wenzhuo <wenzhuo.lu@intel.com>; Xing, Beilei
> <beilei.xing@intel.com>; Iremonger, Bernard
> <bernard.iremonger@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>;
> Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
> Cc: Yigit, Ferruh <ferruh.yigit@intel.com>; dev@dpdk.org; stable@dpdk.org
> Subject: [dpdk-dev] [PATCH] app/testpmd: revert setting MTU explicitly
> after configure
> 
> Setting MTU after each 'rte_eth_dev_configure()' prevents using "--max-
> pkt-len=N" parameter and "port config all max-pkt-len #" command
> 
> This is breaking DTS scatter test case which is using "--max-pkt-len=9000"
> testpmd parameter.
> 
> Reverting workaround to recover the DTS testcase.
> 
> Fixes: 1c21ee95cf52 ("app/testpmd: fix MTU after device configure")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> ---
>  app/test-pmd/testpmd.c | 19 -------------------
>  1 file changed, 19 deletions(-)
> 
> diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index
> 48e9647fc7..33fc0fddf5 100644
> --- a/app/test-pmd/testpmd.c
> +++ b/app/test-pmd/testpmd.c
> @@ -2537,8 +2537,6 @@ start_port(portid_t pid)
>  		}
> 
>  		if (port->need_reconfig > 0) {
> -			uint16_t mtu = RTE_ETHER_MTU;
> -
>  			port->need_reconfig = 0;
> 
>  			if (flow_isolate_all) {
> @@ -2572,23 +2570,6 @@ start_port(portid_t pid)
>  				port->need_reconfig = 1;
>  				return -1;
>  			}
> -
> -			/*
> -			 * Workaround for rte_eth_dev_configure(),
> max_rx_pkt_len
> -			 * set MTU wrong for the PMDs that have frame
> overhead
> -			 * bigger than RTE_ETHER_HDR_LEN +
> RTE_ETHER_CRC_LEN.
> -			 * For a PMD that has 26 bytes overhead,
> rte_eth_dev_configure()
> -			 * can set MTU to max 1492, not to expected 1500
> bytes.
> -			 * Using rte_eth_dev_set_mtu() to be able to set
> MTU correctly,
> -			 * default MTU value is 1500.
> -			 */
> -			diag = rte_eth_dev_get_mtu(pi, &mtu);
> -			if (diag)
> -				printf("Failed to get MTU for port %d\n", pi);
> -			diag = rte_eth_dev_set_mtu(pi, mtu);
> -			if (diag != 0 && diag != -ENOTSUP)
> -				printf("Failed to set MTU to %u for
> port %d\n",
> -						mtu, pi);
>  		}
>  		if (port->need_reconfig_queues > 0) {
>  			port->need_reconfig_queues = 0;
> --
> 2.26.2


  reply	other threads:[~2020-11-20  1:51 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-16 19:03 [dpdk-stable] " Ferruh Yigit
2020-11-20  1:51 ` Chen, BoX C [this message]
2020-11-20 12:07   ` [dpdk-stable] [dpdk-dev] " Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DM6PR11MB30993FA93A88E501C18F9250D9FF0@DM6PR11MB3099.namprd11.prod.outlook.com \
    --to=box.c.chen@intel.com \
    --cc=andrew.rybchenko@oktetlabs.ru \
    --cc=beilei.xing@intel.com \
    --cc=bernard.iremonger@intel.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=pingx.yu@intel.com \
    --cc=qi.z.zhang@intel.com \
    --cc=stable@dpdk.org \
    --cc=wenzhuo.lu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

patches for DPDK stable branches

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ http://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git