From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C1CA1A034F for ; Thu, 1 Apr 2021 09:48:39 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BB43314108D; Thu, 1 Apr 2021 09:48:39 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id DF1644013F; Thu, 1 Apr 2021 09:48:36 +0200 (CEST) IronPort-SDR: j/aOtdZkcBp3MO7aNWDqywaRYnT+DUbbJlg/jPgdAafkry/tk3nYyge4naIWWfnFkyQTwMby3I GDuDheMgmgjA== X-IronPort-AV: E=McAfee;i="6000,8403,9940"; a="171595121" X-IronPort-AV: E=Sophos;i="5.81,296,1610438400"; d="scan'208";a="171595121" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Apr 2021 00:48:33 -0700 IronPort-SDR: hPgV51hILiMYRmJ7ODwFoKWhzbNz3t5OKjthyHBwCG7uV3xYFIP/pA4MsPqUt+6UxIpdFt+2yr LU8UopY9jDpQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.81,296,1610438400"; d="scan'208";a="455865257" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orsmga001.jf.intel.com with ESMTP; 01 Apr 2021 00:48:33 -0700 Received: from fmsmsx604.amr.corp.intel.com (10.18.126.84) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Thu, 1 Apr 2021 00:48:32 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Thu, 1 Apr 2021 00:48:32 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.170) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2106.2; Thu, 1 Apr 2021 00:48:31 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CiCMJOAilCY0NV/cnVkWWw1rBS/X7vg066KUhQ32hRqbPgQ7T9d8EzADWE0Ino0okEPukigY45JG3H41D0n9Uup6Fbx3jSsZ0p8Bl9vxTP3hAGrho2IbFZ+kAMlk8jJRuKmD0VkrHwGAm5J0JZ5aQA826ymAgVzzH4LMGUfj49UQV3zo/uYxUIlzw064y0mWX0NL3Ahwsh+VKsdwTb8w6QNq78fcAIbNm6HS44iDC22FKxP3VBzztv3zA/2P8TdHF/SsjtEb6usnX1knlpXNDl+IvTcDkpbBgokeIjAyIfCaxUQo0Ky3H3HUlvOMQQIcg3fjm+4qUuHlhFfX+DXxfg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UeHYRe0tr3/sX5DIdCl7/rLX4mM2CamcIk0grFILwlI=; b=J3S18R8pL1gEvSyihVlwRO/4/ye3aW1+1JyxIUTWhOMhnPv4RTN92xOagdPldOFHYxp+IXDUv8SX64Pm5dpcKdbFrNjRIhK9V1wd1ydeI9WTuoxt7ljfthJE9KupxRAl/0vG3FmxARJGNBotZh8FCce+JxNnwPbtQFhW2hXAFiXULVWLkjXqpWD68kp1F7/HUGOvGKdFDF8ZQx3hSZopYcL+dN1+tBjAnHOW6W+KB7IbtDN9Pr792+FZQa6kTRTRwWnem1QKSPnQp7Oa7ugtvKUxdIoz8a1FAOS/YJByD/L4ySsa0UiS1kO5FhhrYZEfJ7k2BRHva61QGL9GTtKvLA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UeHYRe0tr3/sX5DIdCl7/rLX4mM2CamcIk0grFILwlI=; b=rnzlMatofIAO2I1sLo/mRHQtK+9Xq+/ULlzhb0hdg3Z6CWqYFhi7tuJpnOEdc1GVP4zP4EVHib5peDS1aSGhLtnzuQHSceeZyG8i3XBBI/hC8lc+/pdAXmT2Ljpd2xtzFLMgQle80HsqfQYNrjnvpHtNg+m4++pIc91zP/S2fwQ= Received: from DM6PR11MB3131.namprd11.prod.outlook.com (2603:10b6:5:6d::32) by DM6PR11MB3468.namprd11.prod.outlook.com (2603:10b6:5:5c::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3977.29; Thu, 1 Apr 2021 07:48:27 +0000 Received: from DM6PR11MB3131.namprd11.prod.outlook.com ([fe80::181b:59f1:8b7e:b9db]) by DM6PR11MB3131.namprd11.prod.outlook.com ([fe80::181b:59f1:8b7e:b9db%6]) with mapi id 15.20.3999.028; Thu, 1 Apr 2021 07:48:27 +0000 From: "Zhang, Tianfei" To: "Huang, Wei" , "dev@dpdk.org" , "Xu, Rosen" , "Zhang, Qi Z" CC: "stable@dpdk.org" Thread-Topic: [PATCH v1 1/2] raw/ifpga/base: use untained variable as argument Thread-Index: AQHXGwbcljF4z//aWkmB96cos1f9AaqfYLXQ Date: Thu, 1 Apr 2021 07:48:27 +0000 Message-ID: References: <1615969417-17118-1-git-send-email-wei.huang@intel.com> <1615969417-17118-2-git-send-email-wei.huang@intel.com> In-Reply-To: <1615969417-17118-2-git-send-email-wei.huang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.5.1.3 dlp-reaction: no-action authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.200] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 0e7c7c27-5d61-4827-8682-08d8f4e28921 x-ms-traffictypediagnostic: DM6PR11MB3468: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:517; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: S4xEMQKpZop2NrDm5A79ihusPM6l4g1fKByYCXw0txnhEedvIIaddOPJ7Hpai5yNOKMstiXmIDDUDFdUq8fGZ0W1iF3mX22O4DvCgoNbDIIyYy8h/YSsXvfDqckSW/c1JL9Rimqy7AouHmNb66sISfqqetORmjw2M29C2j+wDDjzBFrBgPPknv/gsOxflfVUdIWAlL3/0cc8E78bUJJFa3YgpdbVbHZNeiiXfxluJ9/7qK7a712vHuxTvVL9RHWUHchQylNcmiMrN6khogIYRlHvPsGcvTENDXmH79QBhawEGhB2TZGfIsLBOaqFN5pGQGDrZn8s4l1BSxD5jRdhxDA8FaX4kUpFnSLrmhAg9TxHwSf8ZFLdIT+6hQy5IDW1L0pATcIXwHRON+wjrhxHTJuklARQlBYxuC+aPrurALOWMDBKNwhNXgYBqA/7nGhAJRJKOStjuLFLo0i5ic7qX3YhAj+WLxqtPRq4wRmAhOVyN91TYQ+iYeVOVljoDzMqkGI9P8mW8k8d4bZjaq/HxuR8OxpGqAJvum9koZQHAtmTbngSa9GNj6PguvL7hDgf3HNCI83+QNqAT2bE8evyUzAezY0tC3M/f3bL0gSvmNHUHm6Z9q6mOoWqaldOVpxO0r+hndkaznBFaF6/cAXmiSKvuakPJPKaQd1kpbPHPtQ= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB3131.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(376002)(396003)(136003)(366004)(346002)(39860400002)(66446008)(33656002)(7696005)(66946007)(66476007)(2906002)(53546011)(38100700001)(26005)(316002)(55016002)(9686003)(186003)(76116006)(71200400001)(110136005)(86362001)(5660300002)(4326008)(450100002)(8676002)(6636002)(52536014)(64756008)(83380400001)(8936002)(6506007)(478600001)(66556008); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: =?iso-2022-jp?B?R2dPVGtVTk1xZWQvRDFOQ2N4em55YUptL1MvYTBxNU9aYi9Lc09QVU1D?= =?iso-2022-jp?B?aHMwaDRqSGx4aXpNVVk0bUVaMDVEaVpkYTExZHprNjZ1cWtpaFVGNGFK?= =?iso-2022-jp?B?TkNzZmpIWkx5eTFVRjl0b0xhTG4rczdjWjdrRE52MTJ0Q21mN25xVkhV?= =?iso-2022-jp?B?VWZhR3pKNmNHZlhobkNwR3kwNzR2d3U1b3ZZcWlNc3JJOElRcTlGSldh?= =?iso-2022-jp?B?QU40RWkvMGcyL2ZoZFpVaUhTSVNXVStkdDRqZWoxcDZrSHlsT0lSOXk2?= =?iso-2022-jp?B?RzhrTnc3ZmZlQ1hFZGpCWUkvR01YKzVSbXZQd3RYQUhOVmN3dk9WOWg5?= =?iso-2022-jp?B?K01KOENkLzRIa3RjY0ZEdklLUnhoY1NtZFFLb1AyZExxZkxLNzg0NCs2?= =?iso-2022-jp?B?R0hRUUJSUmt5d1FGdlNycVBpTDZJKzhQRkx5eGg0TENHSXpVZzJYQm9U?= =?iso-2022-jp?B?YmEzc1lhMmZIZUtGOXVIa3NNcEpmN3hnS21VR1FkamdqUEFzdHFRc1RK?= =?iso-2022-jp?B?bUNvaWRvYndhRXloMmlnWEJXVjg5N0NPQzFsUkFKNHdjMVdmR0Rpb0FY?= =?iso-2022-jp?B?a09sQ29YTTB5ZDJYbXVqdEJTQ1hIMzRIRDlpVG5XTnFLWmRZVEZraXFq?= =?iso-2022-jp?B?MFFBdDBLdmhGbS9NbzROUVV0bjlMcnFjTFB5dGI4RUEyNDEyNTRlNW01?= =?iso-2022-jp?B?ZDVhZ0dmSUgzOU5vR3RNb3oyUFc2MXd5a2M5S1FzajFBa2FYMm5Ba2x2?= =?iso-2022-jp?B?Q3pjRFBGdE9YdzBEVWw1WWFUaDBrcE5zRzhBMEw3U3dOOWx6UTdPdTZV?= =?iso-2022-jp?B?ZFhjWG1HZXg4WXNjeW42NUZGTnlOaVNJLzNNTlRCOVFlbGRGNEo0a05k?= =?iso-2022-jp?B?aFFQeFBIVFYzek1vT3Q5YXZVUlpvdUF6ZWNQdmdUSVhUcmc1Z3Y2NENw?= =?iso-2022-jp?B?K3J5dlMyUDJhTkc1Sk1tbzZ5d2ZtQ0JQVWIrUjJaalRsb3phSTNOMU5Q?= =?iso-2022-jp?B?ME0ra0Q3eFJPa2xLWUY5ZjdZNkpEN0V3TEpDV3g5N09adVZUQTJIWDlN?= =?iso-2022-jp?B?S0pncFlJYXo2ZGJLdkRNMy82VDVhdnJYbmIrL2I3aVdTdWxyTVBlUndE?= =?iso-2022-jp?B?QW83amVid255VFRtUVdIYVpXYTlCRUsrS3BRRnl0QThhMEI4QUlJd1hK?= =?iso-2022-jp?B?ZnA2MnNWOHZBYkhqMklEUWFOZFNlblJMYklPNkxZZmN5bDhZcVIxRjVl?= =?iso-2022-jp?B?ZVVnUkVrWS8vUndseUVjVUwwSkZXaWhqa01ibTM5QTFRek00NFBHM1Vi?= =?iso-2022-jp?B?OGdLbE9qSUtJeEJMd3Y2Y3Y4T3luRStWTGs0RG44Y096OU1zSWRmVzZR?= =?iso-2022-jp?B?clg3YlkvY0JhWG9PQXd1T2U1aTJBVlJrRDg1cGpITXhhM1BYWW5lTlZD?= =?iso-2022-jp?B?TjU1QmhSQWRteTlwWDJGRHlaYkZRVzhWdDRHWmM5L2ovSFQyWGhnWith?= =?iso-2022-jp?B?L25TUXh5c1AzWC9PcWJvdmxPTTVpSzd0YlBrOSt6a2JMR1QvY1JsaVZq?= =?iso-2022-jp?B?V1pVMk11Wm1EcFl6TUhrK0tQMlN6bXFtN2J6STJjZVlzMlptelBaQ25X?= =?iso-2022-jp?B?WnFIOEVVTFNibENZb1RuU09Tbytrb2gyV3dXaVJES0dIVVNUbm50UWND?= =?iso-2022-jp?B?SWlGWkllaW15eDNzQXpEUXBscFR0bllDNUc1WlFMR3ErcG9Kc21GSXFS?= =?iso-2022-jp?B?WmpoT3Y5WXRsSWUwRi9TZ1U3dm9DbzczNk9KRlhLb3NBdnlHbWhQN042?= =?iso-2022-jp?B?cU95eTFmT0FBeVJUVlhUV05wNWhhVm9wRUhidmRuVW5HN1VGa1dTTlg1?= =?iso-2022-jp?B?S1E4V0Z4dUw4WlByTTVIZVoyV3ZjRFl6UGlrdGdoUGFKb2dwL0FmWENJ?= Content-Type: text/plain; charset="iso-2022-jp" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3131.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0e7c7c27-5d61-4827-8682-08d8f4e28921 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Apr 2021 07:48:27.2007 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Kx1UDJdgQrd6+JUcvRtu0MzNzpT2xT3gabGxozBXbpHvAPcfcCPSKVqzCWHC+wmoz+v2v84gulGBVscqLO7Fzg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3468 X-OriginatorOrg: intel.com Subject: Re: [dpdk-stable] [PATCH v1 1/2] raw/ifpga/base: use untained variable as argument X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" > -----Original Message----- > From: Huang, Wei > Sent: 2021=1B$BG/=1B(B3=1B$B7n=1B(B17=1B$BF|=1B(B 16:24 > To: dev@dpdk.org; Xu, Rosen ; Zhang, Qi Z > > Cc: stable@dpdk.org; Zhang, Tianfei ; Huang, Wei > > Subject: [PATCH v1 1/2] raw/ifpga/base: use untained variable as argument >=20 > In fme_spi_init(), passing tainted expression "fme->max10_dev" > to function "intel_max10_device_remove" has risk. Untainted variable > "max10" should be used. >=20 > Coverity issue: 367480 > Fixes: 96ebfcf8125c ("raw/ifpga/base: add SPI and MAX10 device driver") >=20 > Signed-off-by: Wei Huang > --- > drivers/raw/ifpga/base/ifpga_fme.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/raw/ifpga/base/ifpga_fme.c > b/drivers/raw/ifpga/base/ifpga_fme.c > index 43c7b9c3dc..a63f90331f 100644 > --- a/drivers/raw/ifpga/base/ifpga_fme.c > +++ b/drivers/raw/ifpga/base/ifpga_fme.c > @@ -1001,7 +1001,7 @@ static int fme_spi_init(struct ifpga_feature > *feature) > return ret; >=20 > max10_fail: > - intel_max10_device_remove(fme->max10_dev); > + intel_max10_device_remove(max10); > spi_fail: > altera_spi_release(spi_master); > return ret; > -- Acked-by: Tianfei zhang