From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <stable-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9A446427F6 for <public@inbox.dpdk.org>; Tue, 21 Mar 2023 09:41:09 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 87FE8410EF; Tue, 21 Mar 2023 09:41:09 +0100 (CET) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id 5B62140A7A; Tue, 21 Mar 2023 09:41:06 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1679388066; x=1710924066; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=jNMaHlhQ5Kq528XFF8BrDsrNaM2nO9NpYdCbJYbDanM=; b=nOlVSUYaYOTU6NM6uoNUpVyzjEYexE4oIdnMRLDzXcu3XZeTAdJoQzhO EF9GpI7IowKaD4VO52a1gHkEEKLqIvJ51YKRnbDHJBo70B61iGE83fmwf spBKH3Lpx5Z92RPuvnm/1kdo3PEW76VWKdB1Ay8FCgIOQ9OlTnQm7JHJZ IM2PA0DHy2fREa/b77bSE+ntCt8lMI+UnNvZcwmO4SqAXZS8xSbofrN9R PCxSA0/NtWLvPAnOl2VGnXvd0AgnBvHlJsAvI+uUMRiiLd/3EYneCrMBf Jo2XJsgQGAfwsYa4GTb53CwaAFH4sjG6LrQ6XuJWETs3BpK/FyTMkNou9 g==; X-IronPort-AV: E=McAfee;i="6600,9927,10655"; a="340427846" X-IronPort-AV: E=Sophos;i="5.98,278,1673942400"; d="scan'208";a="340427846" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Mar 2023 01:41:05 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10655"; a="745769566" X-IronPort-AV: E=Sophos;i="5.98,278,1673942400"; d="scan'208";a="745769566" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga008.fm.intel.com with ESMTP; 21 Mar 2023 01:41:05 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Tue, 21 Mar 2023 01:41:04 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Tue, 21 Mar 2023 01:41:04 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21 via Frontend Transport; Tue, 21 Mar 2023 01:41:04 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.170) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.21; Tue, 21 Mar 2023 01:41:04 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EDKsnPGY8avdl0hc9OVH+q3uJWezzEAnLpBMcTwuhGwVz91yVClB5xoBJQoIrXrSERImse3sO9FXHf7hYY4navHSOgm/ewe9hn/wWEv8+rEcaW87eHEI0U87KfufwhhifnAe4N1tWnKzgfr1mVFi19fY/RW8ILY3IsdqAb3AtK3XrfaenBEvTokVHTXEaZrDzmXCXSTd7xoY7XA959JXU8GHvWv+ENQ+/SujdsU5qoeqhk8KV2HrqtyERiktx1bXKj0/7udmmCkN/0/ntPBWyXBnN9Pghisl3ff9N16Fjm6OloB87Ihmdap0VkNh1ilSeLwoWc3YZpTiGRZVCpaYKw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jNMaHlhQ5Kq528XFF8BrDsrNaM2nO9NpYdCbJYbDanM=; b=Mo9+RTD5GIRRot8xdoCEoBF8jBhCbFDsupAYIVRB1PFO8rlCFJlMDJIXXj8k/PFn82+AvPWS8WVOfWyqQlzn13rFZWOaGfx7EZBNfOMMRK3Sx97hPT5GBT1UXGnNNGvgQVFtWL5QtP4LpiH5OB57pDxsa/ihxjLP1eBVMEWENUnDelf14O/uJlNYyglGoQyaGXtcSP7fuQ7o98NBiagiES0qhYGgFl4J3mQpi8H9jV9ze/HRLI0KN11kFmlZyTBSOtYAB5VZxm+jadv14fgRJvV2UDmIxYozfE8wynVFOhdJaNZq81PzxqcuApGLhAn3uk0CCoh741bmPljttdw3Zg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM6PR11MB3530.namprd11.prod.outlook.com (2603:10b6:5:72::19) by DM4PR11MB6334.namprd11.prod.outlook.com (2603:10b6:8:b5::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.37; Tue, 21 Mar 2023 08:41:02 +0000 Received: from DM6PR11MB3530.namprd11.prod.outlook.com ([fe80::2a1b:9bf9:445f:567f]) by DM6PR11MB3530.namprd11.prod.outlook.com ([fe80::2a1b:9bf9:445f:567f%3]) with mapi id 15.20.6178.037; Tue, 21 Mar 2023 08:41:02 +0000 From: "Huang, Wei" <wei.huang@intel.com> To: Thomas Monjalon <thomas@monjalon.net> CC: "dev@dpdk.org" <dev@dpdk.org>, "david.marchand@redhat.com" <david.marchand@redhat.com>, "stable@dpdk.org" <stable@dpdk.org>, "Xu, Rosen" <rosen.xu@intel.com>, "Zhang, Tianfei" <tianfei.zhang@intel.com>, "Zhang, Qi Z" <qi.z.zhang@intel.com> Subject: RE: [PATCH v1] raw/ifpga: remove virtual device unplug operation Thread-Topic: [PATCH v1] raw/ifpga: remove virtual device unplug operation Thread-Index: AQHZWHHvun1srISqFUW9KK/CSBP1OK8D2uEAgACG2SCAAIedgIAAAFNw Date: Tue, 21 Mar 2023 08:41:02 +0000 Message-ID: <DM6PR11MB35302CEFBD9FD904202E18C1EF819@DM6PR11MB3530.namprd11.prod.outlook.com> References: <20230316204445.360330-1-wei.huang@intel.com> <6411222.K2JlShyGXD@thomas> <DM6PR11MB3530F55C64732307A7B9F563EF819@DM6PR11MB3530.namprd11.prod.outlook.com> <18059490.sWSEgdgrri@thomas> In-Reply-To: <18059490.sWSEgdgrri@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM6PR11MB3530:EE_|DM4PR11MB6334:EE_ x-ms-office365-filtering-correlation-id: 2a6e9f89-81d8-4423-223a-08db29e800cd x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: YvTOpz2rYlHoai1rftCkaO6NtzhnvFndK/66Knz3u/oaKeHeirIovmmxeQLagsW1OoIZ9pEkhk7hQ0SFR+g2HDXTsuSl+Fi5UfYEc+V/FgITvZURUsyne11OyM0uiHpa8SfsqSrcUFVjxCCtqNKqcYML2zoccxlQtipv7lLzVqz6TgBXA0QUjh4WZNepWYDGsiI5MZTw2odXlRsyXQG6GcaoBtib0gd2YUxRv4ErtP1GjUZyvemvsv2BgWN5vAFtpdfg+hx9iplB9ZqEwyPx/0TnYjddmTZxODS9jmYmQm5ylOqiDPrX/c1liQn4c0E1V/cq/akM6ruZWolcpSo+aQXHvF0zum8g3bxgrbpfK/HWLt+bib4E/EfrXOgusb8u12QejbKB5ACtkosS3MngUnpkYdJnPqKs7KE/feamIFv4LIk+DbRkmYwIOmHXdeyeYzSBKwgwFQWfkZRtYGwYV+YX0VnWyBoyUuyDjkMzxyyLlOwc1wfv+uodVLlONmpSd2kpm0VGJOQ5HHIzlL09p2JGJ4uewTUB+3acEeGAJXAWvkx0/ZWO7F01CdQ3iq9sktimGhPeaF/wb4HDREVCCkbF9t1C8lzPtX2nQRAzidk3X4IzIl6eB89EiJmHh/5yuQmhGGMwFJVjNosMdIeHSY3QJckrU+sxrBEBebwJtJLF6NPQl9VO6VuaGkSFPlB7UuyPozW7D7FOQ5Tsu0QNLA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB3530.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(376002)(396003)(136003)(346002)(39860400002)(366004)(451199018)(52536014)(66476007)(8676002)(66446008)(5660300002)(4326008)(6916009)(76116006)(64756008)(66556008)(66946007)(8936002)(41300700001)(26005)(186003)(54906003)(316002)(83380400001)(478600001)(2906002)(71200400001)(7696005)(9686003)(53546011)(6506007)(55016003)(33656002)(107886003)(38100700002)(86362001)(38070700005)(122000001)(82960400001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?IOE5V15ZqUFH+UJzmvXewbncQfvZADwEUnZ9Txqbc1EgBIF8bTs/JpdElh+7?= =?us-ascii?Q?W5uY/BXqCKQ0G/7PpXuB0gHOsSe+mPcEID14ozNhcW8i4s0aSTV8BlQPXIfC?= =?us-ascii?Q?DHPnA94LVc/tEV21XwWmKI3h3UH7B8Fd+gYYxwiTePMSGyfQvslgXJjt/U77?= =?us-ascii?Q?W2W7Wkn3yCXsm4NOSVuwLAsZSHSUqjXOWr5X2kLGwdVpA+fJxOaqkl3rRrGd?= =?us-ascii?Q?WR/oSuCV8mwNVWQGZ6Ks352QYN+SHXW2IPNUUjjjcJdHM5DIGcf4IwIT45cR?= =?us-ascii?Q?4kC+q/316Tjwau231PEFNqOLvqPGpHfmAITRLvC2miSors23KxTXPkzKHG+Y?= =?us-ascii?Q?iPGMFrGfIIflbnVUU8IDWSJzJOfHEhJvRduoODuClDLQ8YMI7rPSapoowMuU?= =?us-ascii?Q?02+h32CEe9UhEtRDBuqlEpPlSigpdYWCxHJoDbAPnrWBuf+mdQXa7vPl8O/s?= =?us-ascii?Q?qft5Ed3l6MGGbhXYSSyS77YdXN7sgt3b1PxAh+2OtaPHhQclE8vOKuqEXF0b?= =?us-ascii?Q?+VzkyDNizgao9QxQ0HzWtGedQMzCrm3dv3HChTL6wHi4BT7OUD9v4zOYEGe1?= =?us-ascii?Q?bEKGCS1J+HocH8Nt+Og+OgcIHwyhOlwBejzWPShh8UI7HnforKy+hv0MYk06?= =?us-ascii?Q?LT44xkRK4xh2DvELYn9yMAieG4iXmMWc8ezZDiKX3/ce2guTd1VbYXjt/5Yv?= =?us-ascii?Q?Dw+xANHfrptxMu6bF5xE1S+2mEodhJ7tl9dLAjOId9ocLHovGZ0m0qigyEGV?= =?us-ascii?Q?dFsyLidB61xfel2o2DmmUXeU+N4NQiTR2eFnnj5l77LfRnN3usaHrK/YKx38?= =?us-ascii?Q?CktugrBbMrQK+ERVA8RpQ8r84WJ3MKTk2X7/oBz12FqDC+2lbFFPxsAUNbIX?= =?us-ascii?Q?uck5lXNLpjdir8z+7JmtmZO58ZFmsAzlbG/ynQdGzsU0zx0zaQZgxnk5+LdB?= =?us-ascii?Q?zJrBv9B28XwD/dHVjap8h7cKDZLlzAbokZh9TSO56TELIJ9jVe0+6q6/6GOu?= =?us-ascii?Q?fXp5eLwMGBknheuKb9edB44TX7nborsRcGtmsXYE5bkvrMa9pgSny5cl9x7d?= =?us-ascii?Q?HINo4K+JtTvnyBp+3Piis4tqYgalIyBTPBowF7kSfv69wqyWLNSSVrRSO3ol?= =?us-ascii?Q?kWdsRFgztkpKmF8XgFkxTRerWfiqaTvvZPQFYmi46Zb3MhK42+EhZhP/Yo5D?= =?us-ascii?Q?/ryfIVR6XYgNlWjBczGc3vsUFvzIARzIIToQ/QtV0ntVBHHO6YkU/01l0Qek?= =?us-ascii?Q?lFojOdvghgZG1mMptUOO4PQy4/1RjImBZWn/jMotbRSmT21h3Syg3Z7ONo8l?= =?us-ascii?Q?zNFR23Lp818untmhTXBuVWgY2m/deC9VzlUO+CUV2f2a9+wOhAli+LZEIToY?= =?us-ascii?Q?shveqFJX0pSrkSFln0Vc6i4QjyqGMS84HSoRXUDik08IYi+KG0lUYYRwbw4C?= =?us-ascii?Q?U2PEj5nuS2JeIan4iCgwQLIeahJZFulcM7MYOcIqJVI/igNNIJeSmsm+lXT0?= =?us-ascii?Q?0OCsW+7AYw1ilWM34zHCKQjUKThF0gQ0yhVu3DiAHWppos3ujgiI57epj+zb?= =?us-ascii?Q?WVccHPKBABHD2h1yP04lA83ZtHCXBiWQ+j67EZ1I?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3530.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2a6e9f89-81d8-4423-223a-08db29e800cd X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Mar 2023 08:41:02.5496 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: lObL5pJ1DYgedeug4XSTm2+O7qbW+jK2fpAMHSL1UsHe5l7AJU9wBRCNwZBWs42b0Ncmp0Nbl2creci5Cr0hGQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB6334 X-OriginatorOrg: intel.com X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches <stable.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/stable>, <mailto:stable-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/stable/> List-Post: <mailto:stable@dpdk.org> List-Help: <mailto:stable-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/stable>, <mailto:stable-request@dpdk.org?subject=subscribe> Errors-To: stable-bounces@dpdk.org Hi Thomas, > -----Original Message----- > From: Thomas Monjalon <thomas@monjalon.net> > Sent: Tuesday, March 21, 2023 16:14 > To: Huang, Wei <wei.huang@intel.com> > Cc: dev@dpdk.org; david.marchand@redhat.com; stable@dpdk.org; Xu, > Rosen <rosen.xu@intel.com>; Zhang, Tianfei <tianfei.zhang@intel.com>; > Zhang, Qi Z <qi.z.zhang@intel.com> > Subject: Re: [PATCH v1] raw/ifpga: remove virtual device unplug operation >=20 > 21/03/2023 01:11, Huang, Wei: > > From: Thomas Monjalon <thomas@monjalon.net> > > > 16/03/2023 21:44, Wei Huang: > > > > VDEV bus has implemented cleanup() function to perform cleanup for > > > > devices on the bus during eal_cleanup(), so there is no need for > > > > ifpga driver to record virtual devices and unplug them. > > > > > > Why no need? > > > If the application wants to explicitly remove a device, what happens? > > > > > > > > EAL will output an error information "Cannot find plugged device (%s)". >=20 > It does not look what we expect. >=20 Let me clear it. With this patch, no error information will be outputted. Without this patch, error information will be outputted. Because bus cleanu= p action will unplug virtual device, then ifpga PMD unplug the virtual devi= ce which is already be cleanup, bus->find_device() returns NULL, EAL output= "Cannot find plugged device (%s)\n" at line 302 in eal_common_dev.c