RE: [PATCH v1] raw/ifpga: fix monitor thread issues

["Huang, Wei" <wei.huang@intel.com>]

Hi Thomas,

> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net>
> Sent: Tuesday, March 8, 2022 06:30
> To: Zhang, Tianfei <tianfei.zhang@intel.com>; Huang, Wei
> <wei.huang@intel.com>
> Cc: dev@dpdk.org; Xu, Rosen <rosen.xu@intel.com>; Zhang, Qi Z
> <qi.z.zhang@intel.com>; nipun.gupta@nxp.com; hemant.agrawal@nxp.com;
> stable@dpdk.org; Yigit, Ferruh <ferruh.yigit@intel.com>
> Subject: Re: [PATCH v1] raw/ifpga: fix monitor thread issues
> 
> 01/03/2022 09:47, Wei Huang:
> > Monitor thread handles graceful shutdown according to the value of
> > specific sensors in device, two issues are found below.
> > 1. Thread is not created when card is probed.
> > 2. Thread is canceled without checking presence of other cards.
> > To fix them, thread is created in pci device probe function, a
> > reference count is checked before canceling the thread.
> >
> > Fixes: 9c006c45 ("raw/ifpga: scan PCIe BDF device tree")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Wei Huang <wei.huang@intel.com>
> > Acked-by: Tianfei Zhang <tianfei.zhang@intel.com>
> 
> In general, it is better to have 2 separate patches for 2 different issues.
> 

These two issue are related, if I split them into two patches, the thread cannot work correctly with any one of the patches applied.

> Applied
> 
>