From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0D445427FF for ; Wed, 22 Mar 2023 02:27:08 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DC4FC40E09; Wed, 22 Mar 2023 02:27:07 +0100 (CET) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id 7665B40A84; Wed, 22 Mar 2023 02:27:05 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1679448425; x=1710984425; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=Ni0oop52/FayH1vA0uBhcQQaB5FZl5fBd6k+oS4O7ds=; b=kTm21HMkFCuWs2+1npgSbNrRMqKPjvhmmW7M4JQD3jJNEI8wTrIvFhNQ EldAeqteP6Dnol0GMaw0pVNihvD17rB+hcSj/zM+zvitR2CBSTFOuqoC1 kEYN+O9rv86hHvFZorDdFnmFjCsJu7zXzyOOq7XJheBOlPudp3+zdCV1w N2bl5WNaahQ+6jYhZILkPjGHKmBYM6C3YaS7bwiLOXJhHxLEh+VdWNftY dvQi8WIwZGS/QwSRkdHcboSKCD0iYtm7muGmZmgjwHU6YDdnZOnljNWbM u8CpA6Apyw2JDY5M0cxnXft+Opr5NuZQv8xoe14w+9dRXdYSA73/i2s/f w==; X-IronPort-AV: E=McAfee;i="6600,9927,10656"; a="337826348" X-IronPort-AV: E=Sophos;i="5.98,280,1673942400"; d="scan'208";a="337826348" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Mar 2023 18:27:04 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10656"; a="855934518" X-IronPort-AV: E=Sophos;i="5.98,280,1673942400"; d="scan'208";a="855934518" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga005.jf.intel.com with ESMTP; 21 Mar 2023 18:27:04 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Tue, 21 Mar 2023 18:27:03 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Tue, 21 Mar 2023 18:27:03 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21 via Frontend Transport; Tue, 21 Mar 2023 18:27:03 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.108) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.21; Tue, 21 Mar 2023 18:27:02 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=d971r/jjygipcbXK2U9cZRLJEzdCMB5FF2QfceM+TbGjaEY+Xaw8UPQbiXHP0KaSIrAfAYD4onR1VUIc61JydIzsyWUKjw/R39EOqIIys4IRvFK0IEUrHBk6DQKJxdVCjGYi8Yzc2vgbh7qRiiNVzZ6X2Q1iqIP2nWVL0PMZ0z6Z2YtzRSu159rkJAeVwWMkhPGLaNaApCN3DAWqLgs1kkrnpouoaHfIQmO1fsoqIqmkxUv1skSHu5fQLaJX05afV5sYhTc2hj/i3u2Ku4ynxNvMfwKQvCV+Fe7H/y6/0tkZZczqPSDXMKOfVXRhzce5Tmp0knIFqveWuNIawGg9Gw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Ni0oop52/FayH1vA0uBhcQQaB5FZl5fBd6k+oS4O7ds=; b=iI8z/FW7Sicv1Hrm9l0xsdcHmwiLleN18dOpUmBQ6tDOdAPZiKQuej7FmgbgGgZcK/mzIxA1w3GfgckNGPq4ncCg8/030iOtO5Nkopkz63JYZtvMx+rLLYcUhRfc+JuRpD5wJVU+fPUDh1SmYbOXof345Y0HyOAc2u5p3eaVtmThhfL/jreHi47CwBNqXwoEMZZMsHQrflE3LntV/N+XrhJZxN44dKI0qnzT3gMnjdYNX1Kluuv8s+zXzvowDkfEzzx1KSyhQiWghuLZhuxaRN+6ZZkkSfEQegvNQWcD+CqkexY3OXbM4JstMUWX6tXT3tutMx5JXpcElqsFm08F7Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM6PR11MB3530.namprd11.prod.outlook.com (2603:10b6:5:72::19) by PH0PR11MB5158.namprd11.prod.outlook.com (2603:10b6:510:3b::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.37; Wed, 22 Mar 2023 01:26:55 +0000 Received: from DM6PR11MB3530.namprd11.prod.outlook.com ([fe80::2a1b:9bf9:445f:567f]) by DM6PR11MB3530.namprd11.prod.outlook.com ([fe80::2a1b:9bf9:445f:567f%3]) with mapi id 15.20.6178.037; Wed, 22 Mar 2023 01:26:55 +0000 From: "Huang, Wei" To: Thomas Monjalon CC: "dev@dpdk.org" , "david.marchand@redhat.com" , "stable@dpdk.org" , "Xu, Rosen" , "Zhang, Tianfei" , "Zhang, Qi Z" Subject: RE: [PATCH v1] raw/ifpga: remove virtual device unplug operation Thread-Topic: [PATCH v1] raw/ifpga: remove virtual device unplug operation Thread-Index: AQHZWHHvun1srISqFUW9KK/CSBP1OK8D2uEAgACG2SCAAIedgIAAAFNwgAAltoCAAPfrAA== Date: Wed, 22 Mar 2023 01:26:55 +0000 Message-ID: References: <20230316204445.360330-1-wei.huang@intel.com> <18059490.sWSEgdgrri@thomas> <2637984.KRxA6XjA2N@thomas> In-Reply-To: <2637984.KRxA6XjA2N@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM6PR11MB3530:EE_|PH0PR11MB5158:EE_ x-ms-office365-filtering-correlation-id: b3b45c65-cd0c-472f-3843-08db2a748605 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 8oLDSFr8Mnmw1M5D1P3es05Iz1yOBT6O+fm+O+UKQqAgNVpVYRJCF636FKDEiDupannEhUbm3p4OHTy0omU3pKbGgM+igvH7LKs3VocSmWkpwXO2gOiQU0ugwTaYoQA8aqAhc5mBC9XS+6aX8mbC2Xs+2h0e2ganGqRBrBRJ1by9/4uPAJWAPww5N3FneBVla0plnr9JL+IsPPZhJOfn7Fpf2+gjh9HlntWZHsMLYN0M3PxISIlmQJsya8NKlWfxEoZH+Hg642UPPTamQ78HctKpofag8D900tVeEAMJs+zg/QyI6JygDX8Hx9D5mRB4YFxdhjLCb/Yms6R1G6j5vVQSA2z7Y5bEK9W6Mf6ORHPF6jHoaIThYL83rzdiWYHMlTZFr9rjkNX9NhkJiEFVa2eFKEI9xOvu11LbS5qwks1a3ZorZ4tU7WXV0xLioV2t66lxyhxTZXDkFX3gBFkgjMDD0OyW7P84Dkht/EjOE/tmhVA7ylqWNn8wg6kHHsZGEVFAj+ucgEpM/KAcl1ZMPjuRtqPEBlhZruVHpiv2PrajESuricj3uEcFHBKCgyMpxlUtj8b50hv6E+php+Ag6i6kMlAUYiocGvr9zP3+I+nbjMweJleIICUi8sdMF84DdvFri8wycbGQA225Hy5moOzlr+dBJgeIAac2CI7Z6vsLqPEaRNEhIqSn4U5GKPJ+MDXX0EJ+GpuMIWZF09PMLg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB3530.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(366004)(136003)(376002)(39860400002)(396003)(346002)(451199018)(5660300002)(8936002)(52536014)(41300700001)(86362001)(55016003)(38070700005)(33656002)(38100700002)(2906002)(82960400001)(122000001)(4326008)(83380400001)(478600001)(107886003)(71200400001)(7696005)(186003)(6506007)(26005)(9686003)(53546011)(54906003)(66476007)(316002)(8676002)(66946007)(66556008)(6916009)(76116006)(64756008)(66446008); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?dp+Y96AFrfVIbph5FKbrWcU6d5a+PqIYsmSqm5hv+cdhop2p2G+xZd/uI11r?= =?us-ascii?Q?bv4PPyXSmtDdzFhGCxk27xrp22RGAAHRAoQ1/i+gbf/FtNWYEgSScAjw/9hu?= =?us-ascii?Q?SCstFHv4aRHJ2P3j7clOZ91QaV66Fp3TDyTjww/jxdt/owmN9Qf6sl6Wg2aI?= =?us-ascii?Q?TrKblfkm5D2O70OHnXNU1hIdQ5NkCMCWBIFvzozGLbiU/RCJbz4OdfmzxT5F?= =?us-ascii?Q?XVZM7J763cYq8A+2YB4lD8i5ThfBaGI0vLosRZbe6jlStXZn+T7trEvBNEpg?= =?us-ascii?Q?zuSzcbpROXbEt4ucv0aGQPDPJ5MMDdgEi99iOkc3DqdRTBuVGPYv5ml1Vhvl?= =?us-ascii?Q?bX4XLf1QyxPUzITWnZzuIGolYIyOiaeeRq3vA8YW/mABLKlb6midE2/WreuG?= =?us-ascii?Q?7DsqTQosZl3W7ykIDN+idCq6PDhUxMSpDWhTqAuI7CVIOe5Pg7v/+Si+aApk?= =?us-ascii?Q?Cy+weCDIZ8U/V0uvIuRhS58OYq+0bD+ahaeTwz/UI7/KlEwwbFMFnovG29ls?= =?us-ascii?Q?79K+oRhi3hZL1ovpUq1pVUV/RUV4nuLR7pXn5Z+y/cD7Lh0wkPsrCAu/5ULj?= =?us-ascii?Q?gdjbxQ90qlp9xPeZUZDCrfbnDlecWYCyQong3lck99569onPZEZQO5zAXe1I?= =?us-ascii?Q?RauzVFjJ+4HSkGSS2+Sk4YwF7Hyj+X/sVjOr15fsGfpg1sYgr4YKEGgL37wc?= =?us-ascii?Q?k3IpfSI3Bb6BnfOc0wmuOLJvIICPiBZNb2Jyf+q4Hp0HD+i8Ri39vr5mZYWl?= =?us-ascii?Q?TYjoxEfXZtiPGWvwVGC95It/0gisHT0O66UDQokwgyAO6EtPqdSOB/1lOI6F?= =?us-ascii?Q?GlMa5X/lyJlg70i1lJ0TcwBs3u+b2dtocVAC2CfpjEeyPBbNDt4G8QUVWl5C?= =?us-ascii?Q?2b8GNZwxv4e9TOJ4LW6rS4xbCS5ux+E4rYxO7VPgpWqq7Ymcf4kRqVwMcCUT?= =?us-ascii?Q?YJCSqdG5evM6TwRIQkBQI4tsMmKAO8LLqHFclGZrwvPZU9sVNUxhE5rTd8fu?= =?us-ascii?Q?eAH6zEG6xtGtLwrSPCmTzWbvm3TEDqmVdMFrnw7FWva2ucHdxaghe+bymsUs?= =?us-ascii?Q?QRYCdoJZyZH9zoH8t+H/CaOI4E/tELvxSdPGZ4DFOh4Kf0soBrQkj6VgPRZk?= =?us-ascii?Q?DOOyzZf7x9fKUxdHTXmqj2bt2tETI0xTV46VG6+aFkKYOkvFYTkVdoYsvS7O?= =?us-ascii?Q?Ogk+2StaS1VG85SFMCjYznYVgmhuNd57YFTz44+C6rK4TixHCMZzKYXrhCSN?= =?us-ascii?Q?cEVAH/eWivqfUwEI75QKrxLRww2EmZkpR7HKJKLbbbkeX08xdsH/N4ncSqO8?= =?us-ascii?Q?nv+SJYAYvZW9i7Va2lPLx7iBOoHMMQOFV3eQOgoKCbn8owCvaBhcPqL1dTWb?= =?us-ascii?Q?ZrsmK6fYT92KsO5GNtlue2Yugrp5Da1A/qDpYiKuVcz8fRneiQQXlroMyimZ?= =?us-ascii?Q?4AIFKy8DH9GvzrWraXINhYOolEVbP0z8Ihv7iGHJ9iYVrk0AhgSK6ovid7+1?= =?us-ascii?Q?KCcaaP7gcuj6uvGXlbYeA20pZ0ruQF4+EgP+L2n07he8V2Gc+Yz5J1e3F07t?= =?us-ascii?Q?WA2MrKSSOsuRczehsDC2evveUwPaVRdAWEzubv3X?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3530.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b3b45c65-cd0c-472f-3843-08db2a748605 X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Mar 2023 01:26:55.5806 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: HRtPNyYYKR/J8t0eyMlk+d1K3IwRxgFDzKZjOPdmAFqO9ibIpAj26IskpkzEgkBTFjFM2DF6A2HDHW3z0Rlrtw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5158 X-OriginatorOrg: intel.com X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org > -----Original Message----- > From: Thomas Monjalon > Sent: Tuesday, March 21, 2023 18:30 > To: Huang, Wei > Cc: dev@dpdk.org; david.marchand@redhat.com; stable@dpdk.org; Xu, > Rosen ; Zhang, Tianfei ; > Zhang, Qi Z > Subject: Re: [PATCH v1] raw/ifpga: remove virtual device unplug operation >=20 > 21/03/2023 09:41, Huang, Wei: > > From: Thomas Monjalon > > > 21/03/2023 01:11, Huang, Wei: > > > > From: Thomas Monjalon > > > > > 16/03/2023 21:44, Wei Huang: > > > > > > VDEV bus has implemented cleanup() function to perform cleanup > > > > > > for devices on the bus during eal_cleanup(), so there is no > > > > > > need for ifpga driver to record virtual devices and unplug them= . > > > > > > > > > > Why no need? > > > > > If the application wants to explicitly remove a device, what happ= ens? > > > > > > > > > > > > > > EAL will output an error information "Cannot find plugged device (%= s)". > > > > > > It does not look what we expect. > > > > > Let me clear it. > > With this patch, no error information will be outputted. > > Without this patch, error information will be outputted. > > Because bus cleanup action will unplug virtual device, then ifpga PMD > > unplug the virtual device which is already be cleanup, >=20 > Why ipfga unplug the device after the bus cleanup? > I'm not following. >=20 The virtual device is created upon ifpga, if VDEV bus doesn't perform clean= up, ifpga has the responsibility to unplug these virtual devices. > > bus->find_device() returns NULL, > > EAL output "Cannot find plugged device (%s)\n" at line 302 in > > eal_common_dev.c >=20 > Anyway, the good answer is not to completely remove the "remove" > operation. >=20 If not to completely remove the "remove", the same virtual device will be u= nplug twice, is it reasonable?