From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E3EECA034D for ; Thu, 10 Feb 2022 11:43:52 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DC6C641C25; Thu, 10 Feb 2022 11:43:52 +0100 (CET) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id 5A6F44013F; Thu, 10 Feb 2022 11:43:50 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1644489830; x=1676025830; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=OwupOdjT4nbLN2RKu4XbnBomDwole64WO/OEOIkH+Pc=; b=Fy9BG9D2WDtu9Bdiy/0Ev8Fgm6GxBvzbYkcJgRP1B/1MCLJkMC1eMiA4 /12F2n/WQ0J3lkAmCrYWiOxCvqGjddCm0i2ipRpBT+WmGt3EzMEyGiw+8 XB3kcjhZdmvweD2144I9Wq17aFOY1Hsf7muzSTJCVVUV4Au7gjyT4nbol I7p3bRS330Q5Ih3fJBzF5XWUlCLqVVtDk6sJLeWFri+NvwQ/AixsbHrh+ vUyBIsFT9ZdK8iDL10FnDWMR3SDKin/wltoq9g4LiNziWg7Q8uOFGGhci XOeHTtsxtedwOvMDmQbalETi4w+bwyvuBmF0srY6lDovSGa2DETlg8ioQ A==; X-IronPort-AV: E=McAfee;i="6200,9189,10253"; a="312749920" X-IronPort-AV: E=Sophos;i="5.88,358,1635231600"; d="scan'208";a="312749920" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Feb 2022 02:43:49 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,358,1635231600"; d="scan'208";a="679104439" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmsmga001.fm.intel.com with ESMTP; 10 Feb 2022 02:43:48 -0800 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Thu, 10 Feb 2022 02:43:48 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Thu, 10 Feb 2022 02:43:48 -0800 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (104.47.73.42) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Thu, 10 Feb 2022 02:43:48 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GQCcdicDR7FYdZhBhL4fXBeYzhm9Q/jXDWnVty4DtVscAF0mQw8G/APqHQM44Zh0fSHCnBGQ8EXEYOlg0CB42NxfsIwcvC1TdZxalT2cUdqikPs5gI1TwEBe/pTNUIoyhnOgbdYOBdu2h955YXxSp2JJlyHuBLXuPGmO5qbdg3bwZ5Gi435u5ZWm/MReJVfzt4HG6B0LPs31XHnPw/cPilItLEw6yp8hjL1Zm80eogH2BoWi4KJ5fBV4/kn0bkDYTbvwXbd6fkvrvds1GnqA/n1G0xrE0AEPR9Ejts7HFL0iWwsIMqY+VvjndqtAXnw8U9HKGqn3CXLbU5lBDduu7A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sSvfQsgBKJZnbEcbS3LGIW1VD+HsW76XIIP7xd+VSAw=; b=e+ch7VJ1xuUhH0de01DOZmjD7vrT8JEa05H3aD5eonxmGhDUSUnEugTnwFg8rgszlDnVYwLTYduXr9Fr8lo6xBpq9bKp0sUCG/LWJZAJ/7vohy5g+Ktn+t46+tsNHfqkiCovutmwE4WMrf3SJ02HKScYuddtBDk9fDbyaEMf7xAdrXBW3F1mTLDRgGXEHx2XAi4E6FLz0hefws0C6VBfA1QNAdOZyW49ZGz/I7aEbG/G9oXn89Rju7rD34C5Frf4BAtB2od1Pq9+BETvZS4LTohqnV8n5y81sn6N8ofzQeWwRJpelBRZCNG2Wyrv+myzNW5ymsuGBNCVKLk2efoXwg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from DM6PR11MB3723.namprd11.prod.outlook.com (2603:10b6:5:13f::25) by BL0PR11MB2883.namprd11.prod.outlook.com (2603:10b6:208:7b::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.11; Thu, 10 Feb 2022 10:43:46 +0000 Received: from DM6PR11MB3723.namprd11.prod.outlook.com ([fe80::2821:b80d:b05c:1682]) by DM6PR11MB3723.namprd11.prod.outlook.com ([fe80::2821:b80d:b05c:1682%5]) with mapi id 15.20.4951.019; Thu, 10 Feb 2022 10:43:46 +0000 From: "Guo, Junfeng" To: "Wu, Jingjing" CC: "dev@dpdk.org" , "stable@dpdk.org" Subject: RE: [PATCH] raw/ntb: add check for DB intr handler registering Thread-Topic: [PATCH] raw/ntb: add check for DB intr handler registering Thread-Index: AQHYHkeIGlhboD3sRUCfkNnaxcjhEKyMXG2AgAABJgCAADo6EA== Date: Thu, 10 Feb 2022 10:43:46 +0000 Message-ID: References: <20220210062841.646294-1-junfeng.guo@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.200.16 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 91cf3301-c99e-498c-2fd2-08d9ec82372b x-ms-traffictypediagnostic: BL0PR11MB2883:EE_ x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7691; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Buo6uyQSSSuMySHfTPRERCYoGZaLkNxXqw1XAHhViRMyYtMPz8Rfb3yG+wcZ51QRet2gkwi52HvkVAxhHgsLpIN4O/EflVJh4uYrULD2DoVPgKQNsbcqdHHT4Okj6m0VvBiSAHmlOn4MUygXmOyzV5lqKQqZLU6syRV+a6l4Pb7kWDdZBJMDBkDdDdROEHmsZnwPH40IvScYMUtbkfGN4chKowZlCfjyQN1UJ/lQsgdp8A1MAOusa7kRQwRall1IPrXl3kTjWGpZWsFf4T0R88CPjMDKwMb+Gp99Wn7KFPueUfX98dz4Mj6SBQjF5GTaGhKLA4mFsiVgGn5XDasT+0AL18PU3vcRKsVgsHvDy3IOjCErrKlQZ/A0vL4B7M/yyD5J0c+eMHrQUXV+DD6kUiTIsa96I2X46adE359LA9XM78QbYOOc1STZ4bGPonUnOTOXQl8ZPiMYBRsM39dHyevWgQsLCKLiB/YqDGwrCqCG3rWooCceeL/o0uoAB/N+JTb1LOVQXQJekT8ojoXhWaPbU+4PgjvQXCtQLEeUof3mfo+OeIo6Sba4k8nYlwE5hTcqoYddPZKUkXOVUUT9pcwXJT20aEi6reR67Q58KF7hD6s1J1OPkHVmnPsnQqaJYcgARqY1YI6F791Uze3jrxxwVUtiLivuXbS1g8hmdM+KGz/Btx4d1/hWetGtkV/0bPzEC5H0UeEioqM7AmHMnQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB3723.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(6862004)(9686003)(4326008)(7696005)(6506007)(53546011)(71200400001)(2906002)(122000001)(5660300002)(52536014)(86362001)(8936002)(8676002)(6636002)(54906003)(316002)(33656002)(83380400001)(26005)(186003)(66476007)(450100002)(2940100002)(66946007)(66556008)(66446008)(76116006)(55016003)(64756008)(508600001)(82960400001)(38070700005)(38100700002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?yOY5GIm2ay4Nz/ktsOMgVzuU4fxvzCOKRIY23sUkGI/JV8RoC7+ZTrz2yZHF?= =?us-ascii?Q?tBq1o5WAe8MAsNAI6TrkCAW8rO81u6l0ehva2XlOjq/4qI6BcGBtwdV1WMT7?= =?us-ascii?Q?RObYOP8p+AtlIRqXuQ9fd2mF7ZKlxFXgPpchhJickIo/eGGg3KRsuvieSlnY?= =?us-ascii?Q?YctgHBmuROS0X+SVDGS8B5TSv1QEZ3BhxNC6cVXxMqMspe1bUaal32lx5WkP?= =?us-ascii?Q?xS+VqiEDsrJcJg/AHXJxNWpk5TXTr6lFnTqSN4k0By8CfRIJ3qdi7SMBPDH2?= =?us-ascii?Q?6zRpPAZ8M6ty/8WqRRGV7+f9MreQ+ZoW4UW996pgDrxcoDT4jRSyHNDWqDOY?= =?us-ascii?Q?0Xk3Azaps1L6wX6ELItRNauzpLnygRBm077ycauzAty/b6RN7nxuzk1m/An1?= =?us-ascii?Q?52JsXyaDZlnkcDfHrp+cN7TOwI14HKwBez7WSajTSkphwmurLaOu9i1rZidW?= =?us-ascii?Q?LtVofTPO1ky82WoDo0nByZu21OOTDbwpTEoAJJrzjLyUk9s6YPewRWL34575?= =?us-ascii?Q?MDM/QEhfeTZsxzLYnSVjsozTqObFtazjEN9s1+LXxxyeTIa8Gh088072MZer?= =?us-ascii?Q?XS4E7XyD+ZQh3bzg8TQzLqYtS2OiGCjc9bCcQQN3rfWTlAuUtivacQto6Q2g?= =?us-ascii?Q?TmZqMc8yA8P7twdtdu5EzfH0PwsbV9U+IC22Hjm4DMWscbo5DOmNKtrjUNrm?= =?us-ascii?Q?7VLfTANr5ou5WvfM3MEzRhHd29LoGd2v951CtbCqdJaqMamzcAWaoZL/HzvK?= =?us-ascii?Q?xLBgAHq0nnnN49GMwcEr5/jBaBI6yw5E6szSg9MbiAEC9ph0U7mYH8m1gebx?= =?us-ascii?Q?tQiuBw0nQdPGvoaqT0R1clsmiHbaLeYzRzva876b9fhewaUvlKKCckjbOFKd?= =?us-ascii?Q?2lzPZWXOw32BXE0sE/TLFoe/+fdX4hMVgsKb5ovZ9FOLO/9i3YKVjk9H1rIO?= =?us-ascii?Q?8xy9w8+3Bcs6SrdN+lJIGXFGTQZ6KqU1hunjIHgyitA4PGY+wkLRRQpJYL/O?= =?us-ascii?Q?O+uWkNRwchCOlGLPaItdCm0tGtPcQSXdn2Th2hoOm7G9E+BRQ5vW/Hr6H8AM?= =?us-ascii?Q?m8GlDCLhtXtCdU6Dmq8F9kPCq/WJKLd5ZmDaDUET2YRCzFa5Xl9s//OPu9pV?= =?us-ascii?Q?mG0REGB0Wc3QI5Wj+2Zve8gIuvmhx5Kme7jJObHm9kwMrEIE78iVyuyBgk2K?= =?us-ascii?Q?QKXP838Dix3sRAPEIUmbzzNvvg41r51b6PjTf8gjlQ0F/sdtQyeSxwkgV0SF?= =?us-ascii?Q?Y9bRCMDdYJz1RTRg7XxVZ15+aL7zv4kUhJzKEzYi1IJhkdHLDAdyOL8fPl2l?= =?us-ascii?Q?iFGn1AqmyuLmL6S9MT0xJkJFETU0Ehv2Pikfx7P/56kNi35/VbsA+jtlF1aO?= =?us-ascii?Q?sP27EQoSEj+P8zgPcKCKCTOvtMhNabiCx3BBYP4HZK1bwlg/R8BZyX3p6JRB?= =?us-ascii?Q?N8QB5u5KILpV+/GTWxrT+d0WdAvX8YQQlgQu2wPq6Fxmj1dN0TGKlJr7M60a?= =?us-ascii?Q?J6CBmK3K5LVIUzhDu1y0bCvMBeHziTy5JYq0xKjgcmGDT9qR9OflKuh43K8U?= =?us-ascii?Q?PmN1k0zFGZTdjUwwJs2LN+n6vz2d4uT8xGeqlBCGCFjZ+/E0n5yUY5xzaMo2?= =?us-ascii?Q?PDvrx+62nd1I3k7K5LEO2Uw=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3723.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 91cf3301-c99e-498c-2fd2-08d9ec82372b X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Feb 2022 10:43:46.4335 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: UkBFtCcjybhiE+iweeEEcBSPBNE1KDDRr75NlseORTGhYUNvTiJz9+B74MlFqt/JqruQ3iql0j3bHaPzdHILUw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR11MB2883 X-OriginatorOrg: intel.com X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org > -----Original Message----- > From: Guo, Junfeng > Sent: Thursday, February 10, 2022 15:18 > To: Wu, Jingjing > Cc: dev@dpdk.org; stable@dpdk.org > Subject: RE: [PATCH] raw/ntb: add check for DB intr handler registering >=20 >=20 >=20 > > -----Original Message----- > > From: Wu, Jingjing > > Sent: Thursday, February 10, 2022 15:05 > > To: Guo, Junfeng > > Cc: dev@dpdk.org; stable@dpdk.org > > Subject: RE: [PATCH] raw/ntb: add check for DB intr handler registering > > > > > > > > > -----Original Message----- > > > From: Guo, Junfeng > > > Sent: Thursday, February 10, 2022 2:29 PM > > > To: Wu, Jingjing > > > Cc: dev@dpdk.org; stable@dpdk.org; Guo, Junfeng > > > > > Subject: [PATCH] raw/ntb: add check for DB intr handler registering > > > > > > The callback registering of doorbell interrupt handler should be > > > finished before enabling the interrupt event fd. Thus add the return > > > value check for this callback registering. > > > > > > Fixes: 62012a76811e ("raw/ntb: add handshake process") > > > Cc: stable@dpdk.org > > > > > > Signed-off-by: Junfeng Guo > > > --- > > > drivers/raw/ntb/ntb.c | 8 ++++++-- > > > 1 file changed, 6 insertions(+), 2 deletions(-) > > > > > > diff --git a/drivers/raw/ntb/ntb.c b/drivers/raw/ntb/ntb.c > > > index cc611dfbb9..0801e6d1ae 100644 > > > --- a/drivers/raw/ntb/ntb.c > > > +++ b/drivers/raw/ntb/ntb.c > > > @@ -1403,8 +1403,12 @@ ntb_init_hw(struct rte_rawdev *dev, > struct > > rte_pci_device > > > *pci_dev) > > > > > > intr_handle =3D pci_dev->intr_handle; > > > /* Register callback func to eal lib */ > > > - rte_intr_callback_register(intr_handle, > > > - ntb_dev_intr_handler, dev); > > > + ret =3D rte_intr_callback_register(intr_handle, > > > + ntb_dev_intr_handler, dev); > > > + if (ret) { > > > + NTB_LOG(ERR, "Unable to register doorbell intr > > handler."); > > > + return ret; > > > + } > > When will this register failure happen? Have you checked what is the > root > > cause? >=20 > When bind with vfio-pci, the DB interrupt callback function often cannot > work as expected. > I think this is due to that, the intr callback registering not finished b= efore > event fd enabled. > Add the check of the return value here can make sure about correct > processing sequence. I think some compiler optimization would lead to this condition. So add return value check can prevent this (i.e., registering not finished)= . >=20 > > > > > > > > ret =3D rte_intr_efd_enable(intr_handle, hw->db_cnt); > > > if (ret) > > Need roll back, such as rte_intr_callback_unregister is required when > fail > > or driver remove? > > > -- > > > 2.25.1