From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 54400A034C for ; Tue, 8 Mar 2022 09:08:15 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 47FC2406A2; Tue, 8 Mar 2022 09:08:15 +0100 (CET) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id 8B39740041; Tue, 8 Mar 2022 09:08:12 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1646726892; x=1678262892; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=im8qOx8cRIkTshO3tHSmEScPSvxxki3HYT4PdUt0Umw=; b=X3JtogJ4h+WMHAsy2cN7GLgMKZkDpErMzfj2Okogyu8wrr3oiDjgn3eK pACeAKOBWh3epoWUSGUBtVIUBTLpCsagcoHXI51TAtHwwONbW7k5pzAzh 816CCpKHb3TIZMyIafxwVfNR+BFCxGrGvS3Z9faPGJcfVoXTOUDx0xFCZ 3fb7zq2lH9wbF5Z3oXxEYZwXR9TXv1ZHiLSi4nfvlD5FLjL9QRc6h8JFz pfFwBfX2MkteW9ZaLmWS7UWlCV0o5RkrpBfoRkCQiFtlaKHcgEPwSJBW8 pqDw5XFRi8drzw7P598XOnA455khQpSBIeuPAuURXlrLSQuXa6Wg8ebO9 w==; X-IronPort-AV: E=McAfee;i="6200,9189,10279"; a="315339213" X-IronPort-AV: E=Sophos;i="5.90,163,1643702400"; d="scan'208";a="315339213" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Mar 2022 00:08:04 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,163,1643702400"; d="scan'208";a="513017748" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga006.jf.intel.com with ESMTP; 08 Mar 2022 00:08:04 -0800 Received: from fmsmsx605.amr.corp.intel.com (10.18.126.85) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Tue, 8 Mar 2022 00:08:04 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21 via Frontend Transport; Tue, 8 Mar 2022 00:08:03 -0800 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.177) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.21; Tue, 8 Mar 2022 00:08:03 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FCYy3sv2KpoJldBpx/CbF0sK3R655Z624djvBbGLiyAZCSfirpHGyDx74Y+OH1wTRAtTj06ONTCpG7CYzy1PJ9gQI7k9tqxYrtVaUeGM4yVgZpwjH6fxuB4dYbNBVY8mCHwQxadXdpugyIRz1BvN5AYiNc4uM9WR5QdDqokBdFsxTGI41ZPmEv+yihoO+D33gHslu1RvotcAZWih5NVoKkb4wfKG76Vj7GHecyxRJ3VfnkY5LslwcTYGzfhDy4wzVbWK9bcppsiz5VJdaCcqlYz7RrmxyEd+uk69mt8LTp4Vzz0qhE9XcSo5guXv67I5Wtjp7KqWXmVr0G5XGz3GjQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=r7HNUTP1wn9LXRvOTziXcaM4lrxomqo6ywnacNGiFbQ=; b=WWBYDmIhlOEJWU5AxfUHZXtkUyGW77nTQkOY4C3ypkxDRdu800Pvr6zNPeWBk21k6jqADjWFRbUYhi2ec0yeqEGDWcVnmYKnJI/w0ts0Dwo6B8PwCZlL3p4NWLO7lzrsF9PiThD/aaNKac2G/c88WE2zC16u5XxJLzG5HocBG7ro1RpqnPNkbAUXKFQqaM34FXkth2VnUJA/l1O5eQarP1i9fWa4XvromjPmpv6TkNOoN8cj4ho3KIXiO4gHSduMYZAcuNaKEHNR4sMUUKOMpwOAkdhnNqN8fEE7dZETffjq54Is002wVpTUR7HQWb2bB9oaSN/u9CLS07s2oiABTg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM6PR11MB3723.namprd11.prod.outlook.com (2603:10b6:5:13f::25) by BN7PR11MB2531.namprd11.prod.outlook.com (2603:10b6:406:ba::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5038.14; Tue, 8 Mar 2022 08:08:01 +0000 Received: from DM6PR11MB3723.namprd11.prod.outlook.com ([fe80::8ce5:e41c:9de6:d027]) by DM6PR11MB3723.namprd11.prod.outlook.com ([fe80::8ce5:e41c:9de6:d027%3]) with mapi id 15.20.5038.027; Tue, 8 Mar 2022 08:08:01 +0000 From: "Guo, Junfeng" To: Thomas Monjalon , "Wu, Jingjing" CC: "dev@dpdk.org" , "stable@dpdk.org" Subject: RE: [PATCH] raw/ntb: add check for DB intr handler registering Thread-Topic: [PATCH] raw/ntb: add check for DB intr handler registering Thread-Index: AQHYHkeIGlhboD3sRUCfkNnaxcjhEKyMXG2AgAABJgCAADo6EIAntyuAgAD5xUA= Date: Tue, 8 Mar 2022 08:08:01 +0000 Message-ID: References: <20220210062841.646294-1-junfeng.guo@intel.com> <7235133.6fTUFtlzNn@thomas> In-Reply-To: <7235133.6fTUFtlzNn@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.401.20 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 35e4a232-bb88-43cb-16ba-08da00dac419 x-ms-traffictypediagnostic: BN7PR11MB2531:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: KZfFTuHgS8JSSZw+K72ijyRm6qb7vPrp+dH+2Xr0Flo15nOHkDcwM4433dFUKVa97L9LaMk8qqtn74or23nL315TX7ZCcyq3CC6UTBmceukkShUOTQ6+bZEh5HDe1SeSrMly3uotOQufjaf3cHt02zToWpkEISpWfx21GTCd6m8vtWdoRrpSr2M0fS/KL1qmcqt2kOpbP2MX57Eet8tXmoVsXt2M0VIH8IfLva3uQxzPcle3KCW1un+0IIm7OyX7eDQY2x5FtuR2vjull2v82veOgEebEMI7QhkRjpXj2ogRZj41LGY7Ql2hhzwFYETKc0A06TlFRCCGG6tajIXWYuSC0c9qQClaqHlD/ue4qCJ9MYkxFCxaPDTmnqsD8l1NJBaNW8yWCDw6ZlMr5CgUCEYxObrIR0m5ESWHMFiZR+fYiG22XyYzAhvWORNcK9COUFy7um+hkWMuqN1TowI6rF2hLmhgydevdVTHoN3XI/d0G2FmBtVMxYQQEFgcYgeXx5FrOXQeHNDA+S+1lXURIGya5ODDh3uw8wQGO+KvJwI7VQHqg45KxLPI9GR/PnkGqFbciqCB5UCj1Ww7OzPhV1hEmmId/QPGtxrNip1PO1nJRVueKWRbYL+B0Pfg4x5swsyOuiuqWg4fm/zqPQ9p7K7g3f2AkdT8qCxKfGUrCWqAaS+895kiFIqjMPXgtQXOVPLHAhJ4RTSQSNa8MhUUGg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB3723.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(86362001)(5660300002)(6506007)(7696005)(53546011)(33656002)(52536014)(8936002)(508600001)(9686003)(2906002)(76116006)(186003)(26005)(4326008)(64756008)(66476007)(8676002)(66446008)(66556008)(38100700002)(110136005)(38070700005)(82960400001)(122000001)(55016003)(66946007)(316002)(71200400001)(54906003)(83380400001)(6636002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?KUOMprFjymeBJVpEnn1Q7EUV3zRdATar1s0WtmXuNe/toL/jqjQV9Bkb8qYV?= =?us-ascii?Q?yFG3b0pzJyGtmofV+HxGn8KmFPp1LEwtf1mitucKVWpVsx4x/TOFKz1TWbD7?= =?us-ascii?Q?Mzb+8Iz9K3iE3mu4Y5/KZBUTnZNU3rJ/XFR1mFEf0Q5PsRQ3ybngl6186Ba8?= =?us-ascii?Q?Vl74PT/bk0ZFYsqmnznekjpuEZixOHwlX8kfPZimyBqWACdwxrnbonkUgLUd?= =?us-ascii?Q?mouHI+HY9qTw2wRPu5ETwMwCLTsc1L/1NUJ8hGinFUg2lbI7K+3iLPG/Vjz0?= =?us-ascii?Q?smYlLpG11M9GBtIiS6XfJFKms6cGHgDwZ665xPd3ERX2i2a29vyoYex9SJT8?= =?us-ascii?Q?965f7kP8XmgediVOhJPUqfQWXKb/FOwFPINd/YU+IBD8qZ3ySvTMiWpQHPLI?= =?us-ascii?Q?UVpoEtDrmjIGm0rfUXq6JukkyuOaCuIAfR5N+tvHil/b4YPto5H2nPfYGcl3?= =?us-ascii?Q?/Xfe2ovuXUAHmRqbXUKbO6rUi6o2sFjLQuDe8pf9QANoCFmv4bUNLj+HxWbd?= =?us-ascii?Q?79JaBR4wkG+xVY7rg1P7sWRGb0i1rvVJDUL/3MI4YJh07UJPZiImzeZjJrQP?= =?us-ascii?Q?mn7gm7zaFTEeMsgp6T/Dj+Dz+69xZ5qLVtp49xw1igkQ4Ibk82tc6iLPWDAD?= =?us-ascii?Q?PhM4+sJGWdobUlzPrcZ1WNWd7KKe6xdOmpSD0PCcTgpnm9K+hKVSJDhiQFaX?= =?us-ascii?Q?Aw0QAE3L16mjK+lV8tywtHricHTKjBYoiHG3/KJcIftyFe/HXaxfumugmz4V?= =?us-ascii?Q?H/zZBE9xTRLZdh284tJH7PAEk54kvy9DK/VoDQgEl+mlxHxQo7G+9ogOChuV?= =?us-ascii?Q?gWbfVt6DZJyMEtOiSUHCY3QtiOTmaajm0frrcM4UpngIOoiL5zQzvo9caM/6?= =?us-ascii?Q?9Gh/EgYz2knBTs4A8IMI+OI/43MSB8EPE2HYtiXfZl1amBMpDEqUBUHwZS6/?= =?us-ascii?Q?vgov0fvhJdxpJUHq8kGW62sS0dRiOWxIcaHn0dpjlIEbWZoctnyTz+p9Sm/Y?= =?us-ascii?Q?/gFIXieNDrznftkD062ZwU7+9Awh6U7kyJl3mqAnDpGv+Wn5ehFW21ElceIT?= =?us-ascii?Q?BsiKl7A8HDswGDdNzN+6MOjE1kLovcoujMcb3u4skcSaZNZOAkoioB7qr3mI?= =?us-ascii?Q?fpNVM1r+dX5HZaB6sBjbbJDlUFjAE5YFo7/Jk+eg9QWHProbLd27RGc+p16T?= =?us-ascii?Q?zmOp9h1ZwG9nAK+vE/Zdv5WFa+edbdHyWI/hTTxoJH+fGVUt6D/CUtdRdB9F?= =?us-ascii?Q?rzvDR9IMhnI22GOX+ZcXS3gjTWLHqngnLK6l+7vKsLFaZXKvgHKWExvipPu4?= =?us-ascii?Q?klrVw0XggjKIOdg375XtXgXQAWfsucSa4zymb7xlyDrhLq1mnNIqliiiqOzy?= =?us-ascii?Q?rs2neTObcMwq28IqNjZHadNef4iBAwtF8YIgVrWzYjW373asYDplHC7hRd36?= =?us-ascii?Q?Ycexa2Nzjk9kGycNH9LwWh6LAiTGJVsIkYjSRMGKhS6DuoE0T67bSi9vBCFI?= =?us-ascii?Q?B0zOWrBuMkJUUFuoJjFnywhEe1KzHRIe/Wy0075hbFDxXb5/C4MnlqscWfbM?= =?us-ascii?Q?6Il5j0swKCHGOXdW5O2zb93OV2w/kU5mdXNs4rv7a4YhTSNLYWIU6RHBWjTe?= =?us-ascii?Q?vg=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3723.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 35e4a232-bb88-43cb-16ba-08da00dac419 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Mar 2022 08:08:01.8258 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 9pLeSpIa9IL9tnE2EfR2Rajc4A/QoTdHc6MPLynMxF0SmcC3v/n0oEny9vtOXlTJO9+NkOugdMKuTnwbmf/34w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR11MB2531 X-OriginatorOrg: intel.com X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org > -----Original Message----- > From: Thomas Monjalon > Sent: Tuesday, March 8, 2022 01:07 > To: Wu, Jingjing ; Guo, Junfeng > > Cc: dev@dpdk.org; stable@dpdk.org > Subject: Re: [PATCH] raw/ntb: add check for DB intr handler registering >=20 > 10/02/2022 11:43, Guo, Junfeng: > > > > > -----Original Message----- > > > From: Guo, Junfeng > > > Sent: Thursday, February 10, 2022 15:18 > > > To: Wu, Jingjing > > > Cc: dev@dpdk.org; stable@dpdk.org > > > Subject: RE: [PATCH] raw/ntb: add check for DB intr handler > registering > > > > > > > > > > > > > -----Original Message----- > > > > From: Wu, Jingjing > > > > Sent: Thursday, February 10, 2022 15:05 > > > > To: Guo, Junfeng > > > > Cc: dev@dpdk.org; stable@dpdk.org > > > > Subject: RE: [PATCH] raw/ntb: add check for DB intr handler > registering > > > > > > > > > > > > > > > > > -----Original Message----- > > > > > From: Guo, Junfeng > > > > > Sent: Thursday, February 10, 2022 2:29 PM > > > > > To: Wu, Jingjing > > > > > Cc: dev@dpdk.org; stable@dpdk.org; Guo, Junfeng > > > > > > > > > Subject: [PATCH] raw/ntb: add check for DB intr handler > registering > > > > > > > > > > The callback registering of doorbell interrupt handler should be > > > > > finished before enabling the interrupt event fd. Thus add the ret= urn > > > > > value check for this callback registering. > > > > > > > > > > Fixes: 62012a76811e ("raw/ntb: add handshake process") > > > > > Cc: stable@dpdk.org > > > > > > > > > > Signed-off-by: Junfeng Guo > > > > > --- > > > > > drivers/raw/ntb/ntb.c | 8 ++++++-- > > > > > 1 file changed, 6 insertions(+), 2 deletions(-) > > > > > > > > > > diff --git a/drivers/raw/ntb/ntb.c b/drivers/raw/ntb/ntb.c > > > > > index cc611dfbb9..0801e6d1ae 100644 > > > > > --- a/drivers/raw/ntb/ntb.c > > > > > +++ b/drivers/raw/ntb/ntb.c > > > > > @@ -1403,8 +1403,12 @@ ntb_init_hw(struct rte_rawdev *dev, > > > struct > > > > rte_pci_device > > > > > *pci_dev) > > > > > > > > > > intr_handle =3D pci_dev->intr_handle; > > > > > /* Register callback func to eal lib */ > > > > > - rte_intr_callback_register(intr_handle, > > > > > - ntb_dev_intr_handler, dev); > > > > > + ret =3D rte_intr_callback_register(intr_handle, > > > > > + ntb_dev_intr_handler, > dev); > > > > > + if (ret) { > > > > > + NTB_LOG(ERR, "Unable to register doorbell intr > > > > handler."); > > > > > + return ret; > > > > > + } > > > > When will this register failure happen? Have you checked what is th= e > > > root > > > > cause? > > > > > > When bind with vfio-pci, the DB interrupt callback function often > cannot > > > work as expected. > > > I think this is due to that, the intr callback registering not finish= ed > before > > > event fd enabled. > > > Add the check of the return value here can make sure about correct > > > processing sequence. > > > > I think some compiler optimization would lead to this condition. > > So add return value check can prevent this (i.e., registering not finis= hed). >=20 > There is no formal ack. What is the status of this patch? >=20 Thanks for the reminding! Currently, we agreed that this fix is not for the root cause of no response= of doorbell interrupt when building the connection between two NTB ports. So we decided= to change the status to be superseded and do further investigation for NTB. Thanks for the reviewing! >=20 >=20