From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 76B76A034D for ; Thu, 10 Feb 2022 08:18:19 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6979D41169; Thu, 10 Feb 2022 08:18:19 +0100 (CET) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mails.dpdk.org (Postfix) with ESMTP id C879340041; Thu, 10 Feb 2022 08:18:16 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1644477497; x=1676013497; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=yKVvpzoWDYE0WiGSTNBU8+h6TxI4h2uBbIVgdQJIRVQ=; b=XHl6KESUqiQi5MuQuzDr0b5Q9v1DYll3yTKLWbU2FPB/0mi2QmmC6kjh F0mLZ7FquKraYWamgQJf8nNLcAMX+qrTmedA+XmbVlqSLhNGKnfTK52yc JtvQeANijJuREf3JzbcGGyqam0jiE6APXqqMBafPu8j8GxkWxFyckCuEl TXnP6LdYSx05mQNzfeU820ALUhD2VSjRrmAvB8TF2dJVZ88NDG4hvJKk3 5JnqmVsgqnKHqUbiQgW8JEBcNHpTF1hIz8I+03JPIgrsur4Avq+M+NwDj BO8Mc5hgMXR2mwbqFnBiThGBArQZUe63EBpFHgAHZYUKLd74LITcEWyXs g==; X-IronPort-AV: E=McAfee;i="6200,9189,10253"; a="249374535" X-IronPort-AV: E=Sophos;i="5.88,358,1635231600"; d="scan'208";a="249374535" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga103.jf.intel.com with ESMTP; 09 Feb 2022 23:18:14 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,358,1635231600"; d="scan'208";a="541492669" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orsmga008.jf.intel.com with ESMTP; 09 Feb 2022 23:18:13 -0800 Received: from orsmsx604.amr.corp.intel.com (10.22.229.17) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Wed, 9 Feb 2022 23:18:13 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Wed, 9 Feb 2022 23:18:13 -0800 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.106) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Wed, 9 Feb 2022 23:18:13 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WQFSxhd6h8OJvt0PubTaxD+GQa9kLB4mD66+8qgn76zSqORs6030cgQ4plJLU/NS55e48SPhuCRkf0iL5twdy0FgDoWriSZch4hD35W70zPOoAx+cevuFFvnsCMKDycJt4JGJ3bfdMMxYBokF55R5XDAJa/qNM5KxskTlg4udrJ7H0TdrtrGiBx4JxX6/XaGJsTyyi0ZwQfOA3wNZV9QPwS68zZtMi7jCRLiRy+/gF+Dr9k1+5rwZ9BkVYPi6Kym7qSLMKku6fmwoZXXX/k7do9i0IEax7QILuWaOy7FnH+RNof96mh+cICFEU0vo/VHikRiZwUR4PtvzNxyTsE7NA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mr8Qbd6zaJByIxPqt8dzwoKy/5Vi5ellBt2sTpE0GtM=; b=NrQFgkKcigO35mzn3QQ0Dkix47QDm8VtKIvYnyk3MJAJfLeGWwKT4pXFJfxIL1xBCjz1grzh4BntclBt/8R0jZdLFbFvRtIf//mMVb+VxiLmv+MUc8cYd7qv5EuMz6NpMSCxRn8Xhe5M23QssbziZ6tURiCltnzNf0KR2SgqD+/tgsTkVBiks3DeJ22ZkDKSUZvNhKbc+CxkHrfkwKaXFZISQesOnbd+iyN2N0UebMJ6xMnF4W9B1oQ2Us4cXqBb5DEAPNbYpw4+T1s7bWFgIAXFSmM0Jm1x/RhkCRS9MKch801rxAAcCdX0ElApRxajMAoEKmlqah7Ttj9JMShQcw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from DM6PR11MB3723.namprd11.prod.outlook.com (2603:10b6:5:13f::25) by DM5PR11MB1723.namprd11.prod.outlook.com (2603:10b6:3:14::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.14; Thu, 10 Feb 2022 07:18:05 +0000 Received: from DM6PR11MB3723.namprd11.prod.outlook.com ([fe80::2821:b80d:b05c:1682]) by DM6PR11MB3723.namprd11.prod.outlook.com ([fe80::2821:b80d:b05c:1682%5]) with mapi id 15.20.4951.019; Thu, 10 Feb 2022 07:18:05 +0000 From: "Guo, Junfeng" To: "Wu, Jingjing" CC: "dev@dpdk.org" , "stable@dpdk.org" Subject: RE: [PATCH] raw/ntb: add check for DB intr handler registering Thread-Topic: [PATCH] raw/ntb: add check for DB intr handler registering Thread-Index: AQHYHkeIGlhboD3sRUCfkNnaxcjhEKyMXG2AgAABJgA= Date: Thu, 10 Feb 2022 07:18:05 +0000 Message-ID: References: <20220210062841.646294-1-junfeng.guo@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.200.16 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f3bf067f-db09-4c2d-9812-08d9ec657b84 x-ms-traffictypediagnostic: DM5PR11MB1723:EE_ x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7219; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: a9qUqqnb55FNaspnS520pc7xQHqUIYuIJpCejXtOPtpW1me/3O+Qi3rn0z9iG7mVycVK7wY29RUK4rJiq2SfqJc1ITA4eWo8jlSv7QCAx0uKJCyQcYD3DfTPheJH537Cua0JJ7EmzEpnQz7ZofBQGXIJcyO53xsXXu/7bxw8tGhCMW5ChgcLjNOci0k2odEGW2MM7pS6YByUjQ8KlD9Zm01nHvYdbdjYuEogyvHNjRMiU0Cn5IAjO1W/PG4L2GoPZrfrdiXkB/4dQyADE3ztQJKRz04FiRETHBYKqpZP+zqz5IrNYIyGGJpnazdrg+JICgG7JNEpBr+zOfr5PO1/++1Xe5pVhO1Ki2gyZ0g/8oHNldqPKi5HgFqrOzWoTL3gP4TQCrrg8DJ7wwHQQ3UJuk4EoQEDghjVdweOUAWq7LRNP6Vp/u0nRn1eHCCiZrH7Sgh5BUs03rYmak4Q17iyMgktW82UHHRLbn9QmUOfnwX8Z4hErHXCnnZQKI74YR0S+hPTEdN/edgLFpRnEh5yvo8YNKSF7fJhajuebffUXjVUNdzC70wO55fCpwA/TALyEJU/LkHsGDSMjCnGA3X7UyymbWOfHtazK4lIzopgauT0sXglp+4Z9MhKPx4oEw9hYinFF+8ZJ1VPYSJFvkUXGIGnrEAupOeAknz7nRqRUMRYY/NIl17IU/llqKvZXUaiskOJlcfXWaCnmcAyRgH3fw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB3723.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(9686003)(7696005)(6506007)(83380400001)(450100002)(71200400001)(186003)(8936002)(508600001)(26005)(4326008)(86362001)(5660300002)(52536014)(33656002)(8676002)(53546011)(82960400001)(38100700002)(316002)(2906002)(76116006)(66556008)(54906003)(122000001)(6636002)(66946007)(64756008)(66446008)(66476007)(38070700005)(55016003)(6862004); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ilXi96J8qPe3KH3H8eTE8wb8pSRezymxyBkw6085dHN6vfx9/0br6cKjTQRI?= =?us-ascii?Q?lcEwIRD//AAzP6xmzE0bwPz4lrY+j/Ie3S3iu7dV23SF8ta55kcEpHk70wdr?= =?us-ascii?Q?6p2nvfwki+XaonZ1NU69nYYkXBkZ8h2vEPg4nxyQIYJzRbcH3I4PnuHstfZh?= =?us-ascii?Q?9j+5rB5ersqTmGYczhd7qtawKYA/E+n5ZFGFZ61pVFHZE+MNoR2p3tokh6J/?= =?us-ascii?Q?yluGgvXvQfPBdFQ55qTnmZmzADnGMmfzxPwGqem0JPwP5lp3nwdOcaf++AUz?= =?us-ascii?Q?KLyszkisSsncoXDgN0HQObH9hoGtU4eadt6m0kDwRcnIRShqoImQJhr34jPl?= =?us-ascii?Q?XbkYN2LOty7/vXacYDCVf15bCaGkiinrE0mLPyu35xlH//6kKBxnhdraZe//?= =?us-ascii?Q?UiTpb0328x7vYfLz9gYdS6oNEnPhDpS7inJ+FpFWtl3by/Ex29oj1GWLr02w?= =?us-ascii?Q?hxtR5fpcj6zdGRl6X89FlzMbCIs9wpQ0vFFYBO8g8EmfB+wdF1X4CL7aRiAM?= =?us-ascii?Q?Egc1HjTBb+tnOWlsKmGrqd+mOGgdMIgJLRrNFIfBWWi9PA+xh1yETPsRgONY?= =?us-ascii?Q?3Cu0XPRBR9MuhaoPKhTzBrnHhVO7l14JfxubAVuPm+Rcms2bCd3S3yECOOUc?= =?us-ascii?Q?RlswNhREMcFnPU7J+8CE5nVo9GaH8YzaH8xu7jDCdF6asRdBG7PW25wpWbab?= =?us-ascii?Q?njEAMxFuF9AqjqnmOXurWaJRUSVTkN88fbxG2AZXS6Srlzq15/Hpm+hoszH7?= =?us-ascii?Q?rO78oU7+RKipyoUKAi+1jCHE1HEjprWif78o4EUKBszw4RrhQNjFmn0xqkYM?= =?us-ascii?Q?XMSeLtbV+UVicAbGEIVJcopXjaK2ChEddNp2+vlpTXFvudE0aph2EJdNneQL?= =?us-ascii?Q?USnz1gUJQdEne+Fc+8Bt9F9LbHrcG4QuTqiEDn9MTUeD9VsLvHPQWjkt97AS?= =?us-ascii?Q?XsL63Cg97jSuy1w+2rZKOzzu7R+qEcuC8p0YMWTmgH9SKsxAOaNfUF+XPE4x?= =?us-ascii?Q?8tfLxEMkYVJx++nfGGmA7RcOLjsVOCU1ZiUxSE2aN/kTSMoaWRvBpfhwEqf5?= =?us-ascii?Q?FRtbl4lkrZuvHVzbv/EAzlEKCM9t67BV4XvzPqulzVjDnwj6taGMR9xHkKHw?= =?us-ascii?Q?kIReckBg45sSN8y17fn36cLc+pq6AtB2aN0MQE6GEzEnUTORoHcMFIeCzR0I?= =?us-ascii?Q?hv5OXVj9LvBWceO8v0modCCrSN/h3HFr+4VI1K3oNNcVTrILkMUN5I1GM0TZ?= =?us-ascii?Q?pRJl/jKTXgb6SdM4IvV77+SrvUw+RabpltHh/FF1lEmyglWT5yQ/SDWZR9E5?= =?us-ascii?Q?FJ4iNs8DBe7ocf/y7BL68KVmppQyevnYugwxMj3Nj+W7OCHyEsliUVxOzhZK?= =?us-ascii?Q?4EJ8llOodTXz0mboe/Sn2AauFAf907+XI9iYLQGHj58TamovE8aM7wTrfi0T?= =?us-ascii?Q?M8KXcXCQ3LPFcZlpSwKaGgOuf4of0b57hFqLBmmk68Dgj+sZvs317K0y8Iyc?= =?us-ascii?Q?zwaoOiSX2+ESEtv7CpIcIB3pg++yi1dGNQ8BC723L/MtUx/+dYJRqKXMmLzt?= =?us-ascii?Q?rBHc3S0La7pJ3ZBKnC4dvS+Fb92wNlGtPAvmZZCKd916euKAJWByHHjFitz+?= =?us-ascii?Q?WQSBWhhtwu18yDHbFlk/UXQ=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3723.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f3bf067f-db09-4c2d-9812-08d9ec657b84 X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Feb 2022 07:18:05.7462 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Bi6pRYLvBT9KTkAHR4U8vTJzf2Bq6thOklezLH2p3wR792VcFSbOP003n507mVomhHYjpe7hLOr23OD+ruqhMA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR11MB1723 X-OriginatorOrg: intel.com X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org > -----Original Message----- > From: Wu, Jingjing > Sent: Thursday, February 10, 2022 15:05 > To: Guo, Junfeng > Cc: dev@dpdk.org; stable@dpdk.org > Subject: RE: [PATCH] raw/ntb: add check for DB intr handler registering >=20 >=20 >=20 > > -----Original Message----- > > From: Guo, Junfeng > > Sent: Thursday, February 10, 2022 2:29 PM > > To: Wu, Jingjing > > Cc: dev@dpdk.org; stable@dpdk.org; Guo, Junfeng > > > Subject: [PATCH] raw/ntb: add check for DB intr handler registering > > > > The callback registering of doorbell interrupt handler should be > > finished before enabling the interrupt event fd. Thus add the return > > value check for this callback registering. > > > > Fixes: 62012a76811e ("raw/ntb: add handshake process") > > Cc: stable@dpdk.org > > > > Signed-off-by: Junfeng Guo > > --- > > drivers/raw/ntb/ntb.c | 8 ++++++-- > > 1 file changed, 6 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/raw/ntb/ntb.c b/drivers/raw/ntb/ntb.c > > index cc611dfbb9..0801e6d1ae 100644 > > --- a/drivers/raw/ntb/ntb.c > > +++ b/drivers/raw/ntb/ntb.c > > @@ -1403,8 +1403,12 @@ ntb_init_hw(struct rte_rawdev *dev, struct > rte_pci_device > > *pci_dev) > > > > intr_handle =3D pci_dev->intr_handle; > > /* Register callback func to eal lib */ > > - rte_intr_callback_register(intr_handle, > > - ntb_dev_intr_handler, dev); > > + ret =3D rte_intr_callback_register(intr_handle, > > + ntb_dev_intr_handler, dev); > > + if (ret) { > > + NTB_LOG(ERR, "Unable to register doorbell intr > handler."); > > + return ret; > > + } > When will this register failure happen? Have you checked what is the root > cause? When bind with vfio-pci, the DB interrupt callback function often cannot wo= rk as expected. I think this is due to that, the intr callback registering not finished bef= ore event fd enabled. Add the check of the return value here can make sure about correct processi= ng sequence. >=20 > > > > ret =3D rte_intr_efd_enable(intr_handle, hw->db_cnt); > > if (ret) > Need roll back, such as rte_intr_callback_unregister is required when fai= l > or driver remove? > > -- > > 2.25.1