From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E903C42640 for ; Tue, 26 Sep 2023 09:04:55 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DB463402F0; Tue, 26 Sep 2023 09:04:55 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.126]) by mails.dpdk.org (Postfix) with ESMTP id 741CE40277; Tue, 26 Sep 2023 09:04:50 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1695711893; x=1727247893; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=dkIakPtEjQb7ZXvF85TK2+UES228OuFjzHMgYR3Lsqs=; b=jfVXdydwYI4C39mN6tm4QZXfUUiRZNgeCpBsCVVX52oKNz0kjRPVfi30 OmB9SEehNSsYbWk7+xtelbjfmkIgho1YHGdwF89HjhLSan83f/jwU7j2o WvHCI3VH6WVCtNAMaqN9ygtw0nDWaGj0yMVoV6U5LhIA5rxY2gNMWF6EN WWxq2b7yHwx2LgsJEdnhWLQp0n2X4Es7O4OtIo8dKSagZ4NYen3bAS+ql LC4gd+gmPAUoSdM0n3f3KR06dDS8ll5vMqygjeSoA8F/HVx/tg+9y3o1z zE9tYQgpaBNdEquP2+kXWLuPMUXqUiGrElI3vFZQf5v8Ewb/KVM02mN3y A==; X-IronPort-AV: E=McAfee;i="6600,9927,10843"; a="366561170" X-IronPort-AV: E=Sophos;i="6.03,177,1694761200"; d="scan'208";a="366561170" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Sep 2023 00:04:12 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10843"; a="783849559" X-IronPort-AV: E=Sophos;i="6.03,177,1694761200"; d="scan'208";a="783849559" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga001.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 26 Sep 2023 00:04:11 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32; Tue, 26 Sep 2023 00:04:10 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32 via Frontend Transport; Tue, 26 Sep 2023 00:04:10 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.44) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.32; Tue, 26 Sep 2023 00:04:10 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kKjXKTkfpM40miwTKJmCMMsr1DBTgReMwOT986lQbsiBlbepOZ64ZPDhtXrTxrw90pcKlF54+/4GJxrchr3uI1QRNVAWGjmpYaWjQLEhAryQpU+Ox7buSebn6Bgpwic/xBT5+7132q/jlAslFUwWt+9qIxXVN1gA96C/OQu7kKW3OefAhW1Qgyrn1p8fbXzMH31sfW3cDP9e+SnoMopfWRjX/FJwB8TuUSnFFVUKWYWEAtIQjR8lUaYIWwvMsQLUZVthLzaxLJqlCxuWrWRmsT+hcu1ScaSHyVAXDVCxBmnIlX6+KdSZG/mKDcDHdR4n2FbOKZZHTOzl8EVvPdLMUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xvAOGvvwoQBL0f1UlywzWb0x1Vpvx9tMdjkNLjUlUTw=; b=j/YG6QQqWhN/Fb2t4oC+oHDHG+EKLyELmQrH4K+oaxfCzsRckurSryELVCZD9jE5A/+PGSokNt4xb/OoYUPiLlIeFDUmHT6G3FNLrrhJXNaGXGaQmusrczyke32hD6CsjupxR5+V3C2viHH3AxTzfh+QKWhmzHAzQ7w2gcjZvFh6Kr2Wp0JPpZmj8BfPe3GPRgfTnBbEzyAVOAYRH6J1cr5ZjeERUaJHkUzwNHirMfjW4IDnJ9Q0eObcGdjcgBJuDNbZNVL0mz744S2NXgarTRydx4plQUV28RCXlUaHjLg8ALyqqfrY7wpRYaI/7Nwi9DtPXMCB89fvYfVqrG2IyA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM6PR11MB3868.namprd11.prod.outlook.com (2603:10b6:5:19f::13) by MW3PR11MB4603.namprd11.prod.outlook.com (2603:10b6:303:5e::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6813.32; Tue, 26 Sep 2023 07:04:09 +0000 Received: from DM6PR11MB3868.namprd11.prod.outlook.com ([fe80::ea65:2100:3091:875a]) by DM6PR11MB3868.namprd11.prod.outlook.com ([fe80::ea65:2100:3091:875a%7]) with mapi id 15.20.6813.027; Tue, 26 Sep 2023 07:04:08 +0000 From: "Naga Harish K, S V" To: Rahul Bhansali , "dev@dpdk.org" , Jerin Jacob , "Kundapura, Ganapati" CC: "stable@dpdk.org" Subject: RE: [PATCH v3] eventdev/eth_rx: fix timestamp field register in mbuf Thread-Topic: [PATCH v3] eventdev/eth_rx: fix timestamp field register in mbuf Thread-Index: AQHZ6+JSz75ZV/mIbUagmmBTYfoMfbAstZkg Date: Tue, 26 Sep 2023 07:04:08 +0000 Message-ID: References: <20230918082553.704859-1-rbhansali@marvell.com> <20230920164823.1164930-1-rbhansali@marvell.com> In-Reply-To: <20230920164823.1164930-1-rbhansali@marvell.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM6PR11MB3868:EE_|MW3PR11MB4603:EE_ x-ms-office365-filtering-correlation-id: a2254160-ff67-4fb7-36b5-08dbbe5ec751 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: XkuXAbBCAavYFpH9dfipyp3Sk1q3CZMvedMW2xWmDJHMu62ziyWdQYfjo4yEuDARD2WIJVlr/N7Zhe1QcCgU5GKCXe5vANwBccCxb/dKpdrnuPm89u9dL5ax5AEMD+3RlHYJGmkMvxpOA9UynVpWqlz+pvF1r4mFqHpV5WD1cDJ1Kh3P3zGWyATXrkcRU1UdgaBHh0kF8RAJSQBOzzoB/TnhPqeczXs2AtM8s30F9iCK8NYnmAb3VvVYqwOFObIprfC8YQP4pRCBi6Mf66w/Dql00/6tH9G38qSSQCoxxajIC6TbbWbIJv4PZmIXRAaKatIVRFlwG5oo0KIx7Olp2BTws1KR7syWsyyslv8CDJor1nAIVHo3vFVBbZVwsyYwFp1EhR5e5NgR6tOaKQRDbMGDZZsPTvMn7g3FgsU2+wQVAoVDYyr4NNrsK4eY2MfnTth9np4g3j1dAIRl/4x6ruPpj+dlxHd4YqWlQbSlOem1Y+1gp5tuTwBTaJNIgdhXNZsvC5dlh3MpJtVF9ob9nF6+UC50i5VdcrfqFtJC022diXnxJ626ibA407xhpUPqpVPby0m3H2rSpC+l1zylsWaksNs7QvvgOf4xf4E0womzNFWWCJYPgPa86qRyQlKV x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB3868.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376002)(366004)(346002)(396003)(39860400002)(136003)(230922051799003)(451199024)(1800799009)(186009)(38070700005)(82960400001)(122000001)(38100700002)(86362001)(33656002)(7696005)(6506007)(53546011)(9686003)(2906002)(478600001)(5660300002)(4326008)(52536014)(110136005)(76116006)(41300700001)(71200400001)(8676002)(8936002)(55016003)(66946007)(83380400001)(66556008)(66476007)(66446008)(6636002)(316002)(64756008)(26005); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?e3X977ueEou/omu40Q+pxjOvwz0kGt8xT4uyAuBsuayOIvCQi3NFwMOZbt8y?= =?us-ascii?Q?Hax/8ljn/YvI0RNhCyqEoJsDWRhd5zsNQ3r/NWTE3PS1xyYya52ztojYq1q5?= =?us-ascii?Q?B/1WXZSdtMmBqcmQ1WIxhrc1Wnv72CbO7bDk3maiMKeLTa+yVDTh4dO1+jF7?= =?us-ascii?Q?L+8z4LIZvlrmGCMJhOFNnymMsCZ58MvhWKj+VIWhpVGiWxjUhh2lzL7dcf0H?= =?us-ascii?Q?EmbPzF/gk+bEwsDLWAo7vher5BOyUWTunTUO+MTi/3REyXhUrxfC71LUmPMv?= =?us-ascii?Q?1YSQqqRrVRWVIgLItW0zvRi402nqesaqV2vJux09UXEI+W0fdsoTJqnQDRrW?= =?us-ascii?Q?aYaQrwS3/bpsVULFWT/2mBu3JImEvCcozqG3cJHJeIcHPcB44vWyzGHX5ZHV?= =?us-ascii?Q?maRtjZ6eAAwdxlJNiUgV3nXkxB5GM+rijIqLyu3KEZf+pUf51RQAeamOSDSf?= =?us-ascii?Q?JS41BYqz87Lr5vTaTE79Am7zSzMo9KHLTN3UaMl0ikhcopC7ThmibbupzcOF?= =?us-ascii?Q?7TUlFmUFooakg99DPVNYrQHPcAtGDWecDjRT2tuu88tvGh/vttHfO/9hm89h?= =?us-ascii?Q?pNa112j3X18rp317w+hRyartSG0e0gabXLdB6bG6lsGCSAvlM8HSCaSYSJ2x?= =?us-ascii?Q?yYOS4cW5m0YpMr8wUl4nJ/ky5V75mhWjjmw5XjUrkrfyS28DtG5iaK2vHBYA?= =?us-ascii?Q?qAUGB8Ddnf1tfQLiSkdf3HIodfzEanI6mSlxtVrOANPwuFv+CbCe3wnhOViR?= =?us-ascii?Q?j39oKbz7jMpKVr4Wp24B0iCAg8ISbltzr1fxDwDMb4dbkeLt5YEbR9bU9W2W?= =?us-ascii?Q?BW4B1xM3fyC+DQmT7QHaVXQqLuELeMw/u31PpBcFCJCakknVBgcjPuOTXoBc?= =?us-ascii?Q?aOK1UQ73WKSQ20xiODnwP/YgMi/IcJwZV0D2BbPYqf2IxOTayGP+pbigjx1t?= =?us-ascii?Q?3HzlbjwMJtvtOWdxEZGbLY29kruekD1HP4N33DCMJp9WYNdjTsGaawyEJF0v?= =?us-ascii?Q?mT06DWe0U71o8d3TCWIF7igQfMAQ5vdHUpXkE2SuSq+2k6Y9rQgrlwPrum9U?= =?us-ascii?Q?aPwPvvFljoKjloEFrRYW7OJ/9jbB9CpLjNWfMaZNc0CSJN34RMr49+R8tvuO?= =?us-ascii?Q?xlYoaCfZyzXu8ZRPXffD5KbhiXPVnR0OTyPXC7qggvdHccEpZRX/PfhYteX6?= =?us-ascii?Q?jFEmO9fIdDYr1PnTjGsw6mKWojKpE5xkgPYa0k8Ea3G+362C8/1kOZ49gs8s?= =?us-ascii?Q?6TqKAE2kySFZh8otD1MzxUirQzUIsUqwZ9A+NcOeGf9KiJeW9JduqENlKGIL?= =?us-ascii?Q?zNk/0HuyszZtntdSMIIEO+PRfo9kcNRqb6QnBoYgALZeIIaQ80oCwU+2jC4S?= =?us-ascii?Q?e7/296a86TURKMeyFKb717My5IHcQ/lYIm6kPB30RcIJhMaDbTJWcLRVxuRW?= =?us-ascii?Q?PLdhniel7LGPOd061K7etkGZN4qkQ23YAVzxViRx2plUo1+ZSDwONGoVQ8Hi?= =?us-ascii?Q?TTTCrcXkTZjwROZDmcsukJ5Mp7HgHWy9+ESwYk9AwQoAlVswVHRjYoENFE/Q?= =?us-ascii?Q?Vc3odgdyibmUF2qnq+8cbG9lAdFt3/emR0482S8kDx+Eos679uT5+1sR4XhS?= =?us-ascii?Q?uw=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3868.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a2254160-ff67-4fb7-36b5-08dbbe5ec751 X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Sep 2023 07:04:08.2903 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: csSBZnhE5e+In/sexSTrA42u+im1x3skptVzDgF8kJCxXvTbK2ZuB8sbtccL/Pe/CxS3a0OdBKZ/hOv1sdYXvKcICNJiYtvzH3jBsKKTCS0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR11MB4603 X-OriginatorOrg: intel.com X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org > -----Original Message----- > From: Rahul Bhansali > Sent: Wednesday, September 20, 2023 10:18 PM > To: dev@dpdk.org; Naga Harish K, S V ; Jerin > Jacob ; Kundapura, Ganapati > > Cc: Rahul Bhansali ; stable@dpdk.org > Subject: [PATCH v3] eventdev/eth_rx: fix timestamp field register in mbuf >=20 > For eventdev internal port, timestamp dynamic field registration in mbuf = is not > required as that will be done from net device. > For SW eventdev, Rx timestamp field registration will be done during Rxa > service initialization. >=20 > Fixes: 83ab470d1259 ("eventdev/eth_rx: use timestamp as dynamic mbuf > field") > Cc: stable@dpdk.org >=20 > Signed-off-by: Rahul Bhansali Acked-by: Naga Harish K S V > --- > v3 changes: > - timestamp register move before other Rxa init config. >=20 > v2 changes: > - addresses the review comment to have registration in rxa_init_service() >=20 > lib/eventdev/rte_event_eth_rx_adapter.c | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) >=20 > diff --git a/lib/eventdev/rte_event_eth_rx_adapter.c > b/lib/eventdev/rte_event_eth_rx_adapter.c > index 3ebfa5366d..8df92247fa 100644 > --- a/lib/eventdev/rte_event_eth_rx_adapter.c > +++ b/lib/eventdev/rte_event_eth_rx_adapter.c > @@ -1910,6 +1910,13 @@ rxa_init_service(struct event_eth_rx_adapter > *rx_adapter, uint8_t id) > if (rx_adapter->service_inited) > return 0; >=20 > + if (rte_mbuf_dyn_rx_timestamp_register( > + &event_eth_rx_timestamp_dynfield_offset, > + &event_eth_rx_timestamp_dynflag) !=3D 0) { > + RTE_EDEV_LOG_ERR("Error registering timestamp field in > mbuf\n"); > + return -rte_errno; > + } > + > memset(&service, 0, sizeof(service)); > snprintf(service.name, ETH_RX_ADAPTER_SERVICE_NAME_LEN, > "rte_event_eth_rx_adapter_%d", id); > @@ -2472,13 +2479,6 @@ rxa_create(uint8_t id, uint8_t dev_id, > if (conf_cb =3D=3D rxa_default_conf_cb) > rx_adapter->default_cb_arg =3D 1; >=20 > - if (rte_mbuf_dyn_rx_timestamp_register( > - &event_eth_rx_timestamp_dynfield_offset, > - &event_eth_rx_timestamp_dynflag) !=3D 0) { > - RTE_EDEV_LOG_ERR("Error registering timestamp field in > mbuf\n"); > - return -rte_errno; > - } > - > rte_eventdev_trace_eth_rx_adapter_create(id, dev_id, conf_cb, > conf_arg); > return 0; > -- > 2.25.1