From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E1930A0C45 for ; Tue, 16 Nov 2021 03:13:00 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D6ADD410E9; Tue, 16 Nov 2021 03:13:00 +0100 (CET) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id 0B76C40040; Tue, 16 Nov 2021 03:12:57 +0100 (CET) X-IronPort-AV: E=McAfee;i="6200,9189,10169"; a="233440359" X-IronPort-AV: E=Sophos;i="5.87,237,1631602800"; d="scan'208";a="233440359" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Nov 2021 18:12:57 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,237,1631602800"; d="scan'208";a="735043473" Received: from orsmsx605.amr.corp.intel.com ([10.22.229.18]) by fmsmga006.fm.intel.com with ESMTP; 15 Nov 2021 18:12:56 -0800 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Mon, 15 Nov 2021 18:12:56 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Mon, 15 Nov 2021 18:12:56 -0800 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.107) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Mon, 15 Nov 2021 18:12:53 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=I2CyxE9eECnp5QriARKD2ZEq4DVkb8cbJ6IPzW9iAAm57VnGGI9sWjXCURGWZ5qbjryq5rpnxxihAZEXwiwgBIpECBgHSi97BXtdtQOABRTU17HI526bv1QWaZT5hi/voeRZiGaQCGUrt0qIJE4xmuZsD2zSSrugB0q5Se6MGZLl9XWLbxRrSXBS9dW7gjmG3dEuwg0BGKGUVf+j0VjGQIdcL1NMVgwtNnSJx3Y2g25A8IlLQdjlp27Cuj8aKHfvfKVDIYEGaSlaGWP1gvl+QsCwRtYMpDig1znMY4lFYImxNvEpFyUL/UzBkT87S3Y0opnI2X9AjVg6etHqnfq1mg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Mo4nzAT3SXlNjKl1rTc7DYBb9z2QQwAOIR73Wwe7wxE=; b=i2IzoDpdR5UqoRcqmzCMtbVnhG6cSOSjJI03lMHAoEQVkoolazzCPUs2BgJiOTPPEVbEJblo3raQeiAlDCfFalx/IvCaX2v37CT122/jWy/KGxAuAQjbO5bubZ5PUJ0QW4dZ6ou++Py9ULV3iYsLg3NNEjhJTqCYJIpJaMP+77uKZwmns86/UtmShjBf7zYstJXvrrkaO0zTxBCk2kyqNVCW3nEWbjjIukC5KcFlmGbpfiHx5laNuknykIrGleNySqWYtOeCa8Adpf8aTmDLK2DRrIslVI9rdCFKwyikSuJuF73yOBfjY9lgTiHJfLcapTxXKXeIzxoxTijxexFn2w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Mo4nzAT3SXlNjKl1rTc7DYBb9z2QQwAOIR73Wwe7wxE=; b=Pk+mVNAbDAxx/W37e3lr17to1kWAbYmZS8i+xz7AtV0Tg0xnBHv54BVWxZrqFPdDglRlkAhzYPskp8xU9lf+ly+EeHpXMS8G7ZK0MYX40YdGKQNU8UtiIc972AI+Pupytwdn8DehPzDq9IbRxATNMfY6atj3mlJW/21thgTSRO8= Received: from DM6PR11MB3898.namprd11.prod.outlook.com (2603:10b6:5:19f::12) by DM6PR11MB3226.namprd11.prod.outlook.com (2603:10b6:5:59::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4690.27; Tue, 16 Nov 2021 02:12:48 +0000 Received: from DM6PR11MB3898.namprd11.prod.outlook.com ([fe80::f1c4:6652:585d:e293]) by DM6PR11MB3898.namprd11.prod.outlook.com ([fe80::f1c4:6652:585d:e293%7]) with mapi id 15.20.4690.027; Tue, 16 Nov 2021 02:12:48 +0000 From: "Zhang, AlvinX" To: "Zhang, Qi Z" , "Rong, Leyi" CC: "dev@dpdk.org" , "stable@dpdk.org" Subject: RE: [PATCH v2] net/ice: fix secondary process Rx offload path Thread-Topic: [PATCH v2] net/ice: fix secondary process Rx offload path Thread-Index: AQHX2cVTwmt/7EyfyE+27hAuIR9/2KwFXSMAgAAKM5A= Date: Tue, 16 Nov 2021 02:12:48 +0000 Message-ID: References: <20211112054313.20132-1-alvinx.zhang@intel.com> <20211115020539.20468-1-alvinx.zhang@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 5ed7d7c1-c8b8-4c9d-c196-08d9a8a6961e x-ms-traffictypediagnostic: DM6PR11MB3226: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5797; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: larIfH4vjyU/cpDPvWp8tleSw3XZTPHBrM5Xay4hviw5LcRTpoG1Qib0nAXl4tJlZLaSzhnGOppuroxneXGfas3s+52wjof+81uuvcxUJ8P2j4ryL2BUEdd4DFXCKEEMUDfmq42YWXm2ep5WrL1aTuYfsr/v1nJ/o5EjnJlSvez+SRgmeyLcT+qm+wo3K25K1MSAjU4hynY0LzyLSp1iWhxOYCYQsWkFKiq4S5MXnkFTeUZVs8N4RyAiwJ8+tSVMb7MRkNw81MVYa29WfvVgdLYJWEAjkvN3HW4cxToU0TPe1W1Q83hUssu76X3fsXKIpf/y2zB/Fz6lPkppbIpPkgc1wAiIM/MHp9Y9QttX/jgG1OhfrZd5KaS+l3YBrkLUP3sKVAfYfm3RkGWF8YNu6HwQwu7a+IOeEQeRxQt2bRtb9RLuWnAubgX1CErd2HHlIvjwkCMey04ir413fx0A3pZ+vQR/TsKa5TWgrllA3FQpIAV2eSBVEthx8U5XlPBzI88u0GQMbRuHy0wq4INPlNkx8C2z9vbtsy08ivaJOXNjRDH1Re1/w3PRIDxdVc5zpPKnmFSyiM/ziqsj/Nljjf/pNm3U3z24hq/p392tJFsYKmVc8qwEHldGyXzqXsFzpInCe7dNt8yig9Bk6OLUx76PTEqmvU0wBT6BNOkRqZ3q4cvM7fd9Dt7J6lHDykjeWGY8+KU+3pnSi595Zpznmg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB3898.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(508600001)(53546011)(66476007)(4326008)(9686003)(7696005)(52536014)(8676002)(316002)(5660300002)(8936002)(33656002)(122000001)(450100002)(55016002)(38100700002)(38070700005)(54906003)(83380400001)(71200400001)(86362001)(2906002)(110136005)(6506007)(6636002)(186003)(26005)(66946007)(76116006)(66446008)(64756008)(82960400001)(66556008); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?GrxbPtRW3Z6zMuMOFlFNBbNWRdx/cr5hjzW7OWtpQJLzWbNzm9KmVLSiU0nR?= =?us-ascii?Q?2fM5TQ65rG9A2IFaNx2V8UW2KyZOgVThxE1vVu6s/xnFglLHjmqccOqwna0f?= =?us-ascii?Q?PZgsKXBSM1Lg+RnoAm9dChU5gK8CMlX6vtXViC6BaMPLHpdJO5sM+r8S4v8/?= =?us-ascii?Q?hIBkG2HUXkAf0A1u/gE+M+H0jooGQChJ0KlgB/w91MiF6lbIhJnEPZ/Bovrc?= =?us-ascii?Q?x0sidMhVOgQlzHJe9MMQHxM2ydOpzlp4jiZabAC+2dVLKDFCXHAKxKqvX9ER?= =?us-ascii?Q?70htgpLbjKp4Z5IU89OLyVJzp2ipHOdt7dsOWskYIlhK/qsZqRKM5KdxCc8D?= =?us-ascii?Q?wGGxUH79hO+bAv8CwnVqyvzu8nuP7R9pq8NaUerqG5hL9BPAiYfHg8XoRFI5?= =?us-ascii?Q?OlDVtujgNp90lmj1SkUzHw0FJGps4LW7uqWK1EgeJS6DBOuekAo7cgdezV8l?= =?us-ascii?Q?J3iUl/RzdlRZHksGy+hu08YKdnZbb/6BRaOJS6tzkcCrW/JCuMMJPHTUNbOo?= =?us-ascii?Q?H8FFFWGstTQRXeAro6qapjtTomF3roCdXSed1914UXEJdubqgQ8l250E6kZ+?= =?us-ascii?Q?S2X3TX2cB89tZmD9Q4SyAc0LCc8LK9wnsXIMhhg78ZE6gPLt61CGYPSdM0Qj?= =?us-ascii?Q?CSaFu+j1e158oyjxIrm8kro6TZagvW1tTp6381PLANxrJLxsqD/cqyXKYdyn?= =?us-ascii?Q?loTXNu7DKHswYiJDnjA7WR8jZOw+DcmOZwI9R9EQk+cZuorOcxMw7sMV7vak?= =?us-ascii?Q?iinNp1tA6zCjTxcK1L9xBGcXIu9+c+pKiXPUNNElJ7dQQXARKweb2eLlFtby?= =?us-ascii?Q?znfkObnxz82lkfaUN0ZJ9joXCvbNeYttaMCyR+K2UdT7IF+ef7lG1uMNthAl?= =?us-ascii?Q?vtYycdw/wESLa+GwmA3zb6KwNWaw1yTdk0vYAogNx/XMnp2z38qgsnkAaBtM?= =?us-ascii?Q?hk4VYfXtLJ/QIDfic42a4hFr7Z1Cd0/1Mhb4Odt36bgR4OqIVivoYH8b31X2?= =?us-ascii?Q?P87jmPT6gmyi8oiB42O+l2JSR5sn82Yg0GSCvsDAOBipQS3YgwZhS8+6NKre?= =?us-ascii?Q?McNgoITbFKtsDjLw9kpzgX/Mun6bnjw9uCb521s6Mk2wR8UmCWEiCvfzTxuE?= =?us-ascii?Q?PMoMjbT93r8sY0ed0S1SsWBXN2aunjcJFZzD5NPIEHHs1Q9uGA4XVifK+hk2?= =?us-ascii?Q?i7cEbqMZQCDdQlDnxNvN+blyrYTfgVnnOllZ4u8NExKNa9oG9OmGd8JEptLZ?= =?us-ascii?Q?jhmVO6OLug6S89ulp10tn0ykCqAYJnbjFKu/s7JfVBdjx6q8/LVGE+PWwSlb?= =?us-ascii?Q?nRdk16WRRuLuUad2fhvjQpxmKr93LGwqq0PLqt7Yoy6zCQxgHvgQ4e4GTZRc?= =?us-ascii?Q?tmIfOVmH7ozUliVGlSp5JpkWhIRP6/qeuk+PY2aAlNu1zsrxUm+O6MLchGjk?= =?us-ascii?Q?CBxz2giajNZYu1mYzTD78y8dlYSdYycNSPNF61G0vm+vNN1v6B2BafPpWfCW?= =?us-ascii?Q?DdAu8LqgNygIisgJJg5bsIwuKa6NHkCOQslrKHlXJ2T3UA21nQP+s9LQaqg0?= =?us-ascii?Q?UejxyAgbjL+OURTJGBb36wsGGB5OQUAinRaxxGHHJYcm5IQmy18v4fgDRLUo?= =?us-ascii?Q?dQ=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3898.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5ed7d7c1-c8b8-4c9d-c196-08d9a8a6961e X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Nov 2021 02:12:48.5261 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: iNK9nrBdqe56rk6haYwpG4iPedwpqQzqnBbsmwJshhKJdyJodjlcp6Am1zvdLQHK4fWGY2opDWHrQxyWiZdXOw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3226 X-OriginatorOrg: intel.com X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org > -----Original Message----- > From: Zhang, Qi Z > Sent: Tuesday, November 16, 2021 9:22 AM > To: Zhang, AlvinX ; Rong, Leyi > Cc: dev@dpdk.org; stable@dpdk.org > Subject: RE: [PATCH v2] net/ice: fix secondary process Rx offload path >=20 >=20 >=20 > > -----Original Message----- > > From: Zhang, AlvinX > > Sent: Monday, November 15, 2021 10:06 AM > > To: Zhang, Qi Z ; Rong, Leyi > > > > Cc: dev@dpdk.org; Zhang, AlvinX ; > > stable@dpdk.org > > Subject: [PATCH v2] net/ice: fix secondary process Rx offload path > > > > Secondary process depends on the vector offload flag to select right > > Rx offload path. This patch adds a variable in share memory to store > > the vector offload flag that can be directly read by secondary process. > > > > Fixes: 808a17b3c1e6 ("net/ice: add Rx AVX512 offload path") > > Cc: stable@dpdk.org > > > > Signed-off-by: Alvin Zhang > > --- > > drivers/net/ice/ice_ethdev.h | 1 + > > drivers/net/ice/ice_rxtx.c | 19 +++++++++++-------- > > 2 files changed, 12 insertions(+), 8 deletions(-) > > > > diff --git a/drivers/net/ice/ice_ethdev.h > > b/drivers/net/ice/ice_ethdev.h index > > 3a5bb9b..52daae0 100644 > > --- a/drivers/net/ice/ice_ethdev.h > > +++ b/drivers/net/ice/ice_ethdev.h > > @@ -538,6 +538,7 @@ struct ice_adapter { bool rx_use_avx512; bool > > tx_use_avx2; bool tx_use_avx512; > > +int rx_vec_path; >=20 > Can we make the type/ name more specific, how about defined as: "bool > rx_vec_offload_support;" ? >=20 > Then we can keep most thing unchanged in primary process branch, but only > add below , >=20 > ad->rx_vec_offload_support =3D (rx_check_ret =3D=3D ICE_VECTOR_OFFLOAD_PA= TH); >=20 >=20 > in following branch >=20 > we can avoid duplicate if (rx_check_ret =3D=3D ICE_VECTOR_OFFLOAD_PATH).. >=20 Ok, I'll update it in V3. >=20 >=20 >=20 > > #endif > > }; > > > > diff --git a/drivers/net/ice/ice_rxtx.c b/drivers/net/ice/ice_rxtx.c > > index 2d771ea..981493e 100644 > > --- a/drivers/net/ice/ice_rxtx.c > > +++ b/drivers/net/ice/ice_rxtx.c > > @@ -3172,15 +3172,14 @@ > > #ifdef RTE_ARCH_X86 > > struct ice_rx_queue *rxq; > > int i; > > -int rx_check_ret =3D -1; > > > > if (rte_eal_process_type() =3D=3D RTE_PROC_PRIMARY) { > > ad->rx_use_avx512 =3D false; > > ad->rx_use_avx2 =3D false; > > -rx_check_ret =3D ice_rx_vec_dev_check(dev); > > +ad->rx_vec_path =3D ice_rx_vec_dev_check(dev); > > if (ad->ptp_ena) > > -rx_check_ret =3D -1; > > -if (rx_check_ret >=3D 0 && ad->rx_bulk_alloc_allowed && > > +ad->rx_vec_path =3D -1; > > +if (ad->rx_vec_path >=3D 0 && ad->rx_bulk_alloc_allowed && > > rte_vect_get_max_simd_bitwidth() >=3D RTE_VECT_SIMD_128) { > > ad->rx_vec_allowed =3D true; for (i =3D 0; i < dev->data->nb_rx_queues= ; > > i++) { @@ -3215,7 > > +3214,8 @@ > > if (dev->data->scattered_rx) { > > if (ad->rx_use_avx512) { > > #ifdef CC_AVX512_SUPPORT > > -if (rx_check_ret =3D=3D ICE_VECTOR_OFFLOAD_PATH) { > > +if (ad->rx_vec_path =3D=3D > > + ICE_VECTOR_OFFLOAD_PATH) { > > PMD_DRV_LOG(NOTICE, > > "Using AVX512 OFFLOAD Vector Scattered Rx (port %d).", > > dev->data->port_id); @@ -3230,7 +3230,8 @@ } #endif } else if > > (ad->rx_use_avx2) { -if (rx_check_ret =3D=3D ICE_VECTOR_OFFLOAD_PATH) { > > +if (ad->rx_vec_path =3D=3D > > + ICE_VECTOR_OFFLOAD_PATH) { > > PMD_DRV_LOG(NOTICE, > > "Using AVX2 OFFLOAD Vector Scattered Rx (port %d).", > > dev->data->port_id); > > @@ -3252,7 +3253,8 @@ > > } else { > > if (ad->rx_use_avx512) { > > #ifdef CC_AVX512_SUPPORT > > -if (rx_check_ret =3D=3D ICE_VECTOR_OFFLOAD_PATH) { > > +if (ad->rx_vec_path =3D=3D > > + ICE_VECTOR_OFFLOAD_PATH) { > > PMD_DRV_LOG(NOTICE, > > "Using AVX512 OFFLOAD Vector Rx (port %d).", dev->data->port_id); @@ > > -3267,7 +3269,8 @@ } #endif } else if (ad->rx_use_avx2) { -if > > (rx_check_ret =3D=3D ICE_VECTOR_OFFLOAD_PATH) { > > +if (ad->rx_vec_path =3D=3D > > + ICE_VECTOR_OFFLOAD_PATH) { > > PMD_DRV_LOG(NOTICE, > > "Using AVX2 OFFLOAD Vector Rx > > (port %d).", > > dev->data->port_id); > > -- > > 1.8.3.1 >=20