From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id ED264A04A6 for ; Wed, 26 Jan 2022 08:08:08 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DCD004270A; Wed, 26 Jan 2022 08:08:08 +0100 (CET) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id ECB784069D; Wed, 26 Jan 2022 08:08:05 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1643180886; x=1674716886; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=qTHlLItgCwjiwfVMztECYgLu80dNXAVvqRlOXLy97jo=; b=iiCG9CJp3FGyx1sH1+20BMxFRLl2j9NToJ0Fq+z8SKaNOr/8zd1vfYal ukHQWEcZmZHrClcVZ/GFkesxVRYoIu9oa5bg3EA+6shkIgBaQchOVuo/g ckO6kmTYKRspPBKBhn8d2JQzCx06vxO3UmgStQOzLIUSq7+7Qh33EVczr 2HRc9p9dc8V2AilG5iGbR15MO4c1cFd90Es+2oTicR9dZJC7U+eMDlqVu tmAYzWYrLSsLqFlka98qNxIUp1sAlA41zdwmrxs7DFzoO9XX83/hIfKCn DIKuM2DG3zCUOcgMnXx6jFNv5dcoy2g1mR28kcXueCLjUrDYg8/an8FI0 g==; X-IronPort-AV: E=McAfee;i="6200,9189,10238"; a="307209454" X-IronPort-AV: E=Sophos;i="5.88,317,1635231600"; d="scan'208";a="307209454" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Jan 2022 23:08:05 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,317,1635231600"; d="scan'208";a="535076219" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by orsmga008.jf.intel.com with ESMTP; 25 Jan 2022 23:08:04 -0800 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Tue, 25 Jan 2022 23:08:04 -0800 Received: from fmsmsx606.amr.corp.intel.com (10.18.126.86) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Tue, 25 Jan 2022 23:08:04 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Tue, 25 Jan 2022 23:08:04 -0800 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.108) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Tue, 25 Jan 2022 23:08:02 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UXN5sKm/eB0TuYddV1nR8HdcBdcbig4+yuL5s2udaJ3l3DDxyYk0K/+3xWYX2tm4pYajwkgf+dxvMQ/FHl5+Ygicbol36TF4jpltT6w0GmV+Ky+DjTx4lzFPpFN8Mp0jbcgAjJiSZAn8MiBtw7rIZ1/SryWakxYM8+I8Sjr4RfvRGj766QKFLYZupdzcVaH9H0XXpiHnghsDd+OUDbUf8s4MUc7TNWn5H3PVkFcE+/i5c5Bt0XSLjeJhJcj4dtxTt8TIb2ZEUYDFc8pviyIblSLmSMqpoU5RQLt3lgf4DQY1L7JgL87msgo2ykmUUDtERe4XEOhe2DJRzL8LodG7zQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bt2MS0t0Ax/yzTTH+9obLGNYI0n9OneDhN6uShdGuHo=; b=jqpwu7hXOffqns8BnoeS6dihuDHrbs8ZicQga3KuI/hfhIcOZa3U/8X/OWUQZgGMSkbW3CNgQNGXTJYuEfV5w85HYd3bhLhjhGWe9V2HfsiqEX7fcmzlLfnpNwLN9IZKk4TYA8E2cBRsTlTzxMlIn/gnZdCJWUo3k0NVrCmPEb/YNxoGAGYLzLhqWTyCRHVczRxW70yvno9zv4JSOCi3e7dxJhNXKopaof2y2GwCE21ZMX59TVoVNbkPCIA7qN41czNVbG6IHCJssWUJiOoQxlogy/TFVx7ATSoc1SZ3ypN3c+LGIaJwnMM5aekrfPYUpKFEtn0tqlmA8lxNUBS78w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from DM6PR11MB4252.namprd11.prod.outlook.com (2603:10b6:5:201::26) by DM6PR11MB3033.namprd11.prod.outlook.com (2603:10b6:5:68::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4909.8; Wed, 26 Jan 2022 07:07:59 +0000 Received: from DM6PR11MB4252.namprd11.prod.outlook.com ([fe80::88d0:b735:5126:3fb0]) by DM6PR11MB4252.namprd11.prod.outlook.com ([fe80::88d0:b735:5126:3fb0%4]) with mapi id 15.20.4909.017; Wed, 26 Jan 2022 07:07:59 +0000 From: "Xu, Rosen" To: "Huang, Wei" , "dev@dpdk.org" , "Zhang, Qi Z" CC: "stable@dpdk.org" , "Zhang, Tianfei" , "Yigit, Ferruh" Subject: RE: [PATCH v1] raw/ifpga: fix ifpga devices cleanup function Thread-Topic: [PATCH v1] raw/ifpga: fix ifpga devices cleanup function Thread-Index: AQHYEmV0ghn/nbtKJkuJbE77wuvjg6x04gzQ Date: Wed, 26 Jan 2022 07:07:59 +0000 Message-ID: References: <20220126032953.24695-1-wei.huang@intel.com> In-Reply-To: <20220126032953.24695-1-wei.huang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYjFmNGRlYjYtYWZkNC00MmMyLWJhZTYtMjM0NTMxM2ZhOGYxIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoibDlEdVc0c1ZBXC8yVmoyaFF3SkMwb3pHZUpJXC80OTBwSW1NQzFnWmlGczdiRlwvYm5nV1llS1B3Y1gwXC9Tc1kzcm4ifQ== x-ctpclassification: CTP_NT authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 87eab0d1-1a17-44c8-d5ce-08d9e09a95e0 x-ms-traffictypediagnostic: DM6PR11MB3033:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2276; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Qhz9AE3iVk8LAdWeIL6qI7jjA6z6OPSzT2DcZOxEbeP7tXvw3OCRg8Y0IxWHQopUpiVlD6ahpFq7AEIQrdM999qbY0Z1zfv4bF40G2EOlC7pF3s5GJw5nfwKY1BhLYAurxGqL9g+f4fvi1oYS3pN55uqQV8/uqvp/LFLxp+dIEdZDs83eP8FEjvJk7gX4iQMBMPk2b7Tg95rOXfNRq68qKrfjpOmnP3FcO+9SV4BL9/xidFG3iu7tNPaRc+8S5L9O7lI/fvfSdjauZf8sbrvlbvOkgjQvTVDIg7Sn8QLNqlezlXHm/Jnpu76GI2G+wAsc1zachqGLNIv/kaz8d3kJNPgnwk3tZg5ic3VBCF6pqb/+Aaf3cwbAinDlBhy2RDzJv3r3/yvgnU+Au8KL+i7Z9DJuhc9sSTcXiOHkL5aSglDrUWaFGHkgtfk/xB+K1QrjYXVtz87dNiI+8RB6Eq02toNAk9KUR3KrvzqxGeCcht70GuyyuWOpcXaFU4QCkLqPOjzJsugz9t377MiKDNyUpBwSfCk+xnATCdhw9fXnE+6lYOenjQD/eLmlJ4v37MqOGKLBgnYVmFEKM7zM384jinEGVE4ZPaXOo9/OhJkhCwB9DplJrqqgZjhmaW+BZDZgyfiDcbQFwopfJjl8eWBoxRvAHCi5P72bBT9Lr/ps8Ab9OkHpNr8L2MbwW3Ao7KHCgofnLT3IHtr4dnThPWmHQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB4252.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(186003)(54906003)(316002)(110136005)(107886003)(33656002)(83380400001)(6636002)(53546011)(38100700002)(9686003)(7696005)(6506007)(38070700005)(52536014)(450100002)(86362001)(26005)(5660300002)(8676002)(4326008)(71200400001)(508600001)(76116006)(66476007)(66556008)(64756008)(66946007)(66446008)(2906002)(82960400001)(122000001)(55016003)(8936002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?bQJ90RBKJSvfRHl6yDVhJeJr1B8c8whwgbZJmIPgYrJaev4qxALkgAs8YGNI?= =?us-ascii?Q?Vxg9LHnBU/229w3PhPIFCgwWpsMQNiLF2rA3BX9BjkEK7yFZurST1GXwbrm1?= =?us-ascii?Q?CBx1kVbOBPgR0kZRSo7mb0AYFZnzFOkW3HQ8Acnt/emwE+CdEBr7jxhXKEFX?= =?us-ascii?Q?0slQm2cSM6bCey3pNB7eM87d9oAzpDyywiT7PO9lGJHcxZXncKguKfADTPZF?= =?us-ascii?Q?AN8yuxk8wUlF/6X/M+xKrGQXcR3QYFasQZMlahvs9rv4JJ2dz0QFzsAl5398?= =?us-ascii?Q?kPQuzkN/wqUP+UZI1VKpgYCm4+KTHzplVLJl0bFaKU40gYYXHO0iEXnIFEOy?= =?us-ascii?Q?f9jzpLDQoEq0U57D0OSLP5E7y/lOOwBnOlgtrVUnTWz8N9zcha7qOwPFroY2?= =?us-ascii?Q?Iy7LS9tWGIE8YOUMeidN6jY2KiQu4Met7p8hcZuz2DY9KcVrioVKWoDNb7xq?= =?us-ascii?Q?631wJWFcAQu9tAUObZS7yZ+q7Z48cuDuoJMnuN2dMmw03z3hmJ4J7/vgXM6M?= =?us-ascii?Q?pytWLIF72eVHueOnFVTjK4IbIb5ea56d9mwA4EmKMHhLPxQCKHUQ59+cuANx?= =?us-ascii?Q?Fetmo1d+iy02SIYDvavWgYh+zIZywsaDMYsubntxoorAL0qJip3AU1Q31HVq?= =?us-ascii?Q?/H3NgUToSDFPgY4D2q9IaUSTojHZV/Ui1tnWGLWNbHDubPUE6fIp4i7ArUKs?= =?us-ascii?Q?Cnb5UHPynYhEd7yOqxVImZpqjQQTMD8a+Z0K0TdY0fVoMfPaoZFK4Sl/9Dzx?= =?us-ascii?Q?DB24DQ9P3CHCrYwP9GawHb0bULNU7GMugBSRirvI257K/Qs9buGTfTqlDDfs?= =?us-ascii?Q?RgQxa1jcEJzGdFVePCx718wsQSHjT60lm3L2AbhnX8IoiPmyesoPJW7IIpqR?= =?us-ascii?Q?eNhx0NzWrTlk3thuNklyKcJPHDxrtMETUI+ddsVJ8HhBZQCdlkmXpxc1TX7l?= =?us-ascii?Q?gva49mxZLmhxm1vS8zncHtWxIB5hZg4d09EmX0JIGzfdEHQYnrZEe9ipLu7F?= =?us-ascii?Q?D7yZVj9hzoqHe92tZdjKVON7HIh5/ZFgOZPpOz+u8QP7trjCAT2jgkVhjvU1?= =?us-ascii?Q?3Ak/Tzu7xeQziEnpuMZAygPJ3gVFKsQksTK8tBZschB62L4K5ziAwYsz2xiy?= =?us-ascii?Q?M6SXg0+8ADNL3QxGQOth58CfmCNJNdMGLZD1p31UmI1rXMXfJ3p7vQHOrXzX?= =?us-ascii?Q?62RiahyXTAMnBk9/9GRt5Y7d1hDb8T/Q3CkgEzy+//8Oeh12jqUoL5oAz/Co?= =?us-ascii?Q?GTLUD61N6ZKRFYAFfHyK05iCaUZgQjjuzrEjTO4itsKPB5CJDEmKFvf1f0f4?= =?us-ascii?Q?iUaqkCZnfeZcPDaP0Enz+rJ5n3RXNgZ/XHqsC/hvi9T34UJIqBoi04Gx9Ozw?= =?us-ascii?Q?oWkHPdV+/XunKisXQIqt4q1xN0dikuaymKLWxXZz9AtJIFPihOiI0VlEtf9l?= =?us-ascii?Q?bQ5HkM+bDSSG670C8Jv8EYkb+WD1kvHpajFQ5c3S0QEGC/yeW/7LtMEnDDbV?= =?us-ascii?Q?66g4xZOGd+tG4v3FzAvwPCuEp5rcbU6U8yeVwCAVR0p0KKwbO5uIqGpyplzU?= =?us-ascii?Q?q5KLvBqRYBtfHoTsROJpHfzeglaxciVtlZy6lnkM0RkaSJrALz8BTXH7JB6R?= =?us-ascii?Q?jACnFnJkt0903funLjDZbNA=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4252.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 87eab0d1-1a17-44c8-d5ce-08d9e09a95e0 X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Jan 2022 07:07:59.2823 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Vp/nh4lAdjiFTueV0is+iTx7YcuV0WzJ09zbDnAtmkKSK2bxL2A/UGmx7zeu3xPwA7JjZfQ8MDRViQZXKyQTLA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3033 X-OriginatorOrg: intel.com X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, > -----Original Message----- > From: Huang, Wei > Sent: Wednesday, January 26, 2022 11:30 > To: dev@dpdk.org; Xu, Rosen ; Zhang, Qi Z > > Cc: stable@dpdk.org; Zhang, Tianfei ; Yigit, Fer= ruh > ; Huang, Wei > Subject: [PATCH v1] raw/ifpga: fix ifpga devices cleanup function >=20 > Use rte_dev_remove() to replace rte_rawdev_pmd_release() in > ifpga_rawdev_cleanup(), resources occupied by ifpga raw devices such as > threads can be released correctly. >=20 > Fixes: f724a802 ("raw/ifpga: add miscellaneous APIs") >=20 > Signed-off-by: Wei Huang > --- > drivers/raw/ifpga/ifpga_rawdev.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) >=20 > diff --git a/drivers/raw/ifpga/ifpga_rawdev.c > b/drivers/raw/ifpga/ifpga_rawdev.c > index fdf3c23..88c38aa 100644 > --- a/drivers/raw/ifpga/ifpga_rawdev.c > +++ b/drivers/raw/ifpga/ifpga_rawdev.c > @@ -1787,12 +1787,14 @@ int ifpga_rawdev_partial_reconfigure(struct > rte_rawdev *dev, int port, void ifpga_rawdev_cleanup(void) { > struct ifpga_rawdev *dev; > + struct rte_rawdev *rdev; > unsigned int i; >=20 > for (i =3D 0; i < IFPGA_RAWDEV_NUM; i++) { > dev =3D &ifpga_rawdevices[i]; > if (dev->rawdev) { > - rte_rawdev_pmd_release(dev->rawdev); > + rdev =3D dev->rawdev; > + rte_dev_remove(rdev->device); > dev->rawdev =3D NULL; > } > } > -- > 1.8.3.1 Acked-by: Rosen Xu