From: "Xu, Rosen" <rosen.xu@intel.com>
To: "Huang, Wei" <wei.huang@intel.com>, "dev@dpdk.org" <dev@dpdk.org>,
"thomas@monjalon.net" <thomas@monjalon.net>,
"david.marchand@redhat.com" <david.marchand@redhat.com>
Cc: "stable@dpdk.org" <stable@dpdk.org>,
"Zhang, Tianfei" <tianfei.zhang@intel.com>,
"Zhang, Qi Z" <qi.z.zhang@intel.com>
Subject: RE: [PATCH v1] net/ipn3ke: fix thread exit issue
Date: Mon, 20 Mar 2023 06:53:40 +0000 [thread overview]
Message-ID: <DM6PR11MB4252E85347CB5887507E77E889809@DM6PR11MB4252.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20230316204506.360432-1-wei.huang@intel.com>
Hi,
> -----Original Message-----
> From: Huang, Wei <wei.huang@intel.com>
> Sent: Friday, March 17, 2023 4:45 AM
> To: dev@dpdk.org; thomas@monjalon.net; david.marchand@redhat.com
> Cc: stable@dpdk.org; Xu, Rosen <rosen.xu@intel.com>; Zhang, Tianfei
> <tianfei.zhang@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>; Huang, Wei
> <wei.huang@intel.com>
> Subject: [PATCH v1] net/ipn3ke: fix thread exit issue
>
> Thread does not exit after driver is removed. When there is no more
> representor exist, the variable 'num' will be 0 and thread can exit safely at
> this time.
>
> Fixes: 70d6b7f550f4 ("net/ipn3ke: add representor")
> Cc: stable@dpdk.org
>
> Signed-off-by: Wei Huang <wei.huang@intel.com>
> ---
> drivers/net/ipn3ke/ipn3ke_representor.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ipn3ke/ipn3ke_representor.c
> b/drivers/net/ipn3ke/ipn3ke_representor.c
> index 2ef96a9..e50fc73 100644
> --- a/drivers/net/ipn3ke/ipn3ke_representor.c
> +++ b/drivers/net/ipn3ke/ipn3ke_representor.c
> @@ -2579,7 +2579,7 @@ struct rte_eth_xstat_name *xstats_names,
> }
> rte_delay_us(50 * MS);
>
> - if (num == 0xffffff)
> + if (num == 0 || num == 0xffffff)
> return NULL;
> }
>
> --
> 1.8.3.1
Acked-by: Rosen Xu <rosen.xu@intel.com>
next prev parent reply other threads:[~2023-03-20 6:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-16 20:45 Wei Huang
2023-03-20 6:53 ` Xu, Rosen [this message]
2023-03-20 13:01 ` Zhang, Qi Z
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM6PR11MB4252E85347CB5887507E77E889809@DM6PR11MB4252.namprd11.prod.outlook.com \
--to=rosen.xu@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=qi.z.zhang@intel.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
--cc=tianfei.zhang@intel.com \
--cc=wei.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).