patches for DPDK stable branches
 help / color / mirror / Atom feed
From: "Jayatheerthan, Jay" <jay.jayatheerthan@intel.com>
To: "Naga Harish K, S V" <s.v.naga.harish.k@intel.com>,
	"jerinj@marvell.com" <jerinj@marvell.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "stable@dpdk.org" <stable@dpdk.org>
Subject: RE: [PATCH v2] eventdev/eth_tx: fix adapter create
Date: Thu, 16 Jun 2022 05:57:55 +0000	[thread overview]
Message-ID: <DM6PR11MB43482EBFB6C790BE829713B5FDAC9@DM6PR11MB4348.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20220616051458.2197410-1-s.v.naga.harish.k@intel.com>

Looks good.

Acked-by: Jay Jayatheerthan <jay.jayatheerthan@intel.com>

-Jay



> -----Original Message-----
> From: Naga Harish K, S V <s.v.naga.harish.k@intel.com>
> Sent: Thursday, June 16, 2022 10:45 AM
> To: Naga Harish K, S V <s.v.naga.harish.k@intel.com>; Jayatheerthan, Jay <jay.jayatheerthan@intel.com>; jerinj@marvell.com
> Cc: dev@dpdk.org; stable@dpdk.org
> Subject: [PATCH v2] eventdev/eth_tx: fix adapter create
> 
> During adapter create, memory is allocated for storing event port
> configuration which is freed during adapter free. The following
> error is seen during free "EAL: Error: Invalid memory"
> 
> The service data pointer storage for txa_service_data_array is
> allocated during adapter create with incorrect size which is less
> than the required size.
> Initialization of this memory causes buffer overflow and result in
> metadata overwrite of event port config memory allocated above
> and results in the above error message during free.
> 
> Allocating the correct size of memory for txa_service_data_array
> prevents overwriting other memory areas like event port config
> memory.
> 
> Fixes: a3bbf2e09756 ("eventdev: add eth Tx adapter implementation")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Naga Harish K S V <s.v.naga.harish.k@intel.com>
> ---
> v2:
> * fix commit message
> ---
>  lib/eventdev/rte_event_eth_tx_adapter.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/eventdev/rte_event_eth_tx_adapter.c b/lib/eventdev/rte_event_eth_tx_adapter.c
> index 1b304f0a73..c700fb7b1f 100644
> --- a/lib/eventdev/rte_event_eth_tx_adapter.c
> +++ b/lib/eventdev/rte_event_eth_tx_adapter.c
> @@ -224,7 +224,7 @@ txa_service_data_init(void)
>  	if (txa_service_data_array == NULL) {
>  		txa_service_data_array =
>  				txa_memzone_array_get("txa_service_data_array",
> -					sizeof(int),
> +					sizeof(*txa_service_data_array),
>  					RTE_EVENT_ETH_TX_ADAPTER_MAX_INSTANCE);
>  		if (txa_service_data_array == NULL)
>  			return -ENOMEM;
> --
> 2.25.1


  reply	other threads:[~2022-06-16  5:58 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20220616050441.2197264-1-s.v.naga.harish.k@intel.com>
2022-06-16  5:14 ` Naga Harish K S V
2022-06-16  5:57   ` Jayatheerthan, Jay [this message]
2022-06-20 18:40     ` Jerin Jacob

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DM6PR11MB43482EBFB6C790BE829713B5FDAC9@DM6PR11MB4348.namprd11.prod.outlook.com \
    --to=jay.jayatheerthan@intel.com \
    --cc=dev@dpdk.org \
    --cc=jerinj@marvell.com \
    --cc=s.v.naga.harish.k@intel.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).