patches for DPDK stable branches
 help / color / mirror / Atom feed
From: "Jayatheerthan, Jay" <jay.jayatheerthan@intel.com>
To: "Naga Harish K, S V" <s.v.naga.harish.k@intel.com>,
	"jerinj@marvell.com" <jerinj@marvell.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "stable@dpdk.org" <stable@dpdk.org>
Subject: RE: [PATCH 1/2] eventdev/eth_tx: add spinlock for adapter start/stop
Date: Mon, 1 Aug 2022 06:53:28 +0000	[thread overview]
Message-ID: <DM6PR11MB434834CBC33F7C0828C61DCFFD9A9@DM6PR11MB4348.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20220726042211.1018326-1-s.v.naga.harish.k@intel.com>

> -----Original Message-----
> From: Naga Harish K, S V <s.v.naga.harish.k@intel.com>
> Sent: Tuesday, July 26, 2022 9:52 AM
> To: Jayatheerthan, Jay <jay.jayatheerthan@intel.com>; jerinj@marvell.com
> Cc: dev@dpdk.org; stable@dpdk.org
> Subject: [PATCH 1/2] eventdev/eth_tx: add spinlock for adapter start/stop
> 
> add spinlock protection for tx adapter stop and start APIs
> add null check for tx adapter service pointer in adapter start/stop apis.
> 
> Fixes: a3bbf2e09756 ("eventdev: add eth Tx adapter implementation")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Naga Harish K S V <s.v.naga.harish.k@intel.com>
> ---
>  lib/eventdev/rte_event_eth_tx_adapter.c | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/lib/eventdev/rte_event_eth_tx_adapter.c b/lib/eventdev/rte_event_eth_tx_adapter.c
> index a237e8edba..3251dad61f 100644
> --- a/lib/eventdev/rte_event_eth_tx_adapter.c
> +++ b/lib/eventdev/rte_event_eth_tx_adapter.c
> @@ -44,7 +44,7 @@
>  #define RTE_EVENT_ETH_TX_ADAPTER_ID_VALID_OR_ERR_RET(id, retval) \
>  do { \
>  	if (!txa_valid_id(id)) { \
> -		RTE_EDEV_LOG_ERR("Invalid eth Rx adapter id = %d", id); \
> +		RTE_EDEV_LOG_ERR("Invalid eth Tx adapter id = %d", id); \
>  		return retval; \
>  	} \
>  } while (0)
> @@ -468,10 +468,13 @@ txa_service_ctrl(uint8_t id, int start)
>  	struct txa_service_data *txa;
> 
>  	txa = txa_service_id_to_data(id);
> -	if (txa->service_id == TXA_INVALID_SERVICE_ID)
> +	if (txa == NULL || txa->service_id == TXA_INVALID_SERVICE_ID)
>  		return 0;
> 
> +	rte_spinlock_lock(&txa->tx_lock);
>  	ret = rte_service_runstate_set(txa->service_id, start);
> +	rte_spinlock_unlock(&txa->tx_lock);
> +
>  	if (ret == 0 && !start) {
>  		while (rte_service_may_be_active(txa->service_id))
>  			rte_pause();
> --
> 2.23.0

There are three different changes in this patch. But since they are quite small, it should be ok.

Acked-by: Jay Jayatheerthan <jay.jayatheerthan@intel.com>


  parent reply	other threads:[~2022-08-01  6:53 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-26  4:22 Naga Harish K S V
2022-07-26  4:22 ` [PATCH 2/2] eventdev/eth_tx: fix adapter stop Naga Harish K S V
2022-08-01  6:54   ` Jayatheerthan, Jay
2022-08-01  6:53 ` Jayatheerthan, Jay [this message]
2022-09-09  5:38   ` [PATCH 1/2] eventdev/eth_tx: add spinlock for adapter start/stop Naga Harish K, S V
2022-09-13 16:04     ` Jerin Jacob

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DM6PR11MB434834CBC33F7C0828C61DCFFD9A9@DM6PR11MB4348.namprd11.prod.outlook.com \
    --to=jay.jayatheerthan@intel.com \
    --cc=dev@dpdk.org \
    --cc=jerinj@marvell.com \
    --cc=s.v.naga.harish.k@intel.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).