From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0ABB4A00C3 for ; Fri, 25 Mar 2022 10:32:33 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 052D542847; Fri, 25 Mar 2022 10:32:33 +0100 (CET) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mails.dpdk.org (Postfix) with ESMTP id 1BE7240140; Fri, 25 Mar 2022 10:32:29 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1648200750; x=1679736750; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=posNDWm4bZ2N812DuaBYa6BdaPDLaRjegDzOcx/OCgk=; b=T8AsUddKM98qaUYjIBJH+0pLAc4sF4PI2hRu8OuMlvq+egR7Mo95lXld 6CaLgfsSjMUUSWencMjllZTW/PLcINQwcvph2COHO37KpEdyTbF+W3qqq RiadFusHyG9A7aJN0YqnFCJ3YqgfaQ8+BpWdFvo1Ol4eONgMbbeK/Tkbq YcVc8H6ztgYGOVbKgRgDOvapFgWNn1C1ExivkajZ+lWAj05/t9Yh0FC7p 0VPnb5HP17iAcF7iqF+qCKo4QHJixC02P7apVp+oeyQtKPHVgC3MXQmHJ 9Z0Yt+UsoqXmlQDkMs4ASNPC+CpWSZmLsZ9LchFKe0bnNEw0Inxhje3JV w==; X-IronPort-AV: E=McAfee;i="6200,9189,10296"; a="240752016" X-IronPort-AV: E=Sophos;i="5.90,209,1643702400"; d="scan'208";a="240752016" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Mar 2022 02:32:29 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,209,1643702400"; d="scan'208";a="553175719" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by fmsmga007.fm.intel.com with ESMTP; 25 Mar 2022 02:32:28 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Fri, 25 Mar 2022 02:32:27 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Fri, 25 Mar 2022 02:32:27 -0700 Received: from NAM04-MW2-obe.outbound.protection.outlook.com (104.47.73.168) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.21; Fri, 25 Mar 2022 02:32:27 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YFJHlsqVb4a8pQAYEaafsDn75aULMlH6tiYV3SHRXrqoXjnyH5vzyhH2jGM6txEhFzfAzBPyid5JxbXJYXU6p8Ra22oqPnCjNAIBK8uieIZZvxy65GbjSr5aDkm6TFWFhrR5FD64ePYULoBPUarR2Iy0217n7c8BWiI+OHN/Iy+DO9QswX6nb3T3hb+wJVWW/mpIh1Ck67AbgXdYnrJBLRmYNkfGRUDbMzPKjowsyySozEBBpetMDtbzr4/TLHX/YPwSHbH0aTlNKtH1XbzWDaE1oeYFAKJdljCohDGwUv92+e0hGueeu3hk48GVd25MXyLiDgniu3aCPbCQvPVoeg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=iRHiNy523MUB1iEil4rtHHq+eu5/VZtDYxnd/+/8Muc=; b=QSVhrWKgwf1wVW9d/1vshwtphbM4hxDcGKDiyKxv8grU+PvClhQUYexROFWeO+kqTdyDU/sqfbpmF1cfq/QFE84wt2jDEIPBGG8DAqo/DlxAC+sCSLPDX5B9b19Ljd6vwuXUvQqXE0gkYq11uSigJ9rsArpg9CQrx9OMkJWiKPHqfLV+/9aocrmSMT41Y9mLjWj/bO8ZvDaq9RX9ZrEKkPAgkkfH30A5aeJTWISKNeKkYPgoIUu2iYvkMyoM/1OBAonkNrHsWQ138cBbqmb24/gkIkyNmSIsTpDDoBJxYi1cUQH3wPpS1hCighFcIq685Aipfoi4scUWuk2gHGlpWw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM6PR11MB4348.namprd11.prod.outlook.com (2603:10b6:5:1db::18) by MN2PR11MB4584.namprd11.prod.outlook.com (2603:10b6:208:264::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5102.18; Fri, 25 Mar 2022 09:32:25 +0000 Received: from DM6PR11MB4348.namprd11.prod.outlook.com ([fe80::2d8b:621a:5b05:7edd]) by DM6PR11MB4348.namprd11.prod.outlook.com ([fe80::2d8b:621a:5b05:7edd%3]) with mapi id 15.20.5081.023; Fri, 25 Mar 2022 09:32:25 +0000 From: "Jayatheerthan, Jay" To: David Marchand , "dev@dpdk.org" CC: "stable@dpdk.org" , Jerin Jacob , "Naga Harish K, S V" , "Kundapura, Ganapati" Subject: RE: [PATCH] eventdev: fix telemetry Rx adapters stats reset Thread-Topic: [PATCH] eventdev: fix telemetry Rx adapters stats reset Thread-Index: AQHYP5PdJZMpkDjNMEu7rPLRHCJsNqzP1xAQ Date: Fri, 25 Mar 2022 09:32:25 +0000 Message-ID: References: <20220324152830.28155-1-david.marchand@redhat.com> In-Reply-To: <20220324152830.28155-1-david.marchand@redhat.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.401.20 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 444d0942-0786-45a4-26c6-08da0e425f71 x-ms-traffictypediagnostic: MN2PR11MB4584:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ItTj08pykEr8YWig4J/Ejihkp8+2aps8SIqpnOBU6Iz4pSntdrtYB1va8fTMI3FqtIj+t93/0/zkSl0qfTniVDof3b+XMCYqlbFeanvl3wVjwda9bmyI9wLNn3Hpa75WgJBG7GAPoV6Zs/Sc/k/LncDroPZGv/3BwIgsy7HmKjVScZ4Y17QZMcpscDRl5tguZIylpFOg1xDHJKNeGDZu1v1QXnJF3liHDXtjiZ42Qcz7D2goylr2/RohdEmpS3aFH5rc5eL18eTQzFFy6a1rg2scsMbMkxz9LXa7fHW7sj550cucdm8BvYFUS8e781ivtGF3YEtDtfLe59RcB/R+qV0ajGMOScQ2Qgik2tL01tzANFcptcMUeGlEN8dqZihQO7+mnjDINXcXhWIiT+GP9H9k9tY68kvx54hC31RtpArGez2aW+a86iIxXv2hBoe4nE5khEmCei5WpwURwBmNEOoCrpXNlGty8j4gp7ElKel5/tDGCWTVx0M4Ql2B8LhIWHFWhNCyiAPOtf9K+ai+VzEcd6D9n2Z86BYtFhAS0PUrPmA7JZZz6AVxHdbIaZDXutSMCUcCqBjoAM0rgK1el0SzM1Okjpazk/oq4Gb6+TP481YogAbCEnfj9BBsQf9hObK6eQAS1gaiWJpLvm9Rh4gCRMYtNk2QEincxgV3iUqo551/Eam9vW4abYhlFWc3TKYvcIh7TCs05JjFMd3Btg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB4348.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(508600001)(38070700005)(71200400001)(9686003)(38100700002)(53546011)(55016003)(66446008)(316002)(6506007)(7696005)(86362001)(8676002)(64756008)(66946007)(66556008)(76116006)(66476007)(54906003)(110136005)(4326008)(5660300002)(107886003)(122000001)(2906002)(33656002)(83380400001)(26005)(186003)(52536014)(82960400001)(8936002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?SO26PCWsVZm/+/7Ux6Iz/S+epw4PKDGlHjWVJAhmEfQqL4yXADthHiu1zf0I?= =?us-ascii?Q?57P4wq5cSendKFYAkyt4ZnzlsBsG6b5JMpwk2Fu2iMBx1OP/B4bpzdldNNlO?= =?us-ascii?Q?+ZqqyzKDaexMOTLaJ/DtPfv6obAYRFroMMK06MigT1h7qu5VUlM27dWb/WfS?= =?us-ascii?Q?1KEZY+wJvJMOqppW7b0KO+JpfONhTSaLPXPD4yn0uXitAvXXcKGnlDd5RNGm?= =?us-ascii?Q?aY4hPk7CxDhq8PAvBxAJojA35WB9Yybr3xVGvtV0q72LEfO8jbyVjLYS345r?= =?us-ascii?Q?/EYx0Jzd/KcEZn7BFoLBqp9raxk08HFBUfXQL3hnjDuDBfns/+dTgPvNnFAg?= =?us-ascii?Q?wK7saTwz0UN46N9VVPhrXLpQQxY3DYQmw1ErK+ZCU/CBczLurS5/UjrvEaie?= =?us-ascii?Q?vR4tN3UpCh+bd1oANYfYcrBLpMMDkYm3gsFMxyoaJn6tFRAq+UDW5oI721dZ?= =?us-ascii?Q?tbRZqKMVridUgzWDrL/s/ifl3Ny/HJAw6fNEzdGGoRYomUKXWcUHi/aZJLVB?= =?us-ascii?Q?Wcipsn97ECtZRTz2z0PnNSE0EurKg6reerT4VMzoWPjZ3ZqZEYAWXocMbKSo?= =?us-ascii?Q?OJpzRRsdLnWBwyZ39a4yLLiwT6aapoDiRT0bPnDOxTCr34/GnxVC8RPGvk/Z?= =?us-ascii?Q?4UyGg8ZfLrwmhONISTOyLCJCdaSlmh/URZb0MeI3sdzApM6tb449hQs4964T?= =?us-ascii?Q?GneTN7ISMsi9PmTeu9OmzfnZ6kU2gNCZ3rUNnjWRTu9Ys2hiaqqRiY/rcLaR?= =?us-ascii?Q?EZ6QUfc4bMd051D6glJIFW0f+GOG1V6kYV4K4R7G7L5dsSc16/q4x8UYtPVm?= =?us-ascii?Q?soZkh3hYmodT3TaOuwh/ZmLN8r/1/anW3r9Ikt0IF09foGVa2kenvvUYIvI+?= =?us-ascii?Q?PjKhK9hucm+B1QHX54hiNeYeP+kuX4jm2/IKoHKczdaBb+GLeyIIjJb8+DVH?= =?us-ascii?Q?ac86+SglteWl/05/ljlxS7to835nzj7pr/6vwAQVF8RQFjIQwTHkoqlP1ESX?= =?us-ascii?Q?du6Ac0JVd/ocQAqfycjjM7K7sUR2JFeJpaoVDtmuk1SM03ZSfmfWgi2QnmB8?= =?us-ascii?Q?Fivqh1qeSEWfBcV3Ekj3NIdLx7Kkv5ZYciTswaecjvzvcscRBe82xkiBZwXa?= =?us-ascii?Q?yxW9ulQxx1adewoyr5ttbIJ4OGN4AJatr+DngvjEKs4uw6p/AzvKjcDaNiCC?= =?us-ascii?Q?QwkGvXFFcnDOVm1M9pTwobCUDlarkacgewPphW9SlfADDlXfMoMDofIAqfMS?= =?us-ascii?Q?iFaFnWLPAbO9noaKkdY8CwZkaoU2n9occpXTO0cXwemmRJ3euFVC7GWWMf/P?= =?us-ascii?Q?S/ruQLkXMb6uyRDyjBJjpE+1BX820X62mF887Vmbcxs0VKftRzCevLqKSScY?= =?us-ascii?Q?FoNIPDfvM8nY0J9YINYCFf7SaAWGW+igyEaMP6/QL8jmqV2KFw5QXfvDZHFE?= =?us-ascii?Q?F9rHLZlGNOqEuduAxuoG9FNkdzQTnba3l5yYfcmMFgpErTP4fAum/TFRgRY3?= =?us-ascii?Q?tR5yELEVB+llqnVTWNziOPt47JVdST58g0N8PjoZ7cjUyInCAI4rfY6OwflV?= =?us-ascii?Q?Tbie/CrAyJs+fyjB8QiaJhkOxnMXZmIfNlmLURPJvq3EbauhrOeyJ443rHt2?= =?us-ascii?Q?a3RRcrj43lZpGlC7KNPpHQrqh8JezzVKgKUYkgYMYb1FHRIcTSR3WGAbC6aX?= =?us-ascii?Q?24Hgab2EUF9DrsiPdRkrBe6Nin4YBmxPSRAyhc3mYh8wi3QYxaxczFIdSZOr?= =?us-ascii?Q?/n0fnO6z5ROr3TyLa6fFniv1FKarPwA=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4348.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 444d0942-0786-45a4-26c6-08da0e425f71 X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Mar 2022 09:32:25.7759 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: fLqEs39NPIoAcXUXAxAPuH+BV2vzEXWzmF1HRe1b0hBxpmihi6XPNCpc+GMaJ4ip33PJfKioS8bWWbb9DjSle+UV3CdaAgDLT11TfzAR5KA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4584 X-OriginatorOrg: intel.com X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Looks good, thanks for posting this change. Acked-by: Jay Jayatheerthan -Jay > -----Original Message----- > From: David Marchand > Sent: Thursday, March 24, 2022 8:59 PM > To: dev@dpdk.org > Cc: stable@dpdk.org; Jayatheerthan, Jay ; Je= rin Jacob ; Naga Harish K, S V > ; Kundapura, Ganapati > Subject: [PATCH] eventdev: fix telemetry Rx adapters stats reset >=20 > Caught by covscan: >=20 > 1. dpdk-21.11/lib/eventdev/rte_event_eth_rx_adapter.c:3279: > logical_vs_bitwise: "~(*__ctype_b_loc()[(int)*params] & 2048 /* > (unsigned short)_ISdigit */)" is always 1/true regardless of the values > of its operand. This occurs as the logical second operand of "||". > 2. dpdk-21.11/lib/eventdev/rte_event_eth_rx_adapter.c:3279: remediation: > Did you intend to use "!" rather than "~"? >=20 > While isdigit return value should be compared as an int to 0, > prefer ! since all of this file uses this convention. >=20 > Fixes: 814d01709328 ("eventdev/eth_rx: support telemetry") > Cc: stable@dpdk.org >=20 > Signed-off-by: David Marchand > --- > lib/eventdev/rte_event_eth_rx_adapter.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/lib/eventdev/rte_event_eth_rx_adapter.c b/lib/eventdev/rte_e= vent_eth_rx_adapter.c > index ff83ce8b67..bf8741d2ea 100644 > --- a/lib/eventdev/rte_event_eth_rx_adapter.c > +++ b/lib/eventdev/rte_event_eth_rx_adapter.c > @@ -3334,7 +3334,7 @@ handle_rxa_stats_reset(const char *cmd __rte_unused= , > { > uint8_t rx_adapter_id; >=20 > - if (params =3D=3D NULL || strlen(params) =3D=3D 0 || ~isdigit(*params)) > + if (params =3D=3D NULL || strlen(params) =3D=3D 0 || !isdigit(*params)) > return -1; >=20 > /* Get Rx adapter ID from parameter string */ > -- > 2.23.0