* [dpdk-dev] [PATCH] ring: fix error return value when creating ring
@ 2022-01-10 9:23 Yunjian Wang
2022-01-10 14:11 ` Ananyev, Konstantin
0 siblings, 1 reply; 3+ messages in thread
From: Yunjian Wang @ 2022-01-10 9:23 UTC (permalink / raw)
To: dev
Cc: honnappa.nagarahalli, konstantin.ananyev, dingxiaoxiong,
xudingke, Yunjian Wang, stable
The error value returned by rte_ring_create_elem() should be positive
integers. However, if the rte_ring_get_memsize_elem() function fails,
a negative number is returned and is directly used as the return value.
As a result, this will cause the external call to check the return
value to fail(like called by rte_mempool_create()).
Fixes: a182620042aa ("ring: get size in memory")
Cc: stable@dpdk.org
Reported-by: Nan Zhou <zhounan14@huawei.com>
Signed-off-by: Yunjian Wang <wangyunjian@huawei.com>
---
lib/ring/rte_ring.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/ring/rte_ring.c b/lib/ring/rte_ring.c
index f17bd966be..185f9be798 100644
--- a/lib/ring/rte_ring.c
+++ b/lib/ring/rte_ring.c
@@ -267,7 +267,7 @@ rte_ring_create_elem(const char *name, unsigned int esize, unsigned int count,
ring_size = rte_ring_get_memsize_elem(esize, count);
if (ring_size < 0) {
- rte_errno = ring_size;
+ rte_errno = -ring_size;
return NULL;
}
--
2.27.0
^ permalink raw reply [flat|nested] 3+ messages in thread* RE: [dpdk-dev] [PATCH] ring: fix error return value when creating ring
2022-01-10 9:23 [dpdk-dev] [PATCH] ring: fix error return value when creating ring Yunjian Wang
@ 2022-01-10 14:11 ` Ananyev, Konstantin
2022-02-05 17:04 ` David Marchand
0 siblings, 1 reply; 3+ messages in thread
From: Ananyev, Konstantin @ 2022-01-10 14:11 UTC (permalink / raw)
To: Yunjian Wang, dev; +Cc: honnappa.nagarahalli, dingxiaoxiong, xudingke, stable
> The error value returned by rte_ring_create_elem() should be positive
> integers. However, if the rte_ring_get_memsize_elem() function fails,
> a negative number is returned and is directly used as the return value.
> As a result, this will cause the external call to check the return
> value to fail(like called by rte_mempool_create()).
>
> Fixes: a182620042aa ("ring: get size in memory")
> Cc: stable@dpdk.org
>
> Reported-by: Nan Zhou <zhounan14@huawei.com>
> Signed-off-by: Yunjian Wang <wangyunjian@huawei.com>
> ---
> lib/ring/rte_ring.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/ring/rte_ring.c b/lib/ring/rte_ring.c
> index f17bd966be..185f9be798 100644
> --- a/lib/ring/rte_ring.c
> +++ b/lib/ring/rte_ring.c
> @@ -267,7 +267,7 @@ rte_ring_create_elem(const char *name, unsigned int esize, unsigned int count,
>
> ring_size = rte_ring_get_memsize_elem(esize, count);
> if (ring_size < 0) {
> - rte_errno = ring_size;
> + rte_errno = -ring_size;
> return NULL;
> }
>
> --
Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
> 2.27.0
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH] ring: fix error return value when creating ring
2022-01-10 14:11 ` Ananyev, Konstantin
@ 2022-02-05 17:04 ` David Marchand
0 siblings, 0 replies; 3+ messages in thread
From: David Marchand @ 2022-02-05 17:04 UTC (permalink / raw)
To: Yunjian Wang
Cc: dev, Ananyev, Konstantin, honnappa.nagarahalli, dingxiaoxiong,
xudingke, stable
On Mon, Jan 10, 2022 at 3:15 PM Ananyev, Konstantin
<konstantin.ananyev@intel.com> wrote:
>
> > The error value returned by rte_ring_create_elem() should be positive
> > integers. However, if the rte_ring_get_memsize_elem() function fails,
> > a negative number is returned and is directly used as the return value.
> > As a result, this will cause the external call to check the return
> > value to fail(like called by rte_mempool_create()).
> >
> > Fixes: a182620042aa ("ring: get size in memory")
> > Cc: stable@dpdk.org
> >
> > Reported-by: Nan Zhou <zhounan14@huawei.com>
> > Signed-off-by: Yunjian Wang <wangyunjian@huawei.com>
> Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
Applied, thanks.
--
David Marchand
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-02-05 17:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-10 9:23 [dpdk-dev] [PATCH] ring: fix error return value when creating ring Yunjian Wang
2022-01-10 14:11 ` Ananyev, Konstantin
2022-02-05 17:04 ` David Marchand
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).