From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1E437A0C4E for ; Wed, 13 Oct 2021 11:12:26 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0E81D41171; Wed, 13 Oct 2021 11:12:26 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id D516B40150; Wed, 13 Oct 2021 11:12:23 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10135"; a="227282456" X-IronPort-AV: E=Sophos;i="5.85,370,1624345200"; d="scan'208,217";a="227282456" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Oct 2021 02:12:22 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,370,1624345200"; d="scan'208,217";a="486849100" Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19]) by fmsmga007.fm.intel.com with ESMTP; 13 Oct 2021 02:12:22 -0700 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Wed, 13 Oct 2021 02:12:21 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Wed, 13 Oct 2021 02:12:21 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.170) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Wed, 13 Oct 2021 02:12:19 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=k2LeS6IUE/QZwb3e6eCvzF28GnKR6ShB477jod0f7pPaQsIdyuVKMggwFz9FhkQPMLucSHhr1RZFyjibGfGCqDkmXoDirw9ot5JlRaa1XdrhKNFuLbmaNKUtag783zpUhcb48QxDx3072zOoHoYQw15k8Pb9YSxaLS0kKsRRpkueX3i3JtlEJVv99XR5vu7VLY7aXL+NfxO+jRk4DHpL7C4YA8A1ohUu0DXQIWfDTi7Q1wvB7ciORcR4Q4x9L6obLajWUB17YB6i5TB3bf78L4jwpUe2TSmO8yjqXSQIY+S6v6Ve7RYraJylhV/DD7rMUHzD6GcfMUZb90AE50ut/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Cbo/WDrinAytABeZSVpkk4ZVSd5Vj5sc3YQwt57yz/Y=; b=N/+z9e9BuyuiQGZdwYid/V/dnA0GaKiw6c/S1ibTVCwLk75R41ps1cqFX/P8loypesRmXAkorRoJDQqzrWFUDY5Zse0sfBtj3iN2pqONT8qUwkCQ3hj1QllNqijaV9vBjCAOJ/k2c6V1evCX9Nk1h/wO7McsTuXHdhiZvxli8u86VS6Pnzg972xcNvSaEqaTMFRvHRXebj/IB/1BsZWMQl33D9ttICIrI/6c6OySyIpd3xduF8n1uzGEJ9vLMVOYRORTjfo6Fhg9D4Ls1MEu3X62wcomNOxPW6Slg1jPNQvpPQzl30Y/kmQOC+y1ngaATyqPx9dlr1qZzmDet588zg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Cbo/WDrinAytABeZSVpkk4ZVSd5Vj5sc3YQwt57yz/Y=; b=Pmi9n24jHol95wv+WWfP3HDRtw7MFvWeDTv4qg1aN5Mqg35xA31Otwg4bbVnXikbcG6SnZMQ6QtzzP38u0TyWV7OeYH6dqnwcjL6Ogf6L15b2X1qSWHS/HAKYoq81helUYUZnHK+P0gqXXfqXJf9H4YQmwgeju3nbEQgr/0Qmsc= Received: from DM6PR11MB4491.namprd11.prod.outlook.com (2603:10b6:5:204::19) by DM6PR11MB4578.namprd11.prod.outlook.com (2603:10b6:5:2a7::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.19; Wed, 13 Oct 2021 09:12:18 +0000 Received: from DM6PR11MB4491.namprd11.prod.outlook.com ([fe80::740e:126e:c785:c8fd]) by DM6PR11MB4491.namprd11.prod.outlook.com ([fe80::740e:126e:c785:c8fd%4]) with mapi id 15.20.4587.030; Wed, 13 Oct 2021 09:12:18 +0000 From: "Ananyev, Konstantin" To: =?iso-2022-jp?B?GyRCaHE3RUQ2GyhC?= CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: Re:RE: [PATCH v2] ip_frag: fix fragmenting IPv4 fragment Thread-Index: AQHXvN8l4lA07BuvEEOEje/JJ9EbYqvPJ+VAgAFcagCAACVdcA== Date: Wed, 13 Oct 2021 09:12:18 +0000 Message-ID: References: <1632737174-86870-1-git-send-email-caihc1@chinatelecom.cn> <1633764424-17370-1-git-send-email-chcchc88@163.com> <6a43e87a.26fc.17c786d690e.Coremail.chcchc88@163.com> In-Reply-To: <6a43e87a.26fc.17c786d690e.Coremail.chcchc88@163.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.200.16 authentication-results: 163.com; dkim=none (message not signed) header.d=none;163.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 44ecc616-d137-4921-d3a3-08d98e298ea2 x-ms-traffictypediagnostic: DM6PR11MB4578: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: I4j6gZHMb4njzkuJsv/nm5Kf+eYiI3aAZG0uS34wUMoZStOeVlRjXM7yj0RGHI9I2YM7TM5t6Mkga6aa+WUW35+BTUKm8qS4yLfdyt5J6TqNPwG6So+XoN7MXMfR24Cc/JY8ZLJ8ecEMqT9y8XFGiXQxZu5gMkQCIXtxaE+1tlJRbHbu7l5JnSuBq3kHXeSpF1gE3IfXn5LmO+xR9tLZXwE83ynT41PA/hmrHFxjqgER4HYfojjLFO/+L2t3NXOREO+3PMVIOad5VQhDOCyCmgHtW2qHJgECsXWI+TS+HHtLDkJGpaYrihaz04NlwCkwRb0g6788oSvc2my3DhxQMgMIIka+yd0IQe6piSb5zrUyAQlhb6EcGXiUWAGKC7nWg6/A3DMpVN8NUgy7miiQIX/zvhucjzYPzAz6YCTIcMJSgoizd91vuiE/TKqptv3M+tNl0ePRNfVX2o02uqjXqat+TqPZw2qdY2X5eiSChQVho2EvWSlAD/AekKXk98+ra6WfS0l3lBfh1zM/v3G4meB6R4bEk5FFUzBtRi+N/ONg+ed8zuYWyQN9jZA6kp/QXAB9qKAsEDTGl2InxfUBKhmXYZW7Bi6hq+OE8dysG18rD8L42k6F6RpZd2XFfcyI8u1j82AEQ4sKyIedcMK7EOmgakqgLvUfMtjEvJt/kZmsXupsqa+xuK74p3/QGCv39fc92oDjI8FB5edmzBgAlg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB4491.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(7696005)(38070700005)(2906002)(38100700002)(8936002)(9686003)(26005)(186003)(316002)(122000001)(5660300002)(83380400001)(33656002)(86362001)(6506007)(64756008)(66446008)(54906003)(76116006)(9326002)(71200400001)(55236004)(4326008)(6916009)(55016002)(52536014)(82960400001)(66556008)(8676002)(508600001)(66476007)(53546011)(66946007); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-2022-jp?B?T1ZEOG1PVTVKbnpwWlJPbGJZZ0phMlQzRm1uNUtTQkhRZTFzbm03clBp?= =?iso-2022-jp?B?VDhNMy85aUc0ajRNWmhpN25NZ292WWtPYVEzbkJiUVVpRzZpdHZJcXZH?= =?iso-2022-jp?B?ZTVEVGpVTkZlSC9lUVFpbU4waXlKWnVUc0R4N3I0bHZUQjJYVlo1NUpG?= =?iso-2022-jp?B?ZTQwV2JWVEh2cnNqUUF5d0NRMWlKSGNvMG93b3NIenJXQTVBQStyK1Ix?= =?iso-2022-jp?B?SkZBNnpTYlk2bmRtNWxmTUVrY1FlL1V0emVYMENUckdYWTNxSVB1Nzh4?= =?iso-2022-jp?B?Zi9XL1ZFb0FZWHMvSzYxeTFreFV4SkNZQWtRU2JPZ3pkZUExa2hrRlFy?= =?iso-2022-jp?B?VmlsWXFCVUpYd3p6RDI2VUN1U0NtY0thTHlEUGM5ZGFqZFFJdEY4Rkd2?= =?iso-2022-jp?B?ZlhTTDFMVUQ4VGZ4U0pQYmU2R3V6amRRYmNkeDVLRmhHak90Y2pSL2FO?= =?iso-2022-jp?B?dUtiUGNoYllNQ2JoWW5GQkVtVU95bDBWV0t2QUtGaExrYThMUkk3QXV3?= =?iso-2022-jp?B?Q2hYZWJBeUgrWC9HMFVIRURBeEV4OGNFVkE4bENuVVRraE5scUJIcW5u?= =?iso-2022-jp?B?bGdna0VjZGZUYVU3dkF6eXcwcVhVdUxjRHZpcExxYUN3ckdJRW0xbU41?= =?iso-2022-jp?B?aDJreE5WQjZja0VUa1VwdFc3ajhLVGUyVmtma01yWjUxS1RXQncwOXFj?= =?iso-2022-jp?B?UWJnL1ZLaG5TK2FMd1VhbkwvQ3drNitobFdEQ05CTTNqdmtpdWtER0xQ?= =?iso-2022-jp?B?dHM2NGd3dXk1U2hsd1ExUCtFeTFmNmpDWitvUGgrdmNBNEwycTF2T0Yw?= =?iso-2022-jp?B?Y3NRWDlZWkxLZVIxaksyQ2M2SnJlazV4RkxsM2RpcmZzelEzSEtUK0Vr?= =?iso-2022-jp?B?UkJyUE1JNVZ3Rm9DNGxnOGgxRHpGTUhvK1hqVk9xcEhRTTZDN2tkZVU1?= =?iso-2022-jp?B?SHJpWUZvU1BBZEx2eEp0UWpFWFhYdEJJZ0JjTkR4VVJxUjZ1UVRHMTNw?= =?iso-2022-jp?B?YkJmdVY4ZlJJMWhYSm83c3FVTEZGRVVJT3RoY3hpOWR5VE94c2dTR29v?= =?iso-2022-jp?B?Znl6WVJJWDFDVkErNG9UL21heUYrcEdNdzFOWnZKdE9nMWpyOGRuYTRU?= =?iso-2022-jp?B?NHMwc1FiRTI5RGJUdHhXNGo1NlkzYXdzTUtsUmNsSkNWQ083Ty8wa1ZE?= =?iso-2022-jp?B?TVhCVjdscDRJWDFEVkNzRVFIQjg0OGhTTGgyQytqZHBiWUNuQksweVU5?= =?iso-2022-jp?B?bFhKeVN6RjFHRzUxYjBiREtvcEF6b1RYa1NPbE91VGZwWkFLU3MzWFNn?= =?iso-2022-jp?B?OVVzTEUyUHpXNlZlNWtsaEtTdEVXdnJ5aVdXTFAzT2hud1RtOTIwRFl0?= =?iso-2022-jp?B?T2RZVmJhMlNGRjdrTitUYTV1QSt6SE9FWUZWNm5wUnRUd2I4SDNBR1Yr?= =?iso-2022-jp?B?eHFRZk5CMzhUelFIaDh4SVpDTlN5Ymhabnp5eTFOTFZZc1ZQSmprOHU4?= =?iso-2022-jp?B?MXh2b1JhQnJ0UC8wU0tCU3ZHQlBmb3NvMUhzVCtUZlU1dWpoWmZSS0pC?= =?iso-2022-jp?B?WTllOGRLMUpHRVVKdGJpTmFPelAzMU1PVVQzM2djcU1FRG9xdUlQVkY2?= =?iso-2022-jp?B?V2VJbmNhRE50SEpPOUNpNC8weXhkczNHVy9YaTVjRy9nY1krcDdIQVJh?= =?iso-2022-jp?B?MUpWemJXa3gwdU9BYlZLdmNBZlZwR0t0a0RlNmRMZDdGeDRTeGRKVTJw?= =?iso-2022-jp?B?Szc2MFZ2SmNIeVVmMG0zS0wxM3IraEJwSlEvTzVFVXNqTXJQWDFzNEhG?= =?iso-2022-jp?B?T0ErbkJ4ZVJxRkI3VFVaS0tmOThhNUVxVXpKSW91OTdYV21Mc2JPbTNC?= =?iso-2022-jp?B?UklRdnNxN3BnVis5VmNnUnRvOStIZnZMYTBxbzduaWNMbUZnQkRCWVQv?= x-ms-exchange-transport-forked: True MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4491.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 44ecc616-d137-4921-d3a3-08d98e298ea2 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Oct 2021 09:12:18.6825 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: sjmzsFecFg8Jc30Go02SSm1Ay3pbGFVtoqM8/HyJBr4LJli3WbvCt8fERFnIAnLSu0ZjpSRt6JAguAyiUAKgEou63MDlm22k9x5bLLtBAtU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4578 X-OriginatorOrg: intel.com Content-Type: text/plain; charset="iso-2022-jp" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [dpdk-stable] [PATCH v2] ip_frag: fix fragmenting IPv4 fragment X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi Kevin, AFAIK, no other action from your side is needed at the moment. Now it is up to other reviewers (if any) to have a look, and then DPDK maintainers to bring your patch in. If they will have more comments/questions about the patch - they will email you. Meanwhile, as I said before, it would be really good to add a new test-case to cover that case. It could be a new separate patch on top of current one. Konstantin From: =1B$Bhq7ED6=1B(B Sent: Wednesday, October 13, 2021 7:53 AM To: Ananyev, Konstantin Cc: dev@dpdk.org; stable@dpdk.org Subject: Re:RE: [PATCH v2] ip_frag: fix fragmenting IPv4 fragment Hi,Konstantin I'm glad to receive your ack=1B$B!*=1B(B Follow the documentation =1B$B!T=1B(BContributing Code to DPDK=1B$B!U!'=1B(= B 1.Update Patchwork to mark your previous patches as =1B$B!H=1B(BSuperseded= =1B$B!I=1B(B. --Who is responsible for this update, I just tried, prompt no permission up= date( You don't have permissions to edit patch 'ip_frag: modify the fragment offs= et and mf'). 2.Note: When acking patches please remove as much of the text of the patch = email as possible. It is generally best to delete everything after the Signed-off-by: line. --Does this require me to send another patch email?And the content is like = this: Current implementation of rte_ipv4_fragment_packet() doesn=1B$B!G=1B(Bt tak= e into account offset and flag values of the given packet, but blindly assumes they are always zero (original packet is not fragmented). According to RFC791, fragment and flag values for new fragment should take into account values provided in the original IPv4 packet. Fixes: 4c38e5532a07 ("ip_frag: refactor IPv4 fragmentation into a proper li= brary") Cc: stable@dpdk.org Signed-off-by: huichao cai > Acked-by: Konstantin Ananyev > --- v2:(delete) * Reword commit message.(delete) lib/ip_frag/rte_ipv4_fragmentation.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) Best regards. Kevin