From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A28CDA0503 for ; Tue, 22 Mar 2022 12:50:39 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 95BC5427F0; Tue, 22 Mar 2022 12:50:39 +0100 (CET) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id C145040694; Tue, 22 Mar 2022 12:50:36 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1647949837; x=1679485837; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=EjJTWnfvVWckv5d0vWAd5n+x6JRoy4GPAspIlyUzCQo=; b=RzgHeif1kRI7eV/n05ggjBT+vcQv3bd9E02VojSQCQr0+I08q8boO4Ol YOeYL9zveIi455xqfsuo6BFup6ObYo1jZ5wa0FsOKgrlZHrqoJzzK94ST 141DhCaVMX3og9nLYR+wDh74ySDv7B3gKcuLafYYJ3ybQP8S1xZhHTa/G pJKTy3KMX4esO4Lmz2cA1XSV+pqEliKJAfTnXqpiiVSTZMJAB8lEmD0J7 ba/6zRNqcLmuTdYKAxoVyXPRe2DchqxSOeRlT9wZBFPVA4/o2sL0zEHgT fzt2jaYwu+C6pHu0mkqLnYsjjNEW5VQ3Y0cMo88un99l19fpftzIHfd2+ Q==; X-IronPort-AV: E=McAfee;i="6200,9189,10293"; a="257514637" X-IronPort-AV: E=Sophos;i="5.90,201,1643702400"; d="scan'208";a="257514637" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Mar 2022 04:50:35 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,201,1643702400"; d="scan'208";a="518850075" Received: from orsmsx604.amr.corp.intel.com ([10.22.229.17]) by orsmga006.jf.intel.com with ESMTP; 22 Mar 2022 04:50:35 -0700 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Tue, 22 Mar 2022 04:50:35 -0700 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Tue, 22 Mar 2022 04:50:34 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21 via Frontend Transport; Tue, 22 Mar 2022 04:50:34 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.177) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.21; Tue, 22 Mar 2022 04:50:34 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oKOMGtMQXAEsiTbEoUAZnevYrk4S118+mo9mFP2x6kmu0WCmldRH65NpSDXPlaQ636NrDYgu09+UPiEiPaRLgJTj1tgGFZcllIFMa+hUxvsDE2IpUPimLtJDB5xDJjDlthgE+IH539k94CD6B95RGjqonSaQG/xbmP4+0+KZNXRUsFWJ0fgMbl3AKWayOndeq6D5a/JJkzz7ynqqobBzJYQl6lccGKZOfEtBqwLzrvpEhD2iAi3gcAPoJE4RwbSHXsrel0FMXf1d3jedWMMGuq7Lez7t4Uq3KZZJaXgfceU+jx7nm1PL23aiObdJcjdSVj0iUyxIiGTsab4c5ReLHg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=C7FhQzYoBZLzKaobxfuijr52e4JSJlh1pBwh+7jMhRA=; b=B4cLkX0r/yFzqsYVL22fQPIuXujOjRaVS8KugNtEN9J3hoTK/n3N3c/wz1lp7suW5lm9oKBsOdskzH/94vSjLT/twoplZnFU3W1iJZIZDZl81R2lZfv1mCM6INH/hAB1Bx2m8ChnWyqlUyaD39lcCtH8IniFCnECJWgpq360S8Vwr7o+dGmdaOhLNuid0GrsGTOfewFGw8Iv+NxtzJwfdaFAWfb/u2b6auJrbEYBq+ZYaRDYZov3TW5YneBPrCsbBVbmC1iARgGMN6T5G6X99/1n4RVpQZIKif9FLoP6YQ3tkIzApnuBWuGzEhzMskp8kQr83lutWqQ40JT6HyEx9g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM6PR11MB4491.namprd11.prod.outlook.com (2603:10b6:5:204::19) by DM6PR11MB2555.namprd11.prod.outlook.com (2603:10b6:5:c5::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5081.17; Tue, 22 Mar 2022 11:50:33 +0000 Received: from DM6PR11MB4491.namprd11.prod.outlook.com ([fe80::ad2b:63fd:4cdd:130d]) by DM6PR11MB4491.namprd11.prod.outlook.com ([fe80::ad2b:63fd:4cdd:130d%4]) with mapi id 15.20.5081.023; Tue, 22 Mar 2022 11:50:33 +0000 From: "Ananyev, Konstantin" To: Tyler Retzlaff , "dev@dpdk.org" CC: "stephen@networkplumber.org" , "Burakov, Anatoly" , "stable@dpdk.org" Subject: RE: [PATCH v2] test/bpf: skip test if libpcap is unavailable Thread-Topic: [PATCH v2] test/bpf: skip test if libpcap is unavailable Thread-Index: AQHYPbxC6mUyoBVvRUi5xzrPldax9azLSm7A Date: Tue, 22 Mar 2022 11:50:33 +0000 Message-ID: References: <1647868407-4467-1-git-send-email-roretzla@linux.microsoft.com> <1647933155-30745-1-git-send-email-roretzla@linux.microsoft.com> In-Reply-To: <1647933155-30745-1-git-send-email-roretzla@linux.microsoft.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.401.20 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 2727a99a-c721-4d3f-2f31-08da0bfa2c0e x-ms-traffictypediagnostic: DM6PR11MB2555:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: jYhsWbxaDyNLUWdVnzWKoOjCd3J4twHkamxj9fPHn6SiFqMUN7t/QpV1t0+RCc7rgomk6xnyF5j/Wom/VHXyTkzi6RGrPzYroYh0VCZS8wjI7TbscR5bVTN0j7b6YABEg2jMaFc5E4P8IM3s6w1KqFRKNz22ywPMc3tNtfEyqNKt6O27BTVNQzopJPsHxjBiwiu5h9QUHvabH/rg79LkJmkNlVDjMR9QMUrYfcTKIm/iACOg6wl8YaVrpHKFFgbBXDJnHVIIQ0y8RrK6hi8eHevZ2wgfvRU+53OzpgpXAkVZwVPTdOCGOHzB4Bp/UvrNNk555jZ3m7ceMPdPnMc+xaxWAJN62BSV4tN0kxl/4DZR4/H2Yj9cERXHtLgVai5Xp63tIPsM3TM9AvmyMsCZtJJWw9ZdLglxfMtqU6Knp/+WkQofKekoqUXZ7ro9dMBayGiI8fKQlrci/KOw/WiqWgNiHYa2XZUXLAjbD0zzNarQxh0NwCc0FNdT8cbBXE+uoU9luiqfoUqbcfZxG7l9PkrBHdjxtOwiLgQ/nJFAtBtz3VCPp6NlTIKTqHhBtj8ij7Jlce4ULTX56JbTQorBsmSB+kFVcDkPtEUeT0vv9k/x42EZCch41t9o05mYz9V7ydFwppe9kBjfMoc7ggGuhO7F3N+bgiVfbIH5ofysddEfbYZld96z4I84JGoeia5B836fK4UKBLHXo2Kso871tQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB4491.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(71200400001)(83380400001)(66446008)(66946007)(64756008)(8676002)(66556008)(4326008)(66476007)(9686003)(55016003)(76116006)(122000001)(7696005)(6506007)(508600001)(82960400001)(2906002)(86362001)(316002)(38070700005)(186003)(26005)(8936002)(54906003)(52536014)(33656002)(110136005)(5660300002)(38100700002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?FsiVQqv3ufhAXbLbyZ9xktU4m2TeQpgjBTlsv4X70uKIuRNeWBraZ2Vmhuib?= =?us-ascii?Q?QG2gRR2FQVtHLqMhoFfBIddvecliMMIwrzA2ryzrMtgfB/0fQPvDWQhYmJEp?= =?us-ascii?Q?2MqksQV7x4oFaQ2oxJVLB8MxyrUvGDlZR3olVxhfF0wbisDayLNnCflHUSCV?= =?us-ascii?Q?302fmiGS0aZBPYPdOhkfZo1xGwvxkpiXfm2J+ZZ5Ffj3GLopUGLYDO58osNl?= =?us-ascii?Q?ftX2JPj9/Gt0Pt+rv4SoSv5YFyeIFtW2WKrShlc1nS4PgtouwomE6gGH1ZV4?= =?us-ascii?Q?ZE+cdyfQkXZM9SbpJl4WjnDJVK4QXpoe1bWGW0cw/USJjFzOm74kd+GL5iJL?= =?us-ascii?Q?Rk8DWZBWC5k77mwKuSZ3rxNxh7HNWtTCm2OLZsNzFX53KnBUysVXauTC2Rwp?= =?us-ascii?Q?kU+ydiVO96EshyBbMTcF0clF74wGKG2tZylNZW1HDB8Sw6iJlXwzJQLKHrnf?= =?us-ascii?Q?RxnY2i6W+aQ3WhGhA1mlX4yp5XIamLTsUtQmxuuC9/Es6yTGEvjG5VxFizNQ?= =?us-ascii?Q?bZ6JEZbfjHtZylG+yBRPRCTW4ID+3cZxBd8taoDoVReSptxNmYlOBpsS4Ou7?= =?us-ascii?Q?3nGG2vLEKYCFZbkI3uM4xNCuE/KhVBjgYsrPlKADJr1sVN6k4DcFHJ47/aGT?= =?us-ascii?Q?h8s5MsX15vOQvJ8J3DDqma0SLsK4MF4VK3l+4q06ZuryBGYvd7tYegFU2LTG?= =?us-ascii?Q?45HpWWGtMzU1FWL/DmCe0AjLzeTk6WgZv/iIx9X5nWlgB4Th1OFimqC8cLox?= =?us-ascii?Q?h369xC+ZQln5JXXgkb0/Y6aoOS5qaxD5FkMYtlfYKCuoQkFIxMrSiN+pRDJw?= =?us-ascii?Q?lLa1nTJdYTN7YL+bfD2K8bm2E0DKrkqQ6vGZMUg3vzI9FparsEMePl7EvXow?= =?us-ascii?Q?7B53j23vNk1Y8kdGGth63iQacCVH9gCnjHvvqGqV2P4bvDiKZBblJt6RBAFq?= =?us-ascii?Q?EF1fKTExXquSaSUo6klxjPRcv0Bh1zZpRYES68UoKmjo/wzoOfg+734jhK2R?= =?us-ascii?Q?bQX4mZXcOQXtclOqVEQXVIDRSkc5Hvx8aXxOdB1SL4Eftl9m5LGEZzE9u8Vs?= =?us-ascii?Q?nwN6jksCdvkuBUFzNpk8D2ek1cGjhlLsmZGI8FzWHaRQccTF2RgbwTtrPkKZ?= =?us-ascii?Q?spMmTDUR39BtSLo2RaVnYbVWvkLcd/Hb7IQSPn6OKQi5mQiPw364US/K8PsV?= =?us-ascii?Q?yxDoRLVzUL498jTOr6KmGbY+IHFjqssG6rXEoWV9d3wwyw4M8aAyxAXj82N0?= =?us-ascii?Q?9bT/JsJUvNMFV4Aa7do8uSurOhTZZgWeQ7SEQQze7vi3gj1kAWtcIEgb/Q5x?= =?us-ascii?Q?HI9audY8FZNsB88Ck0YsVE4qxDMi5soVWMOVGsLjsGr743Frr4cVlgx3Ug0j?= =?us-ascii?Q?IaVmRwffbFDmwYney7CvIxiMi/zB8lYXk2wH/9xKyiir2qBJQ69ryhbM095N?= =?us-ascii?Q?J7R1XVqBpyuGzPgeD0X5dyuZQgdEaXnJ0R/PhTuw30QB0i8upSecjA=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4491.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2727a99a-c721-4d3f-2f31-08da0bfa2c0e X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Mar 2022 11:50:33.4265 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: bkIqGbwObJi2rK+iIPas/fRcyb7CwajrB3f0zAxZXk9P/MZ4gZP1e5p+AylwQVybl7H1D/lQLILLCWLUJAP9NlpB+sHlWxxSUKwkhWKSBGU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB2555 X-OriginatorOrg: intel.com X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org > test_bpf_convert is being conditionally registered depending on the > presence of RTE_HAS_LIBPCAP except the UT unconditionally lists it as a > test to run. >=20 > when the UT runs test_bpf_convert test-dpdk can't find the registration > and assumes the DPDK_TEST environment variable hasn't been defined > resulting in test-dpdk dropping to interactive mode and subsequently > waiting for the remainder of the UT fast-test timeout period before > reporting the test as having timed out. >=20 > * unconditionally register test_bpf_convert > * if ! RTE_HAS_LIBPCAP provide a stub test_bpf_convert that reports the > test is skipped similar to that done with the test_bpf test. >=20 > Fixes: 2eccf6afbea9 ("bpf: add function to convert classic BPF to DPDK BP= F") > Cc: stephen@networkplumber.org > Cc: anatoly.burakov@intel.com > Cc: stable@dpdk.org >=20 > Signed-off-by: Tyler Retzlaff > --- > app/test/test_bpf.c | 14 ++++++++++++-- > 1 file changed, 12 insertions(+), 2 deletions(-) >=20 > diff --git a/app/test/test_bpf.c b/app/test/test_bpf.c > index 805cce6..97f5008 100644 > --- a/app/test/test_bpf.c > +++ b/app/test/test_bpf.c > @@ -3264,7 +3264,16 @@ struct bpf_test { >=20 > REGISTER_TEST_COMMAND(bpf_autotest, test_bpf); >=20 > -#ifdef RTE_HAS_LIBPCAP > +#ifndef RTE_HAS_LIBPCAP > + > +static int > +test_bpf_convert(void) > +{ > + printf("BPF convert RTE_HAS_LIBPCAP is undefined, skipping test\n"); > + return TEST_SKIPPED; > +} > + > +#else > #include >=20 > static void > @@ -3462,5 +3471,6 @@ struct bpf_test { > return rc; > } >=20 > -REGISTER_TEST_COMMAND(bpf_convert_autotest, test_bpf_convert); > #endif /* RTE_HAS_LIBPCAP */ > + > +REGISTER_TEST_COMMAND(bpf_convert_autotest, test_bpf_convert); > -- Acked-by: Konstantin Ananyev > 1.8.3.1