From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E309141C41 for ; Wed, 8 Feb 2023 16:33:41 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D7B7F41153; Wed, 8 Feb 2023 16:33:41 +0100 (CET) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id 0C25E40141; Wed, 8 Feb 2023 16:33:38 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1675870419; x=1707406419; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=6oVfgL/oavb7fdTyHHj0YFJ+jVImYEofT3P+JMscGGc=; b=kTMi6eJNQvIoxyqA69vLGzfKAYRA+nDct2eIPEIje5z1lpMXbJHutZ1F npEudeactRZNv4ogvprNpR5uIAXioZ35fDkg27wniagxFrW9r6qrdFKuX VLs7by6yEFxm8LTJ8xZ9E2D4IE4vxua01Jm4TFRpOmDw7XhSAG9Kxof/0 OH+CXLspSObY1osTWCTiE5Te8i0/o4iAq0N9pPD20g7ALnUjmHoXh2srj lyjbABLzjiUIDzP81kJqK1c0FcX5iLEVR5EybcnxgcvkujBdN8pwUJEDz y8jhXP+rHSht/gL3FX7Kprsc2tHfCQB5d2D6WYS5qIhiXM4+K7y1ZSKIP g==; X-IronPort-AV: E=McAfee;i="6500,9779,10615"; a="394420997" X-IronPort-AV: E=Sophos;i="5.97,281,1669104000"; d="scan'208";a="394420997" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Feb 2023 07:33:38 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10615"; a="660680185" X-IronPort-AV: E=Sophos;i="5.97,281,1669104000"; d="scan'208";a="660680185" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga007.jf.intel.com with ESMTP; 08 Feb 2023 07:33:37 -0800 Received: from orsmsx603.amr.corp.intel.com (10.22.229.16) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Wed, 8 Feb 2023 07:33:37 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Wed, 8 Feb 2023 07:33:37 -0800 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.103) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Wed, 8 Feb 2023 07:33:37 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WmT+7fqLX9/D3b8hWlH7M8qnwzTBveo7e0zXIzxlh4DpRWIqESiz3j/QXr3rWLx/eET5qfTep0BuBdg3gssHY68Ew3I6lc7HVK6BAloNyKssBk3c9gE5R+EgI34bXW4ymixcA5+2JwpCTpKg0CWeHcpf5eSTY8r3EXqNacVBedtcPbgnf0vUtjYBiYWL6A1R+ZvylG7fJqm8YKD0R8ExINIbQ57k8rwaw0QZnkZb4wyRAy+XUvxG9X7QhHYByzvRTmHlymYeG8QynwYJIqPfq/D1HlyDvy0Kj2VCLp27aV2hrdJrTWNnc/lCtBcTHkqQrbrbQ7q98ObUAEz07bBHlw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6oVfgL/oavb7fdTyHHj0YFJ+jVImYEofT3P+JMscGGc=; b=ZtsQu02qwh8QG3TBsFhSnwNkz39Zi0ADUDKNAhAUc491LsSQilExfL69VHwuvLB9IQ478ulWd3xOuVo6F7I2gChB4aqq7VBQyYO20Mb+aKuFakQ9V6jO8rmVD5HWq0pBdExKirDXXwTHgtXdb1tyvz/un5TN1z1DFh+nx5Q5Oeu4WexIzothcOYqh8KId2tdDE6nPeTdEu9+dSk/doUaYo/5JeJ8H3gjLPh7nOB0dgI9QR+PLh2vCjJfEX6vqkJ85uk/JO1OKiSEithZhQklCEfxaBa06u3XomnH5bDeBp04c/zl4k1lzzVfGYRbV3jKifkhYyRkw7kWnn9EzjBdWA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM6PR11MB4593.namprd11.prod.outlook.com (2603:10b6:5:2a3::8) by SA3PR11MB7462.namprd11.prod.outlook.com (2603:10b6:806:31d::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.36; Wed, 8 Feb 2023 15:33:30 +0000 Received: from DM6PR11MB4593.namprd11.prod.outlook.com ([fe80::cf02:55c7:23dc:8dc4]) by DM6PR11MB4593.namprd11.prod.outlook.com ([fe80::cf02:55c7:23dc:8dc4%9]) with mapi id 15.20.6086.017; Wed, 8 Feb 2023 15:33:30 +0000 From: "Wiles, Keith" To: "Richardson, Bruce" , "dev@dpdk.org" CC: "stable@dpdk.org" Subject: Re: [PATCH] build: fix invalid characters in toolchain definitions Thread-Topic: [PATCH] build: fix invalid characters in toolchain definitions Thread-Index: AQHZOwf7qxdaDbW4XkKHXDznF3WW0K7FLxb0 Date: Wed, 8 Feb 2023 15:33:30 +0000 Message-ID: References: <20230207152200.122227-1-bruce.richardson@intel.com> In-Reply-To: <20230207152200.122227-1-bruce.richardson@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM6PR11MB4593:EE_|SA3PR11MB7462:EE_ x-ms-office365-filtering-correlation-id: 7c1aef49-5c5b-49cd-d494-08db09e9d4a0 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 20dMIVQbJT76BgQf/NKg30nBoasJ1PbA/44OIwOyPyXcusCU+/gmAFh0YI1jkdMwN1a5CFeafLcGY170uS+fEF+AC7+aKJCA76vOHZf8zF5f6r5PLemX2UuEwt1+OKv0XdUi2P4oYZoxJT3aN3iE22VZVbPBcAUY7peRWArlI3OJC2rVl14poZskpRtXBsPUrtHK9txIKC9Sc9MoPVHBgjApmEAo6jx+dVqGa2FG7lLo91kK3xTfINmOtFKy33NHaVHt/liwune0t+lSDVqjFzxVuiPzoh6oCqIbXRrlrtHfK2A4K5BQvdyOQZ1fVcFLGvThohOl+YZAjTvxqA/AtR4xrjBhKLDCr1yTeEgDq5RhSEsT+cQD9XMTzrZcISmDZKAPhEDOYV8Aw9mZKnufbulLZPhGdB/f2zDoDdhiyInm5be5f9yFf4onLQdM9Upw7SvBxj4cCUommcGagPSkFcYmK1i+9lAtlw86mP2HITJ/ZB0lokVHSqVi1Ji97HlDZ6w+n0x5yUldVvo7XvBVomjZFRpuYxASnDpjwtHe6FCo1OLoZjrmeant/C4CmRws0uzHxrNlpM41hOhd64lZOrWx/LJdGY5pFQIF91oDjbkPmHk4Inc9CBFVrGjB8wDTNl2Bi+h+5J0iZTyR4fDzRy4aqNEUt7fgdIq8IuTaVlUrE2BRiWhKohYd7en6VykG5DOIFRu8mkuofuuGxUfT5mAgEllXpFmJj08JrysixcNX0YSu1KbKCXM4nz2K2KDEBrCjrcweifyQOzFCD49EcA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB4593.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(396003)(346002)(39860400002)(136003)(366004)(376002)(451199018)(53546011)(82960400001)(55016003)(966005)(5660300002)(83380400001)(91956017)(122000001)(9686003)(26005)(52536014)(66556008)(66446008)(64756008)(66946007)(66476007)(4326008)(8676002)(76116006)(71200400001)(450100002)(186003)(478600001)(316002)(7696005)(6506007)(33656002)(41300700001)(86362001)(110136005)(38070700005)(8936002)(38100700002)(2906002)(586874003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?XFW8kMDuO7/MxDlwqrmyJZOAhK9lP065WuklLvk+z9628Hgkv18o9GKerh?= =?iso-8859-1?Q?i2s5mEjVU0WQ1tLJRMHOVG5tzdXkXtEZIgurwHcJGLKzobgQ9hKeNZ/L8C?= =?iso-8859-1?Q?eH17HFZz3rkbDxZw72JNTPXcYPLjh5IEZO4m1ObBNcB255DmArQa8PUp7G?= =?iso-8859-1?Q?Rnk5jWjyA3b6yav+DLI0vyoIRtJ1HCwxn4njL91dVWipmkuccUZ4QdiWPU?= =?iso-8859-1?Q?uO3ZsqAOrb9D/6g7cgtakXq1JWYzkj2hkHcItVvFYcvqjsCOEnMoHnPetL?= =?iso-8859-1?Q?ZrMZQKtnKME7UL3F9K504goviaWn6K9v4YmOE8jeIRXcU957wGcptQfJdD?= =?iso-8859-1?Q?TsEE/uj1BSPIf0+oWbc0HaDoHg6J6lltQCfH21ddpRHcWC9UbKvFBOmkuv?= =?iso-8859-1?Q?VnHOVKnxs6zixwSrPC+J/H7ox2Rm9DLHXZ0OXxPmJCt7LV24H7vpy5uoFG?= =?iso-8859-1?Q?/7x0AfDhgPJgmrs6FVBDDfmBtCmevL0RHir9L2ib00qCK1Utgt6q4clPd0?= =?iso-8859-1?Q?tngnNKoA5SN9ZzADfE7giC7CX6wW0rFg2MGw1Kf25N2h+AbKOFS5h6dURX?= =?iso-8859-1?Q?fH4baUoKe2ZbqC/IohgxMPg3vjBlDl3aofZfdZr/pmuIi3a9I5aX9PsBq0?= =?iso-8859-1?Q?guV8vOLrgCYF6oCZJdJ+ZgZTP4YRvDOVI/ij2MK5gc4kEImd0zc1/JZG4Y?= =?iso-8859-1?Q?xNyIC317amRVTrPeQy0EnjzimjNvFKuPrmYF0Y+2BhMy666bZOz3IQKD55?= =?iso-8859-1?Q?aox9yd7LYpAXlxVhGPTxXlLG1AyHGWXxZ1tsuLfcQ3F9PKPHZOsy5dD6Zv?= =?iso-8859-1?Q?sdDnCk6Q8d9ww4OMjRp3lJZYOt5qiU+0zXfF5NwObK8JuuQsHh9b1vhshg?= =?iso-8859-1?Q?mux9DXKRZXICcHjZJy8lpZkem8BlIOtV2cKp3eQc840+L9U3cMCemdjYgE?= =?iso-8859-1?Q?3IcnIHuXCVl7hAD5fTmvXfLfun11Yu7FB3F8g0Qp62Qbv9skSL5Im+/AFN?= =?iso-8859-1?Q?rZEPFKFYKxR/j2petTq0l6mw3RSMxMSjFMw4hyTRXmURYOA6BpXBqp2Zf4?= =?iso-8859-1?Q?ZxoiDQLdd7afjDu4qrdwN6dnlSmIzb35X96d89DNiVxKqwLfDx2tuXGL9w?= =?iso-8859-1?Q?jrN/WnfE67QBc0zELiPMLvJ6qKQe8a7SEWtIa3vTIJspNvK9ibkawUEzLb?= =?iso-8859-1?Q?wBY9jtffOEdhiTwVNhBVReOHATZzfQO8X2TJrhd+ALUQFuKdQujKk2eJdp?= =?iso-8859-1?Q?oIr8zCrHE3iJi5ufr8Jcol9gAai5NepsWecQWvZTm2o1x5xz+9kepakmGd?= =?iso-8859-1?Q?OD8Y55CMNilkFkQ9d016nNipWSrpaaCpqEBfgpfViqwTwxwogmzbklXf4+?= =?iso-8859-1?Q?ntkwx9Pwm/eoGkscTSM7NT4Rve/5yUsbWI6gaaRONTOu6EuxOCnX6BrIT0?= =?iso-8859-1?Q?5lwGHZY0EHKE46QiZO9BKwr8RYwIV9Bu9blrBd6Eq3Nsf8E7vWMqhWmTcK?= =?iso-8859-1?Q?HcQqwS1M+BADR7YQqXgn/IdwEFro7mti9SC1CUodWn1jm1W5pkjIngwvoB?= =?iso-8859-1?Q?GgBortP4Oe/6zz7NVUJk/2WAMhA5qHJFjQA91z2iUvWqdO050oAphViqHN?= =?iso-8859-1?Q?/pMQpTBS4KWGUxA/y2460c058wVTXiB3zF?= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4593.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7c1aef49-5c5b-49cd-d494-08db09e9d4a0 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Feb 2023 15:33:30.2084 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: P+uB/ULUeGpAvYG+soouvzqHrXo+80Pvj72hH2+Vkj8I/3kOk2QotMPW2PEY2kRl1a5buidO71Az6TfxFH5BXw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR11MB7462 X-OriginatorOrg: intel.com X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org ________________________________________=0A= From: Richardson, Bruce =0A= Sent: Tuesday, February 7, 2023 9:22 AM=0A= To: dev@dpdk.org=0A= Cc: Richardson, Bruce; stable@dpdk.org; Wiles, Keith=0A= Subject: [PATCH] build: fix invalid characters in toolchain definitions=0A= =0A= When using "icx" (Intel(R) oneAPI DPC++/C++ Compiler) to build DPDK,=0A= meson reports the toolchain as "intel-llvm"[1]. This value is used=0A= directly to define the RTE_TOOLCHAIN macros, which means that we end up=0A= with the invalid macro name "RTE_TOOLCHAIN_INTEL-LLVM", and getting the=0A= compiler warning:=0A= =0A= ./rte_build_config.h:422:28: warning: ISO C99 requires whitespace after the= macro name [-Wc99-extensions]=0A= =0A= This can be fixed, and the macro generation made more robust generally,=0A= by adding "underscorify()" on the string. This replaces the "-", and=0A= any other invalid characters, with "_" [2].=0A= =0A= [1] https://mesonbuild.com/Reference-tables.html#compiler-ids=0A= [2] https://mesonbuild.com/Reference-manual_elementary_str.html#strundersco= rify=0A= =0A= Fixes: afd18fa21b5e ("build: set toolchain info during meson configure")=0A= Cc: stable@dpdk.org=0A= =0A= Reported-by: Keith Wiles =0A= Signed-off-by: Bruce Richardson =0A= ---=0A= config/meson.build | 2 +-=0A= 1 file changed, 1 insertion(+), 1 deletion(-)=0A= =0A= diff --git a/config/meson.build b/config/meson.build=0A= index 26f3168bc9..fc3ac99a32 100644=0A= --- a/config/meson.build=0A= +++ b/config/meson.build=0A= @@ -139,7 +139,7 @@ endif=0A= =0A= toolchain =3D cc.get_id()=0A= dpdk_conf.set_quoted('RTE_TOOLCHAIN', toolchain)=0A= -dpdk_conf.set('RTE_TOOLCHAIN_' + toolchain.to_upper(), 1)=0A= +dpdk_conf.set('RTE_TOOLCHAIN_' + toolchain.to_upper().underscorify(), 1)= =0A= =0A= dpdk_conf.set('RTE_ARCH_64', cc.sizeof('void *') =3D=3D 8)=0A= dpdk_conf.set('RTE_ARCH_32', cc.sizeof('void *') =3D=3D 4)=0A= --=0A= 2.37.2=0A= =0A= Acked-by: Keith Wiles =0A=