patches for DPDK stable branches
 help / color / mirror / Atom feed
* [dpdk-stable] [PATCH] drivers/net/mlx: do not enforce RSS hash offload
@ 2020-09-29 18:39 Alexander Kozyrev
  2020-10-27 15:14 ` [dpdk-stable] [PATCH v2] drivers/net: " Alexander Kozyrev
  0 siblings, 1 reply; 3+ messages in thread
From: Alexander Kozyrev @ 2020-09-29 18:39 UTC (permalink / raw)
  To: dev; +Cc: stable, rasland, viacheslavo, arybchenko, matan, Alexander Kozyrev

From: Alexander Kozyrev <akozyrev@mellanox.com>

Rx RSS hash offload should be controlled by the user
and should not be enforced by RSS multi-queue Rx mode.

Fixes: 8b945a7f7dcb ("drivers/net: update Rx RSS hash offload capabilities")
Cc: stable@dpdk.org

Author: Andrew Rybchenko <arybchenko@solarflare.com>
Signed-off-by: Alexander Kozyrev <akozyrev@mellanox.com>
---
 drivers/net/mlx4/mlx4.c        | 3 ---
 drivers/net/mlx5/mlx5_ethdev.c | 3 ---
 2 files changed, 6 deletions(-)

diff --git a/drivers/net/mlx4/mlx4.c b/drivers/net/mlx4/mlx4.c
index 71061a720f..318580bd73 100644
--- a/drivers/net/mlx4/mlx4.c
+++ b/drivers/net/mlx4/mlx4.c
@@ -249,9 +249,6 @@ mlx4_dev_configure(struct rte_eth_dev *dev)
 	struct rte_flow_error error;
 	int ret;
 
-	if (dev->data->dev_conf.rxmode.mq_mode & ETH_MQ_RX_RSS_FLAG)
-		dev->data->dev_conf.rxmode.offloads |= DEV_RX_OFFLOAD_RSS_HASH;
-
 	/* Prepare internal flow rules. */
 	ret = mlx4_flow_sync(priv, &error);
 	if (ret) {
diff --git a/drivers/net/mlx5/mlx5_ethdev.c b/drivers/net/mlx5/mlx5_ethdev.c
index 7631f644b2..09b93405d3 100644
--- a/drivers/net/mlx5/mlx5_ethdev.c
+++ b/drivers/net/mlx5/mlx5_ethdev.c
@@ -86,9 +86,6 @@ mlx5_dev_configure(struct rte_eth_dev *dev)
 		return -rte_errno;
 	}
 
-	if (dev->data->dev_conf.rxmode.mq_mode & ETH_MQ_RX_RSS_FLAG)
-		dev->data->dev_conf.rxmode.offloads |= DEV_RX_OFFLOAD_RSS_HASH;
-
 	memcpy(priv->rss_conf.rss_key,
 	       use_app_rss_key ?
 	       dev->data->dev_conf.rx_adv_conf.rss_conf.rss_key :
-- 
2.24.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [dpdk-stable] [PATCH v2] drivers/net: do not enforce RSS hash offload
  2020-09-29 18:39 [dpdk-stable] [PATCH] drivers/net/mlx: do not enforce RSS hash offload Alexander Kozyrev
@ 2020-10-27 15:14 ` Alexander Kozyrev
  2020-10-27 23:06   ` Raslan Darawsheh
  0 siblings, 1 reply; 3+ messages in thread
From: Alexander Kozyrev @ 2020-10-27 15:14 UTC (permalink / raw)
  To: dev; +Cc: stable, rasland, viacheslavo, arybchenko, matan, Alexander Kozyrev

From: Alexander Kozyrev <akozyrev@mellanox.com>

Rx RSS hash offload should be controlled by the user
and should not be enforced by RSS multi-queue Rx mode.

Fixes: 8b945a7f7dcb ("drivers/net: update Rx RSS hash offload capabilities")
Cc: stable@dpdk.org

Author: Andrew Rybchenko <arybchenko@solarflare.com>
Signed-off-by: Alexander Kozyrev <akozyrev@mellanox.com>
Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
---
 drivers/net/mlx4/mlx4.c        | 3 ---
 drivers/net/mlx5/mlx5_ethdev.c | 3 ---
 2 files changed, 6 deletions(-)

diff --git a/drivers/net/mlx4/mlx4.c b/drivers/net/mlx4/mlx4.c
index 34c2bbb373..d5d8c96351 100644
--- a/drivers/net/mlx4/mlx4.c
+++ b/drivers/net/mlx4/mlx4.c
@@ -249,9 +249,6 @@ mlx4_dev_configure(struct rte_eth_dev *dev)
 	struct rte_flow_error error;
 	int ret;
 
-	if (dev->data->dev_conf.rxmode.mq_mode & ETH_MQ_RX_RSS_FLAG)
-		dev->data->dev_conf.rxmode.offloads |= DEV_RX_OFFLOAD_RSS_HASH;
-
 	/* Prepare internal flow rules. */
 	ret = mlx4_flow_sync(priv, &error);
 	if (ret) {
diff --git a/drivers/net/mlx5/mlx5_ethdev.c b/drivers/net/mlx5/mlx5_ethdev.c
index fc04fc8224..6cadfe3eb0 100644
--- a/drivers/net/mlx5/mlx5_ethdev.c
+++ b/drivers/net/mlx5/mlx5_ethdev.c
@@ -86,9 +86,6 @@ mlx5_dev_configure(struct rte_eth_dev *dev)
 		return -rte_errno;
 	}
 
-	if (dev->data->dev_conf.rxmode.mq_mode & ETH_MQ_RX_RSS_FLAG)
-		dev->data->dev_conf.rxmode.offloads |= DEV_RX_OFFLOAD_RSS_HASH;
-
 	memcpy(priv->rss_conf.rss_key,
 	       use_app_rss_key ?
 	       dev->data->dev_conf.rx_adv_conf.rss_conf.rss_key :
-- 
2.24.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-stable] [PATCH v2] drivers/net: do not enforce RSS hash offload
  2020-10-27 15:14 ` [dpdk-stable] [PATCH v2] drivers/net: " Alexander Kozyrev
@ 2020-10-27 23:06   ` Raslan Darawsheh
  0 siblings, 0 replies; 3+ messages in thread
From: Raslan Darawsheh @ 2020-10-27 23:06 UTC (permalink / raw)
  To: Alexander Kozyrev, dev
  Cc: stable, Slava Ovsiienko, arybchenko, Matan Azrad, Alexander Kozyrev

Hi,

> -----Original Message-----
> From: Alexander Kozyrev <akozyrev@nvidia.com>
> Sent: Tuesday, October 27, 2020 5:15 PM
> To: dev@dpdk.org
> Cc: stable@dpdk.org; Raslan Darawsheh <rasland@nvidia.com>; Slava
> Ovsiienko <viacheslavo@nvidia.com>; arybchenko@solarflare.com; Matan
> Azrad <matan@nvidia.com>; Alexander Kozyrev <akozyrev@mellanox.com>
> Subject: [PATCH v2] drivers/net: do not enforce RSS hash offload
> 
> From: Alexander Kozyrev <akozyrev@mellanox.com>
> 
> Rx RSS hash offload should be controlled by the user
> and should not be enforced by RSS multi-queue Rx mode.
> 
> Fixes: 8b945a7f7dcb ("drivers/net: update Rx RSS hash offload capabilities")
> Cc: stable@dpdk.org
> 
> Author: Andrew Rybchenko <arybchenko@solarflare.com>
> Signed-off-by: Alexander Kozyrev <akozyrev@mellanox.com>
> Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
> ---
>  drivers/net/mlx4/mlx4.c        | 3 ---
>  drivers/net/mlx5/mlx5_ethdev.c | 3 ---
>  2 files changed, 6 deletions(-)
> 
> diff --git a/drivers/net/mlx4/mlx4.c b/drivers/net/mlx4/mlx4.c
> index 34c2bbb373..d5d8c96351 100644
> --- a/drivers/net/mlx4/mlx4.c
> +++ b/drivers/net/mlx4/mlx4.c
> @@ -249,9 +249,6 @@ mlx4_dev_configure(struct rte_eth_dev *dev)
>  	struct rte_flow_error error;
>  	int ret;
> 
> -	if (dev->data->dev_conf.rxmode.mq_mode &
> ETH_MQ_RX_RSS_FLAG)
> -		dev->data->dev_conf.rxmode.offloads |=
> DEV_RX_OFFLOAD_RSS_HASH;
> -
>  	/* Prepare internal flow rules. */
>  	ret = mlx4_flow_sync(priv, &error);
>  	if (ret) {
> diff --git a/drivers/net/mlx5/mlx5_ethdev.c
> b/drivers/net/mlx5/mlx5_ethdev.c
> index fc04fc8224..6cadfe3eb0 100644
> --- a/drivers/net/mlx5/mlx5_ethdev.c
> +++ b/drivers/net/mlx5/mlx5_ethdev.c
> @@ -86,9 +86,6 @@ mlx5_dev_configure(struct rte_eth_dev *dev)
>  		return -rte_errno;
>  	}
> 
> -	if (dev->data->dev_conf.rxmode.mq_mode &
> ETH_MQ_RX_RSS_FLAG)
> -		dev->data->dev_conf.rxmode.offloads |=
> DEV_RX_OFFLOAD_RSS_HASH;
> -
>  	memcpy(priv->rss_conf.rss_key,
>  	       use_app_rss_key ?
>  	       dev->data->dev_conf.rx_adv_conf.rss_conf.rss_key :
> --
> 2.24.1

Patch applied to next-net-mlx,

Kindest regards,
Raslan Darawsheh

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-10-27 23:06 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-29 18:39 [dpdk-stable] [PATCH] drivers/net/mlx: do not enforce RSS hash offload Alexander Kozyrev
2020-10-27 15:14 ` [dpdk-stable] [PATCH v2] drivers/net: " Alexander Kozyrev
2020-10-27 23:06   ` Raslan Darawsheh

patches for DPDK stable branches

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ http://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git