From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 98567A04DD for ; Tue, 17 Nov 2020 12:49:15 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 77EC65916; Tue, 17 Nov 2020 12:49:14 +0100 (CET) Received: from hqnvemgate25.nvidia.com (hqnvemgate25.nvidia.com [216.228.121.64]) by dpdk.org (Postfix) with ESMTP id 855F937B0; Tue, 17 Nov 2020 12:49:09 +0100 (CET) Received: from hqmail.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate25.nvidia.com (using TLS: TLSv1.2, AES256-SHA) id ; Tue, 17 Nov 2020 03:48:58 -0800 Received: from HQMAIL107.nvidia.com (172.20.187.13) by HQMAIL101.nvidia.com (172.20.187.10) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Tue, 17 Nov 2020 11:49:04 +0000 Received: from NAM04-BN3-obe.outbound.protection.outlook.com (104.47.46.52) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Tue, 17 Nov 2020 11:49:04 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AWp09jIM+o1gUkbAyQj+DFI6EKQgDnJ44nbcR0yqcvybu9b6yzhAsmblQK3TZmKk8iLygMuxdXC0ysbpnbcC0S3/sSAyvecSefieOxuTzDc+koQuFH8eGQ6XX29Kb8/OKNT5HZu8Ne9k/EhGbum2twChmO/E2eT7ojMWL5tTjAqhOUF46n9WWglpmRrJISJsDtMZm2rWgQFoCg0GPeebQBMv8UrRkiG2Eimq+m91QJHNJDwVqLfOvF8I6Z6NIGjKdx6C2+nwyZA1SVbiQDjzwAJ9FLKFd6ER+Vo/IFXY3+GgWi8SG/9V8Ha1GwIgxWt0JscKfdfMOaVJAPjRvHVhUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=34C9J4h3KYv8/wURlUMQ1vP2Ipm6xxbshVmK8jqqCA8=; b=TG4PSTV8LNRRXbzBrbMp8exacyN44WWjLJo2AEVNoa7PnVFvxhbbouskJmYvQdDmS5i9WfgOO/GZqbtBs9J4d9W1uRjeOxAG8o39cDkqsZG+y9IiVqABV6jGQA54yBaURZkgXqa6zKzLQJfRIh2myK+YWtEqAFQ/GQjGmqhZ4D4aBuBD6GwKlUNOr4t/c4/cUPFVxhl4dDhtU56SEYxc1E6s6b4P6SL75eGQckIkF4sVWHfBA3zFWtnzEkeAeZaK+/u3YGeEPIqTU4P6xkQKamqyp1yONx98uv+mGOHSMLd1V9oG4z1NMd3jvp9OuZ53vS1a5K+M43OxzjLEbaTqeQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none Received: from DM6PR12MB2748.namprd12.prod.outlook.com (2603:10b6:5:43::28) by DM6PR12MB3164.namprd12.prod.outlook.com (2603:10b6:5:188::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3564.25; Tue, 17 Nov 2020 11:49:03 +0000 Received: from DM6PR12MB2748.namprd12.prod.outlook.com ([fe80::2115:9e13:d36f:af51]) by DM6PR12MB2748.namprd12.prod.outlook.com ([fe80::2115:9e13:d36f:af51%6]) with mapi id 15.20.3564.028; Tue, 17 Nov 2020 11:49:02 +0000 From: Raslan Darawsheh To: Xiaoyu Min , Matan Azrad , "Shahaf Shuler" , Slava Ovsiienko CC: "dev@dpdk.org" , Jack Min , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] net/mlx5: fix validate RSS queues types Thread-Index: AQHWu7150LIOYdeW6kmap/6E/bXgzKnMN6JQ Date: Tue, 17 Nov 2020 11:49:02 +0000 Message-ID: References: <109d4f4e6b5dc9588af9603207d5d4a490fdb725.1605492098.git.jackmin@nvidia.com> In-Reply-To: <109d4f4e6b5dc9588af9603207d5d4a490fdb725.1605492098.git.jackmin@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: mellanox.com; dkim=none (message not signed) header.d=none;mellanox.com; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [188.161.230.205] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: a748107f-4706-4c1e-4907-08d88aeec79e x-ms-traffictypediagnostic: DM6PR12MB3164: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:576; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 4qN2H7sKnkAL78mJ8q3h1Aotu8CcUyCeHIKAjTEYgZzyrG29R+fVaK1apv4Iu517LkW1SsrD4ZMmVVNSFKUosfIygBUozFIjyHUpsuDklGZgb1fjJb8IgQc2ExfRc0nZIOfnAcm6WIokzTHzWoHTqkcn2WL+JwzePM2t8BLm/vUmZtXPqhYeYbK471WGsX4DYq6oYfpbkqH8bRNxlsPGW6PfvWT4YMxZZ47ReWIo6gUeN7l4ulWePnG5oZujqKiCBzeHWc2CSfHws7jCsbwRV+wvhIOIISrzuCA2/O7qkaQGVOfm8k16cv5nhD+3vxlav4EEN4Zs5MGlh+60nh//YQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR12MB2748.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(39860400002)(136003)(396003)(346002)(376002)(366004)(33656002)(86362001)(450100002)(15650500001)(83380400001)(186003)(9686003)(316002)(110136005)(55016002)(7696005)(8676002)(478600001)(54906003)(4326008)(2906002)(52536014)(66556008)(6636002)(66946007)(66446008)(71200400001)(64756008)(66476007)(76116006)(8936002)(6506007)(26005)(53546011)(5660300002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: vcz0Md9HPD4zLtiAehMOT6qf6UGKff+/MszC7WDcwyRHeOwUptGOtOI2rbfGmtbGOl9rkMzlA6NOC/VMGlWlgConSo+q54GI5saTm4d2/AJRs3R5gxjjZiSZD2LthcVOEU9vRrBvdAlwabI/OWrFN9X+XZl3JmJ/tIUltNFsD536QEDe0W4/PfVNuqSPoUU/mqdjbDFcm6v270gO+Wjlea3fHFU7lgmBEyrjCMGZHelwaw10F0ntYMHjRB+7/puPgh9nQP+YJ6n9FCjHv1FCk8hACjgp71JHHa9bVn163Brrm3E0vRj21H1HZ5xMuN1XhufL4nr+MVDRGt8RmNACS7kvPq2YLdcQqIae0q5fLutqgAmSOUVDy6izcuY1P+1uDNR89spEpzygwxukxCc9gK5vRODL38Y/GccERT89JZ0nvRpbLNig9qyq3ePs2uk065L8tzgCNeP5v+DaBP3SrMZhpiZpx62j/zHTmhXrK2fQY42IIau2Ryf/flUm6Dlvd15W969IS26Kw9JKTIWKky9rTV5Kw4ugg+ZYzJhi2sgx+lY/9PAWAwU4wMLgJRIpKGgt2Gq+dlIr7WP6q+OYqcvRtHv8gAmfU9baM1GWuHHYtUne/wiPXcVHP35I7iVQp7xmvVV7TPUy00usAsBnweSx8lKD8vNpZLPEv6dxLFvwMFYIBoXpLDCFdJa4gjvyEaleZOrEDxa0YPKDFF80f5ldou9VSH+hxaoFcpLduTcHj7WaMnWy0I2ke1fs8+JRwu9fNeZmmUWDZ9wwbDz0U9UsNu9XGsOgv4SPzM78nZfzkXJcF0rgcKmUsGNS/CT1xmDX+wXn8+02fMOCRRQvSQqyZF2s9uVNXqjE4RsSCghK+lBQ6VHIQPyGMyEtJVLB6p8ALRnIXsWYZu1WEmQ8AA== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB2748.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a748107f-4706-4c1e-4907-08d88aeec79e X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Nov 2020 11:49:02.6425 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: mNtCJxxJV06cJhBh2kz3lDEha+vqSAr/i4EXLHRmiccG0u+WjKqguQlvDU8KsyIR2IYkNrfzrujJ+YBE8jMyrw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB3164 X-OriginatorOrg: Nvidia.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1605613738; bh=34C9J4h3KYv8/wURlUMQ1vP2Ipm6xxbshVmK8jqqCA8=; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To: CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References: In-Reply-To:Accept-Language:Content-Language:X-MS-Has-Attach: X-MS-TNEF-Correlator:authentication-results:x-originating-ip: x-ms-publictraffictype:x-ms-office365-filtering-correlation-id: x-ms-traffictypediagnostic:x-ms-exchange-transport-forked: x-microsoft-antispam-prvs:x-ms-oob-tlc-oobclassifiers: x-ms-exchange-senderadcheck:x-microsoft-antispam: x-microsoft-antispam-message-info:x-forefront-antispam-report: x-ms-exchange-antispam-messagedata:Content-Type: Content-Transfer-Encoding:MIME-Version: X-MS-Exchange-CrossTenant-AuthAs: X-MS-Exchange-CrossTenant-AuthSource: X-MS-Exchange-CrossTenant-Network-Message-Id: X-MS-Exchange-CrossTenant-originalarrivaltime: X-MS-Exchange-CrossTenant-fromentityheader: X-MS-Exchange-CrossTenant-id:X-MS-Exchange-CrossTenant-mailboxtype: X-MS-Exchange-CrossTenant-userprincipalname: X-MS-Exchange-Transport-CrossTenantHeadersStamped:X-OriginatorOrg; b=gqvP1EBDa8m7VchlMGkK6O9p+TL37Mu3RTEwoJgYTla3XJ/yaRy2oJaYNKWmc6n4P CuNW+LISaLojC1QUhqXQmcqBvgNOhdu6zM0CMc6tpd+cu5YB+V3+25iONFHAcbtUch B9qcd17piKwrLFGOldIRCpw7+9X2s7dhjKp4jJOv3DtsqX736cX1z6MCoeQDtiPb0d SfqwtV89ZHdxrN7QWCU9ejoqv2IJVdw7EvIE+SqthjrkoEDegjHkRT1WkrF99stIUU /YIlAoRIL83G0OePlFzjBKimHAW/SbNVhIQI1nazWWHwDw2JDa3aMQmBt/jeDWeOb+ KHCouZNLY4Eww== Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] net/mlx5: fix validate RSS queues types X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, > -----Original Message----- > From: dev On Behalf Of Xiaoyu Min > Sent: Monday, November 16, 2020 4:08 AM > To: Matan Azrad ; Shahaf Shuler > ; Slava Ovsiienko > Cc: dev@dpdk.org; Jack Min ; stable@dpdk.org > Subject: [dpdk-dev] [PATCH] net/mlx5: fix validate RSS queues types >=20 > From: Xiaoyu Min >=20 > When the RSS queues' types are not uniformed, i.e, mixed with normal RX > queue and hairpin queue, PMD accept this flow after commit[1] instead of > reject it. >=20 > This because commit[1] create RX queue object as DEVX type via DEVX API > instead of IBV type via verbs, in which the latter will check the queues' > type when create verbs ind table but the formmer doesn't check when > create DEVX ind table. >=20 > However, in any case, logically PMD should check whether the input > configuration of RSS action is reasonable or not, which should > include queues' type check as well as the others. >=20 > So add the check of RSS queues' type in validation function to fix issue. >=20 > Fixes: 63bd16292c3a ("net/mlx5: support RSS on hairpin") > Cc: stable@dpdk.org >=20 > [1]: > commit 6deb19e1b2d2 ("net/mlx5: separate Rx queue object creations") >=20 > Signed-off-by: Xiaoyu Min > Acked-by: Matan Azrad Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh