From: Raslan Darawsheh <rasland@nvidia.com>
To: Matan Azrad <matan@nvidia.com>, Slava Ovsiienko <viacheslavo@nvidia.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] net/mlx5: fix Tx queue start
Date: Tue, 27 Oct 2020 14:02:22 +0000 [thread overview]
Message-ID: <DM6PR12MB2748361BF3D46F8C8375E316CF160@DM6PR12MB2748.namprd12.prod.outlook.com> (raw)
In-Reply-To: <1603781005-21080-1-git-send-email-matan@nvidia.com>
Hi,
> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Matan Azrad
> Sent: Tuesday, October 27, 2020 8:43 AM
> To: Slava Ovsiienko <viacheslavo@nvidia.com>
> Cc: dev@dpdk.org; stable@dpdk.org
> Subject: [dpdk-dev] [PATCH] net/mlx5: fix Tx queue start
>
> The Tx queue stop\start operations update the HW state of the Tx queue
> object. The stop API should update the state from ready to reset in
> order to stop any queue traffic and the start API should update the state
> from reset to ready in order to open the traffic path.
>
> The start API wrongly tried to change the state from ready to ready what
> caused a failure in FW on the current state validation.
>
> Replace ready to ready command by reset to ready command in the Tx start
> API.
>
> Fixes: 161d103b231c ("net/mlx5: add queue start and stop")
> Cc: stable@dpdk.org
>
> Signed-off-by: Matan Azrad <matan@nvidia.com>
> Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
> Acked-by: Asaf Penso <asafp@nvidia.com>
> ---
> drivers/net/mlx5/mlx5.h | 1 -
> drivers/net/mlx5/mlx5_txq.c | 2 +-
> 2 files changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/net/mlx5/mlx5.h b/drivers/net/mlx5/mlx5.h
> index 7429811..0902628 100644
> --- a/drivers/net/mlx5/mlx5.h
> +++ b/drivers/net/mlx5/mlx5.h
> @@ -788,7 +788,6 @@ enum mlx5_rxq_modify_type {
> };
>
> enum mlx5_txq_modify_type {
> - MLX5_TXQ_MOD_RDY2RDY, /* modify state from ready to ready. */
> MLX5_TXQ_MOD_RST2RDY, /* modify state from reset to ready. */
> MLX5_TXQ_MOD_RDY2RST, /* modify state from ready to reset. */
> MLX5_TXQ_MOD_ERR2RDY, /* modify state from error to ready. */
> diff --git a/drivers/net/mlx5/mlx5_txq.c b/drivers/net/mlx5/mlx5_txq.c
> index dca9c05..605cbfc 100644
> --- a/drivers/net/mlx5/mlx5_txq.c
> +++ b/drivers/net/mlx5/mlx5_txq.c
> @@ -253,7 +253,7 @@
>
> MLX5_ASSERT(rte_eal_process_type() == RTE_PROC_PRIMARY);
> ret = priv->obj_ops.txq_obj_modify(txq_ctrl->obj,
> - MLX5_TXQ_MOD_RDY2RDY,
> + MLX5_TXQ_MOD_RST2RDY,
> (uint8_t)priv->dev_port);
> if (ret)
> return ret;
> --
> 1.8.3.1
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
prev parent reply other threads:[~2020-10-27 14:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-27 6:43 [dpdk-stable] " Matan Azrad
2020-10-27 14:02 ` Raslan Darawsheh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM6PR12MB2748361BF3D46F8C8375E316CF160@DM6PR12MB2748.namprd12.prod.outlook.com \
--to=rasland@nvidia.com \
--cc=dev@dpdk.org \
--cc=matan@nvidia.com \
--cc=stable@dpdk.org \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).