From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 85691A04B5 for ; Tue, 27 Oct 2020 15:02:31 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5749E4C87; Tue, 27 Oct 2020 15:02:30 +0100 (CET) Received: from hqnvemgate26.nvidia.com (hqnvemgate26.nvidia.com [216.228.121.65]) by dpdk.org (Postfix) with ESMTP id 7F6C24C87; Tue, 27 Oct 2020 15:02:27 +0100 (CET) Received: from hqmail.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate26.nvidia.com (using TLS: TLSv1.2, AES256-SHA) id ; Tue, 27 Oct 2020 07:02:04 -0700 Received: from HQMAIL111.nvidia.com (172.20.187.18) by HQMAIL111.nvidia.com (172.20.187.18) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Tue, 27 Oct 2020 14:02:25 +0000 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.109) by HQMAIL111.nvidia.com (172.20.187.18) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Tue, 27 Oct 2020 14:02:25 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZbCxHYOSrfYLwQ7qBkrd/nX73Kwr5BBQKbyw6o5tV7znVxu2qHe0SCQnTVczmEHnbf9okzeSZV5YGce7hhKLlHp8jmRyRH95otqme+9ujFX0BKo7dripe6UyA4F9VdomqFrGOy4gq6kjvvC4n4v8PV4qQtpV+gN70X6g3oHkGngTSb3uJfIwEG+n7GuugCGicRT896d+k02L6rilN4a69Egfwjiewq94KM1shJTxWkH78Fmouj+FokS3rozzXXZ3gJJxhFnfrU1xJHH+4KmThTA/ltQtKT5WMqijOEp4O1mmAXaFrdZurDY62c9GPQaFLuH+HyGjKIchqct6MI1usA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ye6lYZEKtCMIvckj9Q3BOvzf4QLPbajMvgiCIXpMpGY=; b=bXAsoT6uNlaJvZl0MUKbZ2nrQwjLsXfLx3co5JonUtqeYmRhICMm8TzUytVQYmpMaErjPqo8w5Z6QK0feAfarS7eT4VTAPbrRjaFy6SSIos67dLv8jDm2NUT7XKMeV9RR/GyaAkBcJTxWLsgt9naYP47aBVl2jOFegWkivK56El6u6xWEWOxBXol/LgowCEuCV9CXuxHQorerAeY27nbZaInKyARnng2UbZf1cMY/ftqT3wvF1u7Wo+LAAcJItPp8iDJFWWdfwB16PH74jUM6ZqLpK3Kr1glg0EefPzc5Kp7Atb8sbKTnRJue8j1gE4Lj3ILC1aF6/tRLDVVTadifw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none Received: from DM6PR12MB2748.namprd12.prod.outlook.com (2603:10b6:5:43::28) by DM6PR12MB3258.namprd12.prod.outlook.com (2603:10b6:5:187::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3499.18; Tue, 27 Oct 2020 14:02:23 +0000 Received: from DM6PR12MB2748.namprd12.prod.outlook.com ([fe80::f506:4af8:281b:cdeb]) by DM6PR12MB2748.namprd12.prod.outlook.com ([fe80::f506:4af8:281b:cdeb%7]) with mapi id 15.20.3477.028; Tue, 27 Oct 2020 14:02:22 +0000 From: Raslan Darawsheh To: Matan Azrad , Slava Ovsiienko CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] net/mlx5: fix Tx queue start Thread-Index: AQHWrCyJ3HCnu9TO0UK93Cpwe5FzIqmreyeA Date: Tue, 27 Oct 2020 14:02:22 +0000 Message-ID: References: <1603781005-21080-1-git-send-email-matan@nvidia.com> In-Reply-To: <1603781005-21080-1-git-send-email-matan@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [212.29.221.74] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 68e62564-c63e-4dbf-2506-08d87a80ed61 x-ms-traffictypediagnostic: DM6PR12MB3258: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3826; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Gp/D8L6rwTuG6y5/bQiSPMk2qIHIjBR5QnUbp/MVkpSBVhkD6dP1+2xgwOOGJ2PWxac6f0bX8HV8CMjIsEvAHHdGdzG0h/14IM0wM2crbsS3I7sxyiWaI8KM2+h2U4aDPU0ZGxCni7jQILD2lGdVA0vG/kMSHVF1fP3gSjwLfTB3eF+j60de630/frOpwyRk3GiqjgGHEb6JJHlG42bK2n50vtp78E9M+szs6OfC8GSar+Hasj1hT4ei0w53OJr8hRCjYsAgMcRjJfVpYmzISaub8YzNMsX7IlSvmDiG+LRELdXv1qoWMF2/KVu3F8+R x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR12MB2748.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(346002)(39860400002)(376002)(366004)(136003)(66556008)(64756008)(66476007)(76116006)(7696005)(66946007)(186003)(83380400001)(52536014)(8676002)(316002)(110136005)(9686003)(4326008)(54906003)(5660300002)(53546011)(26005)(86362001)(66446008)(55016002)(71200400001)(2906002)(6506007)(33656002)(8936002)(450100002)(478600001)(6636002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: 0RguVwKDRtir0QKt5+GtI3zphUdF/wvdm4jllUXy1Cn2/jXWItPicj/MG7qV5dAuH+c/nLfRQtxD2Drx3s6cWp9JLPHX6y7s7T77c0XPir5qJ52mVDqYhEtYkWsR5XEArjagX5C9O86XbQUGMgrSZLKKP+IrWFrH/dJVKfYFc7kQpNxCmy/kUR57cdHT//TEYhrfODGxij9ZrNctfY/Rw836ducp16GZmAmRXypZv/b+7u7aTEwotPIX6xxPwYyW3hJcqTSjnl2E4Fa3s9+zeCQtBzRjogAiACPuuYAGVrt2FWlr7N+ycIdvSIq2acs7q0ULPS5G/BQJb4LYCwSiHBpMKlq2JZcVPIN5nwhO/fryPz9bI4Wu9O+sYJnyb6ITzD8B7qngWu/X6TfsQBqh5C4JylQhKpzcYZexHakg1/pJgvGPE1B1449JcFpvTVb494bKRZ/LixVKh46QbN/ZBDq5kH0KKnYJL7Dl1dbAPPaAkpVFV0xXLWhJmqKwavdDBWwPPKY44kFYD/nQpftfSgxz62hYCP/Dqw0cU6guse/PlpMwYdA3ChVt1k6HSLP8ijEVHGx97Yj5vgKljhqXuuOyMTUoZ4yFc4C+viY9Zv2k50XN5TRkpD05MxqZWpaO96lsfpqD37EWO1+8lb1jUg== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB2748.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 68e62564-c63e-4dbf-2506-08d87a80ed61 X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Oct 2020 14:02:22.8415 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 5gEW6qnJKa92Id68C8uWmbQ4cK8wdTPXbQwNVd1ALGf3A8imwPqzltFIhXZrwJCmiymMZCMJuWp4hTxqPOwIxA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB3258 X-OriginatorOrg: Nvidia.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1603807324; bh=ye6lYZEKtCMIvckj9Q3BOvzf4QLPbajMvgiCIXpMpGY=; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To: CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References: In-Reply-To:Accept-Language:Content-Language:X-MS-Has-Attach: X-MS-TNEF-Correlator:authentication-results:x-originating-ip: x-ms-publictraffictype:x-ms-office365-filtering-correlation-id: x-ms-traffictypediagnostic:x-ms-exchange-transport-forked: x-microsoft-antispam-prvs:x-ms-oob-tlc-oobclassifiers: x-ms-exchange-senderadcheck:x-microsoft-antispam: x-microsoft-antispam-message-info:x-forefront-antispam-report: x-ms-exchange-antispam-messagedata:Content-Type: Content-Transfer-Encoding:MIME-Version: X-MS-Exchange-CrossTenant-AuthAs: X-MS-Exchange-CrossTenant-AuthSource: X-MS-Exchange-CrossTenant-Network-Message-Id: X-MS-Exchange-CrossTenant-originalarrivaltime: X-MS-Exchange-CrossTenant-fromentityheader: X-MS-Exchange-CrossTenant-id:X-MS-Exchange-CrossTenant-mailboxtype: X-MS-Exchange-CrossTenant-userprincipalname: X-MS-Exchange-Transport-CrossTenantHeadersStamped:X-OriginatorOrg; b=BKrDh+EQj5E1xtDX7xoFYFA49K7y3P7LAyi/0HHFuwbBCpL9k4WZo9NST4pq+k4Cw 0gAfPwdLEDOjeJVJexH6l2L7ixO22BVlpgCuR8CNO03nEV1bX5Tp5RhhQIcrLZF952 N/sbRuNyg4vGaAeEbM8won/nynPbqAIzmnkjN0U1ArI/G0sOPoWHUtE03wASMYuoqp /960U8OgR5jODI/Qsir8oWrH8qthWzDK+4nA5nJAHnh9PNtlOU/g+RHkmZlX/EwJJP Dn+bEywP/sIvofSSCPMpNVPxAEnmq0NuQlOH21Chj60TJhWVCjKsnEgcj7PiudkaIb m9abHRcfpJ/AA== Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] net/mlx5: fix Tx queue start X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, > -----Original Message----- > From: dev On Behalf Of Matan Azrad > Sent: Tuesday, October 27, 2020 8:43 AM > To: Slava Ovsiienko > Cc: dev@dpdk.org; stable@dpdk.org > Subject: [dpdk-dev] [PATCH] net/mlx5: fix Tx queue start >=20 > The Tx queue stop\start operations update the HW state of the Tx queue > object. The stop API should update the state from ready to reset in > order to stop any queue traffic and the start API should update the state > from reset to ready in order to open the traffic path. >=20 > The start API wrongly tried to change the state from ready to ready what > caused a failure in FW on the current state validation. >=20 > Replace ready to ready command by reset to ready command in the Tx start > API. >=20 > Fixes: 161d103b231c ("net/mlx5: add queue start and stop") > Cc: stable@dpdk.org >=20 > Signed-off-by: Matan Azrad > Acked-by: Viacheslav Ovsiienko > Acked-by: Asaf Penso > --- > drivers/net/mlx5/mlx5.h | 1 - > drivers/net/mlx5/mlx5_txq.c | 2 +- > 2 files changed, 1 insertion(+), 2 deletions(-) >=20 > diff --git a/drivers/net/mlx5/mlx5.h b/drivers/net/mlx5/mlx5.h > index 7429811..0902628 100644 > --- a/drivers/net/mlx5/mlx5.h > +++ b/drivers/net/mlx5/mlx5.h > @@ -788,7 +788,6 @@ enum mlx5_rxq_modify_type { > }; >=20 > enum mlx5_txq_modify_type { > - MLX5_TXQ_MOD_RDY2RDY, /* modify state from ready to ready. */ > MLX5_TXQ_MOD_RST2RDY, /* modify state from reset to ready. */ > MLX5_TXQ_MOD_RDY2RST, /* modify state from ready to reset. */ > MLX5_TXQ_MOD_ERR2RDY, /* modify state from error to ready. */ > diff --git a/drivers/net/mlx5/mlx5_txq.c b/drivers/net/mlx5/mlx5_txq.c > index dca9c05..605cbfc 100644 > --- a/drivers/net/mlx5/mlx5_txq.c > +++ b/drivers/net/mlx5/mlx5_txq.c > @@ -253,7 +253,7 @@ >=20 > MLX5_ASSERT(rte_eal_process_type() =3D=3D RTE_PROC_PRIMARY); > ret =3D priv->obj_ops.txq_obj_modify(txq_ctrl->obj, > - MLX5_TXQ_MOD_RDY2RDY, > + MLX5_TXQ_MOD_RST2RDY, > (uint8_t)priv->dev_port); > if (ret) > return ret; > -- > 1.8.3.1 Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh