From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 335BCA0C52 for ; Tue, 2 Nov 2021 08:55:28 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0AC2B410FF; Tue, 2 Nov 2021 08:55:28 +0100 (CET) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2057.outbound.protection.outlook.com [40.107.94.57]) by mails.dpdk.org (Postfix) with ESMTP id 04ED54068F; Tue, 2 Nov 2021 08:55:26 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YrX8BHmHLBnIoueRfpuiHFqkC1KlspaKj3sROJ4cM3xjNJUotENiOEvN6xR6feKsGIs+FB9LAk2cncFcDzdUpmDBgaLu8NTB1jutSEGl9mOxWYdGgsRM815q0+omW1mL1ux9Gv+Y2wgb9Nb9s7+ylqPiv4G/HPF4cNTbqyWMeyJMGh3L9+sSfHlY6ZM7Dyk8oe+fGgfCQcb2YkdC7dx5ga7JQ8iJ3m1RKvMRvKpd68EKImaLhs8jRhJwAxxmIx15EHbqmQdxIUqN4OgO1kzkN/U8e33oYs5QmwKRIDlebY5BhYQQiu1HpT0Y3Ks3wdl8UHW/GTOJD72vqI86CTaOEg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Kk/VwV6gBgmGVFFVvYh8fs+pwf+XB7on+yf876vwtAM=; b=IXUJtJKHMsgv1pbS/Kf6xQjLjuDlzHeqsV0kDielynngutOP6YoJ5LgBla3Olomb2Fz7K9c8lCIDk/pBNJiF7OHia64GOg56Jv02pUoKS8TDO+5CHvBWx/Hj3LsUAXklGjJCYOw5xHqrFWNy94xnC4g7R2AA8apf8Yb9avHMwOC/lUH94xpnCKh8ysl8Dfsb1X3mQN4KNXFIcbcEqxKpkXma8pBAaQhKw5LVhDQtomL7SA6Gw2YqVlke4+Q2oIq/icO8wnI006KQ2vPGHicVgew+7IU8LeKf0vwwN00TYZsmDMfr7ohYR53LSMZXEVZidegtKcCqJDFZd1YdgRUy7g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Kk/VwV6gBgmGVFFVvYh8fs+pwf+XB7on+yf876vwtAM=; b=a1Rls3s9BydK4d6AF6xAg8Znl8aQjoYtQKzaqz/Jcoctiwd+KTCooCd/by9CscJqeCzuAWnE0JU+DqRno48G4BikzwA8Kj2ijyqL+QvhkWLUrwlBxIuh0jd8C9qXr2qMPzecTvfSjF3iWYsT7VL/wDM21JqxVsmDKwnMyOnhF+2CYYBxATf4zFPCT945SCNo4Ag3y1y6w4auy5hJ/z/2cW43pMCoEN2R/iJel+LUiKZc6Z7dOB14hZP8sMDpXrfS/Hu1DsEKlRSRlkdW+H1QauMmJLRuL5VW1vitc7RMl9r2Q+43ydhd1fttGfG+OQmmSa9ZviqroC3/vgvMmABe/A== Received: from DM6PR12MB3753.namprd12.prod.outlook.com (2603:10b6:5:1c7::18) by DM5PR12MB1691.namprd12.prod.outlook.com (2603:10b6:4:8::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.18; Tue, 2 Nov 2021 07:55:24 +0000 Received: from DM6PR12MB3753.namprd12.prod.outlook.com ([fe80::e550:35a2:96e5:657f]) by DM6PR12MB3753.namprd12.prod.outlook.com ([fe80::e550:35a2:96e5:657f%4]) with mapi id 15.20.4649.019; Tue, 2 Nov 2021 07:55:24 +0000 From: Slava Ovsiienko To: Chengfeng Ye , "david.marchand@redhat.com" , Shahaf Shuler , Matan Azrad CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [PATCH v5] net/mlx5: fix mutex unlock in txpp cleanup Thread-Index: AQHXv1A+CCR8lD8GVEyjRA9GWKzoEavv/0Sg Date: Tue, 2 Nov 2021 07:55:24 +0000 Message-ID: References: <20211012100204.5569-1-cyeaa@connect.ust.hk> In-Reply-To: <20211012100204.5569-1-cyeaa@connect.ust.hk> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: connect.ust.hk; dkim=none (message not signed) header.d=none;connect.ust.hk; dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: b4dd73e2-b2bc-4963-d2a5-08d99dd6205e x-ms-traffictypediagnostic: DM5PR12MB1691: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4941; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: nSWsto3J05ciN1n1VcAFk0aad1ToUWj/+DR3LxjXbTvO112siUl3hZgLa12aCiVNDUgzClikWxX3g3M01UPKxVZo1SpP0soDHVtriZtbrOXvUFQqlba5aTQQxiCF/lma6Vkk0jZ1kgLFyXbviiDuhSRu0o2NWbvugKjr90HoqYPrUbA6Kivwi3IMV23+MhjW7bDaDmDehSHcm2DV+Xojzig7bNsfsyz2LzQOaOrC26iSebzkRukyPngj7noZuiDmut6oeJBWhaTafGwXn9a0w0ck7gNF/0bf5PzxAxM5lxZkCcOR3h2KlndNcnm0RIuGwcH9glCYlVNHacFQQlfQ15bPHSFnLnHxYLNtwJOmpsTwHLitBrvFEMyTuOzRNINztm/hmQTDMLvlOEiQ0fnn4KhIvakkO+r3J4aLCE5VZTCMZP5KplxcBSGLTqNiIyystTW0MJ+aboA61BgTLT6ho4zPe8LTMq+b7N1DQtbOBR4rQsQlBq+qUjON6JQrbg6mGFCZGa6Gvn272L3fgvTWuIMAsPrpAsDvAZtFzkh+p1Y3mRldkVhhEaG1OjIarlBuF2I4idWoroGvYblRL43vUtwR6YnuUXki//MMCS9nROEg+xOH6vdaqZ8lA2xYIUVue/16zAib2gRWT9pjc6i+DnEISSu5cJiHU3talMcr8zkr0nurRLcl0mn9k0hWt+UNi88sE+2ad5G2F4JT5iZuMg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR12MB3753.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(66446008)(53546011)(76116006)(71200400001)(6506007)(296002)(110136005)(316002)(86362001)(5660300002)(33656002)(54906003)(6636002)(2906002)(508600001)(26005)(4744005)(83380400001)(4326008)(66556008)(66946007)(8676002)(186003)(8936002)(52536014)(38100700002)(66476007)(122000001)(38070700005)(64756008)(9686003)(55016002)(7696005); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?EuHeXNF+gDneqz0Z+u632XMG8rtRI7BeNWSn5VD1Unzmyzxr34ZJ2FJLe6hH?= =?us-ascii?Q?w2VySiccA2HsgA+pQu7VXkaCaNKEoI1YdC5U5iN17j9CFvNrfLImExET1K40?= =?us-ascii?Q?G2nXHgdoVk4tiSbBYL8WUOurIOqM9mV/bOJTX8b1R7htDDpko9Ro3T+M/Nuf?= =?us-ascii?Q?16dUjiCe5GzN4UqbYR3XN1QjgzHBF22Bq5cEwYPtrJ7Ejlqtc3DFwzM8ig29?= =?us-ascii?Q?Pn0HR54ehESTeXVQCdIXa2BHkP6xJZLTA9YXICc36w5R8UuvN0RH3lyoGAAp?= =?us-ascii?Q?ZsdUobNSj94C6aOmjjmtDVNL4kFWR6LVaJd4pUu6rlCvFz9n/CuOGUNPPJbK?= =?us-ascii?Q?uThWq0FG7nc2Er093/77fVJL2syyuYndTe2HbT3sNyHQnHDGrf5NQp+kQRdU?= =?us-ascii?Q?Nti9qGl452QjAb0ghYDjGKuGeA1fdZUyYQ/Wa2+mbrAUkRjJwOaCD2Y96Skr?= =?us-ascii?Q?0/nnJVVTfnEmLNY0pb1nK1me1TAIoAc0ljnh2b4X1EQIeFlwYnlg6Q/t3BjC?= =?us-ascii?Q?wJxTZ4giK6SYQ/XMuVenho0aWDCDbyPwHIWjTD4BHTzcicuYEYWS9HxP96rM?= =?us-ascii?Q?z0/bJKkpvzyv2Cfwm8g0qdbtYdh0hV0zu3lShpD+zqkmJSssP2zvwEHFLdZR?= =?us-ascii?Q?5v7x/UERTz1NXIZF0SXiQKWtNIH+hdUvINFnX6kcx6RvBmRFN5VV5NCj3RlL?= =?us-ascii?Q?e7gZ0oriepncJY8Qnibqc9a418A8c8o1bD6H7hYpEilgNmc6XucAcZJxB0n9?= =?us-ascii?Q?5+j7ZNcxGnunkULYQIxnpcd6Da9aR3vyV/uah+HJ3lFAYh/pBNvTS3PUUFjj?= =?us-ascii?Q?Cnft0OXc2TIU1pJMK7oefpmmGtnTmpjBWTFuYZS/MiIlEZTXhLgsoWia4ZwH?= =?us-ascii?Q?H/1S+RnmF3UAPigbYkjAddH/BNCCtPBLnN0kimQtgSHe4anblJ2pe+xcOi4O?= =?us-ascii?Q?EpDnAhe/aB01oNyfeFiTLgSZ51kQsfnSnwY4J04moU4L95xXGa2O4Vzk1ntL?= =?us-ascii?Q?ATj6TW//9wu9Lae4fcGIcsNGRZM9niFUTcFQPQZjTt2zHuGJcj1pNxfsdP0b?= =?us-ascii?Q?qZ33oV5gP6c7DEJ1LuERurVIVQ5Eu7EN8n0UVGEsknhrRh6C2warYPymZp+w?= =?us-ascii?Q?a5XujZyXzoudWra2u+rf5vCcT1hJ+nAcd/2myiJ+pzeSsa8ckdTUvlXGkmY+?= =?us-ascii?Q?ei2DRaowsYkbd+FwWVcjt7DgMLsu+UT6UgT6bWgIfGvcNkr0MAClnYLKGi5b?= =?us-ascii?Q?IW4ZfGIBL5q6YOFbhwTQW3y5O7jthvx0/8jTQCd6grMs1zBlbkH1JqSUvnOj?= =?us-ascii?Q?HUjoyrKcMft/O7jGBL3lH57l4YOOQf1Ug6Ab4OUKLjhpqIF9v828jfOPnTNo?= =?us-ascii?Q?a5TuNJstypuMIwqKwYpKpI1cXQ4nuusgxdphdwV2EG5/PCv/5zKEXyJnwMrS?= =?us-ascii?Q?RVGBISO0cWkA7e24zTtPpE6UaiMNeugCxDfGZKLxzKNuIH0HUxTNlruYb1Lg?= =?us-ascii?Q?0SYCYQxSUJBejjIETZcpJ7eAsYrGDNTRtKhFmTWH/lA96lgT0v2bEQHCP6PT?= =?us-ascii?Q?UHdrFLxz0wO+gL5FyKJSCeAnYxyBpPlQVIqD1Suq98y4UZwgiJgMmdqybSm6?= =?us-ascii?Q?zA=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB3753.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b4dd73e2-b2bc-4963-d2a5-08d99dd6205e X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Nov 2021 07:55:24.0313 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 9F9eqCgFwkdW9YvbcsVoxSx6ilTgZ6ftSyF0PoSR61smMApLenrkTA6hYnHqUoSX0oQ439GA3irTst58uOqNOQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR12MB1691 Subject: Re: [dpdk-stable] [PATCH v5] net/mlx5: fix mutex unlock in txpp cleanup X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Archived-At: List-Archive: > -----Original Message----- > From: Chengfeng Ye > Sent: Tuesday, October 12, 2021 13:02 > To: david.marchand@redhat.com; Slava Ovsiienko > ; Shahaf Shuler ; Matan > Azrad > Cc: dev@dpdk.org; Chengfeng Ye ; > stable@dpdk.org > Subject: [PATCH v5] net/mlx5: fix mutex unlock in txpp cleanup >=20 > The lock sh->txpp.mutex was not correctly released on one path of cleanup > function return, potentially causing the deadlock. >=20 > Fixes: d133f4cdb7 ("net/mlx5: create clock queue for packet pacing") > Cc: stable@dpdk.org >=20 > Signed-off-by: Chengfeng Ye Acked-by: Viacheslav Ovsiienko