patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Slava Ovsiienko <viacheslavo@nvidia.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>,
	Raslan Darawsheh <rasland@nvidia.com>, Ori Kam <orika@nvidia.com>
Cc: "stable@dpdk.org" <stable@dpdk.org>,
	Xiaoyun Li <xiaoyun.li@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Subject: RE: [dpdk-dev] [PATCH v2] app/testpmd: fix gtp psc extension header length
Date: Tue, 16 Nov 2021 13:42:27 +0000
Message-ID: <DM6PR12MB3753A0D26A02D02C9297C739DF999@DM6PR12MB3753.namprd12.prod.outlook.com> (raw)
In-Reply-To: <15512c80-0374-2d4a-6816-354166a22923@intel.com>

> -----Original Message-----
> From: Ferruh Yigit <ferruh.yigit@intel.com>
> Sent: Monday, November 15, 2021 21:02
> To: Raslan Darawsheh <rasland@nvidia.com>; Ori Kam <orika@nvidia.com>;
> Slava Ovsiienko <viacheslavo@nvidia.com>
> Cc: stable@dpdk.org; Xiaoyun Li <xiaoyun.li@intel.com>; dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v2] app/testpmd: fix gtp psc extension header
> length
> 
> On 11/4/2021 9:40 AM, Raslan Darawsheh wrote:
> > Current implementation for raw encap sets the length to be in bytes,
> > but, GTP 'extension' header length is an 8-bit field in 4-octet units.
> >
> > This fixes the length calculation of the header length.
> >
> > Fixes: 9213c50e36fa ("app/testpmd: support GTP PSC option in raw
> > sets")
> > Cc: viacheslavo@nvidia.com
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Raslan Darawsheh <rasland@nvidia.com>
> > ---
> > v2: fix spelling issues
> > ---
> >   app/test-pmd/cmdline_flow.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c
> > index 24b224e632..b4c5aacdbe 100644
> > --- a/app/test-pmd/cmdline_flow.c
> > +++ b/app/test-pmd/cmdline_flow.c
> > @@ -9213,7 +9213,7 @@ cmd_set_raw_parsed(const struct buffer *in)
> >   					uint8_t qfi:6;
> >   					uint8_t next;
> >   				} psc;
> > -				psc.len = sizeof(psc);
> > +				psc.len = sizeof(psc) / 4;
> >   				psc.pdu_type = opt->hdr.type;
> >   				psc.qfi = opt->hdr.qfi;
> >   				psc.next = 0;
> >
> 
> Hi Ori, Slava,
> 
> Can you please review this patch?
Looks good to me.

Reviewed-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>




  reply	other threads:[~2021-11-16 13:42 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-04  9:35 [dpdk-stable] [PATCH] app/testpmd: fix gtp psc extention " Raslan Darawsheh
2021-11-04  9:40 ` [dpdk-stable] [PATCH v2] app/testpmd: fix gtp psc extension " Raslan Darawsheh
2021-11-15 19:02   ` [dpdk-dev] " Ferruh Yigit
2021-11-16 13:42     ` Slava Ovsiienko [this message]
2021-11-16 14:27       ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DM6PR12MB3753A0D26A02D02C9297C739DF999@DM6PR12MB3753.namprd12.prod.outlook.com \
    --to=viacheslavo@nvidia.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=orika@nvidia.com \
    --cc=rasland@nvidia.com \
    --cc=stable@dpdk.org \
    --cc=xiaoyun.li@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

patches for DPDK stable branches

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ http://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git