From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8C405A0544 for ; Mon, 20 Jun 2022 07:16:22 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8609740150; Mon, 20 Jun 2022 07:16:22 +0200 (CEST) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2066.outbound.protection.outlook.com [40.107.92.66]) by mails.dpdk.org (Postfix) with ESMTP id EF19040150; Mon, 20 Jun 2022 07:16:20 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Y34Qs/zwTbfZLMqoVbvEo8doBSfBrnwh+k/fdWIjLNGvNNevz21SLHluEDGjwrzEa3yHkZFD35bo5WCYLTiE5Day2+ax6oH7jOA6xbbHmUwwV7qDN7i4oYpjlecm2NwVChkuGKv398uJihyLlUlwen0+5f9KD6JmiqlJlAuax16L6vMbn3M+Q1QTrVftxdWY6PLGdQhcWhpGeTki/cn6JjkSJ2j0cK9NJeAUBmTiZyL2d3dog4FINvfSit3gjrA1atxVFDBDqKCa2hbWeOzyaGQ5IoGxR5tp8d+m7H46qBuBSQhdIKYHtkl7iq+3aLbZfyTFhAHCYKOMcnniAbHwYw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=T26LN7eit9daozGchbw4T7dIEmNNo4D6YsZoyLDXdbk=; b=dUQ1P6fVRsP9GhCr2J27Co8qpiOZT63yOKq7sufVEQVwltwihWtMXeCg+BhbgnYhCb3cV6xgO8TAeYxXFZ6DdTgmJZkR8GZ+GwvTezrWF8nYqWU7th2Qc1BwFaGiw+KNw4oEZfUUg6zJ7xMzHv6IGHrzTGGfAy485hr2smtVixwPC44byZa527fY6dJDU59hhD0fuJmnOUGkk7ladbwyXAiP4/xX3hKll0TybOAmKYHrUZ9gSqQdoOTpTB/0IPp2DugpwXF7wos+kOfu21BRs96SiWTz5Lh5N4HxDIQrq0shGQlNCI3W9UZVEHl4mIpGbe7VOZLiTay4W6lho3L2og== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=T26LN7eit9daozGchbw4T7dIEmNNo4D6YsZoyLDXdbk=; b=foeb3DGnevi+d7cdIaXzNO79+tBoZMXSJf2nPtFqCWHC3ijvnkbfs8WvpcWUfIZOOn4ON9weCjqRJEJDGvkol2VOq+uL9j891peq4Bfj4IpZ0PHvrziw3DX3j3uFp/L8cM//DN12q7gi9s91tyioGSLO/47DbR+T35Okr2/smaNxQLT5sw22CzB94A87D0nB6DbzsZtM97FPlgXev58oMcuBRfrsq0slWR7BaV/Nl9gOTgGJ2dgqkFr21s3y1YeUtblJpQVS23nlDdQfd3WRa7VxM6z2srU7IcagBI9h98vulvGMW2nwJw70bqjQwUfUf2h2lPPrVHWeoxTZLnXHaw== Received: from DM6PR12MB3753.namprd12.prod.outlook.com (2603:10b6:5:1c7::18) by BN9PR12MB5097.namprd12.prod.outlook.com (2603:10b6:408:136::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5353.15; Mon, 20 Jun 2022 05:16:18 +0000 Received: from DM6PR12MB3753.namprd12.prod.outlook.com ([fe80::8cc6:67d3:8b2e:ff64]) by DM6PR12MB3753.namprd12.prod.outlook.com ([fe80::8cc6:67d3:8b2e:ff64%6]) with mapi id 15.20.5353.020; Mon, 20 Jun 2022 05:16:18 +0000 From: Slava Ovsiienko To: wangyunjian , "dev@dpdk.org" , Raslan Darawsheh CC: Matan Azrad , Michael Baum , dingxiaoxiong , xudingke , "stable@dpdk.org" Subject: RE: [dpdk-dev] [PATCH 1/1] net/mlx5: fix stack buffer overflow of hrxq's rss_key Thread-Topic: [dpdk-dev] [PATCH 1/1] net/mlx5: fix stack buffer overflow of hrxq's rss_key Thread-Index: AQHX+HNW6Wv9Fb6020CzK6qxNCmiLKyJw+yAgCKTAYCArIB/IA== Date: Mon, 20 Jun 2022 05:16:18 +0000 Message-ID: References: <5cd9086411342c7475e3227249d3aa3a3144897d.1640314881.git.wangyunjian@huawei.com> <023022de3a00419b94cd94f6eb90734d@huawei.com> In-Reply-To: <023022de3a00419b94cd94f6eb90734d@huawei.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 3cc8553f-3763-4455-ce96-08da527c01fa x-ms-traffictypediagnostic: BN9PR12MB5097:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: JDAw/Y0LIZWlzI9mxFjQAMgsNOEJxlMkR5PSjiXNoIJTRmw5jZlFNYySYmwfncVsEqcGxU0rxaZgy0wCT4Avbpq1nAoN/AzbOHdjnGlk5KQWN7ihEDRVSl6pxVJrryx2gIk22E8DsRv9gLml7pbwGlXduebHZGTVluXPHmNU10TFOI3n7eWQWJD/TQ6PH/6a6+bVDNlNpBxKaJHZOusxG2ozuBP5nlFhKQl5nUnHVPgeH6VL5k0nE4/9nQDn3vhY+BDcjnV2BQmmt2q8pDXbKLy+lx+efs6yUQFWhMdJ49hNIQS//afk5I+EWrtLfkEYnwqs2cYVmB+Ag04R5U+8kBzaAksoQY68aoz19lJQY+WYpn+AAEiWV0ZhOY4l5PKbVx1K/NUTV6a7ureyuK5cVcb0AaVJPm2FoT/0vSZnwWb4WUpVk1pDgaVx0J5F/OGfILZtc49bSJPU0NV6O3nvJ7iZindSmgtd/LckAKmGUCWCKiUNN0YCamn4J+LeEYFhHzDGPXHZbTZ8A1CYQ3Pf2DElh4JvfdlCkD3EWzlu9ndrhIMUzkfoQYW5H3z1GdssNYy073IjCJmRDQ9WGj1HlBZAsAPJrPvEe1KwcsUWob+afY41qQPWfboiP5jdadE9xdpZyBlPCa5Q8j6XjyfO6RUFvoGYvtS1JiBnfude/G1fhYvqKbmaYASvTN3jbNliFlCeYlAaE99EaDwS90cGBQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR12MB3753.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(4636009)(366004)(396003)(376002)(346002)(136003)(39860400002)(8936002)(86362001)(2906002)(52536014)(7696005)(26005)(9686003)(110136005)(316002)(5660300002)(71200400001)(6506007)(54906003)(6636002)(38100700002)(66946007)(66556008)(66446008)(76116006)(478600001)(38070700005)(64756008)(122000001)(66476007)(8676002)(55016003)(186003)(558084003)(33656002)(41300700001)(4326008); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?u3bosJ9HAjOafc/OpXsWLI7NpKQq8/ed6Bf3sMGhhPJtj8Bq1iSV+AWx1sAG?= =?us-ascii?Q?nRf1ZatqAs19YyAfDxm5D9SrG7Dx1WJS8tP5zoy8RWNNBwkN9RaYG6mbG2kX?= =?us-ascii?Q?07SjxHd2AC6MOeUR7PCoPJZ3Vs+niICDmxD/za5XNHLugrc/Zcc7+L6gKym/?= =?us-ascii?Q?0Zbfraff5pbT5FVxcE6QcDXQNKlcX6gylOTUJfh6WxPQXNq2HkRhyHI8BhV7?= =?us-ascii?Q?8uekDnQnkz2q370ieUi+vtyDzNNXFaH2tby0hHH4yPrJ+7SddiCkc94kvjn3?= =?us-ascii?Q?fX639x/k/ciFXpEiD1JpbjUSbTRmNemouSPs4M8t5mitLezoNAmARjYs8xye?= =?us-ascii?Q?CUm7zxz90EV18LYagWhrtE0CSm+7KZ6nRvKrBhgmSMLvYTzoWL3jhMzE7cYu?= =?us-ascii?Q?Uu8yIB7hEJmIWBgumkPNOxH8dBAZoSTL0A6riVtoULUpH6oKEuGw+sdw340N?= =?us-ascii?Q?c1oxvDS+kr0cd0PwR/F/KYODwJA9KAl1HOd9mduj+SVfAMSq4YMuzf026hPP?= =?us-ascii?Q?pkH//tqVM+2uJnyumzr3+nA2nhFW5zXf6IFXWwzLxovdtCaK5SP/NSJIBkk8?= =?us-ascii?Q?fupJf27i9hQfa6scWE4TVhEMo/C/58Wg3CRhlMLsvFhD2WjKC0y3ve08pmMA?= =?us-ascii?Q?F6mF43Ngjy+12BXupqz0hBpxgiL0h2aWCheRycFtXW0tonN9WXjOHg9JY6kt?= =?us-ascii?Q?g4uA0a0PR6NdZRqROfZbdaeS976u/ASY7aR4PayaUQ41btW3oIedp2tYwVER?= =?us-ascii?Q?LnJlcVgcvHo42QOJMAAVyheuMX2g0c0bxEL/Yz94Mm89dItEVzdwGVA13wS7?= =?us-ascii?Q?bnXOG6LeCLUmJ8EML5elaPC57xgZQGIW+GHMh319uZQMMJXYEp46PRBtCLiz?= =?us-ascii?Q?42V9PkfyWFbBS8V+yNRsMixDqR0aoQqZofRQTrqzgofWhPhnb0JqqKHFhCYz?= =?us-ascii?Q?3kX8gF5YyYA9W/mtqbGNitKHzyPl74j6ZWCDhlsq7VDCn9+oejvj3Oq/khdu?= =?us-ascii?Q?NyYnDcRqUTeI8HVaj2aY8Do05TgRWlUzSCgxFNG0tLBVtwi6BSbpLZp5Myjp?= =?us-ascii?Q?bS/GrGRTyepM3NAC+EwACgyimvVnVjryc2Q/h13vD5s5eS2E05YMJgpVo8eX?= =?us-ascii?Q?bDAvGJB6ZBJk9CkF7Fy+8PpgpulyPKHR2zP/Ucy60psXTm5ah1UmeLgFWlEb?= =?us-ascii?Q?CJ8z1qPrYoDol+J2HmWXSnf2FoDjabs3CcqXGCQ8fl12n9rvhGbOBDFMiwmo?= =?us-ascii?Q?PNRvVLFDoKtYc0iXwxhUFgIPDRHYgDrA7UEJKTBmtYOUkj0cHRyAQDNaBnkx?= =?us-ascii?Q?wpvUTPZdUfg4n3WoAzWc7TIHoBhIQ1KTf9rrrdr4WxUOojiMSFaFXxg9IXKB?= =?us-ascii?Q?oz1gUYWMd2hV06Sm0jYe1pv/bUjfaf5Tsi0UcGjxn6fVqN7LeW0lEEo/TnnF?= =?us-ascii?Q?njuip2qZkbYSMEHo9ayJwlsqUhjNZJyLNxWVz+C0KpufDyxmFeAGemc40P6G?= =?us-ascii?Q?fTYgRZdh25rHu+kf70WODQ9jBaCsG9Qa4Q/sutcBsArF9ehQzfnDCekr0LI/?= =?us-ascii?Q?SnXLPnVW40ENG414OEafaIHTG/t7fmFUlait7pskzUx2B1JhmuRlKH/842P/?= =?us-ascii?Q?3LUYSe5oh3XKO5iK8uCtH+CaQRQJBrZZs6Tvf964sF6uqjYcSVZLvRTU6BkL?= =?us-ascii?Q?l3F9J4e9sl1JRoi5hvUgFUj2E+8AhV7mg+0z1lIWpJIKouxxMimP6LjbwCrl?= =?us-ascii?Q?4YpAj1EGIg=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB3753.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3cc8553f-3763-4455-ce96-08da527c01fa X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Jun 2022 05:16:18.8514 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 57rk9I5B0P4bKMshGNr8U73cSoplqFIMdZTrbelsJ4KT3U6Y2XkgjB61f0vXAUO5OUQr/2GkFMkudNrGW6oagw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR12MB5097 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, Yunjian My sincere apologies for the review delay. I think patch is OK, thank you for finding this. Just of curiosity - did you observe a real crash? Or just found by sanitizer? Acked-by: Viacheslav Ovsiienko With best regards, Slava