From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D2700A0032 for ; Tue, 16 Nov 2021 16:04:19 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7AF37426D8; Tue, 16 Nov 2021 16:04:18 +0100 (CET) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2057.outbound.protection.outlook.com [40.107.244.57]) by mails.dpdk.org (Postfix) with ESMTP id AD221411AE; Tue, 16 Nov 2021 16:04:16 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=K3/Nab0TBWVhXsgwDjELhU0VTeWQcaz/GXhuinfhRLSbNFeAa0+4gYiJ1GMQFaDDzAHrh/YBqcTi5woXo+M2umUSEKmbujdymo9J5OF4vmaXOMBpyEZiePZHWVRAxUzuYybbC0cPTm0LWMJuE+gQA1e+Cl/Maqh3+4GJKaS+vV9mQcybkJPlFNy+XwH1p11WOncKlLqCHxxRKz+nbb0TEf3tILbXbqbUvqSctrR+R9FXNYNIVkKPDPfjCY92zT8h6zclkcL+c/PWHXR4Zu5w6i4Joe/lTVIFWblEo4ZoAMZ4Si3iXum1Bq+ZBkUri07hwQTzRZ0Rl7Jx6c7jmgSNhA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MGaF7mZrxgOgGXUkzsCNxlwOiN7/byIOZop5By7QPyI=; b=VqEWj8x+Z8tN/uG8VebdQQOd3yGX5221Qa/E55GpbaseOav8e3Yw3ZPm+SOQwkw1Wbyt2C5DeQpUhe6lPvirmYv2V9JJYMaQoJuBWSMXZj8QgHpK9t1eIlzRQ6dM2ksPl49j7SzLuksMtuqG4ar+6dQ6utLaR8E5ZIdbGnsABclBGQl+wnTy8cnJWx+HwPM24oVvRHetz9Ua/+0QQaq+vuOeUYOJYk6vAIrSe1zpH9OFiZEkMzNcBC5uwsaObz0h/YtO7uUFBLBhrUidXnjfWPNnAskWp/pc6wFrgeQ+bg3ZZGNpzIvUfliG+vey9ntRdIy2dh2JWi8pvD2LRCcyfQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MGaF7mZrxgOgGXUkzsCNxlwOiN7/byIOZop5By7QPyI=; b=XrqOXp8dMoYDR/dM/v3ZQ/P/YSjI7F4oTXs5w4ldFtxrxfbX7WiQwMoFcFiPF2FkXALFidnS92D4YJfMhFYoOK5Q+Bah1Rmlt15rQhHzYUMxknhGyMNR4Tt30pmHBJzISaAhj5Dvks1lctsqgwN6lcUI1NYoMmtvOfcBVTwW5VN+hG5rpuPxEnkskwOrVrDfpytB/KJazgTFBUOjwSqGwfWGre5TIBGGNL3k+LOj4gjwXLmx7URmmIwdmI/0VqsAKAn966ZJrDovPqq9jv2W6GJFifAVRMpDg4vtiQKTdlmYIeKxr1Z+0VImWgvOH7qCXGfvcDlQA4KU+TG6Ms3W/A== Received: from DM6PR12MB3753.namprd12.prod.outlook.com (2603:10b6:5:1c7::18) by DM5PR12MB2568.namprd12.prod.outlook.com (2603:10b6:4:b5::35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4713.19; Tue, 16 Nov 2021 15:04:15 +0000 Received: from DM6PR12MB3753.namprd12.prod.outlook.com ([fe80::8dc4:eba4:b43b:7d59]) by DM6PR12MB3753.namprd12.prod.outlook.com ([fe80::8dc4:eba4:b43b:7d59%5]) with mapi id 15.20.4690.027; Tue, 16 Nov 2021 15:04:15 +0000 From: Slava Ovsiienko To: Chengfeng Ye , Matan Azrad , Tzahi Oved , "ferruh.yigit@intel.com" , Raslan Darawsheh CC: "dev@dpdk.org" , "stable@dpdk.org" Subject: RE: [PATCH v6] net/mlx5: fix mutex unlock in txpp cleanup Thread-Topic: [PATCH v6] net/mlx5: fix mutex unlock in txpp cleanup Thread-Index: AQHX2vkwRxpXbSfbxUysrT+lASQF06wGP71Q Date: Tue, 16 Nov 2021 15:04:14 +0000 Message-ID: References: <20211116144923.7342-1-cyeaa@connect.ust.hk> In-Reply-To: <20211116144923.7342-1-cyeaa@connect.ust.hk> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 6cbadb69-5ee6-47dc-136d-08d9a9125af3 x-ms-traffictypediagnostic: DM5PR12MB2568: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4941; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Ejx1FRZGOr4ioaLdNbo5THe0us1Ntp4DGjTYoGNmjYCfHNG9Hvp8ttuz3MCT8ZjlH5diOUaFmsPcTSBiS1r3QxNzG7ImFp95urCE75YdZiKgHw56E2CiRz6sRB0kMHn8cVtJQ07/xSDVRVPeQdQlCSv63rmmdhQ+gSRPxJan2gM6yQ5SSPM7AB1pYftTf5tlD6WgzXT3hkuqpO/QGsPw92Eb+EH18qDuqhoxOtP5Y5tVMlfxDl4dnILWuXcf8+wWIPythChd2/7CRJdPgMw63j9IxAZjNyT3kUOE7J9kkvQxqdRc1noPPMlI8koWYQR1F97FkWiKVjQPYTcCVRaWiSCQqVt3MmoSWRg3Qs2DSboUTSb3FM6oj91grhL1SRCaf95gW8GljiG9mPv4mTeUJX+S1aMb0kEtDphGrQC2CDgwS2rtFuqhz+q8haaR8Q7y7sHXl/P77BfG5F0uxdMP02GCVWr7k4p4rebTe0a9Fwef7zIE+J1Rwv1a/gWjphcIlBUxQEZ54QiyBJZTmFSnGhMu10ewtbWthctaPih2PpnX++a/SPnVusMYHVT3iWIO/wpyqeWy1sNjGtArd2X4SCAoRGPov0PVRwsQzZzuOt523uZ0ZCwrW7vxDjlVxT+5uZuRyAgIAxFaKC1mq+GHlXW/5ReNDHIviEjMIxMxiPCwaSoh9tPuv5dZHaXk9qSIlBqkpYLST7Ir+3K6tel4xQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR12MB3753.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(2906002)(83380400001)(52536014)(26005)(4744005)(7696005)(110136005)(33656002)(9686003)(55016002)(38070700005)(71200400001)(8936002)(76116006)(316002)(66946007)(296002)(66476007)(66556008)(38100700002)(8676002)(66446008)(6506007)(6636002)(4326008)(122000001)(53546011)(64756008)(186003)(54906003)(508600001)(5660300002)(86362001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?JuTRpIdivAbDIbsc1cUAUO8fKmhElfP4E1g5wGhFP/D+5tpP36HU99Lyq731?= =?us-ascii?Q?NCH5kc1+af+Oo6mHYS9keGnKuZ1K0fHOM3PVOAoDLy43Gjhxs6NreioW04iD?= =?us-ascii?Q?Q6+T7MNxnX9wGC3YWfluoDOPrC86z0+kMAkRZzHeBm7dNRfbkWWqmxtYwiWt?= =?us-ascii?Q?Uhcq1Al6rxDfOJphJl14wglYG0G/4drlwzVNIQ3cFXzm+7VtiDR9Mo0PLLmV?= =?us-ascii?Q?SkQ3aXFx8D9onV3qDtmoMKELrfDFCJPnFUwdt6aKYWUV9Fx+8CXTDiZOTg5L?= =?us-ascii?Q?7X2/yuzENHANQecrH1Ew+bsKE2/EnB4GDTXQsXcZxwAjKNeGmJRHRGFte907?= =?us-ascii?Q?fiOrJZzksgS+WzXrB40ilxsdP1LNCL52NtoNDQI3zmT+JTgdSA/Bak7hvJuZ?= =?us-ascii?Q?WW+PCXiGjwuAKMFudugx1eO7ljMFMKKFibeRjY3iLjqxQCI5MQ0Y/DP1hlAG?= =?us-ascii?Q?+KDmOloEmCYNLK25yuED31aOZ1JyJEAPDcko2gNHW/Tq019lFOoMZ3avwtBK?= =?us-ascii?Q?oGCDnHAeIjZ2q+9hCN/CdWYTXhg2ZJqmA7iGhcCGJCESBRZMYtePPe172jeL?= =?us-ascii?Q?/gIcypZUG3uOJhI1dn/MV35FZrdS1qUutO9tLwN7NAn3OJVCYp5ZGniTsM4p?= =?us-ascii?Q?Mxle7Cb+4dqA39enRoHqsjTY6UmkPbKngK6QQ8S0cG2bC9Iw5yUOXp+uEmRY?= =?us-ascii?Q?KSCj/f0DKsegwNzgte9PiMLLz3WDACKkr+D7UkkTPp2Gc7Ys7mxJttG1aMhH?= =?us-ascii?Q?flDUIwDqHjHz4Fv5teypaDi/EM8VC1QTM4NH/QcKHJCvaYnufcQ+YjoaNh8n?= =?us-ascii?Q?uuUzMF5bgxxfl8Sn9FPM3yfZkSZkKdtZJ5oHvpPf0zUj+pu0Tf6Z1YRnFt2X?= =?us-ascii?Q?Km23pAhS826EB16PHjvYUkaQKow5gqbIFMRi++BRoL4S49RnRXKjtFr5IMPO?= =?us-ascii?Q?0SDS90skl43CQC+eWINSW+GSc+49Z/kJpVWBy+dREgfE2ewrbTvktafoMeE2?= =?us-ascii?Q?13xia3opoY9V0QgqxXpHB17MBFnflmmP48huqZ39TjJa6Ljy4BXvilrhHJt9?= =?us-ascii?Q?V3Ert9SF96yfUTgR/n7bITrOmAdde+R9xLmEQMX4Ml/pVRI2+6upIg0FTDZy?= =?us-ascii?Q?Sh8V7LKndRNs1X4ZDUsTR+FGV+glv/XFFIjc7OVJIy+/5LR8DHzAHf4aBtD6?= =?us-ascii?Q?q/bLetgxKBTZUn9SIYP0cXg9OYTsN0Tr4biXRZMFP+7uRrVEF1A/Ec+LmM6x?= =?us-ascii?Q?rBA8k3pejvFJMDCTm/VCTwpL9JdUDOXzuVOIDnVbj7y7r5I1keMHfU0FPblR?= =?us-ascii?Q?vdfT9k8w0CZAP5KJC+wEH3F0otlajVLG7ardM2pA7RegF41lPo8zPXAq+KPc?= =?us-ascii?Q?GCJaIrJAk3LHztSvqkPuprqrPyUDAnY6xe2p8Yfqm4K9ZknjjiWxjsWqmffH?= =?us-ascii?Q?zAJ3IISYot7oMrmaWvFiC5BD5GgxweCRJuh+WlY48oGxfxGbjZHSyzlPfG7T?= =?us-ascii?Q?9pdMgVp3SZ/PUDOifnfJiNU6BNk5j6P/bwe3VsdHmkwlsxU58W4r3mtkjFPi?= =?us-ascii?Q?zWjRRWiekBMOk1HUMqDeJJNkmWaWoSkl+ur1MIrA9NWNYmBO9ugebVbdBJYR?= =?us-ascii?Q?HA=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB3753.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6cbadb69-5ee6-47dc-136d-08d9a9125af3 X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Nov 2021 15:04:14.9131 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Esz6ohZrZvq18Z2kwnOelB2hzbhKUlhuW6NRQ51O99W87R1UmX/F8kn5rnffhPJLbvChLjgsGkU3QAYBtYfuCQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR12MB2568 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org > -----Original Message----- > From: Chengfeng Ye > Sent: Tuesday, November 16, 2021 16:49 > To: Matan Azrad ; Slava Ovsiienko > ; Tzahi Oved ; > ferruh.yigit@intel.com; Raslan Darawsheh > Cc: dev@dpdk.org; Chengfeng Ye ; stable@dpdk.org > Subject: [PATCH v6] net/mlx5: fix mutex unlock in txpp cleanup >=20 > The lock sh->txpp.mutex was not correctly released on one path of cleanup > function return, potentially causing the deadlock. >=20 > Fixes: d133f4cdb7 ("net/mlx5: create clock queue for packet pacing") > Cc: stable@dpdk.org >=20 > Signed-off-by: Chengfeng Ye Acked-by: Viacheslav Ovsiienko