From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <stable-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 56569A0C45
for <public@inbox.dpdk.org>; Mon, 18 Oct 2021 07:16:16 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 40EDA410DA;
Mon, 18 Oct 2021 07:16:16 +0200 (CEST)
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
by mails.dpdk.org (Postfix) with ESMTP id 4A9D34003C;
Mon, 18 Oct 2021 07:16:13 +0200 (CEST)
X-IronPort-AV: E=McAfee;i="6200,9189,10140"; a="215336398"
X-IronPort-AV: E=Sophos;i="5.85,381,1624345200"; d="scan'208";a="215336398"
Received: from fmsmga006.fm.intel.com ([10.253.24.20])
by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
17 Oct 2021 22:16:05 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.85,381,1624345200"; d="scan'208";a="717374453"
Received: from orsmsx605.amr.corp.intel.com ([10.22.229.18])
by fmsmga006.fm.intel.com with ESMTP; 17 Oct 2021 22:16:05 -0700
Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by
ORSMSX605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
15.1.2242.12; Sun, 17 Oct 2021 22:16:04 -0700
Received: from orsmsx603.amr.corp.intel.com (10.22.229.16) by
ORSMSX608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
15.1.2242.12; Sun, 17 Oct 2021 22:16:04 -0700
Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by
orsmsx603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
15.1.2242.12 via Frontend Transport; Sun, 17 Oct 2021 22:16:04 -0700
Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.173)
by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
15.1.2242.12; Sun, 17 Oct 2021 22:16:04 -0700
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
b=WzlKVnT18ziqjQ3ki7T+yb6S39OlZMHIQFwaTCoQMfDzC77C2IiCYXfclk1kQ577DKcm0pAvB3PsW/ZjXaNuIycx2cO3rHXwPRIXZZkB8fxCtHriQjjYif2MXgSTdFxEqYqHQmrfYzuJX7ms+HhcNeWOIHR9qJnjBgVZHXC0YwkzSEDtYeHLHKkVRAd2hkiOauj+4hvcLsq05W/If7S7ce4ObtQJUT267e6Yu6OcweUeMcCiLPWnyyURrE52yanxKR/3GV7UFu8+Mfo85ALDFWSA0BGQeMJp5JqE7GwhV4YRuh4L00byfzUNjkhEQpxm182ZrFKHzdyeFe/1dzS00w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
s=arcselector9901;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
bh=8Et3TnXBWgCKYsqpybfGA+SDdr/xsRDDoKIDvs3nVFA=;
b=AMJ/SzKB87WtNGO4N/38YmZeL53ryIQmeVEiXXc0JDShKghEaG6nXqOMMoEAxHWicnAOHcaknT50/avSyezOSwhLSTZWI67POvFB1ffkLa0ZBOOm9MecQDeJpM/6EmvIFqbun80MOi9iW9rgzjVSkSv5ngLW+0av1XT3EXUHQ7tXMC9lZi/wwykJTNw6D1UGE+2rfWDGF90sWoE3SAKqBZ6G0TKPZhjimCnALhv9odMFcs5WpmQnLo2NamLeiCChSCHCitBnKpEc7ojyo6V1SAXQt7QGeoRMX1OMQ+58e/RpL5RWV/zjukaSQv9+H5vniWGPjnBBvG5VgQQu+y76EA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com;
dkim=pass header.d=intel.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com;
s=selector2-intel-onmicrosoft-com;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
bh=8Et3TnXBWgCKYsqpybfGA+SDdr/xsRDDoKIDvs3nVFA=;
b=b37nFo80dNOALOo9lo0GDqzLsD/isft1sfKBC9ss8nqAUr/9xDUhOAhMZoIMpDzGChJnwTFmZ5YzdU0kRIL2MZnpghKCanY3EvYbNRKCZgddreeqxBjb3nOzBQ1Y/dk4zFw0T72OxtykNA+lKzKCa5+XXivaeHuoGXZXYoEvaHs=
Received: from DM8PR11MB5591.namprd11.prod.outlook.com (2603:10b6:8:38::23) by
DM8PR11MB5655.namprd11.prod.outlook.com (2603:10b6:8:28::10) with
Microsoft
SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
15.20.4608.17; Mon, 18 Oct 2021 05:16:03 +0000
Received: from DM8PR11MB5591.namprd11.prod.outlook.com
([fe80::3d47:b590:aa2a:d5cc]) by DM8PR11MB5591.namprd11.prod.outlook.com
([fe80::3d47:b590:aa2a:d5cc%9]) with mapi id 15.20.4608.018; Mon, 18 Oct 2021
05:16:03 +0000
From: "Peng, ZhihongX" <zhihongx.peng@intel.com>
To: Olivier Matz <olivier.matz@6wind.com>
CC: "dmitry.kozliuk@gmail.com" <dmitry.kozliuk@gmail.com>, "dev@dpdk.org"
<dev@dpdk.org>, "stable@dpdk.org" <stable@dpdk.org>
Thread-Topic: [PATCH v4 1/2] lib/cmdline: release cl when cmdline exit
Thread-Index: AQHXv9aDveVd2w7+6UCpIc9cOqO9VKvUCPCAgAQ1oBA=
Date: Mon, 18 Oct 2021 05:16:03 +0000
Message-ID: <DM8PR11MB559100B9AA2D93815B60A7EDF0BC9@DM8PR11MB5591.namprd11.prod.outlook.com>
References: <20211008064131.369133-1-zhihongx.peng@intel.com>
<20211013015223.1155876-1-zhihongx.peng@intel.com>
<YWl645tInjBTRiBZ@platinum>
In-Reply-To: <YWl645tInjBTRiBZ@platinum>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: 6wind.com; dkim=none (message not signed)
header.d=none;6wind.com; dmarc=none action=none header.from=intel.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 093557cb-9a2d-49f7-c8b6-08d991f6619a
x-ms-traffictypediagnostic: DM8PR11MB5655:
x-microsoft-antispam-prvs: <DM8PR11MB56557BBA4461F813CD750A7EF0BC9@DM8PR11MB5655.namprd11.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:6430;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: ngeGuadQA54iJHy2EPxJsj/2XnC6vDBndMt+wy6axgnbzz792BFReNRr1rxABw7zYLXF0IEfIY/Y1JYHE04AaWAIvaJ3JC/GUdB2MmOpx2vDFtWYWm2gxbANY5KewCG1lv/E0DMpURJxjbq1QQXtWSaiafQVu5e4KStGtL98sG/ejsgQoA63LtcFulrl89kc7sQzCW+WDDplPPWJWOH/iaZfAlCR67iutyTZsNEuNHafVYw5J1S1w3c6Ved3M0f1v3Oj8cxM3MP8EZ5Z2Pm9p4zqOe6lWyPxpJzrlQqZICuKosshM+cpMBE5V3GJejpP9ibGY76atk9BQSjXStrnaHeQzgb/7EAF6p6XVxPS7wuHJJM3q6tguU0WecDrd7ksoPisgmXdSHxVVa+8WJgNK9TwFzlsQL9xq3HXV8TCkX8cKFE7MJGn/nSvW4awhzZwkfk77wNxeMZSESAL43GMe9mRk+K0QJ8NyUZ//73iPDMzwaslgfUzFOumug+K7YlkaO0e8ZEqle6Lby5Mcad9z8ro4gAX+AfLf1mthTsDZnb1XdenwIybBhUAs+zAsT0a9gRct0BbEAYW7mLEMEBwteoT9KO5ntnwekVguNEpOs+P77M3KhS/0SVnbjuAH4aGYLb+IcB/CVZ6s0gs0LOddsol1KRcxETIzPnppJqUlljLIvB+dSP0CA3ks26JzN0RWwGUOs8nBdJk3jvFVVDKkA==
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;
IPV:NLI; SFV:NSPM; H:DM8PR11MB5591.namprd11.prod.outlook.com; PTR:; CAT:NONE;
SFS:(366004)(76116006)(38070700005)(83380400001)(54906003)(6916009)(66476007)(64756008)(66556008)(71200400001)(66946007)(186003)(4744005)(6506007)(52536014)(8676002)(508600001)(86362001)(66446008)(5660300002)(7696005)(82960400001)(122000001)(38100700002)(2906002)(55016002)(26005)(8936002)(53546011)(4326008)(316002)(33656002)(9686003);
DIR:OUT; SFP:1102;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?yJOJLfXwHdMSayhpHMd2nFRqe0YWKf0UaMBecwvJV6fNvwHpFHoStL++7Fev?=
=?us-ascii?Q?Ai0cKcp8dgUcnCS2RV29b67ailMpDGujHLhk3MvFBqw0txaifYM/la8naw4W?=
=?us-ascii?Q?hcYMqefpN/gg95DEk3ti8ivQ/iXROqjl7amIKpgtNeF6niFFBrPxh3SiaQ9D?=
=?us-ascii?Q?0fVfLUCwNBRmHP+ExgJz/oufKFIyCyCgLLuZTSdlcuEjFjZiXs8nAFHt53Pj?=
=?us-ascii?Q?vZZynPZjebRX+ooiPCCxtZrYucPqpEW3H9oYMrUKvufg0i/xtY+wCEfTmHhh?=
=?us-ascii?Q?lIBfUSuiDHshDwgzERZJ/jk8W6FOQe8KbEsPxzfnChpUdjrTv3HP1xZgZTq5?=
=?us-ascii?Q?lIvAy8jxKD0g8t+fo6oRfmRzv3ieDG384a+b5wBWfqxLWSIx13Qwp0SNJ+5D?=
=?us-ascii?Q?dKU/GMMvoyvBnawY3ra1Dy4NdjhTHJe7JKuZrKHcgnPw6uGa/D0KLs8JpBGN?=
=?us-ascii?Q?o6hxOstRdWtrxBZKeD4fkQSOB3uMwxjlJxq4FTVvGuUqqiyi33hvGiEvi1YF?=
=?us-ascii?Q?+1rZcM+W9tUWP1bvZYaruGS3Nrhir/IQ6el+VeXif/QmBfBElP9koOEPIKkK?=
=?us-ascii?Q?b/k6/kZkcIpqlAXfgriMXl/+RsUOuMS+TvydFX+96IFhyAmYpeUiQpJ/0r9c?=
=?us-ascii?Q?QKA45KLd28c2h0v+KsnwdkxDvQNryA8Esi27Fv5I+QSmBVSnDiDpowLDz9IJ?=
=?us-ascii?Q?vDnnwIk75DE/qMWblGk1Wxl0Ck+MPHbbGRzE1ljciUAK+1zYXvchsRFZONa5?=
=?us-ascii?Q?FiXoN5YVUFfksnQykh9/lBo3x84w48S78quYrwNhU2uKZasp4h3/mx22GVbz?=
=?us-ascii?Q?T666Xws35wChl+VEhDmUwTmVk+Mk3gKVn6ssVMQBLtIEI+6lNXUpGnoi07Lp?=
=?us-ascii?Q?UiSPEj54OlA6YofPAtjaEEWLUnMMcEERAX2JQ9qzjLc/DcTIrqvjp0LpZxTe?=
=?us-ascii?Q?PMnaSUjsUtTSow7gqFi4dHvwCM4yaaMJ9fCmQA3STi/AnPrLPL4t7aZ2azaw?=
=?us-ascii?Q?75JYg/L0ysLfat+1hmDgSoctywQqab2fKY96nhlgfnYi4vl7A1zO9X/+O0d9?=
=?us-ascii?Q?bvVEkY4UZd1xbu4sQ7g+P5fazLHP4zWfbPW7oL5LqDi9mY5JZ6CoWlpSUHJu?=
=?us-ascii?Q?cN32bqtC3vvhYrgPPLRfCaOxcP7r/P9tNkodaDY39Sanu6VlX3SkEMIUDeBA?=
=?us-ascii?Q?U2TR2GyDVZplSwu2MlDj0AqZGO0lx1lUgfkABSkX7qUk93BvKR2MOfQ1H93c?=
=?us-ascii?Q?14Noy8D3jt34nKFgvm1yjKd68FAmjjOrm0TF3eOCDre/xHyZ5+SulNR/wren?=
=?us-ascii?Q?JgY=3D?=
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM8PR11MB5591.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 093557cb-9a2d-49f7-c8b6-08d991f6619a
X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Oct 2021 05:16:03.4196 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Usx17RGoLK/dN6zMvolOwlWTOjRoadz3x7mu9Ve6zosSrhYdeCKXFl7T6Kc3Kxfk32VuhXoda5aLF9RTRbA2TA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR11MB5655
X-OriginatorOrg: intel.com
Subject: Re: [dpdk-stable] [PATCH v4 1/2] lib/cmdline: release cl when
cmdline exit
X-BeenThere: stable@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: patches for DPDK stable branches <stable.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/stable>,
<mailto:stable-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/stable/>
List-Post: <mailto:stable@dpdk.org>
List-Help: <mailto:stable-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/stable>,
<mailto:stable-request@dpdk.org?subject=subscribe>
Errors-To: stable-bounces@dpdk.org
Sender: "stable" <stable-bounces@dpdk.org>
> -----Original Message-----
> From: Olivier Matz <olivier.matz@6wind.com>
> Sent: Friday, October 15, 2021 8:58 PM
> To: Peng, ZhihongX <zhihongx.peng@intel.com>
> Cc: dmitry.kozliuk@gmail.com; dev@dpdk.org; stable@dpdk.org
> Subject: Re: [PATCH v4 1/2] lib/cmdline: release cl when cmdline exit
>=20
> On Wed, Oct 13, 2021 at 01:52:22AM +0000, zhihongx.peng@intel.com wrote:
> > From: Zhihong Peng <zhihongx.peng@intel.com>
> >
> > Malloc cl in the cmdline_stdin_new function, so release in the
> > cmdline_stdin_exit function is logical, so that cl will not be
> > released alone.
> >
> > Fixes: af75078fece3 ("first public release")
> > Cc: stable@dpdk.org
>=20
> As said by Dmitry, we should not backport this fix to avoid breaking exte=
rnal
> apps.
The v5 version will be fixed.
> > Signed-off-by: Zhihong Peng <zhihongx.peng@intel.com>
>=20
> I suggest to merge the 2 patches in one, because the second is mandatory
> when the first one is applied.
The v5 version will be fixed
> Thanks Zhihong, and thanks Dmitry for the previous review.