patches for DPDK stable branches
 help / color / mirror / Atom feed
From: "Peng, ZhihongX" <zhihongx.peng@intel.com>
To: "Dumitrescu, Cristian" <cristian.dumitrescu@intel.com>,
	"david.marchand@redhat.com" <david.marchand@redhat.com>,
	"Burakov, Anatoly" <anatoly.burakov@intel.com>,
	"Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
	"stephen@networkplumber.org" <stephen@networkplumber.org>,
	"Mcnamara, John" <john.mcnamara@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	"Lin, Xueqin" <xueqin.lin@intel.com>,
	"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [PATCH v10 3/4] pipeline: Fix compilation error with gcc ASan
Date: Mon, 18 Oct 2021 12:54:40 +0000
Message-ID: <DM8PR11MB559122083D4288EBF191E63AF0BC9@DM8PR11MB5591.namprd11.prod.outlook.com> (raw)
In-Reply-To: <DM8PR11MB5670CEA218367FFD07A4D4B8EBBC9@DM8PR11MB5670.namprd11.prod.outlook.com>

> -----Original Message-----
> From: Dumitrescu, Cristian <cristian.dumitrescu@intel.com>
> Sent: Monday, October 18, 2021 8:22 PM
> To: Peng, ZhihongX <zhihongx.peng@intel.com>;
> david.marchand@redhat.com; Burakov, Anatoly
> <anatoly.burakov@intel.com>; Ananyev, Konstantin
> <konstantin.ananyev@intel.com>; stephen@networkplumber.org;
> Mcnamara, John <john.mcnamara@intel.com>
> Cc: dev@dpdk.org; Lin, Xueqin <xueqin.lin@intel.com>; stable@dpdk.org
> Subject: RE: [PATCH v10 3/4] pipeline: Fix compilation error with gcc ASan
> 
> 
> 
> > -----Original Message-----
> > From: Peng, ZhihongX <zhihongx.peng@intel.com>
> > Sent: Friday, October 15, 2021 4:11 PM
> > To: david.marchand@redhat.com; Burakov, Anatoly
> > <anatoly.burakov@intel.com>; Ananyev, Konstantin
> > <konstantin.ananyev@intel.com>; stephen@networkplumber.org;
> > Dumitrescu, Cristian <cristian.dumitrescu@intel.com>; Mcnamara, John
> > <john.mcnamara@intel.com>
> > Cc: dev@dpdk.org; Lin, Xueqin <xueqin.lin@intel.com>; Peng, ZhihongX
> > <zhihongx.peng@intel.com>; stable@dpdk.org
> > Subject: [PATCH v10 3/4] pipeline: Fix compilation error with gcc ASan
> >
> > From: Zhihong Peng <zhihongx.peng@intel.com>
> >
> > The gcc will check code more stricter when ASan enabled.
> > "Control reaches end of non-void function" error occurs here.
> >
> > Fixes: f38913b7fb8e ("pipeline: add meter array to SWX")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Xueqin Lin <xueqin.lin@intel.com>
> > Signed-off-by: Zhihong Peng <zhihongx.peng@intel.com>
> > ---
> > v7: no change
> > v8: no change
> > v9: Modify the submit log
> > v10:no change
> > ---
> >  lib/pipeline/rte_swx_pipeline.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/lib/pipeline/rte_swx_pipeline.c
> > b/lib/pipeline/rte_swx_pipeline.c index 1cd09a4b44..0acd6c6752 100644
> > --- a/lib/pipeline/rte_swx_pipeline.c
> > +++ b/lib/pipeline/rte_swx_pipeline.c
> > @@ -4642,7 +4642,7 @@ instr_meter_translate(struct rte_swx_pipeline *p,
> >  		return 0;
> >  	}
> >
> > -	CHECK(0, EINVAL);
> > +	return -EINVAL;
> >  }
> >
> >  static inline void
> > @@ -5937,7 +5937,7 @@ instr_translate(struct rte_swx_pipeline *p,
> >  					      instr,
> >  					      data);
> >
> > -	CHECK(0, EINVAL);
> > +	return -EINVAL;
> >  }
> >
> >  static struct instruction_data *
> > --
> > 2.25.1
> 
> NACK.
> 
> This is a false issue, no bug is here. CHECK(0, EINVAL) translates to an
> unconditional return -EINVAL.
> Does this tool work correctly when macros are present? Maybe the tool
> should parse the preprocessed C code as opposed to initial C code?

Yes, this is not a bug, it just solves the problem that cannot be passed after
adding the asan compiler option.
Only part of the macro reports errors, which may be caused by the tool itself,
but this tool is part of gcc and clang, so we still have to make the code not report errors.
> Regards,
> Cristian

  reply	other threads:[~2021-10-18 12:54 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20210918074155.872358-1-zhihongx.peng@intel.com>
     [not found] ` <20210924022028.1291404-1-zhihongx.peng@intel.com>
2021-09-24  2:20   ` [dpdk-stable] [PATCH v4 2/2] lib/pipeline: Fix gcc compilation error using ASan zhihongx.peng
     [not found]   ` <20210924093309.3411-1-zhihongx.peng@intel.com>
2021-09-24  9:33     ` [dpdk-stable] [PATCH v5 2/2] " zhihongx.peng
     [not found]   ` <20210924100310.4278-1-zhihongx.peng@intel.com>
2021-09-24 10:03     ` [dpdk-stable] [PATCH v5 2/2] lib/pipeline: " zhihongx.peng
     [not found]     ` <20210930052724.195414-1-zhihongx.peng@intel.com>
2021-09-30  5:27       ` [dpdk-stable] [PATCH v6 " zhihongx.peng
2021-09-30  8:29         ` David Marchand
2021-10-12  2:41           ` Peng, ZhihongX
     [not found]     ` <20210930125938.266731-1-zhihongx.peng@intel.com>
2021-09-30 12:59       ` [dpdk-stable] [PATCH v6 2/2] lib/pipeline: Fix compilation error with gcc ASan zhihongx.peng
     [not found]       ` <20211008091751.417468-1-zhihongx.peng@intel.com>
2021-10-08  9:17         ` [dpdk-stable] [PATCH v7 3/3] " zhihongx.peng
     [not found]         ` <20211011062810.422220-1-zhihongx.peng@intel.com>
2021-10-11  6:28           ` [dpdk-stable] [PATCH v8 " zhihongx.peng
     [not found]           ` <20211012094318.1154727-1-zhihongx.peng@intel.com>
2021-10-12  9:43             ` [dpdk-stable] [PATCH v9 3/3] pipeline: " zhihongx.peng
     [not found]               ` <20211015142739.1876210-1-zhihongx.peng@intel.com>
2021-10-15 14:27                 ` [dpdk-stable] [PATCH v10 3/4] " zhihongx.peng
2021-10-15 14:27                 ` [dpdk-stable] [PATCH v10 4/4] performance-thread: Fix cross compilation failed zhihongx.peng
     [not found]               ` <20211015151110.1876850-1-zhihongx.peng@intel.com>
2021-10-15 15:11                 ` [dpdk-stable] [PATCH v10 3/4] pipeline: Fix compilation error with gcc ASan zhihongx.peng
2021-10-18 12:21                   ` Dumitrescu, Cristian
2021-10-18 12:54                     ` Peng, ZhihongX [this message]
2021-10-19 11:26                       ` Dumitrescu, Cristian
2021-10-19 12:11                         ` Peng, ZhihongX
2021-10-15 15:11                 ` [dpdk-stable] [PATCH v10 4/4] performance-thread: Fix cross compilation failed zhihongx.peng
2021-10-19  6:02                   ` Peng, ZhihongX
     [not found]                   ` <20211019101207.1451058-1-zhihongx.peng@intel.com>
2021-10-19 10:12                     ` [dpdk-stable] [PATCH v11 3/4] pipeline: Fix compilation error with gcc ASan zhihongx.peng
2021-10-19 10:12                     ` [dpdk-stable] [PATCH v11 4/4] performance-thread: Fix cross compilation failed zhihongx.peng
2021-10-19 10:37                       ` Bruce Richardson
     [not found]                       ` <20211019130445.1955622-1-zhihongx.peng@intel.com>
2021-10-19 13:04                         ` [dpdk-stable] [PATCH v12 " zhihongx.peng
     [not found]                       ` <20211019135841.2004819-1-zhihongx.peng@intel.com>
2021-10-19 13:58                         ` zhihongx.peng
     [not found]                       ` <20211019151524.2005442-1-zhihongx.peng@intel.com>
2021-10-19 15:15                         ` zhihongx.peng
     [not found]   ` <20211015141326.1875898-1-zhihongx.peng@intel.com>
2021-10-15 14:13     ` [dpdk-stable] [PATCH v10 3/4] pipeline: Fix compilation error with gcc ASan zhihongx.peng
2021-10-15 14:13     ` [dpdk-stable] [PATCH v10 4/4] performance-thread: Fix cross compilation failed zhihongx.peng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DM8PR11MB559122083D4288EBF191E63AF0BC9@DM8PR11MB5591.namprd11.prod.outlook.com \
    --to=zhihongx.peng@intel.com \
    --cc=anatoly.burakov@intel.com \
    --cc=cristian.dumitrescu@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=john.mcnamara@intel.com \
    --cc=konstantin.ananyev@intel.com \
    --cc=stable@dpdk.org \
    --cc=stephen@networkplumber.org \
    --cc=xueqin.lin@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

patches for DPDK stable branches

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ http://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git