From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 30691A034F for ; Wed, 10 Nov 2021 08:24:39 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1E5F140142; Wed, 10 Nov 2021 08:24:39 +0100 (CET) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id 9CD0540142 for ; Wed, 10 Nov 2021 08:24:37 +0100 (CET) X-IronPort-AV: E=McAfee;i="6200,9189,10163"; a="318820007" X-IronPort-AV: E=Sophos;i="5.87,223,1631602800"; d="scan'208";a="318820007" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Nov 2021 23:24:36 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,223,1631602800"; d="scan'208";a="452212123" Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19]) by orsmga006.jf.intel.com with ESMTP; 09 Nov 2021 23:24:35 -0800 Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Tue, 9 Nov 2021 23:24:35 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Tue, 9 Nov 2021 23:24:35 -0800 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.176) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Tue, 9 Nov 2021 23:23:48 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Bj5onG9H9K9ZEuFuisNkFP9nFL98+5NO0xzgnhOyorxV5dy9c93064gxSLep6GdzOoMr/xU8tQKD0MDAlNa9a5XFxVR7LXGlWdNv1yQi+/OIns5gagYKj9mYqfVkIeW02uXYybSB2ANY14qaLR9MRKZ/UgzEHFM2n2VJQLrq5ol7+Ew5YQa9BDpF1q+UAJakqPUS9uLWFwVZ/15EGYq2O5qqbTt36sHzSGfElqvX6pvJ7jUrPm5kTnePRt7NpBMHFzWCpPG71EoFIkNCg9siglZYg2GldRrkRpvFhzR94Cnp0mILybGB6jlI9INf3M48FJbl/+Hx6zaju3mmxUtqPw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=eJFYs2Uga3l2X81934sE6hhQjlsNCCAwQVxLmnCNHXM=; b=nkUnVofZ3ARczQWF+pU90Bx+reoMIcIwdB56xupSnEStvDLhp1inZdb3fGnlVP6szUta6zEB4eita/iciLGxsT5m4tD4ZoS3xLmWoUZA2Gwx/IwuO1kx9GXvs+rqSPgthZHgRLRXMS7cTWXAApE3bSdlcdOP9FMD3+w+34DaGQLXVfRu8UhDpvJj1HY0U6A+MOgYmWVac1JxWi3jn98mdgkcupyJv+3y9RqqLB+0p2DHZ4w+N1x2+72G7MFeEp7Cf6rClhCQ4dqLn0z0wFFd3kUDX07yPXNI4oMVOPxSs3em5a6tnx0XWAginvzxBFCgXShrH9rPBuxEY+/ljVWfWg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eJFYs2Uga3l2X81934sE6hhQjlsNCCAwQVxLmnCNHXM=; b=JgJJt9hm43JBp2t2I/P+bQeN5FyUcvX+yEWFOBazyU9bC1r3NZqDK7Mm2F3Z/slFdTrVkIpiwgRMt2LH5XbyjE7wSM/oDL3ckIjCQ4tlwckPRbjsea26KfrLjHIHVY5dmOgRjd60gI9L0UVh6N+rGESobcFbsoqntYA+F3PeCOc= Received: from DM8PR11MB5591.namprd11.prod.outlook.com (2603:10b6:8:38::23) by DM8PR11MB5622.namprd11.prod.outlook.com (2603:10b6:8:36::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4669.16; Wed, 10 Nov 2021 07:23:47 +0000 Received: from DM8PR11MB5591.namprd11.prod.outlook.com ([fe80::3d47:b590:aa2a:d5cc]) by DM8PR11MB5591.namprd11.prod.outlook.com ([fe80::3d47:b590:aa2a:d5cc%9]) with mapi id 15.20.4669.010; Wed, 10 Nov 2021 07:23:47 +0000 From: "Peng, ZhihongX" To: Xueming Li CC: Luca Boccassi , Dmitry Kozlyuk , Olivier Matz , "dpdk stable" Thread-Topic: patch 'cmdline: free on exit' has been queued to stable release 20.11.4 Thread-Index: AQHX1f+DcSnHbnTqaUqrMeSPEKhOaav8Whmw Date: Wed, 10 Nov 2021 07:23:47 +0000 Message-ID: References: <20211110063216.2744012-1-xuemingl@nvidia.com> <20211110063216.2744012-175-xuemingl@nvidia.com> In-Reply-To: <20211110063216.2744012-175-xuemingl@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 352d1db3-d416-4ec8-7297-08d9a41b0920 x-ms-traffictypediagnostic: DM8PR11MB5622: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: hLrQSsMGQw8w7Q6EW1eZ+ipJwHKp/d57Iy9GrP+KktFTH2f/uVSmYA1H4XeeIUPw7/Nd1cgD0LcWLsGyDHCkC/+8cevJIKuYMbsZGE+UuVTA5QtiARRK0ywYqBWbmZr9bB25prBaymmG+NoLpgZFP8CqFJwRpv3ZWddtfDM5JAmQcK5oGgFgM9zQOT+ZtyNCZJyD5Rd/oXATQkz3uB1IoHflsnvgSzH/MqOyiD1x5P5lSsQLGRR4O63dBqeKDxyF624gxPPBkuTdIrfvb8aZkw5uU0tndd9mV5W+cFGyWAo09INOR5rzfSpPCwPZ3/1FRRQQseLziqTDmYRtJ7LcVxxMgk15RjebLN5lreBcv0EpCCNMCH7FB4lUHnQ5t2iDwSOZfo5aWclw+i7uC7u+y19KbbAquPFPMJ0Ua4wEHhgi7ut1f6GeH1F4Dbrn584yRsyr2Ico3caI+DFOfaOubrQzodkt/S4/4Sp9y3DO082GdOOX1vvyV4OBoXzqbfh05ywXSOCvHMU4Y7wWEyoQbQtiAC9Ic9f1Jessspnk/TmTUQl2+XKlcRS1vEvb2TwqXKfBxNUSUqAaAT6kyxn1sCBEx245pPruCRA5alXSoAp23W5GjDjP9htR8zwRGpuEkx3yFwFArcfMTK1THbHmty9aoYNF1kr1+Vzn95KqbJ+TVrXiMaWiNUefr8Sa9AfIvIwBTQScBdF34b0RmUH3lBuyJAwgEmsOKySZK0VBAiwPZhNBe2nf+yCO3qnIQrggQ88fKruAOIVz2noX/+WRyaE2l7zcI24V+X90IxlewK1TldD9BroCqzpoH7fhkiReKCmloLShWNmGXhEJsn1PHw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM8PR11MB5591.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(66446008)(6916009)(33656002)(4326008)(38070700005)(7696005)(66476007)(186003)(66946007)(2906002)(86362001)(5660300002)(83380400001)(6506007)(52536014)(76116006)(122000001)(53546011)(4001150100001)(9686003)(508600001)(316002)(8676002)(26005)(55016002)(8936002)(966005)(54906003)(38100700002)(71200400001)(82960400001)(64756008)(66556008); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?wUIWwuOGYgFoI32vWd0yu2P7WmsTvDdsphSc86I6b5ZUig0Pe7/uI/0fARv1?= =?us-ascii?Q?ZbClYGS01QHY0a3xWCs/keXljpET7ozYTqOYnpUZlF/XdusZSCdITzCeMONI?= =?us-ascii?Q?dEsL/XfmYXXJwRmACiYly+otlExY3DKkHLoBRNxhVRYPi1GYcjpNtY2WF7ul?= =?us-ascii?Q?dH4uwcZ5GUo8k32s6gjQSVNNYOvuLwI8Q4iOMP63kRBb1zX6lin2zP/+zutv?= =?us-ascii?Q?hvdmpfeYVkld2pperyQS9t/gc4mayvbzc0j8DALxSzdrk1UUu/Byy8G4LvC2?= =?us-ascii?Q?cC/NLiSH+6r+cZA/FAKJ9+PvH7p4fsjaMewu71d+GEQvKdPl0UDJU2nRpTCy?= =?us-ascii?Q?aMgeYG2veQKs8O+tibOcw/HXpnlyzLvDf3qEDxdmlEGO3g41izQlqXEHSNks?= =?us-ascii?Q?/Z/FKhpzxvFE/IiRiBLoJ/oPx4NioX+PHK4zs2QWdLcwrVoCBA+OP7UPzfJq?= =?us-ascii?Q?KuOzrJHMH7yDu4Nad4dxEXUSzR806JNHoNli78UJER6DaMuew1wYpjHOAJs6?= =?us-ascii?Q?QEGqDVZpkYDFgwePjr7kWu2qh9P1M4BDQPsuqsM7TTD/8fADCJ7V4Wqun23q?= =?us-ascii?Q?wWcdGk4hLHynGztLFgSEn0Li0sAUEIP3XKZcvzPlsYd+rsiGn2vjdlDEmhuB?= =?us-ascii?Q?oF4XwoCJiflG6DUfNkInpbua+Jtt//jwR5Xup7YOPUCbJT+q23n48mEG22nY?= =?us-ascii?Q?txBPEMO3+Pk8KC+va0tWX/RXsBRO+lLGZMdZBcwVhZoh2gQVdqLx+lPsLDqQ?= =?us-ascii?Q?WJArEwrrBrFWxqPDSIuI9AD0mpB1H1itc38t+DDgrjy8byiiOQBg7QX9QyQs?= =?us-ascii?Q?2A9GgK0iBPzwjreypniliqEcpha/Q4a96GWMm9NSUKMe6Es8RBw//mR3gwk8?= =?us-ascii?Q?UxyVf22fppWiBMKogRBIbRDAFGE2mK1/Y75gaDWMHjOMS/5cHM6Tqsp5NiCb?= =?us-ascii?Q?M/MoG0SZmfap4Lk4hSK6A5Ui5++5TWiBRrMYF8IwbLGyFQZgwL/1rQEPUo2f?= =?us-ascii?Q?7vD7DQ4Cvt9ZIvObov9YH7WG2OlZP6P2pEe+M8kpNOBDRueZlTIVmvDWJsf6?= =?us-ascii?Q?cx+a6iVjUxY/W1Egj4jXHPsTwqOT/CKXkAz3k+jV/6etlBDu/Yzh1tNJ8dke?= =?us-ascii?Q?d9emN+dr50iCnz7BQ7umjmGywcPWqf+JnKJ9IVd07MdzAI32XWY6yun3LDF+?= =?us-ascii?Q?bD88ToTqfsqPSzlghmjIUA4KRlnDKu2ffQPTXRdbvoAQBfRZAgJoC5ZgXpZ/?= =?us-ascii?Q?ulhpBiQD8kPDhKGEwsH2/RO8EVErL/JiWT07BkfasI8jzSR44WyRtJT7SvYI?= =?us-ascii?Q?XouigUYDafi9WRLRSPeFkBmXpehSjaEkRx5b4BvE4jK59qUgLZ+kTdUe/JZw?= =?us-ascii?Q?nxdXTyAqU8Ecm5IH+RsuNx3eJ5Mqg+qv1pQ9X3pIHxORnNdBA/8X3WCwqxYX?= =?us-ascii?Q?tY0kop1vWdwSqz3PqPqim5lnlrJeNtt5pbuyTdc+gpw9TqFKAK5BxTZ/M6K2?= =?us-ascii?Q?yItFfyon3GQMd9c3yFRaUQKdnkQCvW9Dve28G9KBC2zoeiVThSeFmuqoBuWr?= =?us-ascii?Q?Vl6uv+iSqsRfLFppzO8vfrFPfihRp6Yh3zKekIDuUu/X4ZtQ6TXRrBi1IyPX?= =?us-ascii?Q?Zvdh6maxBynhjLmZUvkXqM0=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8PR11MB5591.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 352d1db3-d416-4ec8-7297-08d9a41b0920 X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Nov 2021 07:23:47.2495 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: nKgGmt2KsAlq+6wW3g6wGv75K8IWbqw61mBfgB7vtAsGvLmBheYuLiFsbxXFlYnc8vFtIYYI67mx/SWb5PKlLg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR11MB5622 X-OriginatorOrg: intel.com Subject: Re: [dpdk-stable] patch 'cmdline: free on exit' has been queued to stable release 20.11.4 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi , Xueming This patch is not backward compatible. Backward compatibility will cause the app to change the CmdLine code. In addition, we found a bug in some test cases of this patch, and I will submit a new patch for solution. Regards, Peng,Zhihong > -----Original Message----- > From: Xueming Li > Sent: Wednesday, November 10, 2021 2:31 PM > To: Peng, ZhihongX > Cc: Luca Boccassi ; Dmitry Kozlyuk > ; Olivier Matz ; dpdk > stable > Subject: patch 'cmdline: free on exit' has been queued to stable release > 20.11.4 >=20 > Hi, >=20 > FYI, your patch has been queued to stable release 20.11.4 >=20 > Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. > It will be pushed if I get no objections before 11/12/21. So please shout= if > anyone has objections. >=20 > Also note that after the patch there's a diff of the upstream commit vs t= he > patch applied to the branch. This will indicate if there was any rebasing > needed to apply to the stable branch. If there were code changes for > rebasing > (ie: not only metadata diffs), please double check that the rebase was > correctly done. >=20 > Queued patches are on a temporary branch at: > https://github.com/steevenlee/dpdk >=20 > This queued commit can be viewed at: > https://github.com/steevenlee/dpdk/commit/f181839864ae7ba170519235a6 > da969a7df36a85 >=20 > Thanks. >=20 > Xueming Li >=20 > --- > From f181839864ae7ba170519235a6da969a7df36a85 Mon Sep 17 00:00:00 > 2001 > From: Zhihong Peng > Date: Mon, 18 Oct 2021 21:58:50 +0800 > Subject: [PATCH] cmdline: free on exit > Cc: Xueming Li >=20 > [ upstream commit 6ad06203a587a8ce10392d9224e9fbdcb77b3d5c ] >=20 > Malloc cl in the cmdline_stdin_new function, so release in the > cmdline_stdin_exit function is logical, so that cl will not be released a= lone. >=20 > Fixes: af75078fece3 ("first public release") >=20 > Signed-off-by: Zhihong Peng > Reviewed-by: Dmitry Kozlyuk > Acked-by: Olivier Matz > Tested-by: Zhihong Peng > --- > app/test/test.c | 1 - > app/test/test_cmdline_lib.c | 1 - > lib/librte_cmdline/cmdline_socket.c | 1 + > 3 files changed, 1 insertion(+), 2 deletions(-) >=20 > diff --git a/app/test/test.c b/app/test/test.c index 864523ed61..f7d09467= 61 > 100644 > --- a/app/test/test.c > +++ b/app/test/test.c > @@ -195,7 +195,6 @@ main(int argc, char **argv) >=20 > cmdline_interact(cl); > cmdline_stdin_exit(cl); > - cmdline_free(cl); > } > #endif > ret =3D 0; > diff --git a/app/test/test_cmdline_lib.c b/app/test/test_cmdline_lib.c in= dex > d5a09b4541..6bcfa6511e 100644 > --- a/app/test/test_cmdline_lib.c > +++ b/app/test/test_cmdline_lib.c > @@ -174,7 +174,6 @@ test_cmdline_socket_fns(void) > /* void functions */ > cmdline_stdin_exit(NULL); >=20 > - cmdline_free(cl); > return 0; > error: > printf("Error: function accepted null parameter!\n"); diff --git > a/lib/librte_cmdline/cmdline_socket.c b/lib/librte_cmdline/cmdline_socket= .c > index 0fe1497008..f919537460 100644 > --- a/lib/librte_cmdline/cmdline_socket.c > +++ b/lib/librte_cmdline/cmdline_socket.c > @@ -57,4 +57,5 @@ cmdline_stdin_exit(struct cmdline *cl) > return; >=20 > terminal_restore(cl); > + cmdline_free(cl); > } > -- > 2.33.0 >=20 > --- > Diff of the applied patch vs upstream commit (please double-check if no= n- > empty: > --- > --- - 2021-11-10 14:17:09.660774437 +0800 > +++ 0174-cmdline-free-on-exit.patch 2021-11-10 14:17:01.984078497 +0800 > @@ -1 +1 @@ > -From 6ad06203a587a8ce10392d9224e9fbdcb77b3d5c Mon Sep 17 00:00:00 > 2001 > +From f181839864ae7ba170519235a6da969a7df36a85 Mon Sep 17 00:00:00 > 2001 > @@ -4,0 +5,3 @@ > +Cc: Xueming Li > + > +[ upstream commit 6ad06203a587a8ce10392d9224e9fbdcb77b3d5c ] > @@ -17,5 +20,4 @@ > - app/test/test.c | 1 - > - app/test/test_cmdline_lib.c | 1 - > - doc/guides/rel_notes/release_21_11.rst | 3 +++ > - lib/cmdline/cmdline_socket.c | 1 + > - 4 files changed, 4 insertions(+), 2 deletions(-) > + app/test/test.c | 1 - > + app/test/test_cmdline_lib.c | 1 - > + lib/librte_cmdline/cmdline_socket.c | 1 + > + 3 files changed, 1 insertion(+), 2 deletions(-) > @@ -24 +26 @@ > -index 173d202e47..5194131026 100644 > +index 864523ed61..f7d0946761 100644 > @@ -27 +29 @@ > -@@ -233,7 +233,6 @@ main(int argc, char **argv) > +@@ -195,7 +195,6 @@ main(int argc, char **argv) > @@ -36 +38 @@ > -index 054ebf5e9d..f238094b07 100644 > +index d5a09b4541..6bcfa6511e 100644 > @@ -39 +41 @@ > -@@ -180,7 +180,6 @@ test_cmdline_socket_fns(void) > +@@ -174,7 +174,6 @@ test_cmdline_socket_fns(void) > @@ -47,19 +49,5 @@ > -diff --git a/doc/guides/rel_notes/release_21_11.rst > b/doc/guides/rel_notes/release_21_11.rst > -index 9b1843eb09..450bcbb445 100644 > ---- a/doc/guides/rel_notes/release_21_11.rst > -+++ b/doc/guides/rel_notes/release_21_11.rst > -@@ -325,6 +325,9 @@ API Changes > - removed. Its usages have been replaced by a new function > - ``rte_kvargs_get_with_value()``. > - > -+* cmdline: ``cmdline_stdin_exit()`` now frees the ``cmdline`` structure= . > -+ Calls to ``cmdline_free()`` after it need to be deleted from applicat= ions. > -+ > - * cmdline: Made ``cmdline`` structure definition hidden on Linux and > FreeBSD. > - > - * cmdline: Made ``rdline`` structure definition hidden. Functions are a= dded - > diff --git a/lib/cmdline/cmdline_socket.c b/lib/cmdline/cmdline_socket.c = - > index 998e8ade25..ebd5343754 100644 > ---- a/lib/cmdline/cmdline_socket.c > -+++ b/lib/cmdline/cmdline_socket.c > -@@ -53,4 +53,5 @@ cmdline_stdin_exit(struct cmdline *cl) > +diff --git a/lib/librte_cmdline/cmdline_socket.c > +b/lib/librte_cmdline/cmdline_socket.c > +index 0fe1497008..f919537460 100644 > +--- a/lib/librte_cmdline/cmdline_socket.c > ++++ b/lib/librte_cmdline/cmdline_socket.c > +@@ -57,4 +57,5 @@ cmdline_stdin_exit(struct cmdline *cl)